Attention is currently required from: jolly, laforge.

View Change

2 comments:

• File include/osmocom/core/soft_uart.h:

  • Patch Set #3, Line 28: uart_parity_mode

    For completeness you should add OSMO_SUART_PARITY_MARK and OSMO_SUART_PARITY_SPACE. […]

    Done, please see https://gerrit.osmocom.org/c/libosmocore/+/35067.

• File src/core/soft_uart.c:

  • Patch Set #3, Line 127: suart->rx.shift_reg |= 0x80

    The last RX bit is always MSB of shift_reg. […]

    Indeed, thanks. I also uncovered this when improving the unit tests. This is now fixed, please see: https://gerrit.osmocom.org/c/libosmocore/+/35066.

To view, visit change 30763. To unsubscribe, or for help writing mail filters, visit settings.