- gerrit-log - lists.osmocom.org

[L] Change in libosmocore[master]: core: Add software UART implementation
by jolly 18 Nov '23

18 Nov '23

Attention is currently required from: fixeria, laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email ) Change subject: core: Add software UART implementation ...................................................................... Patch Set 3: (2 comments) File include/osmocom/core/soft_uart.h: https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/133ce3d3_0134743a PS3, Line 28: uart_parity_mode For completeness you should add OSMO_SUART_PARITY_MARK and OSMO_SUART_PARITY_SPACE. (parity bit always 1 or always 0 respectively) File src/core/soft_uart.c: https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/bbc7357e_c1760049 PS3, Line 127: suart->rx.shift_reg |= 0x80 The last RX bit is always MSB of shift_reg. If num_data_bits is less than 8, the result is misaligned when forwarding to receive buffer. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2ca95963fd5852ddb89bdd35b86b31489127fe84 Gerrit-Change-Number: 30763 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 18 Nov 2023 11:04:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: obs-worker: support more recent opensuse versions
by laforge 18 Nov '23

18 Nov '23

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/35056?usp=email ) Change subject: obs-worker: support more recent opensuse versions ...................................................................... obs-worker: support more recent opensuse versions We don't want to install new builders with 15.3, and the playbook should just detect the installed version rather than making assumptions Change-Id: I96f9896c0eeab120633d5800198d8b93371f7a5a --- M ansible/roles/osmocom-obs-worker/tasks/obs.yml 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/56/35056/1 diff --git a/ansible/roles/osmocom-obs-worker/tasks/obs.yml b/ansible/roles/osmocom-obs-worker/tasks/obs.yml index 08367ac..a0a6227 100644 --- a/ansible/roles/osmocom-obs-worker/tasks/obs.yml +++ b/ansible/roles/osmocom-obs-worker/tasks/obs.yml @@ -1,6 +1,6 @@ - name: add OBS rpm repository zypper_repository: - repo: https://download.opensuse.org/repositories/OBS:/Server:/2.10/15.3/OBS:Serve… + repo: https://download.opensuse.org/repositories/OBS:/Server:/2.10/{{ ansible_distribution_version }}/OBS:Server:2.10.repo autorefresh: yes auto_import_keys: yes -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/35056?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I96f9896c0eeab120633d5800198d8b93371f7a5a Gerrit-Change-Number: 35056 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ci[master]: hosts: Add build4-obsworker
by laforge 18 Nov '23

18 Nov '23

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/35057?usp=email ) Change subject: hosts: Add build4-obsworker ...................................................................... hosts: Add build4-obsworker Change-Id: I0c663fa281042aa98822d27a67add8ba07dca172 --- M ansible/hosts M ansible/util/known_hosts 2 files changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/57/35057/1 diff --git a/ansible/hosts b/ansible/hosts index 6a1783e..0db38fb 100644 --- a/ansible/hosts +++ b/ansible/hosts @@ -22,6 +22,7 @@ [obs_workers] build3-obsworker1 ansible_host=2a01:4f8:212:3762::1:2 obs_worker_instances=8 obs_worker_jobs=8 +build4-obsworker1 ansible_host=2a01:4f8:121:200a::1:2 obs_worker_instances=8 obs_worker_jobs=8 lx2-1-obs-aarch64-1 ansible_host=2a02:8106:13:1e34:4e9:e7ff:fe97:fe92 obs_worker_instances=1 obs_worker_jobs=4 # Need to have kvm inside lxc, see OS#5365 diff --git a/ansible/util/known_hosts b/ansible/util/known_hosts index 05b30c8..cdb573b 100644 --- a/ansible/util/known_hosts +++ b/ansible/util/known_hosts @@ -6,3 +6,4 @@ 10.9.25.60 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIOAK6SQXmifMamE1VHL/1GmPkk6KhplzT20jSOwb8PyZ 10.9.25.70 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAILioWTUt6CyZTceSKqy09mtlNUif+ETKTF6whnWuIROx 2a01:4f8:121:200a::1:3 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIGafw2VdeZo4YNvbu8VEBjDrsCFL+ZSbHtvhspNIQ9PR +2a01:4f8:121:200a::1:2 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIFyp0daWkfsRHErCVCcP/FZmtiRvFNAsK2A5TlQ6Ja+P -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/35057?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0c663fa281042aa98822d27a67add8ba07dca172 Gerrit-Change-Number: 35057 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: gmstap_util: Fix sending out gsmtap messages
by laforge 18 Nov '23

18 Nov '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35055?usp=email ) Change subject: gmstap_util: Fix sending out gsmtap messages ...................................................................... gmstap_util: Fix sending out gsmtap messages Previously undetected, because the vty command 'gsmtap log ...' never used write queue mode Change-Id: I88ba8984518d2d0327cfacd0d2cdf33c7e1d091b --- M src/core/gsmtap_util.c 1 file changed, 21 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/core/gsmtap_util.c b/src/core/gsmtap_util.c index d817885..b64c7b0 100644 --- a/src/core/gsmtap_util.c +++ b/src/core/gsmtap_util.c @@ -491,16 +491,21 @@ if (ofd_wq_mode) { gti->out = osmo_iofd_setup(gti, gti->wq.bfd.fd, "gsmtap_inst.io_fd", OSMO_IO_FD_MODE_READ_WRITE, &gsmtap_ops, NULL); - if (gti->out == NULL) { - talloc_free(gti); - close(fd); - return NULL; - } + if (gti->out == NULL) + goto err_cleanup; + if (osmo_iofd_register(gti->out, gti->wq.bfd.fd) < 0) + goto err_cleanup; + /* osmo write queue previously used was set up with value of 64 */ osmo_iofd_set_txqueue_max_length(gti->out, 64); } return gti; + +err_cleanup: + talloc_free(gti); + close(fd); + return NULL; } /*! Open GSMTAP source socket, connect and register osmo_fd -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35055?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I88ba8984518d2d0327cfacd0d2cdf33c7e1d091b Gerrit-Change-Number: 35055 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in libosmocore[master]: gmstap_util: Fix sending out gsmtap messages
by laforge 18 Nov '23

18 Nov '23

Attention is currently required from: arehbein, daniel, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35055?usp=email ) Change subject: gmstap_util: Fix sending out gsmtap messages ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35055?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I88ba8984518d2d0327cfacd0d2cdf33c7e1d091b Gerrit-Change-Number: 35055 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Sat, 18 Nov 2023 08:51:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: hlr: add imsi unknown cause test case
by lynxis lazus 18 Nov '23

18 Nov '23

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569?usp=email ) Change subject: hlr: add imsi unknown cause test case ...................................................................... hlr: add imsi unknown cause test case Check if the reject-cause is correct implement when the subscriber couldn't found. Depends-on: Icea39020c23fbbea9e92847df76af8986fdbf48a (osmo-hlr) Change-Id: I87c3a2d7304b81cfc11a364d933567e1a080b99a --- M hlr/HLR_Tests.ttcn 1 file changed, 35 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved daniel: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/hlr/HLR_Tests.ttcn b/hlr/HLR_Tests.ttcn index e99011d..794ef9b 100644 --- a/hlr/HLR_Tests.ttcn +++ b/hlr/HLR_Tests.ttcn @@ -152,6 +152,7 @@ f_vty_set_prompts(VTY); f_vty_transceive(VTY, "enable"); f_vty_config(VTY, "mslookup", "no mdns bind"); + f_vty_config(VTY, "hlr", "reject-cause not-found imsi-unknown"); } private altstep as_Tguard() runs on test_CT { @@ -987,6 +988,7 @@ vc_conn := f_start_handler(refers(f_TC_ul_unknown_imsi), pars); vc_conn.done; } + testcase TC_gsup_ul_unknown_imsi_via_proxy() runs on test_CT { var hexstring imsi := f_rnd_imsi('26242'H); var HLR_ConnHdlrPars pars := valueof(t_Pars_via_proxy(imsi)); @@ -997,6 +999,25 @@ vc_conn.done; } +/* Test if the HLR can be configured to a different error code if the subscriber can't be found. + * E.g. on event networks the HLR should return Roaming Not Allowed to unknown subscribers instead + * of Subscriber Unknown in HLR. + */ +private function f_TC_ul_unknown_imsi_roaming_not_allowed() runs on HLR_ConnHdlr { + f_vty_config(VTY, "hlr", "reject-cause not-found roaming-not-allowed"); + f_perform_UL(g_pars.sub.imsi, ?, 13, source_name := g_pars.source_name); + setverdict(pass); +} +testcase TC_gsup_ul_unknown_imsi_roaming_not_allowed() runs on test_CT { + var hexstring imsi := f_rnd_imsi('26242'H); + var HLR_ConnHdlrPars pars := valueof(t_Pars(imsi)); + var HLR_ConnHdlr vc_conn; + + f_init(false); + vc_conn := f_start_handler(refers(f_TC_ul_unknown_imsi_roaming_not_allowed), pars); + vc_conn.done; +} + /* test UL for a number of different subscriber cases (algo, 2g/3g, ...) */ private function f_TC_gsup_ul() runs on HLR_ConnHdlr { var GSUP_PDUs res; @@ -2076,6 +2097,7 @@ execute( TC_gsup_sai_eps() ); execute( TC_gsup_ul_unknown_imsi() ); execute( TC_gsup_ul_unknown_imsi_via_proxy() ); + execute( TC_gsup_ul_unknown_imsi_roaming_not_allowed() ); execute( TC_gsup_sai_err_unknown_imsi() ); execute( TC_gsup_ul() ); execute( TC_gsup_ul_via_proxy() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I87c3a2d7304b81cfc11a364d933567e1a080b99a Gerrit-Change-Number: 27569 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmocore[master]: gmstap_util: Fix sending out gsmtap messages
by arehbein 17 Nov '23

17 Nov '23

Attention is currently required from: daniel, jolly. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35055?usp=email ) Change subject: gmstap_util: Fix sending out gsmtap messages ...................................................................... Patch Set 2: (1 comment) File src/core/gsmtap_util.c: https://gerrit.osmocom.org/c/libosmocore/+/35055/comment/d50ad5b0_74213e31 PS1, Line 499: osmo_iofd_register > What if registration fails? Can you handle it? My bad, fixed it. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35055?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I88ba8984518d2d0327cfacd0d2cdf33c7e1d091b Gerrit-Change-Number: 35055 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Nov 2023 17:55:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: gmstap_util: Fix sending out gsmtap messages
by arehbein 17 Nov '23

17 Nov '23

Attention is currently required from: arehbein, daniel. Hello Jenkins Builder, daniel, jolly, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35055?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: gmstap_util: Fix sending out gsmtap messages ...................................................................... gmstap_util: Fix sending out gsmtap messages Previously undetected, because the vty command 'gsmtap log ...' never used write queue mode Change-Id: I88ba8984518d2d0327cfacd0d2cdf33c7e1d091b --- M src/core/gsmtap_util.c 1 file changed, 21 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/55/35055/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35055?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I88ba8984518d2d0327cfacd0d2cdf33c7e1d091b Gerrit-Change-Number: 35055 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmocore[master]: gmstap_util: Fix sending out gsmtap messages
by jolly 17 Nov '23

17 Nov '23

Attention is currently required from: arehbein, daniel. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35055?usp=email ) Change subject: gmstap_util: Fix sending out gsmtap messages ...................................................................... Patch Set 1: (1 comment) File src/core/gsmtap_util.c: https://gerrit.osmocom.org/c/libosmocore/+/35055/comment/0e0fb043_0e017169 PS1, Line 499: osmo_iofd_register What if registration fails? Can you handle it? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35055?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I88ba8984518d2d0327cfacd0d2cdf33c7e1d091b Gerrit-Change-Number: 35055 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Nov 2023 17:30:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in libosmocore[master]: core: Add software UART implementation
by laforge 17 Nov '23

17 Nov '23

Attention is currently required from: fixeria, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email ) Change subject: core: Add software UART implementation ...................................................................... Patch Set 3: (1 comment) File src/core/soft_uart.c: https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/b08f4bd0_2bbe7a2e PS3, Line 203: /* FIXME: Tx */ > Ah, I actually wanted to clarify the idea behind this function first. […] enabling/disabling the receiver are completely orthogonal functions to modem status lines (they also are completely independent in any hardware UART). modem status lines tell you information like the state of the *attached* equipment. Example: Is the data terminal ready (DTR)? Does the modem have a carrier? (DCD). See V.110 and the table in https://osmocom.org/projects/retronetworking/wiki/RS232_vs_ITU_V24_Signal_N… giving "normal" names for those numeric circuit numbers in V.110 So basically all this function here would do is to set some state whcih then ends up in the S/X-bits, and which is used by the remote end to replicate those status lines. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2ca95963fd5852ddb89bdd35b86b31489127fe84 Gerrit-Change-Number: 30763 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Nov 2023 16:42:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log