- gerrit-log - lists.osmocom.org

[M] Change in osmo-pcu[master]: doc: Introduce code architecture section with main class diagram
by pespin 12 Apr '24

12 Apr '24

Attention is currently required from: fixeria, jolly, osmith, pespin. Hello Jenkins Builder, fixeria, jolly, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/36555?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: doc: Introduce code architecture section with main class diagram ...................................................................... doc: Introduce code architecture section with main class diagram This is useful to understand the data model in a quick gasp. Change-Id: Ibf6dd6f7e4d6370ad40733820faa70f9e5bc0e7d --- A doc/manuals/chapters/code-architecture.adoc M doc/manuals/osmopcu-usermanual.adoc 2 files changed, 84 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/55/36555/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36555?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibf6dd6f7e4d6370ad40733820faa70f9e5bc0e7d Gerrit-Change-Number: 36555 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-ttcn3-hacks[master]: pcu: Update component diagram
by pespin 12 Apr '24

12 Apr '24

Attention is currently required from: fixeria, osmith. Hello Jenkins Builder, fixeria, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36556?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: pcu: Update component diagram ...................................................................... pcu: Update component diagram The component architecture in PCU_Tests is quite complex to follow. Update the diagram in order to make it easier for people to gasp the big picture. Change-Id: Ie592a9301b7a900334650741ed633cd70535a2b1 --- M pcu/PCU_Tests.ttcn M pcu/README.md 2 files changed, 100 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/56/36556/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36556?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie592a9301b7a900334650741ed633cd70535a2b1 Gerrit-Change-Number: 36556 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-ttcn3-hacks[master]: pcu: Update component diagram
by pespin 12 Apr '24

12 Apr '24

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36556?usp=email ) Change subject: pcu: Update component diagram ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I finally decided to rework a bit differently the graph, simply copy the graphviz code to the webpage I shared above if you want to see the result. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36556?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie592a9301b7a900334650741ed633cd70535a2b1 Gerrit-Change-Number: 36556 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Apr 2024 19:30:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: pcu: Update component diagram
by pespin 12 Apr '24

12 Apr '24

Attention is currently required from: fixeria, osmith. Hello Jenkins Builder, fixeria, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36556?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: pcu: Update component diagram ...................................................................... pcu: Update component diagram The component architecture in PCU_Tests is quite complex to follow. Update the diagram in order to make it easier for people to gasp the big picture. Change-Id: Ie592a9301b7a900334650741ed633cd70535a2b1 --- M pcu/PCU_Tests.ttcn M pcu/README.md 2 files changed, 100 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/56/36556/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36556?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie592a9301b7a900334650741ed633cd70535a2b1 Gerrit-Change-Number: 36556 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-ttcn3-hacks[master]: pcu: Update component diagram
by pespin 12 Apr '24

12 Apr '24

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36556?usp=email ) Change subject: pcu: Update component diagram ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: https://dreampuf.github.io/GraphvizOnline/?compressed=CYSw5gTghgDgFgAgOIIN4… -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36556?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie592a9301b7a900334650741ed633cd70535a2b1 Gerrit-Change-Number: 36556 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Apr 2024 19:19:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: pcu: Update component diagram
by pespin 12 Apr '24

12 Apr '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36556?usp=email ) Change subject: pcu: Update component diagram ...................................................................... pcu: Update component diagram The component architecture in PCU_Tests is quite complex to follow. Update the diagram in order to make it easier for people to gasp the big picture. Change-Id: Ie592a9301b7a900334650741ed633cd70535a2b1 --- M pcu/PCU_Tests.ttcn M pcu/README.md 2 files changed, 100 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/56/36556/1 diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 442d617..cab70e8 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -157,7 +157,7 @@ var StatsD_Checker_CT vc_STATSD; /* Connection to the PCUIF component */ - port RAW_PCU_MSG_PT PCUIF; + //port RAW_PCU_MSG_PT PCUIF; /* VTY connection to the PCU */ port TELNETasp_PT PCUVTY; @@ -282,7 +282,7 @@ /* Init PCU interface component */ vc_PCUIF := RAW_PCUIF_CT.create("PCUIF") alive; - connect(vc_PCUIF:MTC, self:PCUIF); + //connect(vc_PCUIF:MTC, self:PCUIF); map(vc_PCUIF:PCU, system:PCU); /* Create one BTS component (we may want more some day) */ diff --git a/pcu/README.md b/pcu/README.md index a2e439a..2a32f21 100644 --- a/pcu/README.md +++ b/pcu/README.md @@ -2,17 +2,94 @@ * external interfaces * Gb (emulates SGSN side NS/BSSGP) - * unix pcu socket (emulates BTS) + * PCUIF: unix pcu socket (emulates BTS) * VTY + * CTRL + * StatsD -{% dot msc_tests.svg +{% dot pcu_tests.svg digraph G { - rankdir=LR; - PCU [label="IUT\nosmo-pcu",shape="box"]; - ATS [label="ATS\nPCU_Tests.ttcn"]; + PCU [label="IUT\nosmo-pcu",shape="box", color=red]; - PCU -> ATS [label="Gb"]; - PCU -> ATS [label="pcu_sock"]; - ATS -> PCU [label="VTY"]; + subgraph cluster_ats { + label = "ATS\n(TTCN-3)"; + + system_PCU_PT [label="port system:PCU"]; + + subgraph cluster_RAW_PCU_Test_CT { + label = "RAW_PCU_Test_CT\n(PCU_Tests.ttcn)"; + + RAW_PCU_MSG_PT_PCUIF_A [label="port RAW_PCU_MSG_PT PCUIF\n(unused)"] + PCUVTY [label="PCUVTY"]; + StatsD_ConnHdlr [label="StatsD_ConnHdlr"]; + CTRL_Adapter_CT [label="CTRL_Adapter_CT"]; + + test [label="testcasename()\n(PCU_Tests.ttcn)", color=red]; + + subgraph cluster_bssgp_CT { + label="bssgp_CT\nSGSN_Components.ttcn"; + subgraph cluster_BSSGP_Client_CT { + label="BSSGP_Client_CT\nBSSGP_Emulation.ttcnpp"; + BSSGP_PT [label="port BSSGP_PT BSSGP"]; + } + } + + subgraph cluster_MS_BTS_IFACE_CT { + label = "MS_BTS_IFACE_CT\n(GPRS_Components.ttcn)"; + + RAW_PCU_MSG_PT_BTS_IFACE [label="port RAW_PCU_MSG_PT BTS"]; + + subgraph cluster_RAW_PCU_BTS_CT { + label = "RAW_PCU_BTS_CT\n(PCUIF_Components.ttcn)"; + + RAW_PCU_MSG_PT_CLCK_A [label="port RAW_PCU_MSG_PT CLCK"]; + RAW_PCU_MSG_PT_PCUIF_B [label="port RAW_PCU_MSG_PT PCUIF"]; + RAW_PCU_MSG_PT_TC [label="port RAW_PCU_MSG_PT TC"]; + + subgraph cluster_RAW_PCU_ClckGen_CT { + label = "RAW_PCU_ClckGen_CT\n(PCUIF_Components.ttcn)"; + + RAW_PCU_MSG_PT_CLCK_B [label="port RAW_PCU_MSG_PT CLCK", color=purple]; + } + + RAW_PCU_MSG_PT_CLCK_A -> RAW_PCU_MSG_PT_CLCK_B [dir=back]; + RAW_PCU_MSG_PT_PCUIF_B -> RAW_PCU_MSG_PT_TC [dir=none]; + } + } + + RAW_PCU_MSG_PT_TC -> RAW_PCU_MSG_PT_BTS_IFACE [dir=none]; + + } + + subgraph cluster_RAW_PCUIF_CT { + label = "RAW_PCUIF_CT\n(PCUIF_Components.ttcn)"; + + PCUIF_CODEC_PT_PCU [label="port PCUIF_CODEC_PT PCU"]; + RAW_PCU_MSG_PT_BTS [label="port RAW_PCU_MSG_PT BTS"]; + RAW_PCU_MSG_PT_MTC [label="port RAW_PCU_MSG_PT MTC"]; + + PCUIF_CODEC_PT_PCU -> RAW_PCU_MSG_PT_BTS [dir=none]; + PCUIF_CODEC_PT_PCU -> RAW_PCU_MSG_PT_MTC [dir=none]; + + } + + RAW_PCU_MSG_PT_MTC -> RAW_PCU_MSG_PT_PCUIF_A [dir=none]; + RAW_PCU_MSG_PT_PCUIF_B -> RAW_PCU_MSG_PT_BTS [dir=none]; + + PCUIF_CODEC_PT_PCU -> system_PCU_PT [dir=none]; + + test -> RAW_PCU_MSG_PT_BTS_IFACE [dir=none]; + //test -> RAW_PCU_MSG_PT_PCUIF_A [label="(unused)", dir=none]; + test -> BSSGP_PT; + test -> PCUVTY; + test -> StatsD_ConnHdlr; + test -> CTRL_Adapter_CT; + } + + PCU -> BSSGP_PT [label="Gb"]; + PCU -> StatsD_ConnHdlr [label="statsd"]; + system_PCU_PT -> PCU [label="PCUIF"]; + PCUVTY -> PCU [label="VTY"]; + CTRL_Adapter_CT -> PCU [label="CTRL"]; } %} -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36556?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie592a9301b7a900334650741ed633cd70535a2b1 Gerrit-Change-Number: 36556 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-pcu[master]: README.md: Remove 'multi-slot ul tbf' line from 'Current Limitations'
by fixeria 12 Apr '24

12 Apr '24

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/36551?usp=email ) Change subject: README.md: Remove 'multi-slot ul tbf' line from 'Current Limitations' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36551?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I9abe54f280ab4e62c0c5220d010575b912c8c141 Gerrit-Change-Number: 36551 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Apr 2024 17:01:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: tbf_ul.h: Mark empty param list as void
by fixeria 12 Apr '24

12 Apr '24

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/36554?usp=email ) Change subject: tbf_ul.h: Mark empty param list as void ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36554?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a9213a9fdbe0f4b70d820c449dbb71539a733ce Gerrit-Change-Number: 36554 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Apr 2024 17:01:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: tbf.h: Fix wrong type declaration of field dl_ass_fsm
by fixeria 12 Apr '24

12 Apr '24

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/36553?usp=email ) Change subject: tbf.h: Fix wrong type declaration of field dl_ass_fsm ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36553?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibbc59a0584ee0cd83de0e04eebdcca2aebe3e970 Gerrit-Change-Number: 36553 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Apr 2024 17:01:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: bts: Drop no-longer existing GprsMsStorage reference
by fixeria 12 Apr '24

12 Apr '24

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/36552?usp=email ) Change subject: bts: Drop no-longer existing GprsMsStorage reference ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36552?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2047588b1c187c842007fcb1eab0e8e4b7d7ed10 Gerrit-Change-Number: 36552 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Apr 2024 17:01:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log