- gerrit-log - lists.osmocom.org

[S] Change in osmo-pcu[master]: README.md: Remove 'multi-slot ul tbf' line from 'Current Limitations'
by fixeria 12 Apr '24

12 Apr '24

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/36551?usp=email ) Change subject: README.md: Remove 'multi-slot ul tbf' line from 'Current Limitations' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36551?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I9abe54f280ab4e62c0c5220d010575b912c8c141 Gerrit-Change-Number: 36551 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Apr 2024 17:00:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-pcu[master]: doc: Introduce code architecture section with main class diagram
by pespin 12 Apr '24

12 Apr '24

Attention is currently required from: fixeria, jolly, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/36555?usp=email ) Change subject: doc: Introduce code architecture section with main class diagram ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I created this diagram for my upcoming talk about Pcu past, present & future. I think it totally makes sense to have it in the project documentation. We already have something similar for osmo-trx. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36555?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibf6dd6f7e4d6370ad40733820faa70f9e5bc0e7d Gerrit-Change-Number: 36555 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Apr 2024 15:58:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-pcu[master]: doc: Introduce code architecture section with main class diagram
by pespin 12 Apr '24

12 Apr '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/36555?usp=email ) Change subject: doc: Introduce code architecture section with main class diagram ...................................................................... doc: Introduce code architecture section with main class diagram This is useful to understand the data model in a quick gasp. Change-Id: Ibf6dd6f7e4d6370ad40733820faa70f9e5bc0e7d --- A doc/manuals/chapters/code-architecture.adoc M doc/manuals/osmopcu-usermanual.adoc 2 files changed, 84 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/55/36555/1 diff --git a/doc/manuals/chapters/code-architecture.adoc b/doc/manuals/chapters/code-architecture.adoc new file mode 100644 index 0000000..c3c0c70 --- /dev/null +++ b/doc/manuals/chapters/code-architecture.adoc @@ -0,0 +1,71 @@ +[[code_architecture]] +== Code Architecture + +[[fig-code-architecture-general]] +.General overview of main OsmoTRX components +[graphviz] +---- +digraph hierarchy { +node[shape=record,style=filled,fillcolor=gray95] +edge[dir=back, arrowtail=empty] + +PCU[label = "{gprs_pcu|+ pcu_sock_state\l+ bssgp\l+ bts_list[]\l}"] +BTS[label = "{gprs_rlcmac_bts|+ gsm_sysinfo\l+ trx_list[]\l+ ms_list[]\l}"] +TRX[label = "{gprs_rlcmac_bts_trx|+ul_tbfs[]\l+dl_tbfs[]\l}"] +PDCH[label = "{gprs_rlcmac_pdch|+ is_enabled\l+ pdch_ulc\l+ assigned_usf_mask\l+ assigned_tfi_mask_(dl,ul)\l+ tbfs_dl[]\l+ tbfs_ul[]\l+ pagings[]\l}"] +ULC[label = "{pdch_ulc|+ registered_polls[]\l}"] +ULC_NODE[label = "{pdch_ulc_node|+ fn\l+ type\l}"] +ULC_NODE_TBF_USF[label = "{pdch_ulc_node_tbf_usf|+ ul_tbf\l}"] +ULC_NODE_TBF_POLL[label = "{pdch_ulc_node_tbf_poll|+ poll_tbf (UL/DL)\l+ reason\l}"] +ULC_NODE_SBA[label = "{pdch_ulc_node_sba|+ sba\l}"] +MS[label = "{GprsMs|+ imsi, tlli, ta...\l+ refcount\l+ current_trx\l+ first_common_ts\l+ llc_queue\l}"] +TBF[label = "{gprs_rlcmac_tbf|+ tfi\l+ egprs_enabled\l+ control_ts\l+ pdch[]\l+ ul_ass_fsm\l+ dl_ass_fsm\l+ window\l+ llc_frame\l+ rlc_blocks\l}"] +UL_TBF[label = "{gprs_rlcmac_ul_tbf|+ state_fsm\l+ ul_ack_fsm\l+ usf[]\l}"] +DL_TBF[label = "{gprs_rlcmac_dl_tbf|+ state_fsm\l}"] +SBA[label = "{gprs_rlcmac_sba|+ pdch\l+ fn\l+ ta\l}"] +RLC_WINDOW[label = "{gprs_rlcmac_window|+ sns\l+ ws\l}"] +RLC_WINDOW_UL[label = "{gprs_rlcmac_window_ul|+ v_r\l+ v_q\l+ v_n[]\l}"] +RLC_WINDOW_DL[label = "{gprs_rlcmac_window_dl|+ v_s\l+ v_a\l+ v_b[]\l}"] +LLC_QUEUE[label = "{gprs_llc_queue|+ prio_queues[]\l}"] +LLC_PRIO_QUEUE[label = "{gprs_llc_prio_queue|+ codel_state\l+ priority\l+ frames[]\l}"] +LLC_FRAME[label = "{gprs_llc_frame|+ payload[]\l+ priority\l}"] +RLC_BLOCK[label = "{gprs_rlcmac_rlc_block|...}"] + +PCU -> BTS [headlabel="*", taillabel="1"] +BTS -> TRX [headlabel="0..8", taillabel="1"] +BTS -> MS [headlabel="*", taillabel="1"] +TRX -> PDCH [headlabel="0..8", taillabel="1"] + +PDCH -> ULC [headlabel="1", taillabel="0..1"] +ULC -> ULC_NODE [headlabel="*", taillabel="1"] +ULC_NODE -> ULC_NODE_TBF_USF [arrowtail=odiamond] +ULC_NODE -> ULC_NODE_TBF_POLL [arrowtail=odiamond] +ULC_NODE -> ULC_NODE_SBA [arrowtail=odiamond] +ULC_NODE_SBA -> SBA[headlabel="1", taillabel="1"] + +TBF -> UL_TBF [arrowtail=odiamond] +TBF -> DL_TBF [arrowtail=odiamond] + +RLC_WINDOW -> RLC_WINDOW_UL [arrowtail=odiamond] +RLC_WINDOW -> RLC_WINDOW_DL [arrowtail=odiamond] + +MS -> TBF [headlabel="*", taillabel="1"] + +MS -> LLC_QUEUE [headlabel="1", taillabel="1"] +LLC_QUEUE -> LLC_PRIO_QUEUE [headlabel="*", taillabel="1"] +LLC_PRIO_QUEUE -> LLC_FRAME [headlabel="*", taillabel="1"] + +TBF -> RLC_WINDOW [headlabel="*", taillabel="1"] +TBF -> LLC_FRAME [headlabel="0..1", taillabel="1"] +TBF -> RLC_BLOCK [headlabel="*", taillabel="1"] + +TRX -> MS [headlabel="*", taillabel="1", style=dashed, arrowtail=none, label="assigned"] +TBF -> PDCH [headlabel="0..8", taillabel="1", style=dashed, arrowtail=none, label="assigned"] + +UL_TBF -> ULC_NODE_TBF_USF [style=dashed, arrowtail=none, label="registered"] +TBF -> ULC_NODE_TBF_POLL [style=dashed, arrowtail=none, label="registered"] + +TRX -> UL_TBF [headlabel="*", taillabel="1", style=dashed, label="assigned"] +TRX -> DL_TBF [headlabel="*", taillabel="1", style=dashed, label="assigned"] +} +---- diff --git a/doc/manuals/osmopcu-usermanual.adoc b/doc/manuals/osmopcu-usermanual.adoc index 0fae72a..8c16668 100644 --- a/doc/manuals/osmopcu-usermanual.adoc +++ b/doc/manuals/osmopcu-usermanual.adoc @@ -17,6 +17,8 @@ include::{srcdir}/chapters/configuration.adoc[] +include::./common/chapters/code-architecture.adoc[] + include::{srcdir}/chapters/counters.adoc[] include::./common/chapters/gb.adoc[] -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36555?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibf6dd6f7e4d6370ad40733820faa70f9e5bc0e7d Gerrit-Change-Number: 36555 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-pcu[master]: tbf_ul.h: Mark empty param list as void
by pespin 12 Apr '24

12 Apr '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/36554?usp=email ) Change subject: tbf_ul.h: Mark empty param list as void ...................................................................... tbf_ul.h: Mark empty param list as void While at it, fix wrong whitespace indentation in one of the lines. Change-Id: I2a9213a9fdbe0f4b70d820c449dbb71539a733ce --- M src/tbf_ul.h 1 file changed, 19 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/54/36554/1 diff --git a/src/tbf_ul.h b/src/tbf_ul.h index 4ec0f6f..7a4c70c 100644 --- a/src/tbf_ul.h +++ b/src/tbf_ul.h @@ -59,8 +59,8 @@ struct gprs_rlcmac_ul_tbf : public gprs_rlcmac_tbf { gprs_rlcmac_ul_tbf(struct gprs_rlcmac_bts *bts, GprsMs *ms); - ~gprs_rlcmac_ul_tbf(); - gprs_rlc_window *window(); + ~gprs_rlcmac_ul_tbf(void); + gprs_rlc_window *window(void); void apply_allocated_resources(const struct alloc_resources_res *res); /* blocks were acked */ int rcv_data_block_acknowledged( @@ -70,7 +70,7 @@ /* TODO: extract LLC class? */ int assemble_forward_llc(const gprs_rlc_data *data); - int snd_ul_ud(); + int snd_ul_ud(void); egprs_rlc_ul_reseg_bsn_state handle_egprs_ul_spb( const struct gprs_rlc_data_info *rlc, @@ -87,12 +87,12 @@ struct gprs_rlc_data *block, uint8_t *data, const uint8_t block_idx); - uint16_t window_size() const; - void set_window_size(); + uint16_t window_size(void) const; + void set_window_size(void); void update_coding_scheme_counter_ul(enum CodingScheme cs); - void usf_timeout(); - void contention_resolution_start(); - void contention_resolution_success(); + void usf_timeout(void); + void contention_resolution_start(void); + void contention_resolution_success(void); /* Please note that all variables here will be reset when changing * from WAIT RELEASE back to FLOW state (re-use of TBF). -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36554?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a9213a9fdbe0f4b70d820c449dbb71539a733ce Gerrit-Change-Number: 36554 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-pcu[master]: tbf.h: Fix wrong type declaration of field dl_ass_fsm
by pespin 12 Apr '24

12 Apr '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/36553?usp=email ) Change subject: tbf.h: Fix wrong type declaration of field dl_ass_fsm ...................................................................... tbf.h: Fix wrong type declaration of field dl_ass_fsm The typo was harmless since as of now the two structs where identical. Change-Id: Ibbc59a0584ee0cd83de0e04eebdcca2aebe3e970 --- M src/tbf.h 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/53/36553/1 diff --git a/src/tbf.h b/src/tbf.h index 97f5562..4170ca1 100644 --- a/src/tbf.h +++ b/src/tbf.h @@ -245,7 +245,7 @@ struct rate_ctr_group *m_ctrs; struct osmo_fsm_inst *state_fi; struct tbf_ul_ass_fsm_ctx ul_ass_fsm; - struct tbf_ul_ass_fsm_ctx dl_ass_fsm; + struct tbf_dl_ass_fsm_ctx dl_ass_fsm; struct llist_item m_ms_list; struct llist_item m_trx_list; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36553?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibbc59a0584ee0cd83de0e04eebdcca2aebe3e970 Gerrit-Change-Number: 36553 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-pcu[master]: bts: Drop no-longer existing GprsMsStorage reference
by pespin 12 Apr '24

12 Apr '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/36552?usp=email ) Change subject: bts: Drop no-longer existing GprsMsStorage reference ...................................................................... bts: Drop no-longer existing GprsMsStorage reference This struct was removed (merged into gprs_rlcmac_bts) in commit eb0a0527e0a720fa9b0e351b5b38a8e46cb286e5. Change-Id: I2047588b1c187c842007fcb1eab0e8e4b7d7ed10 --- M src/bts.h 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/52/36552/1 diff --git a/src/bts.h b/src/bts.h index 380c47c..ab3907f 100644 --- a/src/bts.h +++ b/src/bts.h @@ -208,7 +208,6 @@ bool single_block; }; -struct GprsMsStorage; struct pcu_l1_meas; /** -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36552?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2047588b1c187c842007fcb1eab0e8e4b7d7ed10 Gerrit-Change-Number: 36552 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-pcu[master]: README.md: Remove 'multi-slot ul tbf' line from 'Current Limitations'
by pespin 12 Apr '24

12 Apr '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/36551?usp=email ) Change subject: README.md: Remove 'multi-slot ul tbf' line from 'Current Limitations' ...................................................................... README.md: Remove 'multi-slot ul tbf' line from 'Current Limitations' This feature was implemented in commit ed2afa3bed4c1b7a2bffae6be7df881de4f976e7, ~3 years ago. Change-Id: I9abe54f280ab4e62c0c5220d010575b912c8c141 --- M README.md 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/51/36551/1 diff --git a/README.md b/README.md index 3d11a78..8467c50 100644 --- a/README.md +++ b/README.md @@ -78,7 +78,6 @@ * No fixed allocation support (was removed from 3GPP Rel >= 5 anyway) * No extended dynamic allocation support * No unacknowledged mode operation - * Only single slot assignment on uplink direction * No half-duplex class support (only semi-duplex) * No TA loop * No power loop -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36551?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I9abe54f280ab4e62c0c5220d010575b912c8c141 Gerrit-Change-Number: 36551 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: ran-emu: allow receiving Paging without a TMSI
by pespin 12 Apr '24

12 Apr '24

Attention is currently required from: fixeria, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36454?usp=email ) Change subject: ran-emu: allow receiving Paging without a TMSI ...................................................................... Patch Set 2: (1 comment) File library/RAN_Emulation.ttcnpp: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36454/comment/442eea2c_59c6… PS1, Line 507: var template OCT4 tmsi := omit; > it works, why change it? That's like asking "this non-const pointer works, why change it?" -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36454?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1bdf3488be0f8d4f0905665c4ba642f9468b9777 Gerrit-Change-Number: 36454 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Apr 2024 10:29:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: expand TC_lu_tmsi_noauth_notmsi
by pespin 12 Apr '24

12 Apr '24

Attention is currently required from: fixeria, laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36460?usp=email ) Change subject: msc: expand TC_lu_tmsi_noauth_notmsi ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36460?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5e596597add7d585efd27c850067b8d7ba34ecc0 Gerrit-Change-Number: 36460 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Apr 2024 10:27:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: msc: add TC_lu_tmsi_noauth_notmsi
by pespin 12 Apr '24

12 Apr '24

Attention is currently required from: fixeria, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36459?usp=email ) Change subject: msc: add TC_lu_tmsi_noauth_notmsi ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36459?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If10b9987395670b084ff8ad6d1f033ff46896d75 Gerrit-Change-Number: 36459 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Apr 2024 10:26:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log