Attention is currently required from: neels.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/36557?usp=email )
Change subject: manual: 'Running': tweak word, fix ws at line end
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/36557?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Id9a4d2d75f86a252df0da6e7e0ae5ab47e8a7bf9
Gerrit-Change-Number: 36557
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 13 Apr 2024 16:23:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria, jolly, osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/36555?usp=email )
Change subject: doc: Introduce code architecture section with main class diagram
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> I created this diagram for my upcoming talk about Pcu past, present & future. […]
You can see it displayed here:
https://dreampuf.github.io/GraphvizOnline/?compressed=CYSw5gTghgDgFgAjiAptCBjOBPBBvAKADsB7YFAbQGc5YUBeCFDEiYAGioBdsAbBgGYhe-DkJEterepCjYAnAFYAugRTAwlUBHoAjKBgDW7BFAgQSAdy5Rh9FAFsYPVQQAKAYQCqFXlF0ovAj0CABEeGAwEFQA%2BjAYAK4APgDUCPEJMVQkRlk2XCgAOrxpulRUkcWlXLG8INwUysUAvqGqAEIAKgDKvv6BwWERUbEQvBgOBjG6NakIYFQOWdhUIEQCJFUIXBAAHjF1DU0lCA619VyNLW0EnQBKABp9AUEh4ZHRMWMTUzOxO7tUgleDEuLoBFQriVgCCwRCoa1VG4ACIeAASzwGb2Gn2%2BkwwcWAWDm9RiKCI-lEWxgRLgMWBGC2UHK4CI6npVAEMUmVEMTJZYDZwFBQm5zMMMQAFDD2MCAJRbOGxGFQtJK%2Bm8VXpKBgNYLBE3LwAGQ8mNeQxpWA1GDmTF13DQ7JgJBEkOOiIIxo8MQAcgB5ZEAUTNg3ClrpDJipHIcwEREV2BgRV4Hq9voDgZinXaADEYl5ujmQ9jw9ao2QUKDwRyBHNgVWBNdVGn-UGs7mYm4-UajcWLbSy9HK3C4i7eHNnSIGwhJcaAPTIo0Kk5MZkkeMpw0m9Nt7rtACCfbDA8jQ6y%2BjmVH0TYIAFlen4XqG8ABxEa3qgks4gExcEQ-7YoAAOhArYmAEFgEiILgtkScxyS4UE9i2IRokQlgHAcddQSoLYJBiABHBIUGIm9syLR8sSGD5RnGfEGzmLghC2FAaLJCldCpE4WGgixYVwk5wy1etmViCEHC2GEYlEmJxK2Sw1mAKw8PGWToAcZM0m%2BaYpCMATUyNdsKP6c13hGL46Kmes4UvfJKzkk4RNyBy0gSTkDVURcjKPHFaJ%2BAkpJstJuCgApZMWG890PSjTN8iz-PPKAJ1pFCNzVKAbzubcAHUAEkfWRP1sp8ti8SmBSiCUyxLyIAS0ksfSbiy708oKor817GLn1KyyCQqqqNTmAA3L4thGgixqjDyCGamJWsK7KYkXErzLKvrFKsGIYWGrJJoyk4Rt0aae29ABFLxAwulbPnwoiSJQCcIBAEhCOI4i3RvE7OzuXK-Ric7LuDLrsTY-Come177rmFhyBBEKCmpJ7WBAHgUPUlAPs3VQvpzO591vIGTO68z8IEdGJzkKQoGALVweR1GsZm7d2iNP0PAAaWuvz6O0zickMJIQKAj13G8BAAFoAD4EC6boEAoOAUGpmL6FCAAqUJf1sEQTNVgBGG5ZYl6X7geeXFeV3XQgABhAgAOTXAOEFXQgNjoemNhB73NpWYStjWtedq23duR5PZRdEfctl5VdtoCHcDnWY9dm53FRNFPa9KO-eTg3E5duOQ6zqWEBbDNs5dgOnaTwJ9a3b1W0DTPt0boz80LeWzAsaxtfoMgQCgLDKubFvy5Lsu23IztuyNTvzCsGw7H7wf12AEeG7H6WJ8zKK5%2B7xfeD70AV%2BHz1R93A9PaihXfZdvPq7v1PyOboy94X3vl6HtfblzT2vOfigXd35L2Pl-Vws15pFU9hA-KC0Opvx7iAgeYCmYtVgVAkuMC2qLUXAgg%2BR9kGr1cN7EuACLY51rurR2B9H7ELliXL6AMLoV2DtQ7WtCCCMIuswhh243A-T%2BkwpuN9o6UKrjQ1h2M%2BECP%2BtwpuvDvS43xsI8hlc2FB1zk-X%2BmCcroOyiw5O4j2GSJ-jmT2OM8YEwMZQwu6ia6HxTqoZ%2BOjvQszZuzaxDijEaMoSHUOZsS7exERQrxdjH4mG4HwBgwBmSKw4KYeeiDD6kDZCYF2olWTqBuM46WEcM7BILvbMJrCIk8H4PQGJNB1AmCAUk%2BgKSUBpKthkwUWTXDGlfuPc%2BmYp4FjMdQMp0TYnVISfvXuDSmnJztBcR0wBsnaK3t0tuXYezy0ieUypcSamJPwRMhALtpkOiYHM1wpsX5kNvv7YpmjSlRIqcM%2BJ6SBRCmyWHEu-9f4FKufnEpCB1lDKqY85pzy2kEGaEAA
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36555?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ibf6dd6f7e4d6370ad40733820faa70f9e5bc0e7d
Gerrit-Change-Number: 36555
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 13 Apr 2024 15:02:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/36557?usp=email )
Change subject: manual: 'Running': tweak word, fix ws at line end
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/36557?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Id9a4d2d75f86a252df0da6e7e0ae5ab47e8a7bf9
Gerrit-Change-Number: 36557
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 13 Apr 2024 14:56:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment