- gerrit-log - lists.osmocom.org

[XS] Change in pysim[master]: pySim.esim.saip: Fix docstring warnings:
by fixeria 09 Feb '26

09 Feb '26

Attention is currently required from: laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/42078?usp=email ) Change subject: pySim.esim.saip: Fix docstring warnings: ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/42078/comment/ff965f98_584e0a71?usp=em… : PS1, Line 2007: ' Why is this comma needed here? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42078?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id7debf9296923b735f76623808cee68967a1ece7 Gerrit-Change-Number: 42078 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 09 Feb 2026 12:07:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: logging: Fix print tid value in multithreadded programs
by pespin 09 Feb '26

09 Feb '26

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/42085?usp=email ) Change subject: logging: Fix print tid value in multithreadded programs ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42085?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I363751ab1368d916aad8905b056ec4f9d62b7175 Gerrit-Change-Number: 42085 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder

1 0

[S] Change in libosmocore[master]: logging: Fix print tid value in multithreadded programs
by pespin 09 Feb '26

09 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/42085?usp=email ) Change subject: logging: Fix print tid value in multithreadded programs ...................................................................... logging: Fix print tid value in multithreadded programs Change-Id: I363751ab1368d916aad8905b056ec4f9d62b7175 --- M src/core/logging.c 1 file changed, 9 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/85/42085/1 diff --git a/src/core/logging.c b/src/core/logging.c index db5433e..acfdf3c 100644 --- a/src/core/logging.c +++ b/src/core/logging.c @@ -606,9 +606,15 @@ OSMO_STRBUF_PRINTF(sb, " "); } if (target->print_tid) { - if (log_thread_state.tid == 0) - log_thread_state.tid = (long int)osmo_gettid(); - OSMO_STRBUF_PRINTF(sb, "%ld ", log_thread_state.tid); + long int tid; + if (!osmo_log_tgt_mutex_on) { + tid = log_thread_state.tid; + if (OSMO_UNLIKELY(tid == 0)) + tid = log_thread_state.tid = (long int)osmo_gettid(); + } else { + tid = (long int)osmo_gettid(); + } + OSMO_STRBUF_PRINTF(sb, "%ld ", tid); } if (target->print_category) OSMO_STRBUF_PRINTF(sb, "%s%s%s%s ", -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42085?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I363751ab1368d916aad8905b056ec4f9d62b7175 Gerrit-Change-Number: 42085 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: osmo_io: Lazy-initialize during osmo_iofd_setup()
by pespin 09 Feb '26

09 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/42084?usp=email ) Change subject: osmo_io: Lazy-initialize during osmo_iofd_setup() ...................................................................... osmo_io: Lazy-initialize during osmo_iofd_setup() This way new threads (!=main) don't need to explicitly call osmo_iofd_init() explicitly before using osmo_io. This is specially useful for threads using osmo_io indirectly, eg, when logging. The osmo_iofd_setup() API is really the only main API which requires initialization. All other APIs requiring it come after osmo_iofd_setup() since they use an osmo_iofd pointer. Change-Id: Ia543c1b9d111c929cd9dbed266b6d21b74e47e4b --- M src/core/osmo_io.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/84/42084/1 diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index 9e159a1..7c59a61 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -69,9 +69,14 @@ /* Used by some tests, can't be static */ struct iofd_backend_ops osmo_iofd_ops; +static __thread bool g_thread_initialized = false; + /*! initialize osmo_io for the current thread */ void osmo_iofd_init(void) { + if (g_thread_initialized) + return; + switch (g_io_backend) { case OSMO_IO_BACKEND_POLL: break; @@ -84,6 +89,7 @@ OSMO_ASSERT(0); break; } + g_thread_initialized = true; } /* ensure main thread always has pre-initialized osmo_io @@ -833,6 +839,7 @@ const struct osmo_io_ops *ioops, void *data) { struct osmo_io_fd *iofd; + osmo_iofd_init(); /* reject unsupported/unknown modes */ switch (mode) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42084?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia543c1b9d111c929cd9dbed266b6d21b74e47e4b Gerrit-Change-Number: 42084 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: osmo_io_uring: Split global init from per-thread init
by pespin 09 Feb '26

09 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/42083?usp=email ) Change subject: osmo_io_uring: Split global init from per-thread init ...................................................................... osmo_io_uring: Split global init from per-thread init osmo_iofd_init() is expected to be called per-thread, while some code in osmo_iofd_uring_init() was only expected to be called once. Change-Id: Ifa5c46d7532ea49869f3cfe7268fdd082906fd10 --- M src/core/osmo_io.c M src/core/osmo_io_internal.h M src/core/osmo_io_uring.c 3 files changed, 19 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/83/42083/1 diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index e7645cb..9e159a1 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -101,6 +101,7 @@ } else if (!strcmp("IO_URING", backend)) { g_io_backend = OSMO_IO_BACKEND_IO_URING; osmo_iofd_ops = iofd_uring_ops; + osmo_iofd_uring_constructor(); #endif } else { fprintf(stderr, "Invalid osmo_io backend requested: \"%s\"\nCheck the environment variable %s\n", backend, OSMO_IO_BACKEND_ENV); diff --git a/src/core/osmo_io_internal.h b/src/core/osmo_io_internal.h index 6b642b9..81a70f3 100644 --- a/src/core/osmo_io_internal.h +++ b/src/core/osmo_io_internal.h @@ -21,6 +21,7 @@ #if defined(HAVE_URING) extern const struct iofd_backend_ops iofd_uring_ops; +void osmo_iofd_uring_constructor(void); void osmo_iofd_uring_init(void); #endif diff --git a/src/core/osmo_io_uring.c b/src/core/osmo_io_uring.c index 3925f94..6ae21cf 100644 --- a/src/core/osmo_io_uring.c +++ b/src/core/osmo_io_uring.c @@ -107,15 +107,15 @@ } /*! initialize the uring and tie it into our event loop */ -void osmo_iofd_uring_init(void) +void osmo_iofd_uring_constructor(void) { const char *env; - int rc, evfd; + int rc; if ((env = getenv(OSMO_IO_URING_BATCH))) g_io_uring_batch = true; - if (!g_ring && (env = getenv(OSMO_IO_URING_INITIAL_SIZE))) { + if ((env = getenv(OSMO_IO_URING_INITIAL_SIZE))) { int env_value; rc = osmo_str_to_int(&env_value, env, 10, 1, IOFD_URING_MAXIMUM_SIZE); if (rc < 0) { @@ -130,13 +130,6 @@ g_io_uring_size = env_value; } - g_ring = talloc_zero(OTC_GLOBAL, struct osmo_io_uring); - INIT_LLIST_HEAD(&g_ring->cancel_queue); - - rc = io_uring_queue_init(g_io_uring_size, &g_ring->ring, 0); - if (rc < 0) - osmo_panic("failure during io_uring_queue_init(): %s\n", strerror(-rc)); - if ((env = getenv(OSMO_IO_URING_READ_SQE))) { g_io_uring_read_sqes = atoi(env); if (g_io_uring_read_sqes < 1 || g_io_uring_read_sqes > IOFD_MSGHDR_MAX_READ_SQES) { @@ -145,6 +138,20 @@ exit(1); } } +} + +/*! Per-thread: initialize the uring and tie it into our event loop */ +void osmo_iofd_uring_init(void) +{ + int rc, evfd; + + g_ring = talloc_zero(OTC_GLOBAL, struct osmo_io_uring); + OSMO_ASSERT(g_ring); + INIT_LLIST_HEAD(&g_ring->cancel_queue); + + rc = io_uring_queue_init(g_io_uring_size, &g_ring->ring, 0); + if (rc < 0) + osmo_panic("failure during io_uring_queue_init(): %s\n", strerror(-rc)); rc = eventfd(0, 0); if (rc < 0) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42083?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifa5c46d7532ea49869f3cfe7268fdd082906fd10 Gerrit-Change-Number: 42083 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in pysim[master]: pySim-shell_test/euicc: ensure test-profile is enabled
by dexter 09 Feb '26

09 Feb '26

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42077?usp=email ) Change subject: pySim-shell_test/euicc: ensure test-profile is enabled ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42077?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie57b0305876bc5001ab3a9c3a3b5711408161b74 Gerrit-Change-Number: 42077 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 09 Feb 2026 11:34:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in libosmocore[master]: osmo_io: Move function declaration to internal header
by pespin 09 Feb '26

09 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/42082?usp=email ) Change subject: osmo_io: Move function declaration to internal header ...................................................................... osmo_io: Move function declaration to internal header Change-Id: I25ffb94e00225bcdc565f56a3f0f7834df00e974 --- M src/core/osmo_io.c M src/core/osmo_io_internal.h 2 files changed, 1 insertion(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/82/42082/1 diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index 8ee6967..e7645cb 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -69,10 +69,6 @@ /* Used by some tests, can't be static */ struct iofd_backend_ops osmo_iofd_ops; -#if defined(HAVE_URING) -void osmo_iofd_uring_init(void); -#endif - /*! initialize osmo_io for the current thread */ void osmo_iofd_init(void) { diff --git a/src/core/osmo_io_internal.h b/src/core/osmo_io_internal.h index 4f35fee..6b642b9 100644 --- a/src/core/osmo_io_internal.h +++ b/src/core/osmo_io_internal.h @@ -21,6 +21,7 @@ #if defined(HAVE_URING) extern const struct iofd_backend_ops iofd_uring_ops; +void osmo_iofd_uring_init(void); #endif struct iofd_backend_ops { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42082?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I25ffb94e00225bcdc565f56a3f0f7834df00e974 Gerrit-Change-Number: 42082 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: pySim.esim.saip.personalization: Fix docstring error
by laforge 09 Feb '26

09 Feb '26

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42080?usp=email ) Change subject: pySim.esim.saip.personalization: Fix docstring error ...................................................................... pySim.esim.saip.personalization: Fix docstring error pySim/esim/saip/personalization.py:docstring of pySim.esim.saip.personalization.MilenageXoringConstants:4: ERROR: Unexpected indentation. [docutils] Change-Id: If6ae360b7f74c095fa9075ae9aa988440496e6de --- M pySim/esim/saip/personalization.py 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/80/42080/1 diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py index 54aaa43..c61675f 100644 --- a/pySim/esim/saip/personalization.py +++ b/pySim/esim/saip/personalization.py @@ -640,12 +640,14 @@ class MilenageXoringConstants(BinaryParam, AlgoConfig): """XOR-ing constants c1,c2,c3,c4,c5 of Milenage, 128bit each. See 3GPP TS 35.206 Sections 2.3 + 5.3. Provided as octet-string concatenation of all 5 constants. The default value by 3GPP is the concetenation - of: + of:: + 00000000000000000000000000000000 00000000000000000000000000000001 00000000000000000000000000000002 00000000000000000000000000000004 00000000000000000000000000000008 + """ name = 'MilenageXOR' algo_config_key = 'xoringConstants' -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42080?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If6ae360b7f74c095fa9075ae9aa988440496e6de Gerrit-Change-Number: 42080 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: pySim.esim.saip: Fix docstring warnings:
by laforge 09 Feb '26

09 Feb '26

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42078?usp=email ) Change subject: pySim.esim.saip: Fix docstring warnings: ...................................................................... pySim.esim.saip: Fix docstring warnings: this fixes the following two warnings: pySim/esim/saip/__init__.py:docstring of pySim.esim.saip.FsNode.walk:1: WARNING: Inline strong start-string without end-string. [docutils] pySim/esim/saip/__init__.py:docstring of pySim.esim.saip.FsNodeDF.walk:1: WARNING: Inline strong start-string without end-string. [docutils] Change-Id: Id7debf9296923b735f76623808cee68967a1ece7 --- M pySim/esim/saip/__init__.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/78/42078/1 diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index 6962ee8..a50e86f 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -2004,7 +2004,7 @@ return x def walk(self, fn, **kwargs): - """call 'fn(self, **kwargs) for the File.""" + """call 'fn(self, ``**kwargs``) for the File.""" return [fn(self, **kwargs)] class FsNodeEF(FsNode): @@ -2094,7 +2094,7 @@ return cur def walk(self, fn, **kwargs): - """call 'fn(self, **kwargs) for the DF and recursively for all children.""" + """call 'fn(self, ``**kwargs``) for the DF and recursively for all children.""" ret = super().walk(fn, **kwargs) for c in self.children.values(): ret += c.walk(fn, **kwargs) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42078?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id7debf9296923b735f76623808cee68967a1ece7 Gerrit-Change-Number: 42078 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: pysim.utils.decomposeATR: Fix docutils warning
by laforge 09 Feb '26

09 Feb '26

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42079?usp=email ) Change subject: pysim.utils.decomposeATR: Fix docutils warning ...................................................................... pysim.utils.decomposeATR: Fix docutils warning pySim/utils.py:docstring of pySim.utils.decomposeATR:9: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils] Change-Id: Ifda4ba15014ba97634fd5bd5c9b19d9110f4670e --- M pySim/utils.py 1 file changed, 11 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/79/42079/1 diff --git a/pySim/utils.py b/pySim/utils.py index 7d8e3fa..1fdcefe 100644 --- a/pySim/utils.py +++ b/pySim/utils.py @@ -631,15 +631,17 @@ Returns: dictionary of field and values - >>> decomposeATR("3B A7 00 40 18 80 65 A2 08 01 01 52") - { 'T0': {'value': 167}, - 'TB': {1: {'value': 0}}, - 'TC': {2: {'value': 24}}, - 'TD': {1: {'value': 64}}, - 'TS': {'value': 59}, - 'atr': [59, 167, 0, 64, 24, 128, 101, 162, 8, 1, 1, 82], - 'hb': {'value': [128, 101, 162, 8, 1, 1, 82]}, - 'hbn': 7} + Example:: + + >>> decomposeATR("3B A7 00 40 18 80 65 A2 08 01 01 52") + { 'T0': {'value': 167}, + 'TB': {1: {'value': 0}}, + 'TC': {2: {'value': 24}}, + 'TD': {1: {'value': 64}}, + 'TS': {'value': 59}, + 'atr': [59, 167, 0, 64, 24, 128, 101, 162, 8, 1, 1, 82], + 'hb': {'value': [128, 101, 162, 8, 1, 1, 82]}, + 'hbn': 7} """ ATR_PROTOCOL_TYPE_T0 = 0 atr_txt = normalizeATR(atr_txt) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42079?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ifda4ba15014ba97634fd5bd5c9b19d9110f4670e Gerrit-Change-Number: 42079 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log