- gerrit-log - lists.osmocom.org

[M] Change in libosmo-sigtran[master]: Refactor xua_layer_manager object
by pespin 06 Feb '26

06 Feb '26

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42054?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: Refactor xua_layer_manager object ...................................................................... Refactor xua_layer_manager object Several changes to improve separation of the LM object and its lifecycle: * Store in ss7_asp a pointer to a xua_layer_manager, which contains all implementation dependent information inside its priv pointer. * Add a new free_func field to the xua_layer_manager struct in order to be able to free it without knowing how it was allocated. * Get rid og the loglevel param, LOGL_DEBUG was always passed and that was actually an implementation specific detail of the default xua layer manager. * Pass pointer to function to be called by LM to submit primitives to M3UA. Change-Id: Ia96ebf40444f46ad718d61befbecb523f267fd6c --- M include/osmocom/sigtran/osmo_ss7.h M src/ss7_asp.c M src/ss7_asp.h M src/xua_default_lm_fsm.c 4 files changed, 69 insertions(+), 51 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/54/42054/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42054?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ia96ebf40444f46ad718d61befbecb523f267fd6c Gerrit-Change-Number: 42054 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: lm: Initialize layer manager also on role=SG
by pespin 06 Feb '26

06 Feb '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42062?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: lm: Initialize layer manager also on role=SG ...................................................................... lm: Initialize layer manager also on role=SG Right now the LM will stay in IDLE for role=SG, but it already provides with an easier logic where all xUA ASPs (no matter their role) have an associated FSM object, which can be extnded later on. This way we already valdiate the FSM instance lifecycle wroks as expected. It also allows in the future more easily integrating the LM in role IPSP, where it will need to be extended. Change-Id: I1f25cf8371ba72d710796e01a9a967d3fafffb99 --- M src/ss7_asp.c M src/xua_default_lm_fsm.c 2 files changed, 7 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/62/42062/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42062?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I1f25cf8371ba72d710796e01a9a967d3fafffb99 Gerrit-Change-Number: 42062 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[XS] Change in libosmo-sigtran[master]: lm: Use layer manager also on transport-role=server
by pespin 06 Feb '26

06 Feb '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42059?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: lm: Use layer manager also on transport-role=server ...................................................................... lm: Use layer manager also on transport-role=server The upper layers (M3UA) should behave similarly eg. on role ASP independently of transport role being client or server. Change-Id: I5f0109463323f214e15610b2c4fe253b828fce3b --- M src/ss7_asp.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/59/42059/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42059?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I5f0109463323f214e15610b2c4fe253b828fce3b Gerrit-Change-Number: 42059 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: Fix asp selection if no tcap-range was found
by daniel 06 Feb '26

06 Feb '26

daniel has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42064?usp=email ) Change subject: tcap_as_loadshare: Fix asp selection if no tcap-range was found ...................................................................... tcap_as_loadshare: Fix asp selection if no tcap-range was found Keep doing loadshare round-robin style, but select only active asps that have tcap enabled in the config. Related: SYS#5423 Change-Id: I07e77548ecb75df9227487901b75018261bd1232 --- M src/ss7_as.h M src/tcap_as_loadshare.c 2 files changed, 13 insertions(+), 7 deletions(-) Approvals: lynxis lazus: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/src/ss7_as.h b/src/ss7_as.h index 50df338..252e863 100644 --- a/src/ss7_as.h +++ b/src/ss7_as.h @@ -159,6 +159,7 @@ struct { bool enabled; unsigned int timeout_s; + uint8_t last_asp_idx_sent; } tcap; #endif /* WITH_TCAP_LOADSHARING */ } loadshare; diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index 623bd3b..5c964ce 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -230,17 +230,22 @@ static struct osmo_ss7_asp *find_asp_no_tcap_range(struct osmo_ss7_as *as) { - struct osmo_ss7_asp *asp = NULL; + struct osmo_ss7_asp *asp; + unsigned int i; + unsigned int first_idx; - for (int i = 0; i < ARRAY_SIZE(as->cfg.asps); i++) { + first_idx = (as->cfg.loadshare.tcap.last_asp_idx_sent + 1) % ARRAY_SIZE(as->cfg.asps); + i = first_idx; + do { asp = as->cfg.asps[i]; - if (!asp) - continue; - if (!asp->tcap.enabled) + if (asp && osmo_ss7_asp_active(asp) && asp->tcap.enabled) { + as->cfg.loadshare.tcap.last_asp_idx_sent = i; return asp; - } + } + i = (i + 1) % ARRAY_SIZE(as->cfg.asps); + } while (i != first_idx); - return asp; + return NULL; } static bool ssn_contains_tcap(uint8_t ssn) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42064?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I07e77548ecb75df9227487901b75018261bd1232 Gerrit-Change-Number: 42064 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: Fix asp selection if no tcap-range was found
by lynxis lazus 06 Feb '26

06 Feb '26

Attention is currently required from: daniel. lynxis lazus has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42064?usp=email ) Change subject: tcap_as_loadshare: Fix asp selection if no tcap-range was found ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42064?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I07e77548ecb75df9227487901b75018261bd1232 Gerrit-Change-Number: 42064 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 Feb 2026 14:42:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: Fix asp selection if no tcap-range was found
by pespin 06 Feb '26

06 Feb '26

Attention is currently required from: daniel, lynxis lazus. pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42064?usp=email ) Change subject: tcap_as_loadshare: Fix asp selection if no tcap-range was found ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42064?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I07e77548ecb75df9227487901b75018261bd1232 Gerrit-Change-Number: 42064 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 06 Feb 2026 14:35:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: Fix asp selection if no tcap-range was found
by daniel 06 Feb '26

06 Feb '26

Attention is currently required from: lynxis lazus, pespin. daniel has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42064?usp=email ) Change subject: tcap_as_loadshare: Fix asp selection if no tcap-range was found ...................................................................... Patch Set 2: (2 comments) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42064/comment/a59f6239_b9c93… : PS1, Line 233: struct osmo_ss7_asp *asp; > I would also set it to NULL I adjusted the loop to not need the initialization here. https://gerrit.osmocom.org/c/libosmo-sigtran/+/42064/comment/098262cf_693d4… : PS1, Line 247: return asp; > ACK. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42064?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I07e77548ecb75df9227487901b75018261bd1232 Gerrit-Change-Number: 42064 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 06 Feb 2026 14:34:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: Fix asp selection if no tcap-range was found
by daniel 06 Feb '26

06 Feb '26

Attention is currently required from: lynxis lazus, pespin. Hello Jenkins Builder, lynxis lazus, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42064?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: tcap_as_loadshare: Fix asp selection if no tcap-range was found ...................................................................... tcap_as_loadshare: Fix asp selection if no tcap-range was found Keep doing loadshare round-robin style, but select only active asps that have tcap enabled in the config. Related: SYS#5423 Change-Id: I07e77548ecb75df9227487901b75018261bd1232 --- M src/ss7_as.h M src/tcap_as_loadshare.c 2 files changed, 13 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/64/42064/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42064?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I07e77548ecb75df9227487901b75018261bd1232 Gerrit-Change-Number: 42064 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: as_rsl_meas_res(): tolerate bad RxQual in early reports
by pespin 06 Feb '26

06 Feb '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42070?usp=email ) Change subject: bts: as_rsl_meas_res(): tolerate bad RxQual in early reports ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42070?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie8acb15b66cd92092ec49bc8caeaf0ad4d471f1d Gerrit-Change-Number: 42070 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 Feb 2026 09:40:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: as_rsl_meas_res(): tolerate bad RxQual in early reports
by fixeria 06 Feb '26

06 Feb '26

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42070?usp=email ) Change subject: bts: as_rsl_meas_res(): tolerate bad RxQual in early reports ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42070/comment/315e5717_dd23… : PS1, Line 9: Bit errors are expected during early stage of channel establishment. > why are they expected? Several reasons: * Before the MS goes to DCCH, the BTS is getting NOPE.ind => bit errors. * After the MS goes to DCCH, it's not guaranteed that it starts transmitting exactly at `bid=0` => bit errors. * For TCH channels employing block-diagonal interleaving, the very first UL block contains only 50% of the actual data => but errors. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42070?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie8acb15b66cd92092ec49bc8caeaf0ad4d471f1d Gerrit-Change-Number: 42070 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 Feb 2026 09:39:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log