- gerrit-log - lists.osmocom.org

[M] Change in osmo-ggsn[master]: gtp: Allow setting callback to receive update_context_ind
by laforge 31 Jul '24

31 Jul '24

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/37597?usp=email ) Change subject: gtp: Allow setting callback to receive update_context_ind ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/37597?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ic80a9a928c55b6ff85be96014920bb42793cb943 Gerrit-Change-Number: 37597 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 Jul 2024 15:02:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ggsn[master]: gtp: Allow setting callback to receive update_context_ind
by laforge 31 Jul '24

31 Jul '24

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/37597?usp=email ) Change subject: gtp: Allow setting callback to receive update_context_ind ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: likewise, TODO-RELEASE for ABI change? -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/37597?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ic80a9a928c55b6ff85be96014920bb42793cb943 Gerrit-Change-Number: 37597 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 Jul 2024 15:02:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in libosmo-netif[master]: ipa: Ensure osmo_ipa_segmentation_cb sets msg->l2h to the payload data
by daniel 31 Jul '24

31 Jul '24

daniel has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/37661?usp=email ) Change subject: ipa: Ensure osmo_ipa_segmentation_cb sets msg->l2h to the payload data ...................................................................... ipa: Ensure osmo_ipa_segmentation_cb sets msg->l2h to the payload data Previously if ih->proto was IPAC_PROTO_OSMO msg->l2h would still point to the extension header byte which breaks assumptions in e.g. osmo-bsc. Change-Id: Id91cddf9948ca49abf092850fae3a8f17e445b45 Related: OS#6422 --- M src/ipa.c 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/src/ipa.c b/src/ipa.c index 8720427..d43df00 100644 --- a/src/ipa.c +++ b/src/ipa.c @@ -375,7 +375,8 @@ #define MSG_CB_IPA_INFO_OFFSET 0 /* Check and remove headers (in case of p == IPAC_PROTO_OSMO, also the IPA extension header). - * Returns a negative number on error, otherwise the number of octets removed */ + * Returns a negative number on error, otherwise the number of octets removed. + * Both msg->data and msg->l2h point to the user data after the (extended) IPA header if this function is successful. */ static inline int ipa_check_pull_headers(struct msgb *msg) { int ret; @@ -397,6 +398,7 @@ osmo_ipa_msgb_cb_proto_ext(msg) = msg->data[0]; msgb_pull(msg, sizeof(struct ipa_head_ext)); octets_removed += sizeof(struct ipa_head_ext); + msg->l2h = msg->data; return octets_removed; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/37661?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Id91cddf9948ca49abf092850fae3a8f17e445b45 Gerrit-Change-Number: 37661 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ggsn[master]: gtp: Allow UpdatePDPContext initiated by GGSN
by laforge 31 Jul '24

31 Jul '24

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/37666?usp=email ) Change subject: gtp: Allow UpdatePDPContext initiated by GGSN ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/37666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I1c3441c71b90c5bbf6f4545484586222e6180fe1 Gerrit-Change-Number: 37666 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 Jul 2024 15:01:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ggsn[master]: gtp: Store rx Direct Tunnel Flags in UpdatePDPCtx{Req,Resp}
by laforge 31 Jul '24

31 Jul '24

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/37595?usp=email ) Change subject: gtp: Store rx Direct Tunnel Flags in UpdatePDPCtx{Req,Resp} ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/37595?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ia3e360a35d30858eab1e438dc2508fd756c2e22e Gerrit-Change-Number: 37595 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 Jul 2024 15:00:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ggsn[master]: gtp: Allow tx Direct Tunnel Flags in UpdatePDPCtx{Req,Resp}
by laforge 31 Jul '24

31 Jul '24

Attention is currently required from: daniel, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/37594?usp=email ) Change subject: gtp: Allow tx Direct Tunnel Flags in UpdatePDPCtx{Req,Resp} ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: doesn't this need a TODO-RELEASE for the ABI breakage? -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/37594?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I36d93619e2fe9cafd3092515df18b82d29099d2d Gerrit-Change-Number: 37594 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 Jul 2024 15:00:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: tbf_ul_ass_fsm: Clarify use of X2000 timer
by pespin 31 Jul '24

31 Jul '24

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-pcu/+/37669?usp=email ) Change subject: tbf_ul_ass_fsm: Clarify use of X2000 timer ...................................................................... tbf_ul_ass_fsm: Clarify use of X2000 timer See 683ce64039bb9192b597e62344f0aa084b4ac4c9 for a complementary analysis and description of the timer. Related: OS#3928 Change-Id: Iee27d1b2a8ddac53e14efd20a8c8aec35de58174 --- M src/tbf_ul_ass_fsm.c M tests/tbf/TbfTest.err 2 files changed, 28 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/69/37669/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/37669?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iee27d1b2a8ddac53e14efd20a8c8aec35de58174 Gerrit-Change-Number: 37669 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-pcu[master]: tbf_ul_ass_fsm: Clarify use of X2000 timer
by pespin 31 Jul '24

31 Jul '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/37669?usp=email ) Change subject: tbf_ul_ass_fsm: Clarify use of X2000 timer ...................................................................... tbf_ul_ass_fsm: Clarify use of X2000 timer Related: OS#3928 Change-Id: Iee27d1b2a8ddac53e14efd20a8c8aec35de58174 --- M src/tbf_ul_ass_fsm.c M tests/tbf/TbfTest.err 2 files changed, 25 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/69/37669/1 diff --git a/src/tbf_ul_ass_fsm.c b/src/tbf_ul_ass_fsm.c index 6f88f11..de5b901 100644 --- a/src/tbf_ul_ass_fsm.c +++ b/src/tbf_ul_ass_fsm.c @@ -156,16 +156,26 @@ unsigned long val; unsigned int sec, micro; - /* Start release after rejecting only if it is UL TBF */ if (prev_state == TBF_UL_ASS_SEND_ASS_REJ && tbf_direction(ctx->tbf) == GPRS_RLCMAC_UL_TBF) { - /* tbf_free() called upon trigger */ + /* If TBF object doing the UL assignment is also an UL TBF, and + * it was just rejected over PACCH, then there's nothing more to do + * with this UL TBF other than freeing it and waiting for MS to + * retry asking for another UL TBF assignment. But since we are + * currently being called from the scheduled (we arrived here + * through st_send_ass_rej(TBF_UL_ASS_EV_CREATE_RLCMAC_MSG)), + * then we need to delay the tbf_free() to do it asynchrosnouly + * in the event loop. Using a fixed 0ms internal fsm timer + * number would have been fine here, but since for historical + * reasons we have VTY-configurable X2000 for this purpose, keep + * using it (it is expected to be 0 usually). + */ fi->T = -2000; val = osmo_tdef_get(the_pcu->T_defs, fi->T, OSMO_TDEF_MS, -1); sec = val / 1000; micro = (val % 1000) * 1000; - LOGPTBF(ctx->tbf, LOGL_DEBUG, "Starting timer X2000 [reject (PACCH)] with %u sec. %u microsec\n", - sec, micro); + LOGPTBF(ctx->tbf, LOGL_DEBUG, "Starting timer X2000 [delay free after Packet Access Reject (PACCH)] with %lums\n", + val); osmo_timer_schedule(&fi->timer, sec, micro); } diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err index 062dd23..fdaf917 100644 --- a/tests/tbf/TbfTest.err +++ b/tests/tbf/TbfTest.err @@ -11923,7 +11923,7 @@ UL_ASS_TBF(UL:TFI-0-0--1:G:TLLI-0xffeeddcc){NONE}: state_chg to SEND_ASS_REJ UL_ASS_TBF(UL:TFI-0-0--1:G:TLLI-0xffeeddcc){SEND_ASS_REJ}: Received Event CREATE_RLCMAC_MSG UL_ASS_TBF(UL:TFI-0-0--1:G:TLLI-0xffeeddcc){SEND_ASS_REJ}: state_chg to NONE -TBF(UL:TFI-0-0--1:G:TLLI-0xffeeddcc){ASSIGN} Starting timer X2000 [reject (PACCH)] with 0 sec. 0 microsec +TBF(UL:TFI-0-0--1:G:TLLI-0xffeeddcc){ASSIGN} Starting timer X2000 [delay free after Packet Access Reject (PACCH)] with 0ms PDCH(bts=0,trx=0,ts=7) FN=2654218 Scheduling control message at RTS for TBF(UL:TFI-0-0--1:G:TLLI-0xffeeddcc){ASSIGN} UL_ASS_TBF(UL:TFI-0-0--1:G:TLLI-0xffeeddcc){NONE}: Timeout of X2000 TBF(UL:TFI-0-0--1:G:TLLI-0xffeeddcc){ASSIGN} free -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/37669?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iee27d1b2a8ddac53e14efd20a8c8aec35de58174 Gerrit-Change-Number: 37669 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ci[master]: OBS: latest: handle "version is None"
by osmith 31 Jul '24

31 Jul '24

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37668?usp=email ) Change subject: OBS: latest: handle "version is None" ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Looks like this script needs some unit tests... agreed, this would be useful -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37668?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I69cb884d499d1f6a8cae4b4585d31b5bc095fd6e Gerrit-Change-Number: 37668 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 Jul 2024 11:06:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: OBS: latest: handle "version is None"
by fixeria 31 Jul '24

31 Jul '24

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37668?usp=email ) Change subject: OBS: latest: handle "version is None" ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Looks like this script needs some unit tests... -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37668?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I69cb884d499d1f6a8cae4b4585d31b5bc095fd6e Gerrit-Change-Number: 37668 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 Jul 2024 10:32:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log