- gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: sgsn: Introduce test TC_update_ctx_err_ind_from_ggsn
by pespin 30 Jul '24

30 Jul '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37665?usp=email ) Change subject: sgsn: Introduce test TC_update_ctx_err_ind_from_ggsn ...................................................................... sgsn: Introduce test TC_update_ctx_err_ind_from_ggsn Related: OS#6512 Related: SYS#5435 Change-Id: Ic417b23cae798361f73150f6a72f91e2f8528e7a --- M library/GTPv1C_Templates.ttcn M library/GTPv1U_Templates.ttcn M sgsn/BSSGP_ConnHdlr.ttcn M sgsn/SGSN_Tests_Iu.ttcn M sgsn/expected-results.xml 5 files changed, 201 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/65/37665/1 diff --git a/library/GTPv1C_Templates.ttcn b/library/GTPv1C_Templates.ttcn index 893ab01..b1059fe 100644 --- a/library/GTPv1C_Templates.ttcn +++ b/library/GTPv1C_Templates.ttcn @@ -404,6 +404,18 @@ } } + /* 7.7.81 Direct Tunnel Flags */ + template (value) DirectTunnelFlags ts_DirectTunnelFlags(BIT1 dTI := '0'B, + BIT1 gCSI := '0'B, + BIT1 eI := '0'B) := { + type_gtpc := 'B6'O, + lengthf := 0, /* overwritten */ + dTI := dTI, + gCSI := gCSI, + eI := eI, + spare := '00000'B + } + /* 7.7.29 PDP Context */ template (value) PDP_Context_GTPC ts_PDP_Context_GTPC(template (value) octetstring pdp_addr, template (value) octetstring ggsn_gsn_addr, @@ -902,6 +914,53 @@ sgsn_ip_data, pco, ratType, uli)), seq) } + /* Update PPD Context Sent GGSN -> SGSN: */ + template (value) GTPC_PDUs ts_UpdatePdpPDU_GGSN(template (value) BIT4 nsapi, + template (omit) hexstring imsi := omit, + template (omit) Recovery_gtpc recovery := omit, + template (omit) EndUserAddress eua := omit, + template (omit) ProtConfigOptions pco := omit, + template (omit) QualityOfServiceProfile qos := omit, + template (omit) DirectTunnelFlags dtf := omit) := { + updatePDPContextRequest := { + updatePDPContextRequestGGSN := { + imsi := f_ts_Imsi(imsi), + recovery := recovery, + nsapi := ts_NSAPI(nsapi), + endUserAddress := eua, + protConfigOptions := pco, + qualityOfServiceProfile := qos, + tft := omit, + commonFlags := omit, + aPN_Restriction := omit, + mS_InfoChangeReportingAction := omit, + directTunnelFlags := dtf, + bearerControlMode := omit, + evolvedAllocationRetentionPriorityI := omit, + extendedCommonFlags := omit, + cSGInfoReportingAction := omit, + aPN_AMBR := omit, + private_extension_gtpc := omit + } + } + } + template (value) Gtp1cUnitdata ts_GTPC_UpdatePDP_GGSN(template (value) Gtp1cPeer peer, + template (value) OCT4 teid, + template (value) uint16_t seq, + template (value) BIT4 nsapi, + template (omit) hexstring imsi := omit, + template (omit) Recovery_gtpc recovery := omit, + template (omit) EndUserAddress eua := omit, + template (omit) ProtConfigOptions pco := omit, + template (omit) QualityOfServiceProfile qos := omit, + template (omit) DirectTunnelFlags dtf := omit) := { + peer := peer, + gtpc := ts_GTP1C_PDU(updatePDPContextRequest, teid, + ts_UpdatePdpPDU_GGSN(nsapi, imsi, recovery, + eua, pco, qos, dtf), + seq) + } + template (value) NSAPI_GTPC ts_NSAPI(template (value) BIT4 nsapi) := { type_gtpc := '14'O, @@ -1029,6 +1088,48 @@ eua, recovery, pco)), seq) } + /* Update PDP Context Resp sent SGSN -> GGSN: */ + template (present) GTPC_PDUs tr_UpdatePdpRespSGSNPDU(template (present) GTP_Cause cause := ?, + template Recovery_gtpc recovery := *, + template TeidDataI teidDataI := *, + template ProtConfigOptions pco := *, + template GSN_Address_GTPC sgsn_addr_traffic := *, + template QualityOfServiceProfile qos := *, + template DirectTunnelFlags dtf := *) := { + updatePDPContextResponse := { + updatePDPContextResponseSGSN := { + + cause := tr_Cause_gtpc(cause), + + recovery := recovery, + teidDataI := teidDataI, + protConfigOptions := pco, + sgsn_addr_traffic := sgsn_addr_traffic, + qualityOfServiceProfile := qos, + userLocationInformation := *, + mS_TimeZone := *, + directTunnelFlags := dtf, + evolvedAllocationRetentionPriorityI := *, + aPN_AMBR := *, + private_extension_gtpc := * + } + } + } + + template (present) Gtp1cUnitdata tr_GTPC_UpdatePdpRespSGSN(template (present) Gtp1cPeer peer, uint16_t seq, OCT4 teid, + template (present) GTP_Cause cause := ?, + template Recovery_gtpc recovery := *, + template TeidDataI teidDataI := *, + template ProtConfigOptions pco := *, + template GSN_Address_GTPC sgsn_addr_traffic := *, + template QualityOfServiceProfile qos := *, + template DirectTunnelFlags dtf := *) := { + peer := peer, + gtpc := tr_GTP1C_PDU(updatePDPContextResponse, teid, + tr_UpdatePdpRespSGSNPDU(cause, recovery, teidDataI, pco, + sgsn_addr_traffic, qos, dtf)) + } + /* PCO send base template */ template (value) ProtConfigOptions ts_PCO := { type_gtpc := '84'O, diff --git a/library/GTPv1U_Templates.ttcn b/library/GTPv1U_Templates.ttcn index 86d2401..c242115 100644 --- a/library/GTPv1U_Templates.ttcn +++ b/library/GTPv1U_Templates.ttcn @@ -140,17 +140,41 @@ gtpu := ts_GTP1U_PDU('02'O, seq, '00000000'O, ts_UEchoRespPDU(rest_ctr)) } + template (present) GSNAddress_gtpu tr_UGsnAddr(template (present) octetstring ip_addr := ?) := { + type_gtpu := '85'O, + lengthf := ?, + gSNAddressValue := ip_addr + } template (value) GSNAddress_gtpu ts_UGsnAddr(template (value) octetstring ip_addr) := { type_gtpu := '85'O, lengthf := lengthof(valueof(ip_addr)), gSNAddressValue := ip_addr } + template (present) TeidDataI_gtpu tr_UteidDataI(template (present) OCT4 teid := ?) := { + type_gtpu := '10'O, + teidDataI := teid + } template (value) TeidDataI_gtpu ts_UteidDataI(template (value) OCT4 teid) := { type_gtpu := '10'O, teidDataI := teid } + template (present) GTPU_IEs tr_UErrorIndication(template (present) OCT4 teid := ?, + template (present) octetstring gsn_addr := ?) := { + errorIndication_IEs := { + teidDataI_gtpu := tr_UteidDataI(teid), + gSNAddress_gtpu := tr_UGsnAddr(gsn_addr), + private_extension_gtpu := * + } + } + template (present) Gtp1uUnitdata tr_GTPU_ErrorIndication(template (present) Gtp1uPeer peer := ?, + template (present) OCT4 teid := ?, + template (present) octetstring gsn_addr := ?) := { + peer := peer, + gtpu := tr_GTP1U_PDU('1A'O, '00000000'O, tr_UErrorIndication(teid, gsn_addr)) + } + template (value) GTPU_IEs ts_UErrorIndication(template (value) OCT4 teid, template (value) octetstring gsn_addr) := { errorIndication_IEs := { @@ -159,7 +183,6 @@ private_extension_gtpu := omit } } - /* master template for sending a GTP-U Error indication */ template (value) Gtp1uUnitdata ts_GTPU_ErrorIndication(template (value) Gtp1uPeer peer, template (value) uint16_t seq, diff --git a/sgsn/BSSGP_ConnHdlr.ttcn b/sgsn/BSSGP_ConnHdlr.ttcn index 140fa99..055902a 100644 --- a/sgsn/BSSGP_ConnHdlr.ttcn +++ b/sgsn/BSSGP_ConnHdlr.ttcn @@ -54,7 +54,7 @@ /* Emulated GGSN is at GTP_ConnHdlr.GTP[0] */ const integer GTP_GGSN_IDX := 0; -private function ran2gtp_idx(integer ran_index) return integer { +function ran2gtp_idx(integer ran_index) return integer { return ran_index + 1 - NUM_GB; } diff --git a/sgsn/SGSN_Tests_Iu.ttcn b/sgsn/SGSN_Tests_Iu.ttcn index 5010443..f5339d4 100644 --- a/sgsn/SGSN_Tests_Iu.ttcn +++ b/sgsn/SGSN_Tests_Iu.ttcn @@ -12,6 +12,7 @@ import from RANAP_PDU_Descriptions all; import from RANAP_IEs all; +import from GTPv1C_Templates all; import from GTPv1U_Templates all; import from GTP_Emulation all; @@ -262,6 +263,67 @@ f_cleanup(); } +/* TS 29.060 7.3.3, 3GPP TS 23.007 15.2: Emulate GGSN sending +UpdatePDPCtx[NSAPI, Direct Tunnel Flags(EI=1)] due to having receiving an Error +Indication from RNC while in Direct Tunnel mode. SGSN should attempt recreation +of the RAB to make sure PDP context is established, since it may be that RNC got +restarted. */ +private function f_TC_update_ctx_err_ind_from_ggsn(charstring id) runs on BSSGP_ConnHdlr { + var PdpActPars apars := valueof(t_PdpActPars(mp_ggsn_ip, mp_ranap_cfg[0].sctp_addr.local_ip_addr)); + var integer ran_index := 3; + + /* first perform regular attach */ + f_gmm_attach(umts_aka_challenge := true, force_gsm_sres := false, ran_index := ran_index); + + f_service_request(apars, ran_index := ran_index); + + f_pdp_ctx_act(apars, ran_index := ran_index); + + /* then transceive a downlink PDU */ + f_gtpu_xceive_mt(apars, f_rnd_octstring(100), ran_index := ran_index); + /* RNC answers with Error Indication, it probably crashed and lost state: */ + f_gtp_register_teid('00000000'O, GTP_GGSN_IDX); /* Ease debugging in case SGSN sends ErrorInd */ + f_ran_register_imsi(g_pars.imsi, g_pars.p_tmsi); /* Forward Paging below to this component */ + GTP[ran2gtp_idx(ran_index)].send(ts_GTPU_ErrorIndication(ts_GtpPeerU(apars.ggsn_ip_u), + 0, apars.rnc_tei_u, + apars.rnc_ip_u)); + GTP[GTP_GGSN_IDX].receive(tr_GTPU_ErrorIndication(ts_GtpPeerU(apars.rnc_ip_u), + apars.rnc_tei_u, + apars.rnc_ip_u)); + + GTP[GTP_GGSN_IDX].send(ts_GTPC_UpdatePDP_GGSN(ts_GtpPeerC(apars.sgsn_ip_c), + apars.sgsn_tei_c, 2, + apars.nsapi, + g_pars.imsi, + dtf := ts_DirectTunnelFlags(eI := '1'B))); + + GTP[GTP_GGSN_IDX].receive(tr_GTPC_UpdatePdpRespSGSN(ts_GtpPeerC(apars.sgsn_ip_c), 2, + apars.ggsn_tei_c, + GTP_CAUSE_REQUEST_ACCEPTED)); + + BSSAP.receive(RAN_Conn_Prim:MSC_CONN_PRIM_DISC_IND); + g_pars.rnc_send_initial_ue := true; + BSSAP.receive(tr_RANAP_Paging(ps_domain, imsi_hex2oct(g_pars.imsi))); + + /* Ue comes back, answering the paging: + * SGSN recreates the Iu ctx and recovers the Direct Tunnel RNC<->GGSN: */ + f_service_request(apars, pdp_status := '2000'O /*NSAPI=5*/, ran_index := ran_index); + as_ranap_rab_ass_req(apars); + as_ggsn_gtp_ctx_upd_req(apars, exp_dir_tun := true, ran_index := ran_index); + + /* Now UE is in PMM ENABLED state, tear it down to clean up: */ + f_pdp_ctx_deact_mo(apars, '00'O, ran_index := ran_index); + setverdict(pass); +} +testcase TC_update_ctx_err_ind_from_ggsn() runs on test_CT { + var BSSGP_ConnHdlr vc_conn; + f_init(); + f_sleep(1.0); + vc_conn := f_start_handler(refers(f_TC_update_ctx_err_ind_from_ggsn), testcasename(), g_gb, 1004); + vc_conn.done; + f_cleanup(); +} + control { execute( TC_iu_attach() ); execute( TC_iu_attach_encr() ); @@ -270,6 +332,7 @@ execute( TC_attach_pdp_act_user() ); execute( TC_attach_pdp_act_pmm_idle() ); execute( TC_pmm_idle_rx_mt_data() ); + execute( TC_update_ctx_err_ind_from_ggsn() ); } diff --git a/sgsn/expected-results.xml b/sgsn/expected-results.xml index 3461721..a29467d 100644 --- a/sgsn/expected-results.xml +++ b/sgsn/expected-results.xml @@ -96,6 +96,7 @@ <testcase classname='SGSN_Tests_Iu' name='TC_attach_pdp_act_pmm_idle' time='MASKED'/> <testcase classname='SGSN_Tests_Iu' name='TC_attach_pdp_act_pmm_idle_lost_pdp_status' time='MASKED'/> <testcase classname='SGSN_Tests_Iu' name='TC_pmm_idle_rx_mt_data' time='MASKED'/> + <testcase classname='SGSN_Tests_Iu' name='TC_update_ctx_err_ind_from_ggsn' time='MASKED'/>  <testcase classname='SGSN_Tests_NS' name='TC_SNS_size' time='MASKED'/> <testcase classname='SGSN_Tests_NS' name='TC_SNS_size_too_big' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37665?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic417b23cae798361f73150f6a72f91e2f8528e7a Gerrit-Change-Number: 37665 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-ttcn3-hacks[master]: sgsn: Introduce test TC_pmm_idle_rx_mt_data
by pespin 30 Jul '24

30 Jul '24

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, pespin. Hello Jenkins Builder, daniel, fixeria, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37646?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+2 by lynxis lazus, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: sgsn: Introduce test TC_pmm_idle_rx_mt_data ...................................................................... sgsn: Introduce test TC_pmm_idle_rx_mt_data Change-Id: I35d660b8e546f6ce0af8c05d7b5c56833a26fb76 --- M sgsn/BSSGP_ConnHdlr.ttcn M sgsn/SGSN_Tests_Iu.ttcn M sgsn/expected-results.xml 3 files changed, 74 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/46/37646/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37646?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I35d660b8e546f6ce0af8c05d7b5c56833a26fb76 Gerrit-Change-Number: 37646 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-bsc[master]: osmo_bsc_sigtran: Don't try to decode ipaccess_head a second time
by fixeria 30 Jul '24

30 Jul '24

Attention is currently required from: daniel, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/37662?usp=email ) Change subject: osmo_bsc_sigtran: Don't try to decode ipaccess_head a second time ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/37662?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I300bbab3c0215d52bc5f6232ace5c37a6613feb7 Gerrit-Change-Number: 37662 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Jul 2024 16:00:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-netif[master]: ipa: Ensure osmo_ipa_segmentation_cb sets msg->l2h to the payload data
by fixeria 30 Jul '24

30 Jul '24

Attention is currently required from: daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/37661?usp=email ) Change subject: ipa: Ensure osmo_ipa_segmentation_cb sets msg->l2h to the payload data ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/37661?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Id91cddf9948ca49abf092850fae3a8f17e445b45 Gerrit-Change-Number: 37661 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Jul 2024 15:59:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: pySim.commands: make use of status word interpreter for CHV
by fixeria 30 Jul '24

30 Jul '24

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37651?usp=email ) Change subject: pySim.commands: make use of status word interpreter for CHV ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37651?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I71efe9d6804c4845bb81f1b3b443215dad0ac301 Gerrit-Change-Number: 37651 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 30 Jul 2024 15:50:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: hnb_persistent: Use incrementing counter for rate_ctr + stat_item index
by fixeria 30 Jul '24

30 Jul '24

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37664?usp=email ) Change subject: hnb_persistent: Use incrementing counter for rate_ctr + stat_item index ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37664?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I0bb6a679fb05a6aba917f089401fe3765a5d1fc3 Gerrit-Change-Number: 37664 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 30 Jul 2024 15:48:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: osmo_bsc_sigtran: Don't try to decode ipaccess_head a second time
by laforge 30 Jul '24

30 Jul '24

Attention is currently required from: daniel, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/37662?usp=email ) Change subject: osmo_bsc_sigtran: Don't try to decode ipaccess_head a second time ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: > I guess it depends on the version of libosmo-sigtran in use. […] Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/37662?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I300bbab3c0215d52bc5f6232ace5c37a6613feb7 Gerrit-Change-Number: 37662 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Jul 2024 15:47:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: hnb_persistent: Use incrementing counter for rate_ctr + stat_item index
by pespin 30 Jul '24

30 Jul '24

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37664?usp=email ) Change subject: hnb_persistent: Use incrementing counter for rate_ctr + stat_item index ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37664?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I0bb6a679fb05a6aba917f089401fe3765a5d1fc3 Gerrit-Change-Number: 37664 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 30 Jul 2024 15:46:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: hnb_persistent: Use incrementing counter for rate_ctr + stat_item index
by laforge 30 Jul '24

30 Jul '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37664?usp=email ) Change subject: hnb_persistent: Use incrementing counter for rate_ctr + stat_item index ...................................................................... hnb_persistent: Use incrementing counter for rate_ctr + stat_item index This will remove the annoying log messages like DLGLOBAL ERROR counter group 'hnb' already exists for index 0, instead using index 1. This is a software bug that needs fixing. (rate_ctr.c:221) Closes: OS#6433 Change-Id: I0bb6a679fb05a6aba917f089401fe3765a5d1fc3 --- M src/osmo-hnbgw/hnbgw.c 1 file changed, 19 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/64/37664/1 diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c index d4515a8..90b8147 100644 --- a/src/osmo-hnbgw/hnbgw.c +++ b/src/osmo-hnbgw/hnbgw.c @@ -497,19 +497,22 @@ osmo_timer_schedule(&hnbp->disconnected_timeout, period_s, 0); } +static unsigned int g_hnbp_ctr_id; + struct hnb_persistent *hnb_persistent_alloc(const struct umts_cell_id *id) { struct hnb_persistent *hnbp = talloc_zero(g_hnbgw, struct hnb_persistent); + unsigned int ctr_id = g_hnbp_ctr_id++; if (!hnbp) return NULL; hnbp->id = *id; hnbp->id_str = talloc_strdup(hnbp, umts_cell_id_to_str(id)); - hnbp->ctrs = rate_ctr_group_alloc(hnbp, &hnb_ctrg_desc, 0); + hnbp->ctrs = rate_ctr_group_alloc(hnbp, &hnb_ctrg_desc, ctr_id); if (!hnbp->ctrs) goto out_free; rate_ctr_group_set_name(hnbp->ctrs, hnbp->id_str); - hnbp->statg = osmo_stat_item_group_alloc(hnbp, &hnb_statg_desc, 0); + hnbp->statg = osmo_stat_item_group_alloc(hnbp, &hnb_statg_desc, ctr_id); if (!hnbp->statg) goto out_free_ctrs; osmo_stat_item_group_set_name(hnbp->statg, hnbp->id_str); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37664?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I0bb6a679fb05a6aba917f089401fe3765a5d1fc3 Gerrit-Change-Number: 37664 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bsc[master]: osmo_bsc_sigtran: Don't try to decode ipaccess_head a second time
by daniel 30 Jul '24

30 Jul '24

Attention is currently required from: laforge, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/37662?usp=email ) Change subject: osmo_bsc_sigtran: Don't try to decode ipaccess_head a second time ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: > IIUC this is not really a fix of a bug, but simply a code cleanup/improvement right? No, it fixes parsing ctrl messages over sccplite when libosmo-sccp/netif uses osmo_io. Parsing IPAC_PROTO_EXT_MGCP messages is also broken before this patch. PS1: > The commit message includes: […] I guess it depends on the version of libosmo-sigtran in use. Commit 9257cd896e255403822bee6f87f5487a92fd3c11 there uses osmo_io and calls osmo_stream_cli_set_segmentation_cb(asp->client, osmo_ipa_segmentation_cb) when the AXP proto is OSMO_SS7_ASP_PROT_IPA. Since osmo-bsc reqires libosmo-sigtran >= 1.9.0 which includes this commit this won't really build with any older version, right? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/37662?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I300bbab3c0215d52bc5f6232ace5c37a6613feb7 Gerrit-Change-Number: 37662 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Jul 2024 12:17:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log