- gerrit-log - lists.osmocom.org

[S] Change in libosmo-netif[rel-1.5.1]: ipa: Ensure osmo_ipa_segmentation_cb sets msg->l2h to the payload data
by daniel 31 Jul '24

31 Jul '24

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/37673?usp=email ) Change subject: ipa: Ensure osmo_ipa_segmentation_cb sets msg->l2h to the payload data ...................................................................... ipa: Ensure osmo_ipa_segmentation_cb sets msg->l2h to the payload data Previously if ih->proto was IPAC_PROTO_OSMO msg->l2h would still point to the extension header byte which breaks assumptions in e.g. osmo-bsc. Change-Id: Id91cddf9948ca49abf092850fae3a8f17e445b45 Related: OS#6422 --- M src/ipa.c 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/73/37673/1 diff --git a/src/ipa.c b/src/ipa.c index 8720427..d43df00 100644 --- a/src/ipa.c +++ b/src/ipa.c @@ -375,7 +375,8 @@ #define MSG_CB_IPA_INFO_OFFSET 0 /* Check and remove headers (in case of p == IPAC_PROTO_OSMO, also the IPA extension header). - * Returns a negative number on error, otherwise the number of octets removed */ + * Returns a negative number on error, otherwise the number of octets removed. + * Both msg->data and msg->l2h point to the user data after the (extended) IPA header if this function is successful. */ static inline int ipa_check_pull_headers(struct msgb *msg) { int ret; @@ -397,6 +398,7 @@ osmo_ipa_msgb_cb_proto_ext(msg) = msg->data[0]; msgb_pull(msg, sizeof(struct ipa_head_ext)); octets_removed += sizeof(struct ipa_head_ext); + msg->l2h = msg->data; return octets_removed; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/37673?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: rel-1.5.1 Gerrit-Change-Id: Id91cddf9948ca49abf092850fae3a8f17e445b45 Gerrit-Change-Number: 37673 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ci[master]: OBS: latest: set pattern for gapk releases
by fixeria 31 Jul '24

31 Jul '24

Attention is currently required from: laforge, osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37671?usp=email ) Change subject: OBS: latest: set pattern for gapk releases ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-ci/+/37671/comment/fdd84bab_f6a38c23 PS1, Line 9: may only have two numbers > this is not the case with `v1.1. […] I confirmed (using https://regex101.com/) that this regexp also works for `v1.1.1`. The reason for that is this part `[0-9.]*`, which is allowing zero or more repetitions of a dot or a digit. This regexp would also match versions like `v1.1.` or even `v1........1`. Not critical, I think. Patchset: PS1: I was a bit quicker with https://gerrit.osmocom.org/c/osmo-ci/+/37670 ;) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37671?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If7328a31c6c64b91d0727dbe16bb8d6915fed260 Gerrit-Change-Number: 37671 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 31 Jul 2024 15:31:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-ggsn[master]: gtp: Allow setting callback to receive update_context_ind
by pespin 31 Jul '24

31 Jul '24

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/37597?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: gtp: Allow setting callback to receive update_context_ind ...................................................................... gtp: Allow setting callback to receive update_context_ind This will be used by: * SGSN: Get to know that RNC has gonne down according to GGSN (re-attempt Direct Tunnel or go back to tun SGSN<->GGSN). * GGSN: Maybe find out that Direct Flags are used (should be handled internally directly in the rx path probably) Related: OS#6512 Change-Id: Ic80a9a928c55b6ff85be96014920bb42793cb943 --- M TODO-RELEASE M gtp/gsn.c M gtp/gtp.c M include/osmocom/gtp/gsn.h M include/osmocom/gtp/gtp.h 5 files changed, 91 insertions(+), 27 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/97/37597/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/37597?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ic80a9a928c55b6ff85be96014920bb42793cb943 Gerrit-Change-Number: 37597 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ggsn[master]: gtp: Allow tx Direct Tunnel Flags in UpdatePDPCtx{Req,Resp}
by pespin 31 Jul '24

31 Jul '24

Attention is currently required from: daniel, laforge, osmith. Hello Jenkins Builder, daniel, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/37594?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: gtp: Allow tx Direct Tunnel Flags in UpdatePDPCtx{Req,Resp} ...................................................................... gtp: Allow tx Direct Tunnel Flags in UpdatePDPCtx{Req,Resp} In Update PDP Ctx Response, only SGSN is expected to transmit Direct Tunnel Flags in the message. Related: SYS#5435 Change-Id: I36d93619e2fe9cafd3092515df18b82d29099d2d --- M TODO-RELEASE M gtp/gtp.c M include/osmocom/gtp/pdp.h 3 files changed, 31 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/94/37594/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/37594?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I36d93619e2fe9cafd3092515df18b82d29099d2d Gerrit-Change-Number: 37594 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ci[master]: OBS: latest: set pattern for gapk releases
by fixeria 31 Jul '24

31 Jul '24

Attention is currently required from: laforge, osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37671?usp=email ) Change subject: OBS: latest: set pattern for gapk releases ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ci/+/37671/comment/457fb075_a7960c85 PS1, Line 9: may only have two numbers this is not the case with `v1.1.1`, right? -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37671?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If7328a31c6c64b91d0727dbe16bb8d6915fed260 Gerrit-Change-Number: 37671 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 31 Jul 2024 15:19:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-pcu[master]: rcv_control_ack(): Improve logging of confirmation of Pkt Dl/Ul Ass
by pespin 31 Jul '24

31 Jul '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/37672?usp=email ) Change subject: rcv_control_ack(): Improve logging of confirmation of Pkt Dl/Ul Ass ...................................................................... rcv_control_ack(): Improve logging of confirmation of Pkt Dl/Ul Ass This allows tracking which TBF is used to assigned the new TBF. Change-Id: I1f438cc31ceea24286a914801d3746f577385bfc --- M src/pdch.cpp M tests/tbf/TbfTest.err 2 files changed, 34 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/72/37672/1 diff --git a/src/pdch.cpp b/src/pdch.cpp index 7ff1c7e..3cba690 100644 --- a/src/pdch.cpp +++ b/src/pdch.cpp @@ -389,7 +389,6 @@ osmo_fsm_inst_state_name(tbf_ul_ass_fi(tbf))); return; } - LOGPTBF(tbf, LOGL_DEBUG, "[DOWNLINK] UPLINK ASSIGNED\n"); pdch_ulc_release_fn(ulc, fn); if (tbf_direction(tbf) == GPRS_RLCMAC_DL_TBF) tbf->n_reset(N3105); @@ -397,10 +396,12 @@ new_tbf = ms_ul_tbf(ms); if (!new_tbf) { - LOGPDCH(this, DRLCMAC, LOGL_ERROR, "Got ACK, but UL " - "TBF is gone TLLI=0x%08x\n", tlli); + LOGPDCH(this, DRLCMAC, LOGL_ERROR, + "Got PKT_CTRL_ACK (UL_ASS) from %s, but UL TBF is gone (TLLI=0x%08x)\n", + tbf_name(tbf), tlli); return; } + LOGPTBF(tbf, LOGL_DEBUG, "Got PKT_CTRL_ACK confirming assignment of %s\n", tbf_name(new_tbf)); osmo_fsm_inst_dispatch(new_tbf->state_fi, TBF_EV_ASSIGN_ACK_PACCH, NULL); /* there might be LLC packets waiting in the queue, but the DL @@ -417,7 +418,6 @@ osmo_fsm_inst_state_name(tbf_dl_ass_fi(tbf))); return; } - LOGPTBF(tbf, LOGL_DEBUG, "[UPLINK] DOWNLINK ASSIGNED\n"); pdch_ulc_release_fn(ulc, fn); if (tbf_direction(tbf) == GPRS_RLCMAC_DL_TBF) tbf->n_reset(N3105); @@ -425,10 +425,12 @@ new_tbf = ms_dl_tbf(ms); if (!new_tbf) { - LOGPDCH(this, DRLCMAC, LOGL_ERROR, "Got ACK, but DL " - "TBF is gone TLLI=0x%08x\n", tlli); + LOGPDCH(this, DRLCMAC, LOGL_ERROR, + "Got PKT_CTRL_ACK (DL_ASS) from %s, but DL TBF is gone (TLLI=0x%08x)\n", + tbf_name(tbf), tlli); return; } + LOGPTBF(tbf, LOGL_DEBUG, "Got PKT_CTRL_ACK confirming assignment of %s\n", tbf_name(new_tbf)); if ((tbf->state_is(TBF_ST_WAIT_RELEASE) || tbf->state_is(TBF_ST_WAIT_REUSE_TFI)) && tbf->direction == new_tbf->direction) diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err index fdaf917..a012989 100644 --- a/tests/tbf/TbfTest.err +++ b/tests/tbf/TbfTest.err @@ -2719,9 +2719,9 @@ PDCH(bts=0,trx=0,ts=7) FN=2654283 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=2654283 ------------------------- RX : Uplink Control Block ------------------------- TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} FN=2654283 Rx Packet Control Ack (reason=UL_ASS) -TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} [DOWNLINK] UPLINK ASSIGNED UL_ASS_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){WAIT_ACK}: Received Event RX_ASS_CTRL_ACK UL_ASS_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){WAIT_ACK}: state_chg to NONE +TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} Got PKT_CTRL_ACK confirming assignment of TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} UL_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN}: Received Event ASSIGN_ACK_PACCH UL_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN}: state_chg to FLOW PDCH(bts=0,trx=0,ts=7) Got CS-1 RLC block: R=0, SI=0, TFI=0, CPS=0, RSB=0, rc=184 @@ -2843,9 +2843,9 @@ PDCH(bts=0,trx=0,ts=7) FN=2654283 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=2654283 ------------------------- RX : Uplink Control Block ------------------------- TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} FN=2654283 Rx Packet Control Ack (reason=UL_ASS) -TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} [DOWNLINK] UPLINK ASSIGNED UL_ASS_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){WAIT_ACK}: Received Event RX_ASS_CTRL_ACK UL_ASS_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){WAIT_ACK}: state_chg to NONE +TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} Got PKT_CTRL_ACK confirming assignment of TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} UL_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN}: Received Event ASSIGN_ACK_PACCH UL_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN}: state_chg to FLOW PDCH(bts=0,trx=0,ts=7) Got CS-1 RLC block: R=0, SI=0, TFI=0, CPS=0, RSB=0, rc=184 @@ -2903,9 +2903,9 @@ PDCH(bts=0,trx=0,ts=7) FN=2654288 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=2654288 ------------------------- RX : Uplink Control Block ------------------------- TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FLOW} FN=2654288 Rx Packet Control Ack (reason=DL_ASS) -TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FLOW} [UPLINK] DOWNLINK ASSIGNED DL_ASS_TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){WAIT_ACK}: Received Event RX_ASS_CTRL_ACK DL_ASS_TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){WAIT_ACK}: state_chg to NONE +TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FLOW} Got PKT_CTRL_ACK confirming assignment of TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){ASSIGN} DL_TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){ASSIGN}: Received Event ASSIGN_ACK_PACCH DL_TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){ASSIGN}: state_chg to FLOW PDCH(bts=0,trx=0,ts=7) Expiring FN=2654288 but previous FN=2654279 is still reserved! @@ -3030,9 +3030,9 @@ PDCH(bts=0,trx=0,ts=7) FN=2654361 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=2654361 ------------------------- RX : Uplink Control Block ------------------------- TBF(UL:TFI-0-0-1:G:TLLI-0xf5667788){ASSIGN} FN=2654361 Rx Packet Control Ack (reason=UL_ASS) -TBF(UL:TFI-0-0-1:G:TLLI-0xf5667788){ASSIGN} [DOWNLINK] UPLINK ASSIGNED UL_ASS_TBF(UL:TFI-0-0-1:G:TLLI-0xf5667788){WAIT_ACK}: Received Event RX_ASS_CTRL_ACK UL_ASS_TBF(UL:TFI-0-0-1:G:TLLI-0xf5667788){WAIT_ACK}: state_chg to NONE +TBF(UL:TFI-0-0-1:G:TLLI-0xf5667788){ASSIGN} Got PKT_CTRL_ACK confirming assignment of TBF(UL:TFI-0-0-1:G:TLLI-0xf5667788){ASSIGN} UL_TBF(UL:TFI-0-0-1:G:TLLI-0xf5667788){ASSIGN}: Received Event ASSIGN_ACK_PACCH UL_TBF(UL:TFI-0-0-1:G:TLLI-0xf5667788){ASSIGN}: state_chg to FLOW PDCH(bts=0,trx=0,ts=7) Expiring FN=2654361 but previous FN=2654353 is still reserved! @@ -3181,9 +3181,9 @@ PDCH(bts=0,trx=0,ts=7) FN=2654283 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=2654283 ------------------------- RX : Uplink Control Block ------------------------- TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} FN=2654283 Rx Packet Control Ack (reason=UL_ASS) -TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} [DOWNLINK] UPLINK ASSIGNED UL_ASS_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){WAIT_ACK}: Received Event RX_ASS_CTRL_ACK UL_ASS_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){WAIT_ACK}: state_chg to NONE +TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} Got PKT_CTRL_ACK confirming assignment of TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} UL_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN}: Received Event ASSIGN_ACK_PACCH UL_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN}: state_chg to FLOW PDCH(bts=0,trx=0,ts=7) Got CS-1 RLC block: R=0, SI=0, TFI=0, CPS=0, RSB=0, rc=184 @@ -3300,9 +3300,9 @@ PDCH(bts=0,trx=0,ts=7) FN=2654340 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=2654340 ------------------------- RX : Uplink Control Block ------------------------- TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){ASSIGN} FN=2654340 Rx Packet Control Ack (reason=UL_ASS) -TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){ASSIGN} [DOWNLINK] UPLINK ASSIGNED UL_ASS_TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){WAIT_ACK}: Received Event RX_ASS_CTRL_ACK UL_ASS_TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){WAIT_ACK}: state_chg to NONE +TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){ASSIGN} Got PKT_CTRL_ACK confirming assignment of TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){ASSIGN} UL_TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){ASSIGN}: Received Event ASSIGN_ACK_PACCH UL_TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){ASSIGN}: state_chg to FLOW [DL] algo A <multi> (suggested TRX: 0): Alloc start @@ -3421,9 +3421,9 @@ PDCH(bts=0,trx=0,ts=7) FN=2654283 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=2654283 ------------------------- RX : Uplink Control Block ------------------------- TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} FN=2654283 Rx Packet Control Ack (reason=UL_ASS) -TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} [DOWNLINK] UPLINK ASSIGNED UL_ASS_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){WAIT_ACK}: Received Event RX_ASS_CTRL_ACK UL_ASS_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){WAIT_ACK}: state_chg to NONE +TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} Got PKT_CTRL_ACK confirming assignment of TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} UL_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN}: Received Event ASSIGN_ACK_PACCH UL_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN}: state_chg to FLOW PDCH(bts=0,trx=0,ts=7) Got CS-1 RLC block: R=0, SI=0, TFI=0, CPS=0, RSB=0, rc=184 @@ -3624,9 +3624,9 @@ PDCH(bts=0,trx=0,ts=7) FN=2654283 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=2654283 ------------------------- RX : Uplink Control Block ------------------------- TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} FN=2654283 Rx Packet Control Ack (reason=UL_ASS) -TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} [DOWNLINK] UPLINK ASSIGNED UL_ASS_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){WAIT_ACK}: Received Event RX_ASS_CTRL_ACK UL_ASS_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){WAIT_ACK}: state_chg to NONE +TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} Got PKT_CTRL_ACK confirming assignment of TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} UL_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN}: Received Event ASSIGN_ACK_PACCH UL_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN}: state_chg to FLOW PDCH(bts=0,trx=0,ts=7) Got CS-1 RLC block: R=0, SI=0, TFI=0, CPS=0, RSB=0, rc=184 @@ -3724,9 +3724,9 @@ PDCH(bts=0,trx=0,ts=7) FN=2654288 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=2654288 ------------------------- RX : Uplink Control Block ------------------------- TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FLOW} FN=2654288 Rx Packet Control Ack (reason=DL_ASS) -TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FLOW} [UPLINK] DOWNLINK ASSIGNED DL_ASS_TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){WAIT_ACK}: Received Event RX_ASS_CTRL_ACK DL_ASS_TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){WAIT_ACK}: state_chg to NONE +TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FLOW} Got PKT_CTRL_ACK confirming assignment of TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){ASSIGN} DL_TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){ASSIGN}: Received Event ASSIGN_ACK_PACCH DL_TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){ASSIGN}: state_chg to FLOW PDCH(bts=0,trx=0,ts=7) Expiring FN=2654288 but previous FN=2654279 is still reserved! @@ -4452,9 +4452,9 @@ PDCH(bts=0,trx=0,ts=7) FN=2654413 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=2654413 ------------------------- RX : Uplink Control Block ------------------------- TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){WAIT_RELEASE} FN=2654413 Rx Packet Control Ack (reason=DL_ASS) -TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){WAIT_RELEASE} [UPLINK] DOWNLINK ASSIGNED DL_ASS_TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){WAIT_ACK}: Received Event RX_ASS_CTRL_ACK DL_ASS_TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){WAIT_ACK}: state_chg to NONE +TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){WAIT_RELEASE} Got PKT_CTRL_ACK confirming assignment of TBF(DL:TFI-0-0-1:G:IMSI-0011223344:TLLI-0xf1223344){ASSIGN} TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){WAIT_RELEASE} free PDCH(bts=0,trx=0,ts=7) Detaching TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){WAIT_RELEASE}, 2 TBFs, USFs = 01, TFIs = 00000003. MS(IMSI-0011223344:TLLI-0xf1223344:TA-7:MSCLS-1-0:UL:DL) Detaching TBF: TBF(DL:G:IMSI-0011223344:TLLI-0xf1223344){WAIT_RELEASE} @@ -4878,9 +4878,9 @@ PDCH(bts=0,trx=0,ts=7) FN=2654283 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=2654283 ------------------------- RX : Uplink Control Block ------------------------- TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} FN=2654283 Rx Packet Control Ack (reason=UL_ASS) -TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} [DOWNLINK] UPLINK ASSIGNED UL_ASS_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){WAIT_ACK}: Received Event RX_ASS_CTRL_ACK UL_ASS_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){WAIT_ACK}: state_chg to NONE +TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} Got PKT_CTRL_ACK confirming assignment of TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} UL_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN}: Received Event ASSIGN_ACK_PACCH UL_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN}: state_chg to FLOW PDCH(bts=0,trx=0,ts=7) Got CS-1 RLC block: R=0, SI=0, TFI=0, CPS=0, RSB=0, rc=184 @@ -5010,9 +5010,9 @@ PDCH(bts=0,trx=0,ts=7) FN=2654283 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=2654283 ------------------------- RX : Uplink Control Block ------------------------- TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} FN=2654283 Rx Packet Control Ack (reason=UL_ASS) -TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} [DOWNLINK] UPLINK ASSIGNED UL_ASS_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){WAIT_ACK}: Received Event RX_ASS_CTRL_ACK UL_ASS_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){WAIT_ACK}: state_chg to NONE +TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} Got PKT_CTRL_ACK confirming assignment of TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} UL_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN}: Received Event ASSIGN_ACK_PACCH UL_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN}: state_chg to FLOW PDCH(bts=0,trx=0,ts=7) Got CS-1 RLC block: R=0, SI=0, TFI=0, CPS=0, RSB=0, rc=184 @@ -9282,9 +9282,9 @@ PDCH(bts=0,trx=0,ts=7) FN=2654283 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=2654283 ------------------------- RX : Uplink Control Block ------------------------- TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} FN=2654283 Rx Packet Control Ack (reason=UL_ASS) -TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} [DOWNLINK] UPLINK ASSIGNED UL_ASS_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){WAIT_ACK}: Received Event RX_ASS_CTRL_ACK UL_ASS_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){WAIT_ACK}: state_chg to NONE +TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} Got PKT_CTRL_ACK confirming assignment of TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} UL_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN}: Received Event ASSIGN_ACK_PACCH UL_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN}: state_chg to FLOW PDCH(bts=0,trx=0,ts=7) Got CS-1 RLC block: R=0, SI=0, TFI=0, CPS=0, RSB=0, rc=184 @@ -9516,9 +9516,9 @@ PDCH(bts=0,trx=0,ts=7) FN=2654283 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=2654283 ------------------------- RX : Uplink Control Block ------------------------- TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} FN=2654283 Rx Packet Control Ack (reason=UL_ASS) -TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} [DOWNLINK] UPLINK ASSIGNED UL_ASS_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){WAIT_ACK}: Received Event RX_ASS_CTRL_ACK UL_ASS_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){WAIT_ACK}: state_chg to NONE +TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} Got PKT_CTRL_ACK confirming assignment of TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} UL_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN}: Received Event ASSIGN_ACK_PACCH UL_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN}: state_chg to FLOW PDCH(bts=0,trx=0,ts=7) Got MCS-4 RLC block: R=1, SI=0, TFI=0, CPS=5, RSB=0, rc=385 @@ -10048,9 +10048,9 @@ PDCH(bts=0,trx=0,ts=7) FN=2654283 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=2654283 ------------------------- RX : Uplink Control Block ------------------------- TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} FN=2654283 Rx Packet Control Ack (reason=UL_ASS) -TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} [DOWNLINK] UPLINK ASSIGNED UL_ASS_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){WAIT_ACK}: Received Event RX_ASS_CTRL_ACK UL_ASS_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){WAIT_ACK}: state_chg to NONE +TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} Got PKT_CTRL_ACK confirming assignment of TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} UL_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN}: Received Event ASSIGN_ACK_PACCH UL_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN}: state_chg to FLOW PDCH(bts=0,trx=0,ts=7) Got MCS-4 RLC block: R=0, SI=0, TFI=0, CPS=0, RSB=0, rc=385 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/37672?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I1f438cc31ceea24286a914801d3746f577385bfc Gerrit-Change-Number: 37672 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ggsn[master]: gtp: Allow tx Direct Tunnel Flags in UpdatePDPCtx{Req,Resp}
by pespin 31 Jul '24

31 Jul '24

Attention is currently required from: daniel, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/37594?usp=email ) Change subject: gtp: Allow tx Direct Tunnel Flags in UpdatePDPCtx{Req,Resp} ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > doesn't this need a TODO-RELEASE for the ABI breakage? hmm I thought I had added them, but maybe only in osmo-sgsn patches and forgot the osmo-ggsn ones. Will update them now. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/37594?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I36d93619e2fe9cafd3092515df18b82d29099d2d Gerrit-Change-Number: 37594 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 Jul 2024 15:15:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: OBS: latest: handle "version is None"
by osmith 31 Jul '24

31 Jul '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37668?usp=email ) Change subject: OBS: latest: handle "version is None" ...................................................................... OBS: latest: handle "version is None" Fix the Osmocom_OBS_latest job, which currently fails on git repositories where no tagged release can be found with: File "/obs/lib/debian.py", line 96, in transform_version if "osmo-epdg-" in version: ^^^^^^^^^^^^^^^^^^^^^^^ TypeError: argument of type 'NoneType' is not iterable Fixes: 9b36d2a8 ("OBS: fix up-to-date check for strongswan-epdg") Change-Id: I69cb884d499d1f6a8cae4b4585d31b5bc095fd6e --- M scripts/obs/lib/debian.py 1 file changed, 21 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/scripts/obs/lib/debian.py b/scripts/obs/lib/debian.py index 68459c8..85fcc5f 100644 --- a/scripts/obs/lib/debian.py +++ b/scripts/obs/lib/debian.py @@ -93,6 +93,9 @@ def transform_version(version): + if version is None: + return None + if "osmo-epdg-" in version: version = f"{version.replace('osmo-epdg-', '', 1)}-osmo-epdg" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37668?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I69cb884d499d1f6a8cae4b4585d31b5bc095fd6e Gerrit-Change-Number: 37668 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ci[master]: OBS: latest: handle "version is None"
by osmith 31 Jul '24

31 Jul '24

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37668?usp=email ) Change subject: OBS: latest: handle "version is None" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37668?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I69cb884d499d1f6a8cae4b4585d31b5bc095fd6e Gerrit-Change-Number: 37668 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 Jul 2024 15:13:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: OBS: latest: set pattern for gapk releases
by osmith 31 Jul '24

31 Jul '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/37671?usp=email ) Change subject: OBS: latest: set pattern for gapk releases ...................................................................... OBS: latest: set pattern for gapk releases The gapk release tags start with a v and may only have two numbers. Related: OS#6521 Change-Id: If7328a31c6c64b91d0727dbe16bb8d6915fed260 --- M scripts/obs/lib/config.py 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/71/37671/1 diff --git a/scripts/obs/lib/config.py b/scripts/obs/lib/config.py index 1ad0106..3bfbd4e 100644 --- a/scripts/obs/lib/config.py +++ b/scripts/obs/lib/config.py @@ -116,6 +116,7 @@ git_latest_tag_pattern_default = "^[0-9]*\\.[0-9]*\\.[0-9]*$" git_latest_tag_pattern_other = { + "gapk": "^v[0-9]*\\.[0-9.]*$", "limesuite": "^v[0-9]*\\.[0-9]*\\.[0-9]*$", "open5gs": "^v[0-9]*\\.[0-9]*\\.[0-9]*$", "osmo-fl2k": "^v[0-9]*\\.[0-9]*\\.[0-9]*$", -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37671?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If7328a31c6c64b91d0727dbe16bb8d6915fed260 Gerrit-Change-Number: 37671 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

2026

2025

2024

2023

2022

gerrit-log