- gerrit-log - lists.osmocom.org

[M] Change in osmo-ci[master]: scripts/kernel/linux-shallow-clone: new script
by osmith 10 Feb '26

10 Feb '26

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42095?usp=email ) Change subject: scripts/kernel/linux-shallow-clone: new script ...................................................................... Patch Set 1: (1 comment) File scripts/kernel/linux-shallow-clone.sh: https://gerrit.osmocom.org/c/osmo-ci/+/42095/comment/aef896e8_5d913086?usp=… : PS1, Line 78: mv "$DEST_OLD" "$DEST"-old > iirc it's possible to configure a jenkins job to avoid running another specific jenkins job is runni […] Interesting idea. There is a build blocker plugin, but we don't have it installed right now: https://jenkins-job-builder.readthedocs.io/en/latest/properties.html#proper… If this becomes a problem, I'd probably just tweak the timers instead so we can avoid installing another plugin. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42095?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id3aadb46813047ecac3b80868192809b272dba0e Gerrit-Change-Number: 42095 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Feb 2026 13:51:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: pySim/euicc: fix encoding/decoding of Iccid
by dexter 10 Feb '26

10 Feb '26

dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42086?usp=email ) Change subject: pySim/euicc: fix encoding/decoding of Iccid ...................................................................... pySim/euicc: fix encoding/decoding of Iccid The class Iccid uses a BcdAdapter to encoded/decode the ICCID. This works fine for ICCIDs that have an even (20) number of digits. In case the digit count is odd (19), the ICCID the last digit requires padding. Let's switch to PaddedBcdAdapter for encoding/decoding, to ensure that odd-length ICCIDs are padded automatically. Change-Id: I527a44ba454656a0d682ceb590eec6d9d0ac883a Related: OS#6868 --- M pySim/euicc.py M tests/pySim-shell_test/euicc/get_profiles_info.ok M tests/pySim-shell_test/euicc/test.py M tests/pySim-shell_test/euicc/test_gen_notif.script 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve lynxis lazus: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/euicc.py b/pySim/euicc.py index ccb65be..36e2d2a 100644 --- a/pySim/euicc.py +++ b/pySim/euicc.py @@ -181,7 +181,7 @@ class NotificationAddress(BER_TLV_IE, tag=0x0c): _construct = Utf8Adapter(GreedyBytes) class Iccid(BER_TLV_IE, tag=0x5a): - _construct = BcdAdapter(GreedyBytes) + _construct = PaddedBcdAdapter(GreedyBytes) class NotificationMetadata(BER_TLV_IE, tag=0xbf2f, nested=[SeqNumber, ProfileMgmtOperation, NotificationAddress, Iccid]): pass diff --git a/tests/pySim-shell_test/euicc/get_profiles_info.ok b/tests/pySim-shell_test/euicc/get_profiles_info.ok index 8450cb2..28eeff4 100644 --- a/tests/pySim-shell_test/euicc/get_profiles_info.ok +++ b/tests/pySim-shell_test/euicc/get_profiles_info.ok @@ -15,7 +15,7 @@ }, { "profile_info": { - "iccid": "8949449999999990031f", + "iccid": "8949449999999990031", "isdp_aid": "a0000005591010ffffffff8900001200", "profile_state": "disabled", "service_provider_name": "OsmocomSPN", diff --git a/tests/pySim-shell_test/euicc/test.py b/tests/pySim-shell_test/euicc/test.py index 3cad859..654d575 100644 --- a/tests/pySim-shell_test/euicc/test.py +++ b/tests/pySim-shell_test/euicc/test.py @@ -23,7 +23,7 @@ import json from utils import * -# This testcase requires a sysmoEUICC1-C2T with the test prfile TS48V1-B-UNIQUE (ICCID 8949449999999990031f) +# This testcase requires a sysmoEUICC1-C2T with the test prfile TS48V1-B-UNIQUE (ICCID 8949449999999990031) # installed, and in disabled state. Also the profile must be installed in such a way that notifications are # generated when the profile is disabled or enabled (ProfileMetadata) diff --git a/tests/pySim-shell_test/euicc/test_gen_notif.script b/tests/pySim-shell_test/euicc/test_gen_notif.script index d97dc2b..feb7ef2 100644 --- a/tests/pySim-shell_test/euicc/test_gen_notif.script +++ b/tests/pySim-shell_test/euicc/test_gen_notif.script @@ -4,5 +4,5 @@ select ADF.ISD-R # Generate two (additional) notifications by quickly enabeling the test profile -enable_profile --iccid 8949449999999990031f +enable_profile --iccid 8949449999999990031 enable_profile --iccid 89000123456789012341 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42086?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I527a44ba454656a0d682ceb590eec6d9d0ac883a Gerrit-Change-Number: 42086 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in pysim[master]: euicc: get_profiles_info: add additional tags
by dexter 10 Feb '26

10 Feb '26

Attention is currently required from: lynxis lazus. dexter has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/pysim/+/42058?usp=email ) Change subject: euicc: get_profiles_info: add additional tags ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File pySim/euicc.py: https://gerrit.osmocom.org/c/pysim/+/42058/comment/7703cf08_2844a799?usp=em… : PS1, Line 232: _construct = GreedyBytes in rsp.asn ProfileInfo the NotificationConfigurationInfo comes before the ProfilePolicyRules. Maybe swap the position of both to maintain order? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42058?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I727dbe34d87a42bb3b526bd7a8accd687d20a208 Gerrit-Change-Number: 42058 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 10 Feb 2026 13:18:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: gitignore: fix vim swp file pattern
by laforge 10 Feb '26

10 Feb '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/41916?usp=email ) Change subject: gitignore: fix vim swp file pattern ...................................................................... gitignore: fix vim swp file pattern Change-Id: I5a8351dc09f6ca7c8e9032ff8352e5cf1a4833a3 --- M .gitignore 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/.gitignore b/.gitignore index 7a2e150..0cd5b14 100644 --- a/.gitignore +++ b/.gitignore @@ -1,5 +1,5 @@ *.pyc -.*.swp +.*.sw? /docs/_* /docs/generated -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41916?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5a8351dc09f6ca7c8e9032ff8352e5cf1a4833a3 Gerrit-Change-Number: 41916 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: gitignore: fix vim swp file pattern
by laforge 10 Feb '26

10 Feb '26

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/41916?usp=email ) Change subject: gitignore: fix vim swp file pattern ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41916?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5a8351dc09f6ca7c8e9032ff8352e5cf1a4833a3 Gerrit-Change-Number: 41916 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Feb 2026 13:10:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: xua_snm: assert for unexpected condition
by laforge 10 Feb '26

10 Feb '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42103?usp=email ) Change subject: xua_snm: assert for unexpected condition ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42103?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I24bb335a2a856bf1a5ca255f7afbfe103ebcd86f Gerrit-Change-Number: 42103 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Feb 2026 13:10:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: xua: Improve logging around unexpected snm messages
by laforge 10 Feb '26

10 Feb '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42102?usp=email ) Change subject: xua: Improve logging around unexpected snm messages ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42102?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I697e52dfd733cb9ee260bba133204a7462c4e8ee Gerrit-Change-Number: 42102 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Feb 2026 13:09:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: xua: Allow rx DAUD in IPSP with quirk daud_in_asp
by laforge 10 Feb '26

10 Feb '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42100?usp=email ) Change subject: xua: Allow rx DAUD in IPSP with quirk daud_in_asp ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42100?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8ad0889f4584446f8b01f1255498f57e0cd34012 Gerrit-Change-Number: 42100 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Feb 2026 13:09:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: sua: Support rx SCON in role=IPSP
by laforge 10 Feb '26

10 Feb '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42093?usp=email ) Change subject: sua: Support rx SCON in role=IPSP ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42093?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3f46b634084c1d71643812828d4f114ab45dffde Gerrit-Change-Number: 42093 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Feb 2026 13:08:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: sua: Support rx SCON in role=SG
by laforge 10 Feb '26

10 Feb '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42092?usp=email ) Change subject: sua: Support rx SCON in role=SG ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42092?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ide2b4f876ddbdb1bb0bfed11fad6fc13aaf1afda Gerrit-Change-Number: 42092 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Feb 2026 13:08:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log