- gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: xua_asp_fsm: Improvements to support IPSP
by daniel 11 Feb '26

11 Feb '26

Attention is currently required from: pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42073?usp=email ) Change subject: xua_asp_fsm: Improvements to support IPSP ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42073?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ia268848ee9bb2f97a47ba9be60ecd16fbeb4fb40 Gerrit-Change-Number: 42073 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Feb 2026 13:47:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: xua_rkm: Adapt RKM code to support IPSP
by daniel 11 Feb '26

11 Feb '26

Attention is currently required from: pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42072?usp=email ) Change subject: xua_rkm: Adapt RKM code to support IPSP ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42072?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9c59d6fb43d4e7ceda552f156dd7761173545b11 Gerrit-Change-Number: 42072 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Feb 2026 13:44:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: vty: Prohibit configuring an IPA ASP as IPSP
by daniel 11 Feb '26

11 Feb '26

Attention is currently required from: pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42071?usp=email ) Change subject: vty: Prohibit configuring an IPA ASP as IPSP ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42071?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I18ad3e9ad4aac7a3d8e84483ba1bf09016520b54 Gerrit-Change-Number: 42071 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Feb 2026 13:41:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: TC_ho_inter_bsc: wait for the target BSC to become ready
by fixeria 11 Feb '26

11 Feb '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42107?usp=email ) Change subject: msc: TC_ho_inter_bsc: wait for the target BSC to become ready ...................................................................... msc: TC_ho_inter_bsc: wait for the target BSC to become ready A race condition may occur between the two testcase components emulating BSCs: the source BSC initiates handover to the terget BSC before the later completes connection establishment with the MSC. In this case, the MSC fails to find the target peer and rejects our HandoverRequired with HandoverRequiredReject. Target RAN peer from neighbor config is not connected: Cell ID CGI:023-42-5-6 resolves to target address 0.24.2 Cannot find target peer for cell ID CGI:023-42-5-6 Attempted Handover to 1 cells without success Let's avoid this by waiting for the target BSC to become available before initiating the handover procedure. Use the COORD port ("intercom") to signal readiness of the target BSC. Change-Id: I00b8a8b89ec7bb15590d30aadf40055981375a5d Related: OS#6951 --- M msc/MSC_Tests.ttcn 1 file changed, 17 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/07/42107/1 diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 17fac68..e9acddc 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -6023,6 +6023,12 @@ f_perform_lu(); f_mo_call_establish(cpars); + /* The target BSC needs to be ready for incoming handover. + * This is indicated by f_tc_ho_inter_bsc1() via the "intercom". */ + log("Waiting for the target BSC to become ready..."); + COORD.receive("READY"); + log("The target BSC is ready, it's time for the handover!"); + /* Remember the last n_sd (sequence number), * we will need it when the other BSS hands over back to us. */ var N_Sd_Array last_n_sd := f_bssmap_last_n_sd(); @@ -6131,6 +6137,11 @@ f_init_handler(pars); f_create_bssmap_exp_n_connect(194); + /* At this point, the target BSC is ready for incoming handover. + * Indicate this to f_tc_ho_inter_bsc0() via the "intercom". */ + log("The target BSC becomes ready for handover"); + COORD.send("READY"); + var template BSSMAP_IE_EncryptionInformation encryptionInformation; var template BSSMAP_IE_ChosenEncryptionAlgorithm chosenEncryptionAlgorithm; var template BSSMAP_IE_KC128 kC128; @@ -6236,8 +6247,12 @@ } f_vty_config(MSCVTY, "network", "encryption a5 " & int2str(a5_n)); - vc_conn0 := f_start_handler_with_pars(refers(f_tc_ho_inter_bsc0), pars0); - vc_conn1 := f_start_handler_with_pars(refers(f_tc_ho_inter_bsc1), pars1); + vc_conn0 := f_start_handler_create(pars0); + vc_conn1 := f_start_handler_create(pars1); + connect(vc_conn0:COORD, vc_conn1:COORD); + + f_start_handler_run(vc_conn0, refers(f_tc_ho_inter_bsc0), pars0); + f_start_handler_run(vc_conn1, refers(f_tc_ho_inter_bsc1), pars1); vc_conn0.done; vc_conn1.done; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42107?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I00b8a8b89ec7bb15590d30aadf40055981375a5d Gerrit-Change-Number: 42107 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: f_tc_ho_inter_bsc0(): catch BSSMAP HandoverRequiredReject
by fixeria 11 Feb '26

11 Feb '26

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42106?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin Change subject: msc: f_tc_ho_inter_bsc0(): catch BSSMAP HandoverRequiredReject ...................................................................... msc: f_tc_ho_inter_bsc0(): catch BSSMAP HandoverRequiredReject It may happen that the target BSC is not yet connected to the MSC. In this case the MSC rejects handover with HandoverRequiredReject. Let's catch this PDU to make the verdict cleaner in such case. Change-Id: I5ba98e323e0c7794554ccb115d7697ad03ccbfa5 Related: OS#6951 --- M msc/MSC_Tests.ttcn 1 file changed, 12 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/06/42106/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42106?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5ba98e323e0c7794554ccb115d7697ad03ccbfa5 Gerrit-Change-Number: 42106 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-sgsn[master]: Some older modules, such as the Air20X module, may crash during PDP a...
by Jenkins Builder 11 Feb '26

11 Feb '26

Attention is currently required from: canghaiwuhen, laforge, pespin. Jenkins Builder has posted comments on this change by canghaiwuhen. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/42050?usp=email ) Change subject: Some older modules, such as the Air20X module, may crash during PDP attachment due to excessively long QoS response packets. If the PDP is not released after successful attachment, the module will restart, and subsequent TCP connections will fail. ...................................................................... Patch Set 7: (3 comments) File src/sgsn/gprs_gmm.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/e7aa57dd_a2c0050e?us… : PS7, Line 1347: LOGMMCTXP(LOGL_NOTICE, ctx, trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/b386a87e_e01e069f?us… : PS7, Line 1348: "Re-Attach: Dropping stale PDP context for NSAPI=%u\n", trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/7db19eed_51469fc8?us… : PS7, Line 1375: LOGMMCTXP(LOGL_NOTICE, ctx, trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/42050?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I11c24b64f0e49cf80c825969dbf018b2948d855c Gerrit-Change-Number: 42050 Gerrit-PatchSet: 7 Gerrit-Owner: canghaiwuhen <canghaiwuhen(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: canghaiwuhen <canghaiwuhen(a)gmail.com> Gerrit-Comment-Date: Wed, 11 Feb 2026 12:47:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-sgsn[master]: Some older modules, such as the Air20X module, may crash during PDP a...
by Jenkins Builder 11 Feb '26

11 Feb '26

Attention is currently required from: canghaiwuhen, laforge, pespin. Jenkins Builder has posted comments on this change by canghaiwuhen. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/42050?usp=email ) Change subject: Some older modules, such as the Air20X module, may crash during PDP attachment due to excessively long QoS response packets. If the PDP is not released after successful attachment, the module will restart, and subsequent TCP connections will fail. ...................................................................... Patch Set 6: (8 comments) File src/sgsn/gprs_gmm.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/2dffa20e_9fc7053a?us… : PS6, Line 1340: /* [FIX] Known IMSI context. If the module initiates an Attach, trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/7ce81eed_45325a13?us… : PS6, Line 1342: * We must clean up the old PDP context on the SGSN side; trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/cf1cacbc_f617daf0?us… : PS6, Line 1343: * otherwise, the SGSN will not recreate them, trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/46678442_554d897d?us… : PS6, Line 1347: LOGMMCTXP(LOGL_NOTICE, ctx, trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/0e4aad5f_bad1b9bf?us… : PS6, Line 1348: "Re-Attach: Dropping stale PDP context for NSAPI=%u\n", trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/80c4b694_5bf56800?us… : PS6, Line 1371: /* [FIX] Known P-TMSI context. Similarly, if the module re-attaches, trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/bd43cadc_a05f34d8?us… : PS6, Line 1375: LOGMMCTXP(LOGL_NOTICE, ctx, trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/259d5cf4_b9709496?us… : PS6, Line 1376: "Re-Attach: Dropping stale PDP context for NSAPI=%u\n", trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/42050?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I11c24b64f0e49cf80c825969dbf018b2948d855c Gerrit-Change-Number: 42050 Gerrit-PatchSet: 6 Gerrit-Owner: canghaiwuhen <canghaiwuhen(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: canghaiwuhen <canghaiwuhen(a)gmail.com> Gerrit-Comment-Date: Wed, 11 Feb 2026 12:45:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: f_tc_ho_inter_bsc0(): catch BSSMAP HandoverRequiredReject
by pespin 11 Feb '26

11 Feb '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42106?usp=email ) Change subject: msc: f_tc_ho_inter_bsc0(): catch BSSMAP HandoverRequiredReject ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42106?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5ba98e323e0c7794554ccb115d7697ad03ccbfa5 Gerrit-Change-Number: 42106 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Feb 2026 10:31:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: f_tc_ho_inter_bsc0(): catch BSSMAP HandoverRequiredReject
by fixeria 11 Feb '26

11 Feb '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42106?usp=email ) Change subject: msc: f_tc_ho_inter_bsc0(): catch BSSMAP HandoverRequiredReject ...................................................................... msc: f_tc_ho_inter_bsc0(): catch BSSMAP HandoverRequiredReject It may happen that the target BSC is not yet connected to the MSC. In this case the MSC rejects handover with HandoverRequiredReject. Let's catch this PDU to make the verdict cleaner in such case. Change-Id: I5ba98e323e0c7794554ccb115d7697ad03ccbfa5 --- M msc/MSC_Tests.ttcn 1 file changed, 12 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/06/42106/1 diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 5464355..17fac68 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -6043,12 +6043,19 @@ /* Now the action goes on in f_tc_ho_inter_bsc1() */ /* MSC forwards the RR Handover Command to old BSS */ - var PDU_BSSAP ho_command; - RAN_CONN.receive(tr_BSSMAP_HandoverCommand) -> value ho_command; + var PDU_BSSAP pdu_bssap; + alt { + [] RAN_CONN.receive(tr_BSSMAP_HandoverCommand) -> value pdu_bssap { + log("Rx HandoverCommand: ", pdu_bssap); + RAN_CONN.receive(tr_BSSMAP_HandoverSucceeded) -> value pdu_bssap; + log("Rx HandoverSucceeded: ", pdu_bssap); + } + [] RAN_CONN.receive(tr_BSSMAP_HandoverRequiredReject) -> value pdu_bssap { + setverdict(fail, "Rx HandoverRequiredReject: ", pdu_bssap); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); + } + } - log("GOT HandoverCommand", ho_command); - - RAN_CONN.receive(tr_BSSMAP_HandoverSucceeded); /* f_tc_ho_inter_bsc1() completes Handover, then expecting a Clear here. */ f_expect_clear(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42106?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5ba98e323e0c7794554ccb115d7697ad03ccbfa5 Gerrit-Change-Number: 42106 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[L] Change in libosmo-sigtran[master]: Introduce struct osmo_ss7_as_asp_assoc
by pespin 11 Feb '26

11 Feb '26

Attention is currently required from: daniel, fixeria, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42105?usp=email ) Change subject: Introduce struct osmo_ss7_as_asp_assoc ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > We are usually talking about a handful of ASPs here, up to 16 if comparing to previous setups, so it […] The only place where we may see real benefit on optimizing the llist is probably the override traffic mode, where it may make sense to keep a pointer to the currently active ASP, in order to avoid potentially traversing the whole list. In roundrobin/loadshare traffic modes, one would expect most if not all of the ASPs in the AS be active, which means we are mostly if not always just simply picking the next item in the list from previous state. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42105?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I149ab467899633ac50cba3e482b2cae02124279d Gerrit-Change-Number: 42105 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Feb 2026 10:20:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log