Attention is currently required from: neels.
dexter has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37755?usp=email )
Change subject: pfcp-tool: fix extra newline in vty_out
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37755?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ib3bb0795238f251ea5b515fe639280be66542a01
Gerrit-Change-Number: 37755
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Aug 2024 13:43:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: neels.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-upf/+/37764?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: osmo-pfcp-tool: add GTP flooding using io_uring
......................................................................
osmo-pfcp-tool: add GTP flooding using io_uring
Freely copying from gtp-load-gen.c, implement GTP flooding in
osmo-pfcp-tool scripts.
Add dependency liburing. It can be disabled with
configure --disable-uring
in which case the new 'gtp flood' command only logs an error.
This verbosely commented example script serves as a good explanation:
contrib/osmo-pfcp-tool-scripts/gtp_flood.vty
Related: SYS#6590
Change-Id: I332aa0e2efd55f6e357cde4752a3d8b584db531b
---
M TODO-RELEASE
M configure.ac
A contrib/osmo-pfcp-tool-scripts/gtp_flood.vty
M debian/control
M include/osmocom/pfcptool/Makefile.am
A include/osmocom/pfcptool/checksum.h
A include/osmocom/pfcptool/gtp_flood.h
M include/osmocom/pfcptool/pfcp_tool.h
A include/osmocom/pfcptool/range.h
M src/osmo-pfcp-tool/Makefile.am
A src/osmo-pfcp-tool/checksum.c
A src/osmo-pfcp-tool/gtp_flood.c
M src/osmo-pfcp-tool/osmo_pfcp_tool_main.c
M src/osmo-pfcp-tool/pfcp_tool.c
M src/osmo-pfcp-tool/pfcp_tool_vty.c
A src/osmo-pfcp-tool/range.c
16 files changed, 1,299 insertions(+), 27 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/64/37764/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37764?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I332aa0e2efd55f6e357cde4752a3d8b584db531b
Gerrit-Change-Number: 37764
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Attention is currently required from: laforge.
fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37778?usp=email )
Change subject: pySim.cards: Make file_exists() check for activated/deactivated
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37778?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I73bd1ab3780e475c96a10cd5dbdd45b829c67335
Gerrit-Change-Number: 37778
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 06 Aug 2024 18:50:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: neels.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-upf/+/37761?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: pfcp_tool: add 'date'
......................................................................
pfcp_tool: add 'date'
Allow scripts to output timestamps to easily measure how long certain
actions took to complete. Related: measuring PFCP session management
performance bounds of osmo-upf.
Change-Id: I0486cc92ea298bb9926a0e5c26da17ba5970a72c
---
M src/osmo-pfcp-tool/pfcp_tool_vty.c
1 file changed, 21 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/61/37761/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37761?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I0486cc92ea298bb9926a0e5c26da17ba5970a72c
Gerrit-Change-Number: 37761
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Attention is currently required from: fixeria.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37643?usp=email )
Change subject: ara_m: add export support for the ARA-M application
......................................................................
Patch Set 2:
(2 comments)
File pySim/ara_m.py:
https://gerrit.osmocom.org/c/pysim/+/37643/comment/67788b88_0aa4aab3?usp=em… :
PS1, Line 430: if res_do:
> Too much nesting here, this is making the code harder to read/edit. […]
Done
https://gerrit.osmocom.org/c/pysim/+/37643/comment/c9fd1645_4c6beafd?usp=em… :
PS1, Line 432: if 'response_all_ref_ar_do' in res_do_dict and res_do_dict['response_all_ref_ar_do']:
> ``` […]
Done
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37643?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I811cb9d25cb8ee194b4ead5fb2cabf1fdc0c1c43
Gerrit-Change-Number: 37643
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Aug 2024 13:27:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>