- gerrit-log - lists.osmocom.org

[M] Change in pysim[master]: runtime: integrate escape route for applications without ADF support
by laforge 10 Aug '24

10 Aug '24

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37774?usp=email ) Change subject: runtime: integrate escape route for applications without ADF support ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/pysim/+/37774/comment/43b32c8e_aecaff91?usp=em… : PS2, Line 15: ri rid -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37774?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie6f37d13af880d24a9c7a8a95cef436b603587c7 Gerrit-Change-Number: 37774 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Aug 2024 14:14:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[NoOp] Change in osmo-bsc-nat[master]: do not merge: testing CI
by osmith 10 Aug '24

10 Aug '24

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/33938?usp=email ) Change subject: do not merge: testing CI ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/33938?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Ic78700d85b24a7d4b777360902410ebe21449eda Gerrit-Change-Number: 33938 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[M] Change in pysim[master]: ara_m: add export support for the ARA-M application
by dexter 10 Aug '24

10 Aug '24

Attention is currently required from: fixeria, laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37643?usp=email ) Change subject: ara_m: add export support for the ARA-M application ...................................................................... Patch Set 3: (1 comment) File pySim/ara_m.py: https://gerrit.osmocom.org/c/pysim/+/37643/comment/aaf0937c_11dd4895?usp=em… : PS2, Line 425: if 'ref_ar_do' in ref_ar_do_list: : for ref_ar_do in ref_ar_do_list['ref_ar_do']: : if 'ref_do' in ref_ar_do: : ref_do_list = ref_ar_do['ref_do'] : if 'ar_do' in ref_ar_do: : ar_do_list = ref_ar_do['ar_do'] : : if ref_do_list and ar_do_list: : aid_ref_do = None : dev_app_id_ref_do = None : apdu_ar_do = None : nfc_ar_do = None : perm_ar_do = None : pkg_ref_do = None : for ref_do in ref_do_list: : if 'aid_ref_do' in ref_do: : aid_ref_do = ref_do['aid_ref_do'] : if 'dev_app_id_ref_do' in ref_do: : dev_app_id_ref_do = ref_do['dev_app_id_ref_do'] : if 'pkg_ref_do' in ref_do: : pkg_ref_do = ref_do['pkg_ref_do'] : for ar_do in ar_do_list: : if 'apdu_ar_do' in ar_do: : apdu_ar_do = ar_do['apdu_ar_do'] : if 'nfc_ar_do' in ar_do: : nfc_ar_do = ar_do['nfc_ar_do'] : if 'perm_ar_do' in ar_do: : perm_ar_do = ar_do['perm_ar_do'] > why do we need all those maipulations? it's a lot of hand-written code which I'd rather avoid (also, […] I have put it into a helper function, now it is much shorter. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37643?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I811cb9d25cb8ee194b4ead5fb2cabf1fdc0c1c43 Gerrit-Change-Number: 37643 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Aug 2024 13:23:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[M] Change in ...osmo-s1gw[master]: add debian package files
by fixeria 10 Aug '24

10 Aug '24

Attention is currently required from: osmith. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37730?usp=email ) Change subject: add debian package files ...................................................................... Patch Set 3: (1 comment) Patchset: PS1: > With this patch checked out and `gbp dch --ignore-branch --since=0.1.0`, I got: [...] Interestingly enough, I was getting a different output with exactly the same command. I ended up grabbing this file from `gapk.git` and changing it a bit. This should be enough, I guess. At least I can build the package using `dpkg-buildpackage -B --no-sign`. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37730?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I5446c70c1c1f232a2a45de60be7068cfd683a99c Gerrit-Change-Number: 37730 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Aug 2024 18:06:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: filesystem: fix typo
by dexter 10 Aug '24

10 Aug '24

dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37784?usp=email ) Change subject: filesystem: fix typo ...................................................................... filesystem: fix typo Change-Id: I17f184bbcf494c5fe944602224cf72d6a22cbc9d --- M pySim/filesystem.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved diff --git a/pySim/filesystem.py b/pySim/filesystem.py index e3efcab..624619b 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -64,7 +64,7 @@ Args: fid : File Identifier (4 hex digits) sfid : Short File Identifier (2 hex digits, optional) - name : Brief name of the file, lik EF_ICCID + name : Brief name of the file, like EF_ICCID desc : Description of the file parent : Parent CardFile object within filesystem hierarchy profile : Card profile that this file should be part of -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I17f184bbcf494c5fe944602224cf72d6a22cbc9d Gerrit-Change-Number: 37784 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in pysim[master]: runtime: integrate escape route for applications without ADF support
by dexter 10 Aug '24

10 Aug '24

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37774?usp=email ) Change subject: runtime: integrate escape route for applications without ADF support ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37774?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie6f37d13af880d24a9c7a8a95cef436b603587c7 Gerrit-Change-Number: 37774 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Aug 2024 07:29:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in pysim[master]: pySim-shell: enable export of DF and ADF files
by laforge 10 Aug '24

10 Aug '24

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37641?usp=email ) Change subject: pySim-shell: enable export of DF and ADF files ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/37641/comment/33ad01bb_8304118d?usp=em… : PS2, Line 602: > I made it conditionally because I the information from the ADF (ADF. […] I'd simply include everything by default. One can always easily delete parts from the output, if one doesn't want them. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37641?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3ee661dbae5c11fec23911775f352ac13bc2c6e5 Gerrit-Change-Number: 37641 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Aug 2024 14:11:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in ...osmo-s1gw[master]: add debian package files
by osmith 10 Aug '24

10 Aug '24

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37730?usp=email ) Change subject: add debian package files ...................................................................... Patch Set 3: Code-Review-1 (1 comment) Patchset: PS3: This needs a `contrib/generate_build_dep.sh` like in osmo_dia2gsup, otherwise: ``` dh_auto_build make -j17 make[2]: Entering directory '/obs/_temp/binpkgs/osmo-s1gw' rebar3 asn compile ===> Fetching provider_asn1 (from {git,"https://github.com/knusbaum/provider_asn1.git", {tag,"0.4.0"}}) ===> Errors loading plugin {provider_asn1,".*", {git, "https://github.com/knusbaum/provider_asn1.git", {tag,"0.4.0"}}}. Run rebar3 with DEBUG=1 set to see errors. ===> Command asn not found make[2]: *** [Makefile:15: include/S1AP-*.hrl] Error 1 ``` This can be reproduced by checking out https://gerrit.osmocom.org/c/osmo-ci/+/37773 and running `path-to-osmo-ci/scripts/obs/gerrit_binpkgs.sh debian:12` from the osmo-s1gw directory. I'm looking into how this needs to be adjusted to make it pass. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37730?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I5446c70c1c1f232a2a45de60be7068cfd683a99c Gerrit-Change-Number: 37730 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Aug 2024 09:04:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: filesystem: add export method for ADF files
by dexter 10 Aug '24

10 Aug '24

Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/37642?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: filesystem: add export method for ADF files ...................................................................... filesystem: add export method for ADF files This patch adds an export method to CardADF, which calls the application specific export method in CardApplication class Related: OS#6092 Change-Id: I8129656096ecaf41b36e5f2afbbfbebcd0587886 --- M pySim/filesystem.py 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/42/37642/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37642?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8129656096ecaf41b36e5f2afbbfbebcd0587886 Gerrit-Change-Number: 37642 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: jobs/osmocom-depcheck: update default project
by osmith 10 Aug '24

10 Aug '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/37769?usp=email ) Change subject: jobs/osmocom-depcheck: update default project ...................................................................... jobs/osmocom-depcheck: update default project Use osmo-hlr:master as default instead of a random specific version osmo-hlr:2.0.1. Change-Id: I47d56f599e1b404412998334ab54c474cebe8b04 --- M jobs/osmocom-depcheck.yml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/69/37769/1 diff --git a/jobs/osmocom-depcheck.yml b/jobs/osmocom-depcheck.yml index 5e20f95..8c4ef2b 100644 --- a/jobs/osmocom-depcheck.yml +++ b/jobs/osmocom-depcheck.yml @@ -25,7 +25,7 @@ empty to default to all projects (!), default revision is "master". Examples: "osmo-hlr", "osmo-hlr:0.2.1 osmo-bts:0.8.1" - default: 'osmo-hlr:0.2.1' + default: 'osmo-hlr:master' - string: name: GIT_URL_PREFIX description: | -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37769?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I47d56f599e1b404412998334ab54c474cebe8b04 Gerrit-Change-Number: 37769 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log