- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: ttcn3-(tcp)dump(pcap)-stop.sh: store multiple runs of same test into ...
by laforge 10 Aug '24

10 Aug '24

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37723?usp=email ) Change subject: ttcn3-(tcp)dump(pcap)-stop.sh: store multiple runs of same test into different pcap file ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37723?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib68fc4df1f5a105b4b2c904d2d2003c621a2ad31 Gerrit-Change-Number: 37723 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Aug 2024 12:31:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-mgw[master]: mgcp_network: add missing ntohs
by dexter 10 Aug '24

10 Aug '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/37777?usp=email ) Change subject: mgcp_network: add missing ntohs ...................................................................... mgcp_network: add missing ntohs We must use ntohs before passing the RTCP port to osmo_sockaddr_port Related: OS#6527 Change-Id: I9773c7b1fda8c9b429723ef9f0db0b58894b28fe --- M src/libosmo-mgcp/mgcp_network.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/77/37777/1 diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c index 58d85df..fd27e9a 100644 --- a/src/libosmo-mgcp/mgcp_network.c +++ b/src/libosmo-mgcp/mgcp_network.c @@ -1251,7 +1251,7 @@ return 0; } else if (!trunk->omit_rtcp) { struct osmo_sockaddr rtcp_addr = rtp_end->addr; - osmo_sockaddr_set_port(&rtcp_addr.u.sa, rtp_end->rtcp_port); + osmo_sockaddr_set_port(&rtcp_addr.u.sa, ntohs(rtp_end->rtcp_port)); LOGPENDP(endp, DRTP, LOGL_DEBUG, "send to %s %s rtp_port:%u rtcp_port:%u\n", dest_name, osmo_sockaddr_ntop(&rtcp_addr.u.sa, ipbuf), -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/37777?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I9773c7b1fda8c9b429723ef9f0db0b58894b28fe Gerrit-Change-Number: 37777 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-mgw[master]: mgcp_network: use an uint16_t to store the port number
by dexter 10 Aug '24

10 Aug '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/37776?usp=email ) Change subject: mgcp_network: use an uint16_t to store the port number ...................................................................... mgcp_network: use an uint16_t to store the port number The comment in struct mgcp_rtp_end says that the RTCP port number has to be stored in network byte order. Such a port number is 16 byte long, so let's use an uint16_t instead of an int here. Related: OS#6527 Change-Id: I392b07b243389a78d4ad1d784cdfdc28ec59b487 --- M include/osmocom/mgcp/mgcp_network.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/76/37776/1 diff --git a/include/osmocom/mgcp/mgcp_network.h b/include/osmocom/mgcp/mgcp_network.h index 8f6505c..453fbe9 100644 --- a/include/osmocom/mgcp/mgcp_network.h +++ b/include/osmocom/mgcp/mgcp_network.h @@ -94,7 +94,7 @@ struct osmo_sockaddr addr; /* in network byte order */ - int rtcp_port; + uint16_t rtcp_port; /* currently selected audio codec */ struct mgcp_rtp_codec *codec; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/37776?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I392b07b243389a78d4ad1d784cdfdc28ec59b487 Gerrit-Change-Number: 37776 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in ...osmo_dia2gsup[master]: Makefile: add 'install' target, clean up debian/rules
by osmith 10 Aug '24

10 Aug '24

Attention is currently required from: fixeria, laforge. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37727?usp=email ) Change subject: Makefile: add 'install' target, clean up debian/rules ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Patchset: PS2: nice! File Makefile: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37727/comment/8419fd96_… : PS2, Line 29: install -m 0644 contrib/systemd/osmo_dia2gsup.service $(DESTDIR)$(SYSTEMDUNITDIR) If you use -D, then install will create the directory, e.g.: ```suggestion install -Dm 0644 contrib/systemd/osmo_dia2gsup.service $(DESTDIR)$(SYSTEMDUNITDIR) ``` -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37727?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I0769ca5f922a41f2b0976bf283176040aae4c781 Gerrit-Change-Number: 37727 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Aug 2024 07:39:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...osmo_dia2gsup[master]: Makefile: install 'sys.config' to /etc/osmocom/osmo-dia2gsup.config
by fixeria 10 Aug '24

10 Aug '24

Attention is currently required from: fixeria, laforge, osmith. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37717?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: Makefile: install 'sys.config' to /etc/osmocom/osmo-dia2gsup.config ...................................................................... Makefile: install 'sys.config' to /etc/osmocom/osmo-dia2gsup.config Related: OS#6148 Change-Id: I3b2595ca3d82a2ead8fb5560fcc281091e320aa9 --- M Makefile 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/17/37717/4 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37717?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I3b2595ca3d82a2ead8fb5560fcc281091e320aa9 Gerrit-Change-Number: 37717 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-upf[master]: nft: batch nftables commands
by neels 10 Aug '24

10 Aug '24

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-upf/+/37762?usp=email to look at the new patch set (#3). Change subject: nft: batch nftables commands ...................................................................... nft: batch nftables commands Store nftables ruleset commands for a limited time and a limited volume before submitting in batch, in order to minimize the overhead associated with submitting nftables commands. Configurable by 'timer nft X32' and 'X33' Change-Id: Ib0a8e86b29bab1559d94fc55a89daa00ec670318 --- M include/osmocom/upf/upf.h M src/osmo-upf/upf.c M src/osmo-upf/upf_nft.c M tests/unique_ids/unique_ids_test.err 4 files changed, 192 insertions(+), 31 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/62/37762/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37762?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ib0a8e86b29bab1559d94fc55a89daa00ec670318 Gerrit-Change-Number: 37762 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: podman.is_running() -> testenv.args.podman
by osmith 10 Aug '24

10 Aug '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37765?usp=email ) Change subject: testenv: podman.is_running() -> testenv.args.podman ...................................................................... testenv: podman.is_running() -> testenv.args.podman Use testenv.args.podman instead of testenv.podman.is_running() in all places except for testenv.podman.stop(). - testenv.args.podman is always True when --podman is used. - testenv.podman.is_running() is only True while the container is currently running. Most of the time the behavior is the same. But without this patch, when the container crashes, commands would unexpectedly run outside of the container (and then fail on jenkins due to missing programs). Change-Id: Iea634f5e97d14f1f7e777f4609b9593974964d23 --- M _testenv/testenv/cmd.py M _testenv/testenv/daemons.py 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/65/37765/1 diff --git a/_testenv/testenv/cmd.py b/_testenv/testenv/cmd.py index 93e4e36..cb8386a 100644 --- a/_testenv/testenv/cmd.py +++ b/_testenv/testenv/cmd.py @@ -82,7 +82,7 @@ def run(cmd, check=True, env={}, no_podman=False, stdin=subprocess.DEVNULL, *args, **kwargs): - if not no_podman and testenv.podman.is_running(): + if not no_podman and testenv.args.podman: return testenv.podman.exec_cmd(cmd, check=check, env=env, *args, **kwargs) logging.debug(f"+ {cmd}") diff --git a/_testenv/testenv/daemons.py b/_testenv/testenv/daemons.py index 792341c..9e274d9 100644 --- a/_testenv/testenv/daemons.py +++ b/_testenv/testenv/daemons.py @@ -55,7 +55,7 @@ if testenv.args.io_uring: env["LIBOSMO_IO_BACKEND"] = "IO_URING" - if testenv.podman.is_running(): + if testenv.args.podman: daemons[section] = testenv.podman.exec_cmd_background(cmd, cwd=cwd, env=env) else: logging.debug(f"+ {cmd}") -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37765?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iea634f5e97d14f1f7e777f4609b9593974964d23 Gerrit-Change-Number: 37765 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in pysim[master]: ara_m: add export support for the ARA-M application
by dexter 10 Aug '24

10 Aug '24

Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/37643?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: ara_m: add export support for the ARA-M application ...................................................................... ara_m: add export support for the ARA-M application This patch adds an export method to the CardApplicationARAM class. This method reads the ARA-M configuration and transforms it into executeable command lines, which can be executed as a script later to restore an ARA-M configuration. Related: OS#6092 Change-Id: I811cb9d25cb8ee194b4ead5fb2cabf1fdc0c1c43 --- M pySim/ara_m.py 1 file changed, 75 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/43/37643/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37643?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I811cb9d25cb8ee194b4ead5fb2cabf1fdc0c1c43 Gerrit-Change-Number: 37643 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in pysim[master]: runtime: add method to lookup a file by name without selecting it
by laforge 10 Aug '24

10 Aug '24

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37785?usp=email ) Change subject: runtime: add method to lookup a file by name without selecting it ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37785?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6b6121e749cea843163659e1a26bb3893c032e29 Gerrit-Change-Number: 37785 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Aug 2024 14:58:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[NoOp] Change in pysim[master]: Do not merge: test commit for testing jenkins
by osmith 10 Aug '24

10 Aug '24

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/31052?usp=email ) Change subject: Do not merge: test commit for testing jenkins ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31052?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ifb1f03b06062e3f6eb6738c6ada8f24e6d01a219 Gerrit-Change-Number: 31052 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log