- gerrit-log - lists.osmocom.org

[S] Change in osmo-hnbgw[master]: Integrate mgw/mgcp failures more tightly into context_map fsm
by laforge 18 Feb '26

18 Feb '26

Attention is currently required from: fixeria, neels, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/42129?usp=email ) Change subject: Integrate mgw/mgcp failures more tightly into context_map fsm ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/42129?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ief051e1384d2282708302dc1756454d8f88a6fae Gerrit-Change-Number: 42129 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Feb 2026 19:41:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmo-netif[master]: twjit: add underrun extension feature
by laforge 18 Feb '26

18 Feb '26

Attention is currently required from: falconia, fixeria, pespin. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/42141?usp=email ) Change subject: twjit: add underrun extension feature ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42141?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ibda74c0dbfb163f5d0e3fb13f593a6e2c6817673 Gerrit-Change-Number: 42141 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Feb 2026 19:40:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: Fix/change TC_tcap_loadshare_ipa_tcap_udts()
by laforge 18 Feb '26

18 Feb '26

Attention is currently required from: daniel, fixeria, pespin. laforge has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42135?usp=email ) Change subject: Fix/change TC_tcap_loadshare_ipa_tcap_udts() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42135?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibffa98702fd6eb276410630ab525d986fa0f36e0 Gerrit-Change-Number: 42135 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Feb 2026 19:38:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: Fix/change TC_tcap_loadshare_ipa_tcap_udts()
by daniel 18 Feb '26

18 Feb '26

Attention is currently required from: fixeria, pespin. daniel has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42135?usp=email ) Change subject: Fix/change TC_tcap_loadshare_ipa_tcap_udts() ...................................................................... Patch Set 2: (2 comments) File stp/STP_Tests_TCAP.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42135/comment/cbdc616c_8774… : PS1, Line 663: /* TODO: Get the asp_idx of the received message to verify related > AFAIU, from tcap_configs above, you have 2 possible ASPs where it can be recieved, so it should be f […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42135/comment/fe6b9946_3dea… : PS1, Line 693: TC_tcap_loadshare_ipa_tcap_norange > Please update `stp/expected-results.xml`. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42135?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibffa98702fd6eb276410630ab525d986fa0f36e0 Gerrit-Change-Number: 42135 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Feb 2026 18:31:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: Fix/change TC_tcap_loadshare_ipa_tcap_udts()
by daniel 18 Feb '26

18 Feb '26

Attention is currently required from: daniel. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42135?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Fix/change TC_tcap_loadshare_ipa_tcap_udts() ...................................................................... Fix/change TC_tcap_loadshare_ipa_tcap_udts() The behaviour changed to not reject tcap messages outside of any valid route. Change the test expectation that these messages are indeed forwarded. Change-Id: Ibffa98702fd6eb276410630ab525d986fa0f36e0 --- M stp/STP_Tests_TCAP.ttcn M stp/expected-results.xml 2 files changed, 25 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/35/42135/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42135?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibffa98702fd6eb276410630ab525d986fa0f36e0 Gerrit-Change-Number: 42135 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[L] Change in libosmo-netif[master]: twjit: add underrun extension feature
by falconia 18 Feb '26

18 Feb '26

Attention is currently required from: fixeria, pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/42141?usp=email ) Change subject: twjit: add underrun extension feature ...................................................................... Patch Set 2: (3 comments) File src/twjit.c: https://gerrit.osmocom.org/c/libosmo-netif/+/42141/comment/234ed583_004ff8f… : PS1, Line 554: twjit->stats.underruns++; > In the new iteration of my patch, I added a comment explaining while this stats counter should not b […] PS2 got CR+1 from @pespin@sysmocom.de with no further comments. Is it OK to mark this comment as resolved? https://gerrit.osmocom.org/c/libosmo-netif/+/42141/comment/53823e88_a25dbff… : PS1, Line 630: static void handle_flowing_underrun(struct osmo_twjit *twjit) > I added an explanatory comment in the new iteration of my patch - is it good enough? PS2 got CR+1 from @pespin@sysmocom.de with no further comments. Is it OK to mark this comment as resolved? https://gerrit.osmocom.org/c/libosmo-netif/+/42141/comment/401d686a_482c997… : PS1, Line 671: if (read_sb_is_empty(twjit)) { > if (!read_sb_is_empty(twjit)) { […] PS2 got CR+1 from @pespin@sysmocom.de with no further comments. Is it OK to mark this comment as resolved? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42141?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ibda74c0dbfb163f5d0e3fb13f593a6e2c6817673 Gerrit-Change-Number: 42141 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Feb 2026 17:58:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in libosmo-netif[master]: twjit: add underrun extension feature
by pespin 18 Feb '26

18 Feb '26

Attention is currently required from: falconia, fixeria. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/42141?usp=email ) Change subject: twjit: add underrun extension feature ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42141?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ibda74c0dbfb163f5d0e3fb13f593a6e2c6817673 Gerrit-Change-Number: 42141 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Feb 2026 17:37:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: 5gc: Introduce test TC_connection_suspend
by pespin 18 Feb '26

18 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42144?usp=email ) Change subject: 5gc: Introduce test TC_connection_suspend ...................................................................... 5gc: Introduce test TC_connection_suspend The test is expected to fail because open5gs (as of v2.7.3) doesn't implement such features; see open5gs ticket referenced below. Related: SYS#7073 Related: open5gs GH#4322 Change-Id: I6da2571518a9b50369fa8e0dd19e447137ea20c6 --- M 5gc/C5G_Tests.ttcn M 5gc/ConnHdlr.ttcn M 5gc/expected-results.xml M library/ngap/NGAP_EncDec.cc M library/ngap/NGAP_Types.ttcn 5 files changed, 95 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/44/42144/1 diff --git a/5gc/C5G_Tests.ttcn b/5gc/C5G_Tests.ttcn index 5f1516d..5a35b5a 100644 --- a/5gc/C5G_Tests.ttcn +++ b/5gc/C5G_Tests.ttcn @@ -572,6 +572,35 @@ vc_conn.done; } +/* 3GPP TS 23.502 4.8.1.2 Connection Suspend procedure, + * 3GPP TS 23.502 4.8.2.3 Connection Resume procedure */ +private function f_TC_connection_suspend() runs on ConnHdlr { + f_register(); + f_pdu_sess_establish(false); + + f_ue_context_suspend(); + f_ue_context_resume(); + f_sleep(1.0); + f_ue_context_release(); +} +testcase TC_connection_suspend() runs on MTC_CT { + var ConnHdlr vc_conn; + var ConnHdlrPars pars; + + /* TODO: 3GPP TS 23.501 5.31.18 "User Plane CIoT 5GS Optimisation": + * - UE and AMF negotiated support User Plane CIoT 5GS Optimisation (see clause 5.31.2) over NAS, + * - the UE has indicated support of User Plane CIoT 5GS Optimisation in the UE radio capabilities as defined in TS 36.331 [51] + * AMF has indicated User Plane CIoT 5GS Optimisation support for the UE to NG-RAN + */ + f_init(); + f_ngap_setup(0); + + pars := f_init_pars(ue_idx := 0); + + vc_conn := f_start_handler_with_pars(refers(f_TC_connection_suspend), pars); + vc_conn.done; +} + control { execute( TC_ng_setup() ); execute( TC_ng_setup_unknown_global_gnb_id_plmn() ); @@ -611,8 +640,8 @@ * - 3GPP TS 23.502 4.5.2 Session Management Subscriber Data Update Notification to SMF: open5gs-udm supports sotring subscriptions, but never triggers notifications whenever subscriber data is changed. open5gs-smfd registers to UDM but doesn't implement receiving a notification. * - 3GPP TS 23.502 4.7 ME Identity check procedure: N5g-eir (OGS_SBI_SERVICE_NAME_N5G_EIR_EIC) not implemented * - 3GPP TS 23.502 4.8.1.1(a) Connection Inactive procedure: Not supported by open5gs (https://github.com/open5gs/open5gs/issues/4319) - * - 3GPP TS 23.502 4.8.1.2 Connection Suspend procedure - * - 3GPP TS 23.502 4.8.2 Connection Resume procedure + * - 3GPP TS 23.502 4.8.1.2 Connection Suspend procedure: Not supported by open5gs (https://github.com/open5gs/open5gs/issues/4322) + * - 3GPP TS 23.502 4.8.2 Connection Resume procedure: Not supported by open5gs (https://github.com/open5gs/open5gs/issues/4322) * - 3GPP TS 23.502 4.9 Handover procedures * - 3GPP TS 23.502 4.12 Procedures for Untrusted non-3GPP access * - 3GPP TS 23.502 4.12a Procedures for Trusted non-3GPP access diff --git a/5gc/ConnHdlr.ttcn b/5gc/ConnHdlr.ttcn index d31aaa7..ce7d38f 100644 --- a/5gc/ConnHdlr.ttcn +++ b/5gc/ConnHdlr.ttcn @@ -845,6 +845,42 @@ g_pars.ue_pars.ran_id))); } +/* 3GPP TS 38.413 9.2.2.16 UE CONTEXT SUSPEND REQUEST + * 3GPP TS 23.502 4.8.1.2 Connection Suspend procedure */ +function f_ue_context_suspend() runs on ConnHdlr +{ + var template (value) UEContextSuspendRequestTransfer transfer; + var octetstring transfer_enc; + var template (value) NGAP_PDU tx_pdu; + + transfer := m_uEContextSuspendRequestTransfer(p_suspendIndicator := m_suspendIndicator); + transfer_enc := enc_NGAP_UEContextSuspendRequestTransfer(valueof(transfer)); + tx_pdu := m_ngap_initMsg(m_n2_UEContextSuspendRequest( + g_pars.ue_pars.amf_id, + g_pars.ue_pars.ran_id, + {m_pDUSessionResourceSuspendItemSUSReq(g_pars.ue_pars.sess_pars.id, transfer_enc)})); + NGAP.send(tx_pdu); + NGAP.receive(mw_ngap_succMsg(mw_n2_UEContextSuspendResponse( + g_pars.ue_pars.amf_id, + g_pars.ue_pars.ran_id))); +} + +/* 3GPP TS 38.413 9.2.2.16 9.2.2.19 UE CONTEXT RESUME REQUEST + * 3GPP TS 23.502 4.8.2.3 Connection Resume procedure */ +function f_ue_context_resume() runs on ConnHdlr +{ + var template (value) NGAP_PDU tx_pdu; + + tx_pdu := m_ngap_initMsg(m_n2_UEContextResumeRequest( + g_pars.ue_pars.amf_id, + g_pars.ue_pars.ran_id, + m_rRCEstablishmentCause)); + NGAP.send(tx_pdu); + NGAP.receive(mw_ngap_succMsg(mw_n2_UEContextResumeResponse( + g_pars.ue_pars.amf_id, + g_pars.ue_pars.ran_id))); +} + /* Handle a PDUSessionResourceSetupRequestTransfer contained inside NGAP InitialContextSetupRequest and return a Result for InitialContextSetupResponse */ private function f_pdu_handle_session_resource_released_item(PDUSessionResourceToReleaseItemRelCmd cmd) runs on ConnHdlr return PDUSessionResourceReleasedItemRelRes { diff --git a/5gc/expected-results.xml b/5gc/expected-results.xml index 0472dc7..78d5a11 100644 --- a/5gc/expected-results.xml +++ b/5gc/expected-results.xml @@ -18,4 +18,9 @@ <testcase classname='C5G_Tests' name='TC_connection_inactive' time='MASKED'> <error type='DTE'></error> </testcase> + <testcase classname='C5G_Tests' name='TC_connection_suspend' time='MASKED'> + <failure type='fail-verdict'>"C5G_Tests.ttcn:MASKED : Tguard timeout" + C5G_Tests.ttcn:601 TC_connection_suspend testcase + </failure> + </testcase> </testsuite> diff --git a/library/ngap/NGAP_EncDec.cc b/library/ngap/NGAP_EncDec.cc index b81591d..8b825d5 100644 --- a/library/ngap/NGAP_EncDec.cc +++ b/library/ngap/NGAP_EncDec.cc @@ -109,4 +109,24 @@ return ret; } +OCTETSTRING enc__NGAP__UEContextSuspendRequestTransfer(const NGAP__IEs::UEContextSuspendRequestTransfer &p) +{ + TTCN_Buffer TTCN_buf; + TTCN_buf.clear(); + p.encode(NGAP__IEs::UEContextSuspendRequestTransfer_descr_, TTCN_buf, + TTCN_EncDec::CT_PER, PER_ALIGNED); + return OCTETSTRING(TTCN_buf.get_len(), TTCN_buf.get_data()); +} + +NGAP__IEs::UEContextSuspendRequestTransfer dec__NGAP__UEContextSuspendRequestTransfer(const OCTETSTRING &stream) +{ + NGAP__IEs::UEContextSuspendRequestTransfer ret; + TTCN_Buffer TTCN_buf; + TTCN_buf.clear(); + TTCN_buf.put_os(stream); + ret.decode(NGAP__IEs::UEContextSuspendRequestTransfer_descr_, TTCN_buf, + TTCN_EncDec::CT_PER, PER_ALIGNED); + return ret; +} + } diff --git a/library/ngap/NGAP_Types.ttcn b/library/ngap/NGAP_Types.ttcn index 96ccea9..d9523b4 100644 --- a/library/ngap/NGAP_Types.ttcn +++ b/library/ngap/NGAP_Types.ttcn @@ -17,4 +17,7 @@ external function enc_NGAP_PDUSessionResourceModifyResponseTransfer(NGAP_IEs.PDUSessionResourceModifyResponseTransfer p) return octetstring; external function dec_NGAP_PDUSessionResourceModifyResponseTransfer(in octetstring pdu) return NGAP_IEs.PDUSessionResourceModifyResponseTransfer; + + external function enc_NGAP_UEContextSuspendRequestTransfer(NGAP_IEs.UEContextSuspendRequestTransfer p) return octetstring; + external function dec_NGAP_UEContextSuspendRequestTransfer(in octetstring pdu) return NGAP_IEs.UEContextSuspendRequestTransfer; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42144?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6da2571518a9b50369fa8e0dd19e447137ea20c6 Gerrit-Change-Number: 42144 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in libosmo-netif[master]: twjit: add underrun extension feature
by falconia 18 Feb '26

18 Feb '26

Attention is currently required from: fixeria, pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/42141?usp=email ) Change subject: twjit: add underrun extension feature ...................................................................... Patch Set 2: (2 comments) File src/twjit.c: https://gerrit.osmocom.org/c/libosmo-netif/+/42141/comment/1019d477_d2aed98… : PS1, Line 554: twjit->stats.underruns++; > shouldn't "twjit->stats. […] In the new iteration of my patch, I added a comment explaining while this stats counter should not be incremented in this state. https://gerrit.osmocom.org/c/libosmo-netif/+/42141/comment/fc7dc15b_d96620f… : PS1, Line 630: static void handle_flowing_underrun(struct osmo_twjit *twjit) > Some ideas, no need to apply them if you don't want: […] I added an explanatory comment in the new iteration of my patch - is it good enough? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42141?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ibda74c0dbfb163f5d0e3fb13f593a6e2c6817673 Gerrit-Change-Number: 42141 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Feb 2026 16:45:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in libosmo-netif[master]: twjit: add underrun extension feature
by falconia 18 Feb '26

18 Feb '26

Attention is currently required from: falconia, fixeria, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/42141?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: twjit: add underrun extension feature ...................................................................... twjit: add underrun extension feature Themyscira Wireless RTP jitter buffer implementation (twjit) was originally designed for continuous streaming, as opposed to RTP streams with intentional gaps. However, intentional gaps in the case of DTX pauses or radio errors are called for by 3GPP AoIP specs and are the default mode for UL RTP Tx in OsmoBTS - therefore, this philosophical incompatibility between twjit and RTP intentional gaps is likely to be an obstacle to the desired replacement of Belledonne ortp with twrtp+twjit in OsmoBTS. The greatest practical effect of this philosophical mismatch occurs with RTP streams that apply intentional gaps for DTX: with standard twjit algorithm, isolated-island comfort noise update packets throughout each DTX pause will be dropped. Underrun extension is an optionally-enabled modification to twjit algorithm that solves the problem of isolated-island CN update packets during DTX pauses - i.e., delivers these packets to the application on the output side of twjit. As detailed in the included document update, this solution is not perfect in that these isolated CN update packets will be delivered only in steady flow state but not in new flow acquisition states - but it is the best solution this author can currently provide for the problem of RTP intentional gaps. Related: OS#6474 Change-Id: Ibda74c0dbfb163f5d0e3fb13f593a6e2c6817673 --- M doc/twrtp/twrtp-guide.t M include/osmocom/netif/twjit.h M include/osmocom/netif/twjit_private.h M src/twjit.c M src/twjit_conf.c 5 files changed, 293 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/41/42141/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42141?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ibda74c0dbfb163f5d0e3fb13f593a6e2c6817673 Gerrit-Change-Number: 42141 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log