- gerrit-log - lists.osmocom.org

[M] Change in osmocom-bb[master]: trx_toolkit/clck_gen: Don't use threads because Python GIL is latency...

by fixeria

Attention is currently required from: kirr. fixeria has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40047?usp=email ) Change subject: trx_toolkit/clck_gen: Don't use threads because Python GIL is latency killer ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > The build verification fails because of this error: […] https://docs.python.org/3/library/os.html#timer-file-descriptors tells that this API is added in 3.13, so this change requires a more recent Python version. In general, I am fine bumping the Python version requirement. On the other hand, this would make life harder for those running Debian bookworm, for instance... -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40047?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaa675c95059ec8ccfad667f69984d5a7f608c249 Gerrit-Change-Number: 40047 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Comment-Date: Thu, 17 Apr 2025 10:50:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

2 months, 3 weeks

1
0
0 0

[S] Change in osmocom-bb[master]: trx_toolkit/transceiver: Remove _tx_queue_lock

by fixeria

Attention is currently required from: kirr. fixeria has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40048?usp=email ) Change subject: trx_toolkit/transceiver: Remove _tx_queue_lock ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40048?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I77762564326b370479845a347fc512cb5f643bda Gerrit-Change-Number: 40048 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Comment-Date: Thu, 17 Apr 2025 10:35:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 3 weeks

1
0
0 0

[M] Change in osmocom-bb[master]: trx_toolkit/clck_gen: Don't use threads because Python GIL is latency...

by fixeria

Attention is currently required from: kirr. fixeria has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40047?usp=email ) Change subject: trx_toolkit/clck_gen: Don't use threads because Python GIL is latency killer ...................................................................... Patch Set 1: (1 comment) File src/target/trx_toolkit/clck_gen.py: https://gerrit.osmocom.org/c/osmocom-bb/+/40047/comment/c840305a_225b87a7?u… : PS1, Line 54: RR Scheduler priority of thread. None = don't set it. IMO, it would be cleaner to revert pespin's patches (https://gerrit.osmocom.org/q/I3c7f36c17fc7b9cae1023b4a0ed37f983dc286dc and https://gerrit.osmocom.org/q/I6aa22125e7de4f472d691b271639d5bee25762cb) before this one. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40047?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaa675c95059ec8ccfad667f69984d5a7f608c249 Gerrit-Change-Number: 40047 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Comment-Date: Thu, 17 Apr 2025 10:27:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 months, 3 weeks

1
0
0 0

[M] Change in osmocom-bb[master]: trx_toolkit/clck_gen: Don't use threads because Python GIL is latency...

by fixeria

Attention is currently required from: kirr. fixeria has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40047?usp=email ) Change subject: trx_toolkit/clck_gen: Don't use threads because Python GIL is latency killer ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: The build verification fails because of this error: > AttributeError: module 'os' has no attribute 'timerfd_create' Looks like this requires a more recent Python version? The build slaves should be running `debian:bookworm`, so at least Python 3.11.2. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40047?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaa675c95059ec8ccfad667f69984d5a7f608c249 Gerrit-Change-Number: 40047 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Comment-Date: Thu, 17 Apr 2025 10:22:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 months, 3 weeks

1
0
0 0

[S] Change in osmocom-bb[master]: trx_toolkit/udp_link: Factor code to describe remote into .desc_remot...

by fixeria

Attention is currently required from: kirr, laforge. fixeria has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40046?usp=email ) Change subject: trx_toolkit/udp_link: Factor code to describe remote into .desc_remote() function ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: > I would have turned it into a property - or, if we really print it a lot, compute+store the string o […] Acknowledged, but can be merged as-is and further improved later. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40046?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1e2fa560ada7a8de4c9b9150058c2a1c73874fbe Gerrit-Change-Number: 40046 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 17 Apr 2025 10:05:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

2 months, 3 weeks

1
0
0 0

[XS] Change in osmocom-bb[master]: trx_toolkit/*: Don't use `del x; x = None` idiom

by fixeria

Attention is currently required from: kirr. fixeria has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40045?usp=email ) Change subject: trx_toolkit/*: Don't use `del x; x = None` idiom ...................................................................... Patch Set 1: Code-Review+2 Verified+1 (1 comment) Patchset: PS1: We can ignore the linter here since it complains about existing code. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40045?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7a83bdd52fb9318bd8b975f85ce37c7144873f61 Gerrit-Change-Number: 40045 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Comment-Date: Thu, 17 Apr 2025 10:02:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

2 months, 3 weeks

1
0
0 0

[XS] Change in osmocom-bb[master]: trx_toolkit/transceiver: Use `msg is None` instead of `not msg`

by laforge

Attention is currently required from: kirr. laforge has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40090?usp=email ) Change subject: trx_toolkit/transceiver: Use `msg is None` instead of `not msg` ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40090?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1278bed0a83dfac13734467f5333fae30e19bd5a Gerrit-Change-Number: 40090 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Comment-Date: Thu, 17 Apr 2025 09:59:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 3 weeks

1
0
0 0

[S] Change in osmocom-bb[master]: trx_toolkit/udp_link: Factor code to describe remote into .desc_remot...

by laforge

Attention is currently required from: kirr. laforge has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40046?usp=email ) Change subject: trx_toolkit/udp_link: Factor code to describe remote into .desc_remote() function ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: I would have turned it into a property - or, if we really print it a lot, compute+store the string once and return that rather than format-printing it ecah time? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40046?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1e2fa560ada7a8de4c9b9150058c2a1c73874fbe Gerrit-Change-Number: 40046 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Comment-Date: Thu, 17 Apr 2025 09:55:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

2 months, 3 weeks

1
0
0 0

[XS] Change in osmocom-bb[master]: trx_toolkit/burst_fwd: Use 'is' instead of '==' when checking if trx ...

by fixeria

Attention is currently required from: kirr. fixeria has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40044?usp=email ) Change subject: trx_toolkit/burst_fwd: Use 'is' instead of '==' when checking if trx is src_trx ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40044?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic9e16720daeb348b5f9c535c24a682db53a93529 Gerrit-Change-Number: 40044 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Comment-Date: Thu, 17 Apr 2025 09:54:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 3 weeks

1
0
0 0

[XS] Change in osmocom-bb[master]: trx_toolkit/*: Don't use `del x; x = None` idiom

by laforge

Attention is currently required from: kirr. laforge has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40045?usp=email ) Change subject: trx_toolkit/*: Don't use `del x; x = None` idiom ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40045?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7a83bdd52fb9318bd8b975f85ce37c7144873f61 Gerrit-Change-Number: 40045 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Comment-Date: Thu, 17 Apr 2025 09:53:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log