Attention is currently required from: jolly, neels, nt2mku.
Hello Jenkins Builder, neels, nt2mku,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-msc/+/38197?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: Remove speech codec list from bearer_cap for phase 1 mobile station
......................................................................
Remove speech codec list from bearer_cap for phase 1 mobile station
According to TS 04.08 Clause 10.5.4.5.1, the octet 3a ect. shall not be
included, if only GSM full/half rate speech version 1 is supported.
As phase 1 mobile stations only support FR and HR speech, the speech
list in the bearer capability must be reduced to the codecs listed
above. If there is none of these codecs left, the call is rejected.
The octet 3a ect. must be omitted when encoding bearer capability for
phase 1 mobile stations. This is done by removing the speech list.
I do not use a "codec filter", because it is not required. The phase 1
mobile station can only respond with codecs it supports, so no filtering
is required.
Related: OS#6461
Change-Id: Idd267dad0ade18cee7d5be813a57e1ee3168e2db
---
M include/osmocom/msc/codec_mapping.h
M src/libmsc/codec_mapping.c
M src/libmsc/gsm_04_08_cc.c
3 files changed, 43 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/97/38197/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38197?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Idd267dad0ade18cee7d5be813a57e1ee3168e2db
Gerrit-Change-Number: 38197
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: nt2mku <degrunert.web(a)googlemail.com>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: nt2mku <degrunert.web(a)googlemail.com>
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/38253?usp=email )
Change subject: contrib/jenkins: add SKIP_CLEAN_WORKSPACE
......................................................................
contrib/jenkins: add SKIP_CLEAN_WORKSPACE
In order to run this script from pyosmocom's contrib/jenkins.sh script,
we want to skip the clean workspace step. Add an environment variable to
do that.
Related: OS#6570
Change-Id: Ic8dc9b85da17719195f7374d37eccb4dedba6ce8
---
M contrib/jenkins.sh
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/53/38253/1
diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 42bf5af..5fa5226 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -5,6 +5,7 @@
# * WITH_MANUALS: build manual PDFs if set to "1"
# * PUBLISH: upload manuals after building if set to "1" (ignored without WITH_MANUALS = "1")
# * JOB_TYPE: one of 'test', 'distcheck', 'pylint', 'docs'
+# * SKIP_CLEAN_WORKSPACE: don't run osmo-clean-workspace.sh (for pyosmocom CI)
#
export PYTHONUNBUFFERED=1
@@ -16,7 +17,9 @@
exit 1
fi
-osmo-clean-workspace.sh
+if [ -z "$SKIP_CLEAN_WORKSPACE" ]; then
+ osmo-clean-workspace.sh
+fi
case "$JOB_TYPE" in
"test")
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/38253?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic8dc9b85da17719195f7374d37eccb4dedba6ce8
Gerrit-Change-Number: 38253
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Attention is currently required from: dexter, laforge, pespin.
osmith has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38246?usp=email )
Change subject: Add debian packaging for pyosmocom
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS1:
> I'm not sure how to proceed with the build error. lib/config. […]
I forgot to push my osmith/wip branch at that point, then triggered it again (https://gerrit.osmocom.org/c/osmo-ci/+/38248)
--
To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38246?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: python/pyosmocom
Gerrit-Branch: master
Gerrit-Change-Id: If862c14c7802d1967d99c3939038b8eb7fe301f3
Gerrit-Change-Number: 38246
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 23 Sep 2024 07:30:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/38251?usp=email )
Change subject: manuals: publish pyosmocom manuals for releases
......................................................................
manuals: publish pyosmocom manuals for releases
Adjust the building and publishing commands to work for pyosmocom.
Remove the 0.0.3 release from TAGS_IGNORE, because it already has
manuals.
Skip "apt-get -y build-dep" and adjusting "debian/control" if that file
does not exist, as it is the case with the 0.0.3 and 0.0.4 releases of
pyosmocom.
Change-Id: I3799cf825937cdd8dfca9fbd98e8b6b159f7cea8
---
M scripts/manuals/publish-manuals-for-tags.sh
1 file changed, 13 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/51/38251/1
diff --git a/scripts/manuals/publish-manuals-for-tags.sh b/scripts/manuals/publish-manuals-for-tags.sh
index 690eafc..50b7a3b 100755
--- a/scripts/manuals/publish-manuals-for-tags.sh
+++ b/scripts/manuals/publish-manuals-for-tags.sh
@@ -203,7 +203,6 @@
pyosmocom:0.0.1,
pyosmocom:0.0.2,
- pyosmocom:0.0.3,
"
mkdir -p \
@@ -331,8 +330,10 @@
git clean -dxf
# Fix depends on packages that don't exist anymore
- sed -i 's/dh-systemd \(.*\),//g' debian/control
- sed -i 's/python-minimal,//g' debian/control
+ if [ -e debian/control ]; then
+ sed -i 's/dh-systemd \(.*\),//g' debian/control
+ sed -i 's/python-minimal,//g' debian/control
+ fi
}
# $1: repository
@@ -367,7 +368,9 @@
# Install dependencies
case $repo in
*)
- apt-get -y build-dep /build
+ if [ -e debian/control ]; then
+ apt-get -y build-dep /build
+ fi
;;
esac
@@ -386,6 +389,9 @@
osmo-epdg)
su build -c \"make -C docs/manuals\"
;;
+ pyosmocom)
+ su build -c \"make -C docs html latexpdf\"
+ ;;
*)
su build -c \"autoreconf -fi\"
su build -c \"./configure $configure_opts\"
@@ -404,6 +410,9 @@
osmo-epdg)
su build -c \"make -C docs/manuals publish\"
;;
+ pyosmocom)
+ su build -c \"make -C docs publish publish-html\"
+ ;;
*)
su build -c \"make -C doc/manuals publish\"
;;
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38251?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I3799cf825937cdd8dfca9fbd98e8b6b159f7cea8
Gerrit-Change-Number: 38251
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>