- gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: manuals: publish pyosmocom manuals for releases
by laforge 23 Sep '24

23 Sep '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/38251?usp=email ) Change subject: manuals: publish pyosmocom manuals for releases ...................................................................... manuals: publish pyosmocom manuals for releases Adjust the building and publishing commands to work for pyosmocom. Remove the 0.0.3 release from TAGS_IGNORE, because it already has manuals. Skip "apt-get -y build-dep" and adjusting "debian/control" if that file does not exist, as it is the case with the 0.0.3 and 0.0.4 releases of pyosmocom. Change-Id: I3799cf825937cdd8dfca9fbd98e8b6b159f7cea8 --- M scripts/manuals/publish-manuals-for-tags.sh 1 file changed, 13 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/scripts/manuals/publish-manuals-for-tags.sh b/scripts/manuals/publish-manuals-for-tags.sh index 690eafc..50b7a3b 100755 --- a/scripts/manuals/publish-manuals-for-tags.sh +++ b/scripts/manuals/publish-manuals-for-tags.sh @@ -203,7 +203,6 @@ pyosmocom:0.0.1, pyosmocom:0.0.2, - pyosmocom:0.0.3, " mkdir -p \ @@ -331,8 +330,10 @@ git clean -dxf # Fix depends on packages that don't exist anymore - sed -i 's/dh-systemd $.*$,//g' debian/control - sed -i 's/python-minimal,//g' debian/control + if [ -e debian/control ]; then + sed -i 's/dh-systemd $.*$,//g' debian/control + sed -i 's/python-minimal,//g' debian/control + fi } # $1: repository @@ -367,7 +368,9 @@ # Install dependencies case $repo in *) - apt-get -y build-dep /build + if [ -e debian/control ]; then + apt-get -y build-dep /build + fi ;; esac @@ -386,6 +389,9 @@ osmo-epdg) su build -c \"make -C docs/manuals\" ;; + pyosmocom) + su build -c \"make -C docs html latexpdf\" + ;; *) su build -c \"autoreconf -fi\" su build -c \"./configure $configure_opts\" @@ -404,6 +410,9 @@ osmo-epdg) su build -c \"make -C docs/manuals publish\" ;; + pyosmocom) + su build -c \"make -C docs publish publish-html\" + ;; *) su build -c \"make -C doc/manuals publish\" ;; -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38251?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3799cf825937cdd8dfca9fbd98e8b6b159f7cea8 Gerrit-Change-Number: 38251 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ci[master]: manuals: publish pyosmocom manuals for releases
by laforge 23 Sep '24

23 Sep '24

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38251?usp=email ) Change subject: manuals: publish pyosmocom manuals for releases ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38251?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3799cf825937cdd8dfca9fbd98e8b6b159f7cea8 Gerrit-Change-Number: 38251 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Sep 2024 09:42:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: Support replying errors
by laforge 23 Sep '24

23 Sep '24

Attention is currently required from: fixeria, lynxis lazus, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email ) Change subject: s1ap_proxy: Support replying errors ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Patchset: PS2: > Let's keep this patch in review until we have functional or at least unit tests. So what is the status here? Why do we have no unit nor functional/integration tests for this patch? Instead we had a lengthy debate about patch review priorities. I agree with @pespin that it's not acceptable to delay a patch for a month - but then I also agree with @fixeria that we should have at least some test coverage. Let's find a solution, please. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I242e84fb09b00f4794b6e1aa770f348a0e60aea4 Gerrit-Change-Number: 37924 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 23 Sep 2024 09:41:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-msc[master]: Remove speech codec list from bearer_cap for phase 1 mobile station
by laforge 23 Sep '24

23 Sep '24

Attention is currently required from: fixeria, jolly, neels, nt2mku, pespin. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/38197?usp=email ) Change subject: Remove speech codec list from bearer_cap for phase 1 mobile station ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38197?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Idd267dad0ade18cee7d5be813a57e1ee3168e2db Gerrit-Change-Number: 38197 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: nt2mku <degrunert.web(a)googlemail.com> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Sep 2024 09:39:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: gitignore: add files generated with jenkins.sh
by laforge 23 Sep '24

23 Sep '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/38252?usp=email ) Change subject: gitignore: add files generated with jenkins.sh ...................................................................... gitignore: add files generated with jenkins.sh Change-Id: Iaffe04a3dfebd46efc479dc3665fd67f2c95f375 --- M .gitignore 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/.gitignore b/.gitignore index 8401eb2..2eb3d89 100644 --- a/.gitignore +++ b/.gitignore @@ -3,3 +3,7 @@ /docs/_* /docs/generated +/.cache +/.local +/build +/pySim.egg-info -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38252?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iaffe04a3dfebd46efc479dc3665fd67f2c95f375 Gerrit-Change-Number: 38252 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: contrib/jenkins: add SKIP_CLEAN_WORKSPACE
by laforge 23 Sep '24

23 Sep '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/38253?usp=email ) Change subject: contrib/jenkins: add SKIP_CLEAN_WORKSPACE ...................................................................... contrib/jenkins: add SKIP_CLEAN_WORKSPACE In order to run this script from pyosmocom's contrib/jenkins.sh script, we want to skip the clean workspace step. Add an environment variable to do that. Related: OS#6570 Change-Id: Ic8dc9b85da17719195f7374d37eccb4dedba6ce8 --- M contrib/jenkins.sh 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 42bf5af..5fa5226 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -5,6 +5,7 @@ # * WITH_MANUALS: build manual PDFs if set to "1" # * PUBLISH: upload manuals after building if set to "1" (ignored without WITH_MANUALS = "1") # * JOB_TYPE: one of 'test', 'distcheck', 'pylint', 'docs' +# * SKIP_CLEAN_WORKSPACE: don't run osmo-clean-workspace.sh (for pyosmocom CI) # export PYTHONUNBUFFERED=1 @@ -16,7 +17,9 @@ exit 1 fi -osmo-clean-workspace.sh +if [ -z "$SKIP_CLEAN_WORKSPACE" ]; then + osmo-clean-workspace.sh +fi case "$JOB_TYPE" in "test") -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38253?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic8dc9b85da17719195f7374d37eccb4dedba6ce8 Gerrit-Change-Number: 38253 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: contrib/jenkins: add SKIP_CLEAN_WORKSPACE
by laforge 23 Sep '24

23 Sep '24

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/pysim/+/38253?usp=email ) Change subject: contrib/jenkins: add SKIP_CLEAN_WORKSPACE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38253?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic8dc9b85da17719195f7374d37eccb4dedba6ce8 Gerrit-Change-Number: 38253 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Sep 2024 09:38:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: gitignore: add files generated with jenkins.sh
by laforge 23 Sep '24

23 Sep '24

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/pysim/+/38252?usp=email ) Change subject: gitignore: add files generated with jenkins.sh ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38252?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iaffe04a3dfebd46efc479dc3665fd67f2c95f375 Gerrit-Change-Number: 38252 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Sep 2024 09:38:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in pysim[master]: tests: sanitize all cards before running tests
by dexter 23 Sep '24

23 Sep '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/38254?usp=email ) Change subject: tests: sanitize all cards before running tests ...................................................................... tests: sanitize all cards before running tests Even though our tests are written in a way that they shouldn't interfere with each other, it may happen that one testrun writes content to a file that upsets a different testrun. The resulting problems are often difficult to diagnose. To minimize the problem, let's reset the cards to a defined state before running the actual tests. This can be done using pySim-shell's export feature. We can generate a backup from a known good state and then play back the backup to reset files that have been changed. Files that didn't change will not be written thanks to the conserve_write feature of pySim-shell. Related: OS#4384 Change-Id: I42eaf61280968518164f2280245136fd30a603ce --- M contrib/jenkins.sh A tests/card_sanitizer/backup.script A tests/card_sanitizer/card_backup_3b991800118822334455667760_2222334455667788990.script A tests/card_sanitizer/card_backup_3b9a940092027593110001020221_1122334455667788990.script A tests/card_sanitizer/card_backup_3b9f95801fc78031e073f62113674d4516004301008f_89445310150011013678.script A tests/card_sanitizer/card_backup_3b9f96801f878031e073fe211b674a357530350265f8_8949440000001155314.script A tests/card_sanitizer/card_backup_3b9f96801f878031e073fe211b674a4c753034054ba9_8988211000000467343.script A tests/card_sanitizer/card_backup_3b9f96801fc78031a073be21136743200718000001a5_8988211320300000028.script A tests/card_sanitizer/card_backup_3b9f96801fc78031a073be21136744220610000001a9_8988219000000117833.script A tests/card_sanitizer/card_data.csv A tests/card_sanitizer/card_sanitizer.py A tests/card_sanitizer/restore.script 12 files changed, 18,152 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/54/38254/1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38254?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I42eaf61280968518164f2280245136fd30a603ce Gerrit-Change-Number: 38254 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: Support replying errors
by pespin 23 Sep '24

23 Sep '24

Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email ) Change subject: s1ap_proxy: Support replying errors ...................................................................... Patch Set 5: (1 comment) Patchset: PS4: > And yet another week passed with this commit blocked. One month after submission and my patch is still blocked in here. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I242e84fb09b00f4794b6e1aa770f348a0e60aea4 Gerrit-Change-Number: 37924 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 23 Sep 2024 09:27:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log