- gerrit-log - lists.osmocom.org

[XS] Change in ...pyosmocom[master]: gitreview: new file
by osmith 23 Sep '24

23 Sep '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38250?usp=email ) Change subject: gitreview: new file ...................................................................... gitreview: new file Change-Id: I8cff5c840bd8c0a858312f343f6d7262b582673c --- A .gitreview 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/python/pyosmocom refs/changes/50/38250/1 diff --git a/.gitreview b/.gitreview new file mode 100644 index 0000000..74d2692 --- /dev/null +++ b/.gitreview @@ -0,0 +1,3 @@ +[gerrit] +host=gerrit.osmocom.org +project=python/pyosmocom -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38250?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I8cff5c840bd8c0a858312f343f6d7262b582673c Gerrit-Change-Number: 38250 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in ...pyosmocom[master]: Add debian packaging for pyosmocom
by osmith 23 Sep '24

23 Sep '24

Attention is currently required from: dexter, laforge, pespin. osmith has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38246?usp=email ) Change subject: Add debian packaging for pyosmocom ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I've enabled building the debian:12 package in CI: remote: https://gerrit.osmocom.org/c/osmo-ci/+/38247 OBS: build_srcpkg.Dockerfile: add sphinx-common [NEW] remote: https://gerrit.osmocom.org/c/osmo-ci/+/38248 OBS: config: add python/pyosmocom [NEW] remote: https://gerrit.osmocom.org/c/osmo-ci/+/38249 jobs/gerrit-verfifications: pyosmocom: build debs [NEW] I'll retrigger it. -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38246?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: If862c14c7802d1967d99c3939038b8eb7fe301f3 Gerrit-Change-Number: 38246 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Sep 2024 06:08:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ci[master]: OBS: config: add python/pyosmocom
by osmith 23 Sep '24

23 Sep '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/38248?usp=email ) Change subject: OBS: config: add python/pyosmocom ...................................................................... OBS: config: add python/pyosmocom Prepare to build debian packages for pyosmocom. Change-Id: Ieaf033136186cb0f7c5fcba79d066f8dc863d4e2 --- M scripts/obs/lib/config.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/48/38248/1 diff --git a/scripts/obs/lib/config.py b/scripts/obs/lib/config.py index 746bb1c..c6f373e 100644 --- a/scripts/obs/lib/config.py +++ b/scripts/obs/lib/config.py @@ -90,6 +90,7 @@ "osmo-upf", "osmocom-bb", "python/osmo-python-tests", + "python/pyosmocom", "rtl-sdr", "simtrace2", "strongswan-epdg", -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38248?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ieaf033136186cb0f7c5fcba79d066f8dc863d4e2 Gerrit-Change-Number: 38248 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: OBS: build_srcpkg.Dockerfile: add sphinx-common
by osmith 23 Sep '24

23 Sep '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/38247?usp=email ) Change subject: OBS: build_srcpkg.Dockerfile: add sphinx-common ...................................................................... OBS: build_srcpkg.Dockerfile: add sphinx-common Install sphinx-common, as it is needed to build the source package for pyosmocom. Fix for: dh clean --with python3,sphinxdoc --buildsystem=pybuild dh: error: unable to load addon sphinxdoc: Can't locate Debian/Debhelper/Sequence/sphinxdoc.pm in @INC (you may need to install the Debian::Debhelper::Sequence::sphinxdoc module) (@INC contains: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.36.0 /usr/local/share/perl/5.36.0 /usr/lib/x86_64-linux-gnu/perl5/5.36 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.36 /usr/share/perl/5.36 /usr/local/lib/site_perl) at (eval 13) line 1. BEGIN failed--compilation aborted at (eval 13) line 1. Change-Id: I598f0b18c44522adc1a038df9dc4d05c7f39e4b1 --- M scripts/obs/data/build_srcpkg.Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/47/38247/1 diff --git a/scripts/obs/data/build_srcpkg.Dockerfile b/scripts/obs/data/build_srcpkg.Dockerfile index 80488ea..4822450 100644 --- a/scripts/obs/data/build_srcpkg.Dockerfile +++ b/scripts/obs/data/build_srcpkg.Dockerfile @@ -24,6 +24,7 @@ quilt \ rebar3 \ sed \ + sphinx-common \ && \ apt-get clean -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38247?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I598f0b18c44522adc1a038df9dc4d05c7f39e4b1 Gerrit-Change-Number: 38247 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: jobs/gerrit-verfifications: pyosmocom: build debs
by osmith 23 Sep '24

23 Sep '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/38249?usp=email ) Change subject: jobs/gerrit-verfifications: pyosmocom: build debs ...................................................................... jobs/gerrit-verfifications: pyosmocom: build debs Related: pyosmocom If862c14c7802d1967d99c3939038b8eb7fe301f3 Change-Id: I3b7a53cd7a7ca2fc7d00aa0773ff0954818f8125 --- M jobs/gerrit-verifications.yml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/49/38249/1 diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 65d6a58..0e05918 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -307,7 +307,7 @@ - pyosmocom: repos_url: '{gerrit_url}/python/{repos}' gerrit_project: 'python/{repos}' - pipeline_binpkgs: "" + pipeline_binpkgs: "debian:12" a1_name: JOB_TYPE a1: !!python/tuple ["test", "pylint", "docs"] cmd: | -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38249?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3b7a53cd7a7ca2fc7d00aa0773ff0954818f8125 Gerrit-Change-Number: 38249 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in ...pyosmocom[master]: Add debian packaging for pyosmocom
by osmith 23 Sep '24

23 Sep '24

Attention is currently required from: dexter, laforge, pespin. osmith has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38246?usp=email ) Change subject: Add debian packaging for pyosmocom ...................................................................... Patch Set 1: (2 comments) File debian/control: https://gerrit.osmocom.org/c/python/pyosmocom/+/38246/comment/b31a175c_aecd… : PS1, Line 6: pybuild-plugin-pyproject, note that pybuild-plugin-pyproject is only available in debian >= 12 (which is fine with me, but mentioning just in case you want to make it available for older debian releases too) https://gerrit.osmocom.org/c/python/pyosmocom/+/38246/comment/85b964bc_9799… : PS1, Line 7: python3-sphinx * missing python3-sphinx-argparse * maybe put one dep in one line, to make this more diff friendly? -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38246?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: If862c14c7802d1967d99c3939038b8eb7fe301f3 Gerrit-Change-Number: 38246 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Sep 2024 06:02:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in osmo-ttcn3-hacks[master]: library/PFCP_Emulation: a better PDU routing concept
by laforge 22 Sep '24

22 Sep '24

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38207?usp=email ) Change subject: library/PFCP_Emulation: a better PDU routing concept ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File hnbgw/HNBGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38207/comment/759c2167_f3b4… : PS2, Line 1967: f_PFCPEM_subscribe_seid(c_SEID0); > > In this specific case the problem can be solved a lot simpler, simply by swapping these two functi […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38207?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I25802471519fa297ad4cb2b056adaa6748b00af2 Gerrit-Change-Number: 38207 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 22 Sep 2024 06:59:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in osmo-ttcn3-hacks[master]: library/PFCP_Emulation: a better PDU routing concept
by fixeria 21 Sep '24

21 Sep '24

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38207?usp=email ) Change subject: library/PFCP_Emulation: a better PDU routing concept ...................................................................... Patch Set 4: (1 comment) File hnbgw/HNBGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38207/comment/0f283fed_3698… : PS3, Line 1983: f_PFCPEM_unsubscribe_seid(c_SEID0); > You have the same problem here. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38207?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I25802471519fa297ad4cb2b056adaa6748b00af2 Gerrit-Change-Number: 38207 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 21 Sep 2024 15:09:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: library: as_pfcp_ignore(): log SeqNr of received PDUs
by fixeria 21 Sep '24

21 Sep '24

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38208?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: library: as_pfcp_ignore(): log SeqNr of received PDUs ...................................................................... library: as_pfcp_ignore(): log SeqNr of received PDUs Printing the PFCP PDU template ('?' by default) is not very informative when reading logs. Printing the message type of the received PDU is not informative either, because message types are defined as numbers in PFCP_Types.ttcn. Printing the whole PDU is way too verbose, and would be redundant given that the PFCPEM component already does print all received PDUs. Let's print the sequence number. Change-Id: I803ff46def4ae0182310bc01e753fe0c05112836 --- M library/PFCP_Emulation.ttcn 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/08/38208/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38208?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I803ff46def4ae0182310bc01e753fe0c05112836 Gerrit-Change-Number: 38208 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in osmo-ttcn3-hacks[master]: library/PFCP_Emulation: a better PDU routing concept
by fixeria 21 Sep '24

21 Sep '24

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38207?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: library/PFCP_Emulation: a better PDU routing concept ...................................................................... library/PFCP_Emulation: a better PDU routing concept In recently merged 2962d170 I wrongly assumed, that SEID of outgoing PFCP PDUs can be used to correlate and route the incoming PDUs. In fact, the PFCP peers use two different SEID values, negotiating them using the F-SEID IE. We could have implemented a logic to look for F-SEID in the outgoing PDUs, store and then use it for routing. However, a more flexible approach is to allow the the PFCP_ConnHdlr components to subscribe and unsubscribe to/from specific SEID values explicitly. In this spirit, let's allow the PFCP_ConnHdlr components to subscribe and unsubscribe to/from broadcast PDUs (i.e. those, for which the PFCPEM component could not find a single recipient) explicitly. Implicit routing using the SeqNr remains unchanged and will be performed by the PFCPEM component automatically like before. Change-Id: I25802471519fa297ad4cb2b056adaa6748b00af2 Related: 2962d170 "library/PFCP_Emulation: fix routing of incoming PDUs" --- M hnbgw/HNBGW_Tests.ttcn M library/PFCP_Emulation.ttcn M s1gw/S1GW_ConnHdlr.ttcn 3 files changed, 215 insertions(+), 38 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/07/38207/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38207?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I25802471519fa297ad4cb2b056adaa6748b00af2 Gerrit-Change-Number: 38207 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log