- gerrit-log - lists.osmocom.org

[XS] Change in ...osmo-s1gw[master]: s1ap_proxy: clarify a logging statement, reduce verbosity
by pespin 26 Sep '24

26 Sep '24

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38294?usp=email ) Change subject: s1ap_proxy: clarify a logging statement, reduce verbosity ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38294?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I325758c7fb632dc67d0d9cf1f2e58ca337e7a744 Gerrit-Change-Number: 38294 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Sep 2024 13:47:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmo-abis[master]: libosmotrau: implement RAA' decoder function
by pespin 26 Sep '24

26 Sep '24

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38293?usp=email ) Change subject: libosmotrau: implement RAA' decoder function ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38293?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I1347a25ce97d5022502ee9112caded66315b09a4 Gerrit-Change-Number: 38293 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Thu, 26 Sep 2024 13:46:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmo-abis[master]: libosmotrau: implement RAA' encoder function
by pespin 26 Sep '24

26 Sep '24

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38292?usp=email ) Change subject: libosmotrau: implement RAA' encoder function ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38292?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I11fc1529f5be88fa778c7e05cb11eef58a389d40 Gerrit-Change-Number: 38292 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Thu, 26 Sep 2024 13:46:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-abis[master]: trau_rtp_conv: use new RA2 functions for CSD
by pespin 26 Sep '24

26 Sep '24

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38291?usp=email ) Change subject: trau_rtp_conv: use new RA2 functions for CSD ...................................................................... Patch Set 1: (1 comment) File src/trau/trau_rtp_conv.c: https://gerrit.osmocom.org/c/libosmo-abis/+/38291/comment/666271d5_c1cd14d3… : PS1, Line 1099: osmo_csd_ra2_8k_pack(out, ra_bits, 80); I think it may be useful leaving the comment explaining the mangling (the one you are removing in this patch here, also in line 1114). -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38291?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ia157989579ced866b1e7abfc789d69ae489224e9 Gerrit-Change-Number: 38291 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Thu, 26 Sep 2024 13:42:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in libosmo-abis[master]: libosmotrau: add CSD RA2 functions
by pespin 26 Sep '24

26 Sep '24

Attention is currently required from: dexter, falconia, fixeria, laforge. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38290?usp=email ) Change subject: libosmotrau: add CSD RA2 functions ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38290?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I7b98b958651b3fc1a814d119d1b8644c91f98676 Gerrit-Change-Number: 38290 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Sep 2024 13:40:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: library/s1ap: comment out optional IE in tr_S1AP_InitialCtxSetupResp
by fixeria 26 Sep '24

26 Sep '24

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38277?usp=email ) Change subject: library/s1ap: comment out optional IE in tr_S1AP_InitialCtxSetupResp ...................................................................... Patch Set 1: (2 comments) File library/s1ap/S1AP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38277/comment/cfb40d6a_e52d… : PS1, Line 734: /*, { > what's wrong with sending this? You are not explaining why. Why was it already commented out here? I think because it's an **optional** IE that requires at least one E-RAB item (i.e. cannot be empty). There needs to be a logic (likely a function) that would be adding this IE conditionally based on the template parameter `rab_failed_items`. For instance, we want to exclude this `protocolIEs` item completely if `istemplatekind(rab_failed_items, "omit")`. > Furthermore, I'd expect we want to test this case in ttcn3. Yes, I would like to add such testcase (if the time permits). But for a normal scenario when eNB reports all E-RABs as set up, this IE shall not be present in the list. This is why I am commenting it out below in `tr_S1AP_InitialCtxSetupResp`. For that special scenario with not all E-RABs being set up we can: * go for adding the additional `f_gen_protocolIEs()` logic, * easy to implement for `?` or `omit` * gets really complex for `*` * add another pair of templates extending `{ts,tr}_S1AP_InitialCtxSetupResp` * not if that would work for a list of `protocolIEs` though * add optional IEs conditionally in the testcase itself https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38277/comment/cdd7908c_be3f… : PS1, Line 755: protocolIEs := { > then please use superset() here. `superset()` removes the need to put the `*` at the end (which was there before my patches). It does not solve the problem of having optional IEs in a template though. I am fine with migrating to `superset()` in a separate patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38277?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4765036be69ff10adb8c510d4092834c4e923229 Gerrit-Change-Number: 38277 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Sep 2024 11:55:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in pysim[master]: cosmetic: use **kwargs instead of **_kwargs
by dexter 26 Sep '24

26 Sep '24

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38300?usp=email ) Change subject: cosmetic: use **kwargs instead of **_kwargs ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I think this is more a question of coding convention. In all those files **kwargs is not used. I guess the underscore is inherited from erlang where unused parameters must be prefixed with an underscore, otherwise the compiler would reject the code. In python there is no such limitation and a quick search for **_kwargs also didn't reveal any info if this is a common convention or not. I would suggest to remove the underscore prefix. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38300?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I98857cc774185e55a604eb4fbfbf62ed4bd6ded7 Gerrit-Change-Number: 38300 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 26 Sep 2024 09:43:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in pysim[master]: cosmetic: use **kwargs instead of **_kwargs
by dexter 26 Sep '24

26 Sep '24

dexter has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/pysim/+/38300?usp=email ) Change subject: cosmetic: use **kwargs instead of **_kwargs ...................................................................... cosmetic: use **kwargs instead of **_kwargs Some methods sometimes have a **_kwargs parameter, let's be consistent and use **kwargs only. Related: OS#5714 Change-Id: I98857cc774185e55a604eb4fbfbf62ed4bd6ded7 --- M pySim/ts_102_221.py M pySim/ts_31_102.py 2 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/00/38300/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38300?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I98857cc774185e55a604eb4fbfbf62ed4bd6ded7 Gerrit-Change-Number: 38300 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-CC: Jenkins Builder

1 0

[M] Change in pysim[master]: filesystem: pass total_len to construct of when encoding file contents
by dexter 26 Sep '24

26 Sep '24

Attention is currently required from: laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/38195?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: filesystem: pass total_len to construct of when encoding file contents ...................................................................... filesystem: pass total_len to construct of when encoding file contents In our construct models we frequently use a context parameter "total_len", we also pass this parameter to construct when we decode files, but we do not pass it when we generate files. This is a problem, because when total_len is used in the construct model, this parameter must be known also when decoding the file. Let's make sure that the total_len is properly determined and and passed to construct (via pyosmocom) Related: OS#5714 Change-Id: I1b7a51594fbc5d9fe01132c39354a2fa88d53f9b --- M pySim/filesystem.py M pySim/gsm_r.py M pySim/runtime.py M pySim/sysmocom_sja2.py M pySim/ts_31_102.py M pySim/ts_31_102_telecom.py M pySim/ts_51_011.py M tests/pySim-shell_test/file_content/test_record_uicc.ok 8 files changed, 100 insertions(+), 41 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/95/38195/6 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38195?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1b7a51594fbc5d9fe01132c39354a2fa88d53f9b Gerrit-Change-Number: 38195 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[M] Change in pysim[master]: filesystem: pass total_len to construct of when encoding file contents
by dexter 26 Sep '24

26 Sep '24

Attention is currently required from: laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38195?usp=email ) Change subject: filesystem: pass total_len to construct of when encoding file contents ...................................................................... Patch Set 6: (4 comments) File pySim/filesystem.py: https://gerrit.osmocom.org/c/pysim/+/38195/comment/50437558_f503ed26?usp=em… : PS2, Line 1338: def _decode_bin(self, raw_bin_data: bytearray): : chunks = [raw_bin_data[i:i+self.rec_len] : for i in range(0, len(raw_bin_data), self.rec_len)] : return [self.decode_record_bin(x) for x in chunks] : : def _encode_bin(self, abstract_data) -> bytes: : chunks = [self.encode_record_bin(x) for x in abstract_data] : # FIXME: pad to file size : return b''.join(chunks) > There's nothing wrong with anticipating future extensions and passing through `**kwargs`. […] Acknowledged File pySim/filesystem.py: https://gerrit.osmocom.org/c/pysim/+/38195/comment/9c11083f_e8b068e2?usp=em… : PS5, Line 746: __get_size > so this function now actually doesn't return the size, but it returns a dict with a single element […] Yes, that's really odd. I thought it would simplify things a bit when we were using it only with build_construct(), but now we use it in other places too. I have changed it now. https://gerrit.osmocom.org/c/pysim/+/38195/comment/5cec70e2_a0facbdf?usp=em… : PS5, Line 1343: def _encode_bin(self, abstract_data, total_len: int = None, **kwargs) -> bytes: > this also doesn't really match the code above. […] Done File pySim/gsm_r.py: https://gerrit.osmocom.org/c/pysim/+/38195/comment/92766fc6_cf8b1b28?usp=em… : PS5, Line 293: def _encode_record_bin(self, abstract_data : dict, record_nr : int, **kwargs) -> bytearray: > _encode_record_bin now just has **kwargs, while the _encode_bin has a dedicated total_len argument. […] I think we should use **kwargs to transfer total_len. In most cases total_len is not needed at all, so I think **kwargs is the better option here. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38195?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1b7a51594fbc5d9fe01132c39354a2fa88d53f9b Gerrit-Change-Number: 38195 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 26 Sep 2024 09:37:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log