- gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: csd_v110: properly set bit E2 for TCH/F4.8 NT
by falconia 26 Sep '24

26 Sep '24

Attention is currently required from: fixeria. falconia has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/38301?usp=email ) Change subject: csd_v110: properly set bit E2 for TCH/F4.8 NT ...................................................................... Patch Set 3: Code-Review-2 (1 comment) Patchset: PS3: Unfortunately this approach cannot work because bit E7 simply does not exist in NT mode: that bit position gets replaced by one of D-prime bits belonging to the RLP frame. You reference TS 44.021 Figure 1 - but that figure is part of section 10.2.1.1, and that entire part of the spec (all of chapter 10) is applicable only to transparent services. NT services are covered by chapter 12 of this spec instead, plus chapter 15 of TS 48.020 that is more relevant. The only correct solution is to extend the internal API to `csd_v110_rtp_encode()` and pass a flag that indicates alignment with TDMA multiframe structure. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38301?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If8307a9ce0fdc6da45157149ccef7b840ff9d9b3 Gerrit-Change-Number: 38301 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Sep 2024 21:05:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-bts[master]: tests/csd: add NT variants for TCH/F4.8 and TCH/F9.6
by fixeria 26 Sep '24

26 Sep '24

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/38302?usp=email ) Change subject: tests/csd: add NT variants for TCH/F4.8 and TCH/F9.6 ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/38302/comment/d528e94b_eaab6996?usp… : PS1, Line 9: The existing tests were are for T (transparent mode). > were are Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38302?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie335bc0623dd7e887a0b3b1c40d61153b84924b2 Gerrit-Change-Number: 38302 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Sep 2024 19:54:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-bts[master]: tests/csd: add NT variants for TCH/F4.8 and TCH/F9.6
by fixeria 26 Sep '24

26 Sep '24

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/38302?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin Change subject: tests/csd: add NT variants for TCH/F4.8 and TCH/F9.6 ...................................................................... tests/csd: add NT variants for TCH/F4.8 and TCH/F9.6 The existing tests are all for T (transparent mode). Add NT (non-transparent mode) variants. Change-Id: Ie335bc0623dd7e887a0b3b1c40d61153b84924b2 Related: OS#1572 --- M tests/csd/csd_test.c M tests/csd/csd_test.err 2 files changed, 62 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/02/38302/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38302?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie335bc0623dd7e887a0b3b1c40d61153b84924b2 Gerrit-Change-Number: 38302 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: csd_v110: properly set bit E2 for TCH/F4.8 NT
by pespin 26 Sep '24

26 Sep '24

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/38301?usp=email ) Change subject: csd_v110: properly set bit E2 for TCH/F4.8 NT ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File src/common/csd_v110.c: https://gerrit.osmocom.org/c/osmo-bts/+/38301/comment/5121552c_66f0cf96?usp… : PS1, Line 113: if ((i & 1) == 0) { /* executed for Q1/Q3 */ > I prefer using hex-notation when dealing with values sent/received over the wire/radio. […] Done https://gerrit.osmocom.org/c/osmo-bts/+/38301/comment/47530bdc_c42a0a50?usp… : PS1, Line 125: * Q4 | =1 | =1 > Yes, we do not execute this code for `i == 3` (i.e. […] Ah I didn't see it was a loop, fine then. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38301?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If8307a9ce0fdc6da45157149ccef7b840ff9d9b3 Gerrit-Change-Number: 38301 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Sep 2024 19:50:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: csd_v110: properly set bit E2 for TCH/F4.8 NT
by fixeria 26 Sep '24

26 Sep '24

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/38301?usp=email ) Change subject: csd_v110: properly set bit E2 for TCH/F4.8 NT ...................................................................... Patch Set 2: (2 comments) File src/common/csd_v110.c: https://gerrit.osmocom.org/c/osmo-bts/+/38301/comment/a1c1e802_cb2ca365?usp… : PS1, Line 113: if ((i & 1) == 0) { /* executed for Q1/Q3 */ > we usually use hex notation to do bitmask. […] I prefer using hex-notation when dealing with values sent/received over the wire/radio. Here I am just checking for odd values, does `0x0` prefix really improve readability? A quick grep across all osmo-projects shows we're doing `i & 1` in many places... https://gerrit.osmocom.org/c/osmo-bts/+/38301/comment/538b90cd_298770f6?usp… : PS1, Line 125: * Q4 | =1 | =1 Yes, we do not execute this code for `i == 3` (i.e. block Q4) and use the value that was set during the previous iteration (i.e. block Q3), which should be 1 according to the table above. > so you use "e2_bit = 0" at the start of the function ... I am just setting it to a random value (0 looks sane) to make gcc happy and not complain about using uninitialized values (even despite it's not possible here). We have seen this in some cases when it's logically impossible, but gcc is not smart/careful enough... -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38301?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If8307a9ce0fdc6da45157149ccef7b840ff9d9b3 Gerrit-Change-Number: 38301 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Sep 2024 19:44:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-bts[master]: tests/csd: add NT variants for TCH/F4.8 and TCH/F9.6
by pespin 26 Sep '24

26 Sep '24

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/38302?usp=email ) Change subject: tests/csd: add NT variants for TCH/F4.8 and TCH/F9.6 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/38302/comment/1e8ffa2d_6d9f5c6b?usp… : PS1, Line 9: The existing tests were are for T (transparent mode). were are -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38302?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie335bc0623dd7e887a0b3b1c40d61153b84924b2 Gerrit-Change-Number: 38302 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Sep 2024 19:40:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bts[master]: [WIP] csd_v110: align TCH/F4.8 NT with DL radio blocks
by fixeria 26 Sep '24

26 Sep '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/38303?usp=email ) Change subject: [WIP] csd_v110: align TCH/F4.8 NT with DL radio blocks ...................................................................... [WIP] csd_v110: align TCH/F4.8 NT with DL radio blocks Change-Id: Iea4a21ab9d333bbf416a0997971b1ba25784f238 Related: OS#1572 --- M src/common/csd_v110.c 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/03/38303/1 diff --git a/src/common/csd_v110.c b/src/common/csd_v110.c index 5fb86b7..aed1715 100644 --- a/src/common/csd_v110.c +++ b/src/common/csd_v110.c @@ -199,6 +199,16 @@ osmo_csd_12k_6k_encode_frame(&data[i * 60], 60, &df); else /* desc->num_bits == 36 */ osmo_csd_3k6_encode_frame(&data[i * 36], 36, &df); + + if (lchan->csd_mode == LCHAN_CSD_M_NT) { + if ((i & 1) == 0) { /* executed for Q1/Q3 */ + /* E7: 0 for Q1, 1 for Q2/Q3/Q4 (3GPP TS 44.021, Figure 1) + * E2: 0 for Q1/Q2, 1 for Q3/Q4 (3GPP TS 48.020, Table 7) */ + if (OSMO_UNLIKELY(df.e_bits[1] != df.e_bits[6])) + return -EINVAL; /* drop unaligned blocks */ + /* TODO: (for TCH/F4.8) store and send this block later? */ + } + } } return desc->num_blocks * desc->num_bits; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38303?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iea4a21ab9d333bbf416a0997971b1ba25784f238 Gerrit-Change-Number: 38303 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-bts[master]: tests/csd: add NT variants for TCH/F4.8 and TCH/F9.6
by fixeria 26 Sep '24

26 Sep '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/38302?usp=email ) Change subject: tests/csd: add NT variants for TCH/F4.8 and TCH/F9.6 ...................................................................... tests/csd: add NT variants for TCH/F4.8 and TCH/F9.6 The existing tests were are for T (transparent mode). Add NT (non-transparent mode) variants. Change-Id: Ie335bc0623dd7e887a0b3b1c40d61153b84924b2 Related: OS#1572 --- M tests/csd/csd_test.c M tests/csd/csd_test.err 2 files changed, 62 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/02/38302/1 diff --git a/tests/csd/csd_test.c b/tests/csd/csd_test.c index 13a6419..0ad611f 100644 --- a/tests/csd/csd_test.c +++ b/tests/csd/csd_test.c @@ -54,12 +54,24 @@ .csd_mode = LCHAN_CSD_M_T_9600, }, { + .name = "TCH/F9.6 NT", + .lchan_type = GSM_LCHAN_TCH_F, + .tch_mode = GSM48_CMODE_DATA_12k0, + .csd_mode = LCHAN_CSD_M_NT, + }, + { .name = "TCH/F4.8", .lchan_type = GSM_LCHAN_TCH_F, .tch_mode = GSM48_CMODE_DATA_6k0, .csd_mode = LCHAN_CSD_M_T_4800, }, { + .name = "TCH/F4.8 NT", + .lchan_type = GSM_LCHAN_TCH_F, + .tch_mode = GSM48_CMODE_DATA_6k0, + .csd_mode = LCHAN_CSD_M_NT, + }, + { .name = "TCH/H4.8", .lchan_type = GSM_LCHAN_TCH_H, .tch_mode = GSM48_CMODE_DATA_6k0, diff --git a/tests/csd/csd_test.err b/tests/csd/csd_test.err index b862324..cf19aff 100644 --- a/tests/csd/csd_test.err +++ b/tests/csd/csd_test.err @@ -24,6 +24,31 @@ ff ff ff ff ff ff ff ff 3f 3f 3f 3f ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff +[i] Testing 'TCH/F9.6 NT' (bitnum=240) +[i] csd_v110_rtp_encode() returns 160 + 3f 3f 3f 3f bf bf bf bf ff 7f 7f 7f bf bf bf bf + ff 7f 7f 7f bf 3f 7f 7f bf bf bf bf ff 7f 7f 7f + bf bf bf bf ff 7f 7f 7f 3f 3f 3f 3f bf bf bf bf + ff 7f 7f 7f bf bf bf bf ff 7f 7f 7f bf 7f 7f 7f + bf bf bf bf ff 7f 7f 7f bf bf bf bf ff 7f 7f 7f + 3f 3f 3f 3f bf bf bf bf ff 7f 7f 7f bf bf bf bf + ff 7f 7f 7f bf bf 7f 7f bf bf bf bf ff 7f 7f 7f + bf bf bf bf ff 7f 7f 7f 3f 3f 3f 3f bf bf bf bf + ff 7f 7f 7f bf bf bf bf ff 7f 7f 7f bf ff 7f 7f + bf bf bf bf ff 7f 7f 7f bf bf bf bf ff 7f 7f 7f +[i] csd_v110_rtp_decode() returns 240 +[i] Testing 'TCH/F9.6 NT' (IDLE) +[i] csd_v110_rtp_encode() returns 160 + 3f 3f 3f 3f ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff 3f 3f 3f 3f ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + 3f 3f 3f 3f ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff 3f 3f 3f 3f ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff [i] Testing 'TCH/F4.8' (bitnum=120) [i] csd_v110_rtp_encode() returns 160 7f 7f 7f 7f 7f 7f 7f 7f ff 7f ff 7f ff 7f ff 7f @@ -49,6 +74,31 @@ ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff +[i] Testing 'TCH/F4.8 NT' (bitnum=120) +[i] csd_v110_rtp_encode() returns 160 + 7f 7f 7f 7f 7f 7f 7f 7f ff 7f ff 7f ff 7f ff 7f + ff ff 7f ff 7f ff 7f ff ff 7f ff 7f ff 7f ff 7f + ff ff 7f ff 7f ff 7f ff ff 7f 7f 7f 7f ff 7f ff + ff 7f ff 7f ff 7f ff 7f ff ff 7f ff 7f ff 7f ff + ff 7f ff 7f ff 7f ff 7f ff ff 7f ff 7f ff 7f ff + 7f 7f 7f 7f 7f 7f 7f 7f ff 7f ff 7f ff 7f ff 7f + ff ff 7f ff 7f ff 7f ff ff 7f ff 7f ff 7f ff 7f + ff ff 7f ff 7f ff 7f ff ff 7f 7f ff 7f ff 7f ff + ff 7f ff 7f ff 7f ff 7f ff ff 7f ff 7f ff 7f ff + ff 7f ff 7f ff 7f ff 7f ff ff 7f ff 7f ff 7f ff +[i] csd_v110_rtp_decode() returns 120 +[i] Testing 'TCH/F4.8 NT' (IDLE) +[i] csd_v110_rtp_encode() returns 160 + 7f 7f 7f 7f 7f 7f 7f 7f ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + 7f 7f 7f 7f 7f 7f 7f 7f ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff [i] Testing 'TCH/H4.8' (bitnum=240) [i] csd_v110_rtp_encode() returns 160 3f 3f 3f 3f bf bf bf bf ff 7f 7f 7f bf bf bf bf -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38302?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie335bc0623dd7e887a0b3b1c40d61153b84924b2 Gerrit-Change-Number: 38302 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: csd_v110: properly set bit E2 for TCH/F4.8 NT
by fixeria 26 Sep '24

26 Sep '24

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/38301?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: csd_v110: properly set bit E2 for TCH/F4.8 NT ...................................................................... csd_v110: properly set bit E2 for TCH/F4.8 NT As was reported by Mychaela Falconia in: https://www.freecalypso.org/pipermail/community/2024-September/000941.html contrary to 3GPP TS 48.020 Table 7, bit E2 is currently always 0 in the RTP output for TCH/F4.8 channels in non-transparent CSD mode. The problem is that `desc->num_blocks` is 2 for TCH/F4.8 NT, so the for-loop in csd_v110_rtp_encode() will iterate only 2 (not 4) times, and thus `(i >> 1) & 0x01` never evaluates to 1 in this mode. According to 3GPP TS 44.021, Figure 1, bit E7 is set to 0 in every 4-th frame (Q1), so use it to calculate the value of bit E2 properly. Change-Id: If8307a9ce0fdc6da45157149ccef7b840ff9d9b3 Fixes: 183c08886 "csd_v110: properly set E1/E2/E3 for non-transparent data" Related: OS#1572 --- M src/common/csd_v110.c M tests/csd/csd_test.err 2 files changed, 22 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/01/38301/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38301?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If8307a9ce0fdc6da45157149ccef7b840ff9d9b3 Gerrit-Change-Number: 38301 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: csd_v110: properly set bit E2 for TCH/F4.8 NT
by pespin 26 Sep '24

26 Sep '24

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/38301?usp=email ) Change subject: csd_v110: properly set bit E2 for TCH/F4.8 NT ...................................................................... Patch Set 1: (2 comments) File src/common/csd_v110.c: https://gerrit.osmocom.org/c/osmo-bts/+/38301/comment/fa9aeeda_589d3438?usp… : PS1, Line 113: if ((i & 1) == 0) { /* executed for Q1/Q3 */ we usually use hex notation to do bitmask. (i & 0x01) == 0x00 https://gerrit.osmocom.org/c/osmo-bts/+/38301/comment/4b6b2e6b_3f9c79cd?usp… : PS1, Line 125: * Q4 | =1 | =1 for i=3 (0x03, 0b00000011), AFAIU you don't enter here, so you use "e2_bit = 0" at the start of the function which seems to not match Q4 in the table above? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38301?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If8307a9ce0fdc6da45157149ccef7b840ff9d9b3 Gerrit-Change-Number: 38301 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Sep 2024 19:11:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log