- gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: jobs/registry-rebuild-upload-android: new job
by osmith 19 Nov '24

19 Nov '24

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38800?usp=email ) Change subject: jobs/registry-rebuild-upload-android: new job ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38800?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia71bf8df638b9c4359d8b1a723795029541e023a Gerrit-Change-Number: 38800 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 19 Nov 2024 07:11:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in docker-playground[master]: debian-bookworm-android: new container
by osmith 19 Nov '24

19 Nov '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/38799?usp=email ) Change subject: debian-bookworm-android: new container ...................................................................... debian-bookworm-android: new container Add a container for building android-apdu-proxy and possibly more android projects in the future. Related: OS#6367 Change-Id: Ic7a454be23072c3f0ed609d370fc88f49205b04c --- A debian-bookworm-android/Dockerfile A debian-bookworm-android/Makefile 2 files changed, 27 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/debian-bookworm-android/Dockerfile b/debian-bookworm-android/Dockerfile new file mode 100644 index 0000000..da3154f --- /dev/null +++ b/debian-bookworm-android/Dockerfile @@ -0,0 +1,24 @@ +# Image for building Android apps (android-apdu-proxy) +ARG REGISTRY=docker.io +ARG UPSTREAM_DISTRO=debian:bookworm +FROM ${REGISTRY}/${UPSTREAM_DISTRO} + +# Arguments used after FROM must be specified again +ARG UID + +RUN useradd --uid=${UID} -d /build -m build + +RUN set -x && \ + apt-get update && \ + apt-get install -y --no-install-recommends \ + android-sdk \ + sdkmanager \ + && \ + apt-get clean + +ENV ANDROID_HOME=/usr/lib/android-sdk/ + +RUN set -x && \ + sdkmanager 'platforms;android-34' && \ + sdkmanager 'build-tools;34.0.0' && \ + yes | sdkmanager --licenses diff --git a/debian-bookworm-android/Makefile b/debian-bookworm-android/Makefile new file mode 100644 index 0000000..cdac90c --- /dev/null +++ b/debian-bookworm-android/Makefile @@ -0,0 +1,3 @@ +UPSTREAM_DISTRO=debian:bookworm +DISTRO=debian-bookworm +include ../make/Makefile -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/38799?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic7a454be23072c3f0ed609d370fc88f49205b04c Gerrit-Change-Number: 38799 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-hlr[master]: change default reject cause to plmn-not-allowed
by falconia 19 Nov '24

19 Nov '24

Attention is currently required from: keith. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-hlr/+/38794?usp=email ) Change subject: change default reject cause to plmn-not-allowed ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/38794?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Icff1d19670c398b119ec68b1d5f0fad87b605702 Gerrit-Change-Number: 38794 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Tue, 19 Nov 2024 05:09:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in osmo-hlr[master]: vty: always emit reject-cause lines in saved config
by falconia 19 Nov '24

19 Nov '24

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/38818?usp=email ) Change subject: vty: always emit reject-cause lines in saved config ...................................................................... vty: always emit reject-cause lines in saved config When reject-cause (not-found|no-proxy) setting was added, it was implemented such that the new setting is not written into saved config files if it equals the default of 'imsi-unknown'. Change this behavior to always write out the current setting for each of not-found and no-proxy, whether or not they match compiled-in defaults. Change-Id: I18708fc1c08a85e98582c97ec59dd3822a0767fb --- M src/hlr_vty.c M tests/test_nodes.vty 2 files changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/18/38818/1 diff --git a/src/hlr_vty.c b/src/hlr_vty.c index 2c7cd5b..4694c44 100644 --- a/src/hlr_vty.c +++ b/src/hlr_vty.c @@ -320,14 +320,12 @@ { vty_out(vty, "hlr%s", VTY_NEWLINE); - if (g_hlr->reject_cause != GMM_CAUSE_IMSI_UNKNOWN) - vty_out(vty, " reject-cause not-found %s%s", - get_value_string_or_null(gsm48_gmm_cause_vty_names, - (uint32_t) g_hlr->reject_cause), VTY_NEWLINE); - if (g_hlr->no_proxy_reject_cause != GMM_CAUSE_IMSI_UNKNOWN) - vty_out(vty, " reject-cause no-proxy %s%s", - get_value_string_or_null(gsm48_gmm_cause_vty_names, - (uint32_t) g_hlr->no_proxy_reject_cause), VTY_NEWLINE); + vty_out(vty, " reject-cause not-found %s%s", + get_value_string_or_null(gsm48_gmm_cause_vty_names, + (uint32_t) g_hlr->reject_cause), VTY_NEWLINE); + vty_out(vty, " reject-cause no-proxy %s%s", + get_value_string_or_null(gsm48_gmm_cause_vty_names, + (uint32_t) g_hlr->no_proxy_reject_cause), VTY_NEWLINE); if (g_hlr->store_imei) vty_out(vty, " store-imei%s", VTY_NEWLINE); if (g_hlr->db_file_path && strcmp(g_hlr->db_file_path, HLR_DEFAULT_DB_FILE_PATH)) diff --git a/tests/test_nodes.vty b/tests/test_nodes.vty index 6875416..516360f 100644 --- a/tests/test_nodes.vty +++ b/tests/test_nodes.vty @@ -113,6 +113,8 @@ logging level dgsm notice ... hlr + reject-cause not-found imsi-unknown + reject-cause no-proxy imsi-unknown store-imei database hlr_vty_test.db no subscriber-create-on-demand -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/38818?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I18708fc1c08a85e98582c97ec59dd3822a0767fb Gerrit-Change-Number: 38818 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org>

1 0

[XS] Change in osmo-hlr[master]: change default no-proxy reject cause to net-fail
by falconia 19 Nov '24

19 Nov '24

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/38819?usp=email ) Change subject: change default no-proxy reject cause to net-fail ...................................................................... change default no-proxy reject cause to net-fail If LU has to be rejected because DGSM mechanism cannot reach the needed HLR, then returning reject cause #17 (Network Failure) is the most accurate and truthful description of what is actually happening. Reject cause #2 (IMSI unknown in HLR) is unlikely to be a good choice: in areas where regular commercial cell services are present alongside with experimental/adventurous Osmocom-based GSM networks, this reject cause is acutely dangerous as described in the previous commit, and even in areas where no regular commercial cell services are present (the presumed intended use case for DGSM), the behavior of commanding LU-failing phones "please don't ever again try to connect to ANY network until the user power-cycles you" is unlikely to be correct/desirable. If that behavior _is_ desired, it should be configured explicitly, not by default. Change-Id: I557ae1d3291066a87228b5db4f2e207ea721329c --- M src/hlr.c M tests/test_nodes.vty 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/19/38819/1 diff --git a/src/hlr.c b/src/hlr.c index 3d020d6..a900e23 100644 --- a/src/hlr.c +++ b/src/hlr.c @@ -780,7 +780,7 @@ g_hlr->mslookup.server.mdns.domain_suffix = talloc_strdup(g_hlr, OSMO_MDNS_DOMAIN_SUFFIX_DEFAULT); g_hlr->mslookup.client.mdns.domain_suffix = talloc_strdup(g_hlr, OSMO_MDNS_DOMAIN_SUFFIX_DEFAULT); g_hlr->reject_cause = GMM_CAUSE_PLMN_NOTALLOWED; - g_hlr->no_proxy_reject_cause = GMM_CAUSE_IMSI_UNKNOWN; + g_hlr->no_proxy_reject_cause = GMM_CAUSE_NET_FAIL; /* Init default (call independent) SS session guard timeout value */ g_hlr->ncss_guard_timeout = NCSS_GUARD_TIMEOUT_DEFAULT; diff --git a/tests/test_nodes.vty b/tests/test_nodes.vty index a9203b7..b7e7214 100644 --- a/tests/test_nodes.vty +++ b/tests/test_nodes.vty @@ -114,7 +114,7 @@ ... hlr reject-cause not-found plmn-not-allowed - reject-cause no-proxy imsi-unknown + reject-cause no-proxy net-fail store-imei database hlr_vty_test.db no subscriber-create-on-demand -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/38819?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I557ae1d3291066a87228b5db4f2e207ea721329c Gerrit-Change-Number: 38819 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org>

1 0

[S] Change in libosmocore[master]: gprs/gsm23003: add osmo_mme_id_cmp & osmo_gummei_cmp
by lynxis lazus 18 Nov '24

18 Nov '24

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/38763?usp=email ) Change subject: gprs/gsm23003: add osmo_mme_id_cmp & osmo_gummei_cmp ...................................................................... gprs/gsm23003: add osmo_mme_id_cmp & osmo_gummei_cmp In order to support mobility between GERAN and EUTRAN, the SGSN need to route a SGSN Context Request towards a MME identified by the GUMMEI. Change-Id: I9a6769b1bff16450046181b31a8762ff49955ae4 --- M include/osmocom/gsm/gsm23003.h M src/gsm/gsm23003.c M src/gsm/libosmogsm.map 3 files changed, 38 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmocom/gsm/gsm23003.h b/include/osmocom/gsm/gsm23003.h index 4070581..8b9bcfb 100644 --- a/include/osmocom/gsm/gsm23003.h +++ b/include/osmocom/gsm/gsm23003.h @@ -167,6 +167,8 @@ int osmo_rai_cmp(const struct osmo_routing_area_id *a, const struct osmo_routing_area_id *b); int osmo_cgi_cmp(const struct osmo_cell_global_id *a, const struct osmo_cell_global_id *b); int osmo_cgi_ps_cmp(const struct osmo_cell_global_id_ps *a, const struct osmo_cell_global_id_ps *b); +int osmo_mme_id_cmp(const struct osmo_mme_id *a, const struct osmo_mme_id *b); +int osmo_gummei_cmp(const struct osmo_gummei *a, const struct osmo_gummei *b); int osmo_gen_home_network_domain(char *out, const struct osmo_plmn_id *plmn); int osmo_parse_home_network_domain(struct osmo_plmn_id *out, const char *in); diff --git a/src/gsm/gsm23003.c b/src/gsm/gsm23003.c index 1eed41f..0f4c301 100644 --- a/src/gsm/gsm23003.c +++ b/src/gsm/gsm23003.c @@ -656,6 +656,40 @@ return 0; } +/* Compare two MME Ids + * The order of comparison is MME GroupId, MME Code. + * \param a[in] "Left" side MME Id. + * \param b[in] "Right" side MME Id. + * \returns 0 if the MME Ids are equal, -1 if a < b, 1 if a > b. */ +int osmo_mme_id_cmp(const struct osmo_mme_id *a, const struct osmo_mme_id *b) +{ + if (a->group_id < b->group_id) + return -1; + if (a->group_id > b->group_id) + return 1; + + if (a->code < b->code) + return -1; + if (a->code > b->code) + return 1; + + return 0; +} + +/* Compare two GUMMEI + * The order of comparison is MCC, MNC, MME GroupId, MME Code. + * \param a[in] "Left" side GUMMEI. + * \param b[in] "Right" side GUMMEI. + * \returns 0 if the GUMMEI are equal, -1 if a < b, 1 if a > b. */ +int osmo_gummei_cmp(const struct osmo_gummei *a, const struct osmo_gummei *b) +{ + int rc = osmo_plmn_cmp(&a->plmn, &b->plmn); + if (rc) + return rc; + + return osmo_mme_id_cmp(&a->mme, &b->mme); +} + /*! Generate TS 23.003 Section 19.2 Home Network Realm/Domain (text form) * \param out[out] caller-provided output buffer, at least 33 bytes long * \param plmn[in] Osmocom representation of PLMN ID (MCC + MNC) diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map index 3bc8309..8d17ce3 100644 --- a/src/gsm/libosmogsm.map +++ b/src/gsm/libosmogsm.map @@ -502,6 +502,8 @@ osmo_gummei_name; osmo_gummei_name_buf; osmo_gummei_name_c; +osmo_gummei_cmp; +osmo_mme_id_cmp; osmo_mnc_from_str; osmo_mnc_cmp; osmo_plmn_cmp; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38763?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9a6769b1bff16450046181b31a8762ff49955ae4 Gerrit-Change-Number: 38763 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-bts[master]: csd_v110: handle TCH/F14.4
by falconia 18 Nov '24

18 Nov '24

Attention is currently required from: fixeria. falconia has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/38751?usp=email ) Change subject: csd_v110: handle TCH/F14.4 ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38751?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3c3bef0bd2f72b8381597b5699e2060165b702a0 Gerrit-Change-Number: 38751 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Nov 2024 23:00:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bts[master]: csd_v110: clarify lchan description for TCH/F14.4
by falconia 18 Nov '24

18 Nov '24

Attention is currently required from: fixeria. falconia has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/38817?usp=email ) Change subject: csd_v110: clarify lchan description for TCH/F14.4 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38817?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I4f11eda98420587efa339484b62f46bf19f78809 Gerrit-Change-Number: 38817 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Nov 2024 23:00:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bts[master]: csd_v110: clarify field names in csd_v110_lchan_desc[]
by falconia 18 Nov '24

18 Nov '24

Attention is currently required from: fixeria. falconia has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/38816?usp=email ) Change subject: csd_v110: clarify field names in csd_v110_lchan_desc[] ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38816?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If97787a64e30ff9b39c26749ba32aed09d3d7983 Gerrit-Change-Number: 38816 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Nov 2024 23:00:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bts[master]: csd_v110: add CSD_V110_NUM_BITS macro
by falconia 18 Nov '24

18 Nov '24

Attention is currently required from: fixeria. falconia has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/38815?usp=email ) Change subject: csd_v110: add CSD_V110_NUM_BITS macro ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38815?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iabd2ee5ea9d580e0a6f5c93d681f6be67d1949c5 Gerrit-Change-Number: 38815 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Nov 2024 23:00:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log