- gerrit-log - lists.osmocom.org

[M] Change in osmo-bts[master]: csd_v110: handle TCH/F14.4
by fixeria 18 Nov '24

18 Nov '24

Attention is currently required from: falconia. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/38751?usp=email ) Change subject: csd_v110: handle TCH/F14.4 ...................................................................... Patch Set 4: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/38751/comment/36c85917_bad728ba?usp… : PS3, Line 15: E-TRAU frames (spoken over the air) > Acknowledged Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38751?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3c3bef0bd2f72b8381597b5699e2060165b702a0 Gerrit-Change-Number: 38751 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: falconia <falcon(a)freecalypso.org> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 18 Nov 2024 22:32:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-bts[master]: csd_v110: handle TCH/F14.4
by fixeria 18 Nov '24

18 Nov '24

Attention is currently required from: falconia. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/38751?usp=email to look at the new patch set (#5). Change subject: csd_v110: handle TCH/F14.4 ...................................................................... csd_v110: handle TCH/F14.4 Thanks to the work done by Mychaela (see the related Change-IDs), we can finally implement handling of TCH/F14.4 (both T and NT modes) for osmo-bts-trx and osmo-bts-virtual. This channel mode is special in a way that it employs a different rate adaptation function RAA' (defined in 3GPP TS 48.020 chapter 11), which converts between between 290-bit blocks used on Um and Abis-E1 interfaces (E-TRAU frames on the latter) and A-TRAU frames spoken over the A interface. The result of function RAA' in the Uplink direction is 320 bits, which is equal to 4 x 80-bit V.110 frames, but actually carrying 8 x 36-bit packed frames. These 320 bits are then fed to the RA2 function, like we do for other CSD channel modes. Change-Id: I3c3bef0bd2f72b8381597b5699e2060165b702a0 Depends: libosmo-abis.git I11fc1529f5be88fa778c7e05cb11eef58a389d40 Depends: libosmo-abis.git I1347a25ce97d5022502ee9112caded66315b09a4 Related: OS#6167 --- M TODO-RELEASE M src/common/bts.c M src/common/csd_v110.c M src/osmo-bts-trx/main.c M src/osmo-bts-virtual/main.c M tests/csd/csd_test.c M tests/csd/csd_test.err 7 files changed, 59 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/51/38751/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38751?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3c3bef0bd2f72b8381597b5699e2060165b702a0 Gerrit-Change-Number: 38751 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: falconia <falcon(a)freecalypso.org> Gerrit-Attention: falconia <falcon(a)freecalypso.org>

1 0

[M] Change in osmo-bts[master]: csd_v110: handle TCH/F14.4
by fixeria 18 Nov '24

18 Nov '24

Attention is currently required from: falconia. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/38751?usp=email ) Change subject: csd_v110: handle TCH/F14.4 ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38751?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3c3bef0bd2f72b8381597b5699e2060165b702a0 Gerrit-Change-Number: 38751 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: falconia <falcon(a)freecalypso.org> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 18 Nov 2024 22:30:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in osmo-bts[master]: csd_v110: add CSD_V110_NUM_BITS macro
by fixeria 18 Nov '24

18 Nov '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/38815?usp=email ) Change subject: csd_v110: add CSD_V110_NUM_BITS macro ...................................................................... csd_v110: add CSD_V110_NUM_BITS macro Change-Id: Iabd2ee5ea9d580e0a6f5c93d681f6be67d1949c5 --- M include/osmo-bts/csd_v110.h M src/common/csd_v110.c M src/common/l1sap.c M tests/csd/csd_test.c 4 files changed, 8 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/15/38815/1 diff --git a/include/osmo-bts/csd_v110.h b/include/osmo-bts/csd_v110.h index 7d67ff0..d2a27b3 100644 --- a/include/osmo-bts/csd_v110.h +++ b/include/osmo-bts/csd_v110.h @@ -13,6 +13,9 @@ extern const struct csd_v110_lchan_desc csd_v110_lchan_desc[256]; +#define CSD_V110_NUM_BITS(desc) \ + ((desc)->num_blocks * (desc)->num_bits) + int csd_v110_rtp_encode(const struct gsm_lchan *lchan, uint8_t *rtp, const uint8_t *data, size_t data_len, uint8_t nt48_half_num); diff --git a/src/common/csd_v110.c b/src/common/csd_v110.c index f60624f..4d7ee4f 100644 --- a/src/common/csd_v110.c +++ b/src/common/csd_v110.c @@ -92,7 +92,7 @@ return -ENOTSUP; /* handle empty/incomplete Uplink frames gracefully */ - if (OSMO_UNLIKELY(data_len < (desc->num_blocks * desc->num_bits))) { + if (OSMO_UNLIKELY(data_len < CSD_V110_NUM_BITS(desc))) { /* encode N idle frames as per 3GPP TS 44.021, section 8.1.6 */ memset(&ra_bits[0], 0x01, sizeof(ra_bits)); for (unsigned int i = 0; i < desc->num_blocks; i++) @@ -200,5 +200,5 @@ if (align_bits) *align_bits = align_accum; - return desc->num_blocks * desc->num_bits; + return CSD_V110_NUM_BITS(desc); } diff --git a/src/common/l1sap.c b/src/common/l1sap.c index 18d7d93..09f6a90 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -1528,7 +1528,7 @@ gsm_fn2gsmtime(&g_time, fn); desc = &csd_v110_lchan_desc[lchan->tch_mode]; - bits_per_20ms = desc->num_blocks * desc->num_bits; + bits_per_20ms = CSD_V110_NUM_BITS(desc); OSMO_ASSERT(bits_per_20ms != 0); for (i = 0; i < ARRAY_SIZE(input_msg); i++) { @@ -2172,7 +2172,7 @@ int rc, i; desc = &csd_v110_lchan_desc[lchan->tch_mode]; - bits_per_20ms = desc->num_blocks * desc->num_bits; + bits_per_20ms = CSD_V110_NUM_BITS(desc); OSMO_ASSERT(bits_per_20ms != 0); if (data_len != bits_per_20ms * 2) { diff --git a/tests/csd/csd_test.c b/tests/csd/csd_test.c index e52bde2..c46bbd9 100644 --- a/tests/csd/csd_test.c +++ b/tests/csd/csd_test.c @@ -104,7 +104,7 @@ desc = &csd_v110_lchan_desc[tc->tch_mode]; /* total number of bits carried by a radio interface block */ - const unsigned int bit_num = desc->num_bits * desc->num_blocks; + const unsigned int bit_num = CSD_V110_NUM_BITS(desc); if (bit_num == 0) { fprintf(stderr, "[i] Skipping '%s' (not implemented)\n", tc->name); return; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38815?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iabd2ee5ea9d580e0a6f5c93d681f6be67d1949c5 Gerrit-Change-Number: 38815 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: csd_v110: clarify field names in csd_v110_lchan_desc[]
by fixeria 18 Nov '24

18 Nov '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/38816?usp=email ) Change subject: csd_v110: clarify field names in csd_v110_lchan_desc[] ...................................................................... csd_v110: clarify field names in csd_v110_lchan_desc[] A radio-interface block in GSM carries several modified 36-bit or 60-bit V.110 frames. Let's rename the fields to avoid confusion. Change-Id: If97787a64e30ff9b39c26749ba32aed09d3d7983 --- M include/osmo-bts/csd_v110.h M src/common/csd_v110.c 2 files changed, 22 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/16/38816/1 diff --git a/include/osmo-bts/csd_v110.h b/include/osmo-bts/csd_v110.h index d2a27b3..62058f4 100644 --- a/include/osmo-bts/csd_v110.h +++ b/include/osmo-bts/csd_v110.h @@ -6,15 +6,15 @@ struct gsm_lchan; struct csd_v110_lchan_desc { - uint16_t num_blocks; - uint16_t num_bits; - uint8_t ra2_ir; /* intermediate rate (8 or 16 kbit/s) for RA2 step */ + uint16_t num_frames; /* number of V.110 frames in a radio block */ + uint16_t num_frame_bits; /* number of bits in each V.110 frame */ + uint8_t ra2_ir; /* intermediate rate (8 or 16 kbit/s) for RA2 step */ }; extern const struct csd_v110_lchan_desc csd_v110_lchan_desc[256]; #define CSD_V110_NUM_BITS(desc) \ - ((desc)->num_blocks * (desc)->num_bits) + ((desc)->num_frames * (desc)->num_frame_bits) int csd_v110_rtp_encode(const struct gsm_lchan *lchan, uint8_t *rtp, const uint8_t *data, size_t data_len, diff --git a/src/common/csd_v110.c b/src/common/csd_v110.c index 4d7ee4f..f578d52 100644 --- a/src/common/csd_v110.c +++ b/src/common/csd_v110.c @@ -39,27 +39,27 @@ #if 0 [GSM48_CMODE_DATA_14k5] = { /* TCH/F14.4: 290 bits every 20 ms (14.5 kbit/s) */ - .num_blocks = 1, - .num_bits = 290, + .num_frames = 1, + .num_frame_bits = 290, .ra2_ir = 16, }, #endif [GSM48_CMODE_DATA_12k0] = { /* TCH/F9.6: 4 * 60 bits every 20 ms (12.0 kbit/s) */ - .num_blocks = 4, - .num_bits = 60, + .num_frames = 4, + .num_frame_bits = 60, .ra2_ir = 16, }, [GSM48_CMODE_DATA_6k0] = { /* TCH/[FH]4.8: 2 * 60 bits every 20 ms (6.0 kbit/s) */ - .num_blocks = 2, - .num_bits = 60, + .num_frames = 2, + .num_frame_bits = 60, .ra2_ir = 8, }, [GSM48_CMODE_DATA_3k6] = { /* TCH/[FH]2.4: 2 * 36 bits every 20 ms (3.6 kbit/s) */ - .num_blocks = 2, - .num_bits = 36, + .num_frames = 2, + .num_frame_bits = 36, .ra2_ir = 8, }, }; @@ -88,26 +88,26 @@ OSMO_ASSERT(lchan->tch_mode < ARRAY_SIZE(csd_v110_lchan_desc)); desc = &csd_v110_lchan_desc[lchan->tch_mode]; - if (OSMO_UNLIKELY(desc->num_blocks == 0)) + if (OSMO_UNLIKELY(desc->num_frames == 0)) return -ENOTSUP; /* handle empty/incomplete Uplink frames gracefully */ if (OSMO_UNLIKELY(data_len < CSD_V110_NUM_BITS(desc))) { /* encode N idle frames as per 3GPP TS 44.021, section 8.1.6 */ memset(&ra_bits[0], 0x01, sizeof(ra_bits)); - for (unsigned int i = 0; i < desc->num_blocks; i++) + for (unsigned int i = 0; i < desc->num_frames; i++) memset(&ra_bits[i * 80], 0x00, 8); /* alignment pattern */ goto ra1_ra2; } /* RA1'/RA1: convert from radio rate to an intermediate data rate */ - for (unsigned int i = 0; i < desc->num_blocks; i++) { + for (unsigned int i = 0; i < desc->num_frames; i++) { struct osmo_v110_decoded_frame df; /* convert a V.110 36-/60-bit frame to a V.110 80-bit frame */ - if (desc->num_bits == 60) + if (desc->num_frame_bits == 60) osmo_csd_12k_6k_decode_frame(&df, &data[i * 60], 60); - else /* desc->num_bits == 36 */ + else /* desc->num_frame_bits == 36 */ osmo_csd_3k6_decode_frame(&df, &data[i * 36], 36); /* E1 .. E3 must set by out-of-band knowledge */ @@ -116,7 +116,7 @@ /* E1: as per 15.1.2, shall be set to 0 (for BSS-MSC) */ df.e_bits[0] = 0; /* E2: 0 for Q1/Q2, 1 for Q3/Q4 */ - if (desc->num_blocks == 4) + if (desc->num_frames == 4) df.e_bits[1] = (i >> 1) & 0x01; else df.e_bits[1] = nt48_half_num; @@ -165,7 +165,7 @@ OSMO_ASSERT(lchan->tch_mode < ARRAY_SIZE(csd_v110_lchan_desc)); desc = &csd_v110_lchan_desc[lchan->tch_mode]; - if (OSMO_UNLIKELY(desc->num_blocks == 0)) + if (OSMO_UNLIKELY(desc->num_frames == 0)) return -ENOTSUP; if (OSMO_UNLIKELY(rtp_len != RFC4040_RTP_PLEN)) @@ -178,7 +178,7 @@ osmo_csd_ra2_8k_unpack(&ra_bits[0], &rtp[0], RFC4040_RTP_PLEN); /* RA1'/RA1: convert from an intermediate rate to radio rate */ - for (unsigned int i = 0; i < desc->num_blocks; i++) { + for (unsigned int i = 0; i < desc->num_frames; i++) { struct osmo_v110_decoded_frame df; /* We require our RTP input to consist of aligned V.110 @@ -188,9 +188,9 @@ return -EINVAL; /* convert a V.110 80-bit frame to a V.110 36-/60-bit frame */ osmo_v110_decode_frame(&df, &ra_bits[i * 80], 80); - if (desc->num_bits == 60) + if (desc->num_frame_bits == 60) osmo_csd_12k_6k_encode_frame(&data[i * 60], 60, &df); - else /* desc->num_bits == 36 */ + else /* desc->num_frame_bits == 36 */ osmo_csd_3k6_encode_frame(&data[i * 36], 36, &df); /* save bits E2 & E3 that may be needed for RLP alignment */ align_accum <<= 2; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38816?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If97787a64e30ff9b39c26749ba32aed09d3d7983 Gerrit-Change-Number: 38816 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: csd_v110: clarify lchan description for TCH/F14.4
by fixeria 18 Nov '24

18 Nov '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/38817?usp=email ) Change subject: csd_v110: clarify lchan description for TCH/F14.4 ...................................................................... csd_v110: clarify lchan description for TCH/F14.4 According to 3GPP TS 44.021, section 10.3.2, a radio-interface data block for a TCH/F14.4 channel consists of eight 36-bit data frames and two M-bits (290 bits total). Let's fix our definition. Change-Id: I4f11eda98420587efa339484b62f46bf19f78809 Related: OS#6167 --- M include/osmo-bts/csd_v110.h M src/common/csd_v110.c 2 files changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/17/38817/1 diff --git a/include/osmo-bts/csd_v110.h b/include/osmo-bts/csd_v110.h index 62058f4..1621c00 100644 --- a/include/osmo-bts/csd_v110.h +++ b/include/osmo-bts/csd_v110.h @@ -8,13 +8,14 @@ struct csd_v110_lchan_desc { uint16_t num_frames; /* number of V.110 frames in a radio block */ uint16_t num_frame_bits; /* number of bits in each V.110 frame */ + uint16_t num_other_bits; /* number of other bits (e.g. M-bits for TCH/F14.4) */ uint8_t ra2_ir; /* intermediate rate (8 or 16 kbit/s) for RA2 step */ }; extern const struct csd_v110_lchan_desc csd_v110_lchan_desc[256]; #define CSD_V110_NUM_BITS(desc) \ - ((desc)->num_frames * (desc)->num_frame_bits) + ((desc)->num_frames * (desc)->num_frame_bits + (desc)->num_other_bits) int csd_v110_rtp_encode(const struct gsm_lchan *lchan, uint8_t *rtp, const uint8_t *data, size_t data_len, diff --git a/src/common/csd_v110.c b/src/common/csd_v110.c index f578d52..9bbc5fe 100644 --- a/src/common/csd_v110.c +++ b/src/common/csd_v110.c @@ -38,9 +38,10 @@ const struct csd_v110_lchan_desc csd_v110_lchan_desc[256] = { #if 0 [GSM48_CMODE_DATA_14k5] = { - /* TCH/F14.4: 290 bits every 20 ms (14.5 kbit/s) */ - .num_frames = 1, - .num_frame_bits = 290, + /* TCH/F14.4: 8 * 36 + 2 bits every 20 ms (14.5 kbit/s) */ + .num_frames = 8, + .num_frame_bits = 36, /* D-bits */ + .num_other_bits = 2, /* M-bits */ .ra2_ir = 16, }, #endif -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38817?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I4f11eda98420587efa339484b62f46bf19f78809 Gerrit-Change-Number: 38817 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in libosmo-abis[master]: ipaccess: Replace ipa_msg_push_header() with libosmocore ipa_prepend_...
by pespin 18 Nov '24

18 Nov '24

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38814?usp=email ) Change subject: ipaccess: Replace ipa_msg_push_header() with libosmocore ipa_prepend_header() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Wait, this is public API that is used by some projects like osmo-hlr... Ah I didn't think about that, thanks for noticing. I thought it was a private API. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38814?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I59b216c8a5e5a8744d337773ccf6f8d674b9513d Gerrit-Change-Number: 38814 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Nov 2024 20:07:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmo-abis[master]: ipaccess: Simplify code after early return if block
by pespin 18 Nov '24

18 Nov '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38806?usp=email ) Change subject: ipaccess: Simplify code after early return if block ...................................................................... ipaccess: Simplify code after early return if block Change-Id: I406b4f4e973c9b75b102aea3d6fe6aab73d91185 --- M src/input/ipaccess.c 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index f89db15..cab812c 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -967,11 +967,12 @@ } msgb_free(msg); return ret; - } else if (link->port == IPA_TCP_PORT_OML) + } + + if (link->port == IPA_TCP_PORT_OML) e1i_ts = e1inp_line_ipa_oml_ts(link->line); else if (link->port == IPA_TCP_PORT_RSL) e1i_ts = e1inp_line_ipa_rsl_ts(link->line, link->ofd->priv_nr - E1INP_SIGN_RSL); - OSMO_ASSERT(e1i_ts != NULL); if (e1i_ts->type == E1INP_TS_TYPE_NONE) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38806?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I406b4f4e973c9b75b102aea3d6fe6aab73d91185 Gerrit-Change-Number: 38806 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-abis[master]: ipaccess: Fix wrong pointer passed in sign_link_up user callback
by pespin 18 Nov '24

18 Nov '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38805?usp=email ) Change subject: ipaccess: Fix wrong pointer passed in sign_link_up user callback ...................................................................... ipaccess: Fix wrong pointer passed in sign_link_up user callback This bug was introduced in Jun 2011, 13 years ago, so probably this code path is not (usually) used at all. The commit introducing the regression changed sign_link_up() first param from msgb to struct ipaccess_unit, but compiler didn't catch it because it's being passed as a void pointer. Fixes: c9c4fd39055ab02c0af59d5519e62edc456e3d0b Related: OS#3622 Change-Id: I8e514360d5ed1c311af97f8fa728a2ff0a027522 --- M src/input/ipaccess.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index da2f04d..f89db15 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -955,9 +955,9 @@ if (ret == 1 && hh->proto == IPAC_PROTO_IPACCESS) { if (msg_type == IPAC_MSGT_ID_GET) { - sign_link = link->line->ops->sign_link_up(msg, - link->line, - link->ofd->priv_nr); + sign_link = link->line->ops->sign_link_up(link->line->ops->cfg.ipa.dev, + link->line, + link->ofd->priv_nr); if (sign_link == NULL) { LOGP(DLINP, LOGL_ERROR, "Unable to set signal link, " -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38805?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I8e514360d5ed1c311af97f8fa728a2ff0a027522 Gerrit-Change-Number: 38805 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-abis[master]: ipaccess: Use libosmocore API ipa_ccm_send_id_ack()
by pespin 18 Nov '24

18 Nov '24

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38812?usp=email ) Change subject: ipaccess: Use libosmocore API ipa_ccm_send_id_ack() ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38812?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ib8e84718337d16467726de922b410abbaffdac3a Gerrit-Change-Number: 38812 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 18 Nov 2024 20:06:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log