Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/38817?usp=email )
Change subject: csd_v110: clarify lchan description for TCH/F14.4
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File include/osmo-bts/csd_v110.h:
https://gerrit.osmocom.org/c/osmo-bts/+/38817/comment/19cde31d_f7ba098b?usp… :
PS1, Line 11: uint16_t num_other_bits; /* number of other bits (e.g. M-bits for TCH/F14.4) */
> this can be a uint8_t afaiu?
Yes, but it does not really matter. It can be `uint8_t`, it can be just `unsigned int`.
We can change this in a separate patch or when moving to libosmocore.git.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38817?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I4f11eda98420587efa339484b62f46bf19f78809
Gerrit-Change-Number: 38817
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 19 Nov 2024 12:25:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/android-apdu-proxy/+/38820?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: (do not merge) test commit for CI
......................................................................
(do not merge) test commit for CI
Change-Id: Ifb00a05c4df2537f5664d79858f80256a2c63fec
---
A test
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/android-apdu-proxy refs/changes/20/38820/3
--
To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/38820?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: android-apdu-proxy
Gerrit-Branch: master
Gerrit-Change-Id: Ifb00a05c4df2537f5664d79858f80256a2c63fec
Gerrit-Change-Number: 38820
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/38820?usp=email )
Change subject: (do not merge) test commit for CI
......................................................................
(do not merge) test commit for CI
Change-Id: Ifb00a05c4df2537f5664d79858f80256a2c63fec
---
A test
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/android-apdu-proxy refs/changes/20/38820/2
--
To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/38820?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: android-apdu-proxy
Gerrit-Branch: master
Gerrit-Change-Id: Ifb00a05c4df2537f5664d79858f80256a2c63fec
Gerrit-Change-Number: 38820
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/38820?usp=email )
Change subject: (do not merge) test commit for CI
......................................................................
(do not merge) test commit for CI
Change-Id: Ifb00a05c4df2537f5664d79858f80256a2c63fec
---
A test
1 file changed, 0 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/android-apdu-proxy refs/changes/20/38820/1
diff --git a/test b/test
new file mode 100644
index 0000000..e69de29
--- /dev/null
+++ b/test
--
To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/38820?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: android-apdu-proxy
Gerrit-Branch: master
Gerrit-Change-Id: Ifb00a05c4df2537f5664d79858f80256a2c63fec
Gerrit-Change-Number: 38820
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>