osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/39046?usp=email )
Change subject: gitignore: remove debian section
......................................................................
gitignore: remove debian section
Having 'debian/libosmo-gprs-llc*' and similar in gitignore leads to
unexpected behavior when making releases:
* When bumping libversion, we need to rename related install files, e.g.:
debian/libosmo-gprs-llc0.install -> debian/libosmo-gprs-llc1.install
* "git add -A" will not add the new files, instead they just show up as
deleted
* this is easy to miss among the other changes, and it leads to a
potentially confusing build error:
dpkg-shlibdeps: error: cannot find library libosmo-gprs-llc.so.1 needed by debian/libosmo-gprs-gmm1/usr/lib/x86_64-linux-gnu/libosmo-gprs-gmm.so.1.0.0 (ELF format: 'elf64-x86-64' abi: '0201003e00000000'; RPATH: '')
Remove the entire debian dir from gitignore, it is not worth having it
in there.
Change-Id: I508242eef770c6fa467f5371587491147e9fc5eb
---
M .gitignore
1 file changed, 0 insertions(+), 9 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
diff --git a/.gitignore b/.gitignore
index ee800c0..020b541 100644
--- a/.gitignore
+++ b/.gitignore
@@ -31,15 +31,6 @@
ltmain.sh
m4/*.m4
-# debian build products
-debian/libosmo-gprs-rlcmac*
-debian/libosmo-gprs-llc*
-debian/libosmo-csn1*
-debian/autoreconf.*
-debian/.debhelper
-debian/files
-debian/tmp
-
# testsuite
tests/atconfig
tests/package.m4
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/39046?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I508242eef770c6fa467f5371587491147e9fc5eb
Gerrit-Change-Number: 39046
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39042?usp=email )
Change subject: ipaccess: Use new osmo_ipa_ka_fsm_inst APIs from libosmo-netif
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39042?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I6164a44847fcd88d08c77f977d928c2fdf657719
Gerrit-Change-Number: 39042
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 08 Dec 2024 21:38:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39045?usp=email )
Change subject: Drop dependency on libosmo-abis
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39045?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I7658b0c92c589b24a9f2bfe101ada5fc0077059f
Gerrit-Change-Number: 39045
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 08 Dec 2024 21:37:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39035?usp=email )
Change subject: ipa: Add osmo_ipa_ka_fsm_inst APIs
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File include/osmocom/netif/ipa.h:
https://gerrit.osmocom.org/c/libosmo-netif/+/39035/comment/d2093193_a003837… :
PS3, Line 85: void *osmo_ipa_ka_fsm_get_data(const struct osmo_ipa_ka_fsm_inst *ka_fi);
I would normally hand the data directly to the call-back as an argument to avoid the extra function call to a method like this in every call-back.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39035?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I5c36e06e0dc29ec4679b20ad6c426f051b659acd
Gerrit-Change-Number: 39035
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 08 Dec 2024 21:36:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39056?usp=email )
Change subject: ara_m: put hex string values in quotes
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
why would we do this? Have we ever done so in other location? are we not always simply using hex-strings "as-is" e.g. for K, OPc, etc? It's not like those strings contain spaces or tabs...
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/39056?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ia365e83638ff4f1b1a02e1671852cf2006f80c7f
Gerrit-Change-Number: 39056
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 08 Dec 2024 11:26:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39055?usp=email )
Change subject: ara_m: fix spec reference.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/39055?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I77895f1b84126563380ce89aa07a3b448d8784a3
Gerrit-Change-Number: 39055
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 08 Dec 2024 11:25:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes