Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39058?usp=email )
Change subject: ipaccess_line_update: drop set_priority and set_ip_dscp
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39058?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: osmith/1.12.4
Gerrit-Change-Id: Ic46af94db8e0d821c5ca559e96c72d5041d32823
Gerrit-Change-Number: 39058
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 09 Dec 2024 10:49:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39058?usp=email )
Change subject: ipaccess_line_update: drop set_priority and set_ip_dscp
......................................................................
ipaccess_line_update: drop set_priority and set_ip_dscp
Do not run osmo_stream_cli_set_priority() and
osmo_stream_cli_set_ip_dscp() in ipaccess_line_update(). These functions
are not available yet in libosmo-netif 1.5.x and cause the build to
fail.
g_e1inp_ipaccess_config_pars.oml.dscp and
g_e1inp_ipaccess_config_pars.oml.priority are not set anyway, so this
makes no functional difference.
Suggested-by: Pau Espin Pedrol <pespin(a)sysmocom.de>
Change-Id: Ic46af94db8e0d821c5ca559e96c72d5041d32823
---
M src/ipaccess/ipaccess-config-e1-driver.c
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/58/39058/1
diff --git a/src/ipaccess/ipaccess-config-e1-driver.c b/src/ipaccess/ipaccess-config-e1-driver.c
index 71e70e1..48992c5 100644
--- a/src/ipaccess/ipaccess-config-e1-driver.c
+++ b/src/ipaccess/ipaccess-config-e1-driver.c
@@ -423,8 +423,6 @@
osmo_stream_cli_set_port(cli, IPACCESS_BTS_LISTEN_OML_PORT);
osmo_stream_cli_set_proto(cli, IPPROTO_TCP);
osmo_stream_cli_set_nodelay(cli, true);
- osmo_stream_cli_set_priority(cli, g_e1inp_ipaccess_config_pars.oml.dscp);
- osmo_stream_cli_set_ip_dscp(cli, g_e1inp_ipaccess_config_pars.oml.priority);
/* Reconnect is handled by upper layers: */
osmo_stream_cli_set_reconnect_timeout(cli, -1);
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39058?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-bsc
Gerrit-Branch: osmith/1.12.4
Gerrit-Change-Id: Ic46af94db8e0d821c5ca559e96c72d5041d32823
Gerrit-Change-Number: 39058
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Attention is currently required from: laforge.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39056?usp=email )
Change subject: ara_m: put hex string values in quotes
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> why would we do this? Have we ever done so in other location? are we not always simply using hex-str […]
Its due to an aesthetic conflict with the patch after this one. The problem is with the option --aid. When I want to put an empty AID, I must write --aid "". and then I have "" on one option and not on the others. I don't think that this looks very good, that is why I thought that we should put all parameters in "" by default.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/39056?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ia365e83638ff4f1b1a02e1671852cf2006f80c7f
Gerrit-Change-Number: 39056
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 09 Dec 2024 10:44:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: dexter.
pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38964?usp=email )
Change subject: PCUIF: fix usage of bts number in PCUIF_TXT_IND
......................................................................
Patch Set 1:
(1 comment)
File bts/BTS_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38964/comment/0eee7a3b_f13d… :
PS1, Line 5449: /* At this point, a real PCU would not have any BTS context yet. This means that the receiving process is
> In this situation the 0 is just a placeholder.
Yes, I know, but this fact is totally unrelated to the fact that "PCU doesn't have any BTS context yet"...?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38964?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I93de261fc77806b2f817e0d30cb1b0d377ed0dbb
Gerrit-Change-Number: 38964
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 09 Dec 2024 10:19:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: laforge, pespin.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-abis/+/39042?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Verified-1 by Jenkins Builder
Change subject: ipaccess: Use new osmo_ipa_ka_fsm_inst APIs from libosmo-netif
......................................................................
ipaccess: Use new osmo_ipa_ka_fsm_inst APIs from libosmo-netif
Change-Id: I6164a44847fcd88d08c77f977d928c2fdf657719
Related: OS#5896
Depends: libosmo-netif.git Change-Id I5c36e06e0dc29ec4679b20ad6c426f051b659acd
---
M TODO-RELEASE
M include/osmocom/abis/e1_input.h
M src/input/ipaccess.c
3 files changed, 43 insertions(+), 32 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/42/39042/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39042?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I6164a44847fcd88d08c77f977d928c2fdf657719
Gerrit-Change-Number: 39042
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39035?usp=email )
Change subject: ipa: Add osmo_ipa_ka_fsm_inst APIs
......................................................................
Patch Set 4:
(1 comment)
File include/osmocom/netif/ipa.h:
https://gerrit.osmocom.org/c/libosmo-netif/+/39035/comment/b312d658_cde3d09… :
PS3, Line 85: void *osmo_ipa_ka_fsm_get_data(const struct osmo_ipa_ka_fsm_inst *ka_fi);
> I would normally hand the data directly to the call-back as an argument to avoid the extra function […]
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39035?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I5c36e06e0dc29ec4679b20ad6c426f051b659acd
Gerrit-Change-Number: 39035
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 09 Dec 2024 10:03:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>