- gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: SGSN: BSSGP_ConnHdlr: GMM Service Request: add support to expect auth...
by lynxis lazus 09 Dec '24

09 Dec '24

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email ) Change subject: SGSN: BSSGP_ConnHdlr: GMM Service Request: add support to expect authentication ...................................................................... SGSN: BSSGP_ConnHdlr: GMM Service Request: add support to expect authentication On a Service Request, the authentication is optional. Either an authentication must happen or the key material from the previous authentication has to be used. The default behavior is still the same. Change-Id: I9ed08160bf5413e3a30d6e90eb947d4d799e1058 --- M sgsn/BSSGP_ConnHdlr.ttcn 1 file changed, 93 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/sgsn/BSSGP_ConnHdlr.ttcn b/sgsn/BSSGP_ConnHdlr.ttcn index 82788f5..c5501aa 100644 --- a/sgsn/BSSGP_ConnHdlr.ttcn +++ b/sgsn/BSSGP_ConnHdlr.ttcn @@ -303,9 +303,88 @@ } } +/* expect a GSUP Send Auth Information */ +altstep as_gsup_sai(boolean umts_aka_challenge := false) runs on BSSGP_ConnHdlr +{ + [g_pars.net.expect_auth] GSUP.receive(tr_GSUP_SAI_REQ(g_pars.imsi)) { + var GSUP_IE auth_tuple; + + if (umts_aka_challenge) { + g_pars.vec := f_gen_auth_vec_3g(); + auth_tuple := valueof(ts_GSUP_IE_AuthTuple2G3G(g_pars.vec.rand, + g_pars.vec.sres, + g_pars.vec.kc, + g_pars.vec.ik, + g_pars.vec.ck, + g_pars.vec.autn, + g_pars.vec.res)); + } else { + g_pars.vec := f_gen_auth_vec_2g(); + auth_tuple := valueof(ts_GSUP_IE_AuthTuple2G(g_pars.vec.rand, + g_pars.vec.sres, + g_pars.vec.kc)); + } + + GSUP.send(ts_GSUP_SAI_RES(g_pars.imsi, auth_tuple)); + } +} + +/* Only used by as_gmm_auth to support same code path for Gb and Iu */ +private function f_gmm_auth_as(PDU_L3_SGSN_MS l3_mt, boolean umts_aka_challenge := true, boolean force_gsm_sres := false, integer ran_index := 0) runs on BSSGP_ConnHdlr { + var PDU_L3_MS_SGSN l3_mo; + var BIT4 ac_ref := l3_mt.msgs.gprs_mm.authenticationAndCipheringRequest.acReferenceNumber.valueField; + var template (value) PDU_L3_MS_SGSN auth_ciph_resp := ts_GMM_AUTH_RESP_2G(ac_ref, g_pars.vec.sres); + + if (umts_aka_challenge and not force_gsm_sres) { + /* set UMTS response instead */ + auth_ciph_resp.msgs.gprs_mm.authenticationAndCipheringResponse.authenticationParResp := { + valueField := substr(g_pars.vec.res, 0, 4) + }; + auth_ciph_resp.msgs.gprs_mm.authenticationAndCipheringResponse.authenticationRespParExt := { + elementIdentifier := '21'O, + lengthIndicator := lengthof(g_pars.vec.res) - 4, + valueField := substr(g_pars.vec.res, 4, lengthof(g_pars.vec.res) - 4) + }; + } + + l3_mo := valueof(auth_ciph_resp); + if (ispresent(l3_mt.msgs.gprs_mm.authenticationAndCipheringRequest.imeisvRequest) and + l3_mt.msgs.gprs_mm.authenticationAndCipheringRequest.imeisvRequest.valueField == '001'B) { + l3_mo.msgs.gprs_mm.authenticationAndCipheringResponse.imeisv := + valueof(ts_MI_IMEISV_TLV(g_pars.imei & '0'H)); + } + f_send_l3(l3_mo, ran_index); +} + +/* Handles GMM Auth and supplies auth tuples via GSUP if expect_sai is true. */ +altstep as_gmm_auth(boolean umts_aka_challenge := false, boolean force_gsm_sres := false, integer ran_index := 0, + boolean expect_sai := false) runs on BSSGP_ConnHdlr { + var PDU_DTAP_PS_MT mt; + var PDU_L3_SGSN_MS l3_mt; + + /* Ignoring autn for now */ + [is_gb(ran_index)] BSSGP[ran_index].receive(tr_GMM_AUTH_REQ(g_pars.vec.rand)) -> value l3_mt { + f_gmm_auth_as(l3_mt, umts_aka_challenge, force_gsm_sres, ran_index); + } + [is_iu(ran_index)] BSSAP.receive(tr_PDU_DTAP_PS_MT(tr_GMM_AUTH_REQ(g_pars.vec.rand))) -> value mt { + l3_mt := mt.dtap; + f_gmm_auth_as(l3_mt, umts_aka_challenge, force_gsm_sres, ran_index); + } + [expect_sai] as_gsup_sai(umts_aka_challenge := umts_aka_challenge) { repeat; }; +} + /* perform GMM authentication (if expected). * Note, for umts_aka_challenge to work, the revisionLevelIndicatior needs to - * be 1 to mark R99 capability, in the GMM Attach Request, see f_gmm_attach(). */ + * be 1 to mark R99 capability, in the GMM Attach Request, see f_gmm_attach(). + * + * Requires the order to be: + * SAI Req + * SAI Resp + * Auth Req + * Auth Resp + * CommonId + * (out of order: GMM ID Req) + */ function f_gmm_auth (boolean umts_aka_challenge := false, boolean force_gsm_sres := false, integer ran_index := 0) runs on BSSGP_ConnHdlr { var PDU_L3_MS_SGSN l3_mo; var PDU_L3_SGSN_MS l3_mt; @@ -667,6 +746,7 @@ ServiceType service_type := SERVICE_TYPE_Signalling, template (value) OCT2 pdp_status := '0000'O, boolean exp_ggsn_pdp_del := false, + boolean expect_auth := false, integer ran_index := 0, float Tval := 5.0) runs on BSSGP_ConnHdlr { timer T := Tval; @@ -694,8 +774,20 @@ } } + if (expect_auth) { + f_gmm_auth(umts_aka_challenge := true, ran_index := ran_index); + } + alt { [] as_service_request(exp_service_acc := true, ran_index := ran_index) { setverdict(pass); } + [not expect_auth] BSSAP.receive(tr_PDU_DTAP_PS_MT(tr_GMM_AUTH_REQ)) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + "Service Request: Unexpected GMM Auth Req"); + } + [not expect_auth] GSUP.receive(tr_GSUP_SAI_REQ(*)) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + "Service Request: Unexpected GSUP SAI Req"); + } [] BSSAP.receive { repeat; } [] T.timeout { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9ed08160bf5413e3a30d6e90eb947d4d799e1058 Gerrit-Change-Number: 38396 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: f_TC_attach_timeout_after_pdp_act: allow authentication
by lynxis lazus 09 Dec '24

09 Dec '24

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38399?usp=email ) ( 7 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: SGSN: f_TC_attach_timeout_after_pdp_act: allow authentication ...................................................................... SGSN: f_TC_attach_timeout_after_pdp_act: allow authentication While testing, allow the SGSN to authenticate the UE. The new VLR code will authenticate the UE, while the old code doesn't. Change-Id: I11c628ecebbe7c4c1b2c28e63133a33cfc171e12 --- M sgsn/SGSN_Tests.ttcn 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index 0f5da29..116c03d 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -604,7 +604,7 @@ f_TC_attach(id); f_pdp_ctx_act(apars); - /* Now, try another GPRS attach procedure. Note that osmo-sgsn does not require + /* Now, try another GPRS attach procedure. Note that older osmo-sgsn skip a required * authentication for the second GMM ATTACH REQUEST, so we expect GSUP UPDATE * LOCATION REQUEST and optionally a GMM IDENTITY REQUEST (IMEI). */ attach_req := ts_GMM_ATTACH_REQ(f_mi_get_lv(), rai, false, false, omit, omit); @@ -612,6 +612,7 @@ T.start(1.0); alt { + [] as_gmm_auth(ran_index := ran_index) { repeat; }; [] as_gmm_gsup_lu_isd(); [] as_mm_identity(ran_index); [] as_xid(apars, ran_index); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38399?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I11c628ecebbe7c4c1b2c28e63133a33cfc171e12 Gerrit-Change-Number: 38399 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: f_TC_attach_rau: do a periodic RA update instead of RA change
by lynxis lazus 09 Dec '24

09 Dec '24

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38400?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: SGSN: f_TC_attach_rau: do a periodic RA update instead of RA change ...................................................................... SGSN: f_TC_attach_rau: do a periodic RA update instead of RA change After an attach, the periodic RA would be the correct. Change-Id: Ic33687c55915d883b6d9a9a0d640a11588e1d1a0 --- M sgsn/SGSN_Tests.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index 116c03d..aca2979 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -904,9 +904,9 @@ /* first perform regular attach */ f_TC_attach(id); - f_routing_area_update(g_pars.ra); - + f_routing_area_update(g_pars.ra, GPRS_UPD_T_PERIODIC, Tval := 10.0); } + testcase TC_attach_rau() runs on test_CT { var BSSGP_ConnHdlr vc_conn; f_init(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38400?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic33687c55915d883b6d9a9a0d640a11588e1d1a0 Gerrit-Change-Number: 38400 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: TC_attach_auth_id_timeout: set TMSI to provoke a ID Request
by lynxis lazus 09 Dec '24

09 Dec '24

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38401?usp=email ) ( 7 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: SGSN: TC_attach_auth_id_timeout: set TMSI to provoke a ID Request ...................................................................... SGSN: TC_attach_auth_id_timeout: set TMSI to provoke a ID Request This test case simulates a MS which ignores Identity Requests. To ensure the SGSN will ask for the IMSI, do an Attach Request with id TMSI. Later this ID Request (type IMSI) will be ignored and the test case expect a Attach Reject. Change-Id: I5a860582aa57ebc073e4c33f3f2f8884e360edef --- M sgsn/SGSN_Tests.ttcn 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index aca2979..1bb8576 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -661,6 +661,9 @@ private function f_TC_attach_auth_id_timeout(charstring id) runs on BSSGP_ConnHdlr { var RoutingAreaIdentificationV old_ra := f_random_RAI(); + /* Attach via P-TMSI to force Id Request (IMSI) which times out */ + g_pars.p_tmsi := 'c000004a'O; + f_send_l3(ts_GMM_ATTACH_REQ(f_mi_get_lv(), old_ra, false, false, omit, omit)); alt { [] BSSGP[0].receive(tr_GMM_ID_REQ(?)) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38401?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5a860582aa57ebc073e4c33f3f2f8884e360edef Gerrit-Change-Number: 38401 Gerrit-PatchSet: 12 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-abis[master]: input: Move ipaccess_bts_handle_ccm() ipaccess.c -> ipa.c
by pespin 09 Dec '24

09 Dec '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39041?usp=email ) Change subject: input: Move ipaccess_bts_handle_ccm() ipaccess.c -> ipa.c ...................................................................... input: Move ipaccess_bts_handle_ccm() ipaccess.c -> ipa.c This function is no longer used in ipaccess.c, and actually relates to IPA generic code which still exists in ipa.c, hence move it there. Moreover, the function is declared in the "abis/ipa.h" public header, not the "abis/ipaccess.h" header (which was already deprecated). Once moved and it becomes clear this is not used in the e1_line ipaccess driver and hence the "if (line) { ... ipa pong ... } code branch in the function can be dropped, since it won't ever be executed. Change-Id: I2378227515315e7fc0bd0844a1dc4f85e54b455a --- M src/input/ipa.c M src/input/ipaccess.c 2 files changed, 66 insertions(+), 72 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/input/ipa.c b/src/input/ipa.c index f49d0dc..073c1ff 100644 --- a/src/input/ipa.c +++ b/src/input/ipa.c @@ -582,3 +582,69 @@ msgb_enqueue(&conn->tx_queue, msg); osmo_fd_write_enable(&conn->ofd); } + +/* Kept for bacward compat since this is a public API. Will be deprecated at + * some point withthe rest of ipa_client_conn. */ +int ipaccess_bts_handle_ccm(struct ipa_client_conn *link, + struct ipaccess_unit *dev, struct msgb *msg) +{ + struct ipaccess_head *hh = (struct ipaccess_head *) msg->data; + + /* special handling for IPA CCM. */ + if (hh->proto != IPAC_PROTO_IPACCESS) + return 0; + + int ret = 0; + uint8_t *data = msgb_l2(msg); + int len = msgb_l2len(msg); + OSMO_ASSERT(len > 0); + uint8_t msg_type = *data; + + /* ping, pong and acknowledgment cases. */ + ret = ipa_ccm_rcvmsg_bts_base(msg, link->ofd); + if (ret < 0) + goto err; + + /* this is a request for identification from the BSC. */ + if (msg_type == IPAC_MSGT_ID_GET) { + struct msgb *rmsg; + /* The ipaccess_unit dev holds generic identity for the whole + * line, hence no trx_id. Patch ipaccess_unit during call to + * ipa_ccm_make_id_resp_from_req() to identify this TRX: */ + int store_trx_nr = dev->trx_id; + if (link->ofd->priv_nr >= E1INP_SIGN_RSL) + dev->trx_id = link->ofd->priv_nr - E1INP_SIGN_RSL; + else + dev->trx_id = 0; + LOGP(DLINP, LOGL_NOTICE, "received ID_GET for unit ID %u/%u/%u\n", + dev->site_id, dev->bts_id, dev->trx_id); + rmsg = ipa_ccm_make_id_resp_from_req(dev, data + 1, len - 1); + dev->trx_id = store_trx_nr; + if (!rmsg) { + LOGP(DLINP, LOGL_ERROR, "Failed parsing ID_GET message.\n"); + goto err; + } + + ret = ipa_send(link->ofd->fd, rmsg->data, rmsg->len); + if (ret != rmsg->len) { + LOGP(DLINP, LOGL_ERROR, "cannot send ID_RESP message. Reason: %s\n", + strerror(errno)); + msgb_free(rmsg); + goto err; + } + msgb_free(rmsg); + + /* send ID_ACK. */ + ret = ipa_ccm_send_id_ack(link->ofd->fd); + if (ret <= 0) { + LOGP(DLINP, LOGL_ERROR, "cannot send ID_ACK message. Reason: %s\n", + strerror(errno)); + goto err; + } + } + return 1; + +err: + ipa_client_conn_close(link); + return -1; +} diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 6110004..c47c6fb 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -772,78 +772,6 @@ return 0; } -int ipaccess_bts_handle_ccm(struct ipa_client_conn *link, - struct ipaccess_unit *dev, struct msgb *msg) -{ - struct ipaccess_head *hh = (struct ipaccess_head *) msg->data; - - /* special handling for IPA CCM. */ - if (hh->proto != IPAC_PROTO_IPACCESS) - return 0; - - int ret = 0; - uint8_t *data = msgb_l2(msg); - int len = msgb_l2len(msg); - OSMO_ASSERT(len > 0); - uint8_t msg_type = *data; - /* line might not exist if != bsc||bts */ - struct e1inp_line *line = link->line; - - /* peek the pong for our keepalive fsm */ - if (line && msg_type == IPAC_MSGT_PONG) { - struct osmo_fsm_inst *ka_fsm = ipaccess_line_ts(link->ofd, line)->driver.ipaccess.ka_fsm; - ipa_keepalive_fsm_pong_received(ka_fsm); - } - - /* ping, pong and acknowledgment cases. */ - ret = ipa_ccm_rcvmsg_bts_base(msg, link->ofd); - if (ret < 0) - goto err; - - /* this is a request for identification from the BSC. */ - if (msg_type == IPAC_MSGT_ID_GET) { - struct msgb *rmsg; - /* The ipaccess_unit dev holds generic identity for the whole - * line, hence no trx_id. Patch ipaccess_unit during call to - * ipa_ccm_make_id_resp_from_req() to identify this TRX: */ - int store_trx_nr = dev->trx_id; - if (link->ofd->priv_nr >= E1INP_SIGN_RSL) - dev->trx_id = link->ofd->priv_nr - E1INP_SIGN_RSL; - else - dev->trx_id = 0; - LOGP(DLINP, LOGL_NOTICE, "received ID_GET for unit ID %u/%u/%u\n", - dev->site_id, dev->bts_id, dev->trx_id); - rmsg = ipa_ccm_make_id_resp_from_req(dev, data + 1, len - 1); - dev->trx_id = store_trx_nr; - if (!rmsg) { - LOGP(DLINP, LOGL_ERROR, "Failed parsing ID_GET message.\n"); - goto err; - } - - ret = ipa_send(link->ofd->fd, rmsg->data, rmsg->len); - if (ret != rmsg->len) { - LOGP(DLINP, LOGL_ERROR, "cannot send ID_RESP message. Reason: %s\n", - strerror(errno)); - msgb_free(rmsg); - goto err; - } - msgb_free(rmsg); - - /* send ID_ACK. */ - ret = ipa_ccm_send_id_ack(link->ofd->fd); - if (ret <= 0) { - LOGP(DLINP, LOGL_ERROR, "cannot send ID_ACK message. Reason: %s\n", - strerror(errno)); - goto err; - } - } - return 1; - -err: - ipa_client_conn_close(link); - return -1; -} - static struct msgb *ipa_bts_id_ack(void) { struct msgb *nmsg2; -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39041?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I2378227515315e7fc0bd0844a1dc4f85e54b455a Gerrit-Change-Number: 39041 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-abis[master]: input: Move ipaccess_bts_handle_ccm() ipaccess.c -> ipa.c
by pespin 09 Dec '24

09 Dec '24

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39041?usp=email ) Change subject: input: Move ipaccess_bts_handle_ccm() ipaccess.c -> ipa.c ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39041?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I2378227515315e7fc0bd0844a1dc4f85e54b455a Gerrit-Change-Number: 39041 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Dec 2024 11:27:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-abis[master]: input: Move ipaccess_bts_handle_ccm() ipaccess.c -> ipa.c
by osmith 09 Dec '24

09 Dec '24

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39041?usp=email ) Change subject: input: Move ipaccess_bts_handle_ccm() ipaccess.c -> ipa.c ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39041?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I2378227515315e7fc0bd0844a1dc4f85e54b455a Gerrit-Change-Number: 39041 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Dec 2024 11:23:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmo-netif[master]: ipa: Add osmo_ipa_ka_fsm_inst APIs
by laforge 09 Dec '24

09 Dec '24

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39035?usp=email ) Change subject: ipa: Add osmo_ipa_ka_fsm_inst APIs ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39035?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5c36e06e0dc29ec4679b20ad6c426f051b659acd Gerrit-Change-Number: 39035 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Dec 2024 11:13:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: ara_m fix export of AID-REF-DO (empty)
by laforge 09 Dec '24

09 Dec '24

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39057?usp=email ) Change subject: ara_m fix export of AID-REF-DO (empty) ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39057?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I771d5e860b12215280e3d0a8c314ce843fe0d6a2 Gerrit-Change-Number: 39057 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Dec 2024 11:11:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bsc[osmith/1.12.4]: ipaccess_line_update: drop set_priority and set_ip_dscp
by osmith 09 Dec '24

09 Dec '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39058?usp=email ) Change subject: ipaccess_line_update: drop set_priority and set_ip_dscp ...................................................................... ipaccess_line_update: drop set_priority and set_ip_dscp Do not run osmo_stream_cli_set_priority() and osmo_stream_cli_set_ip_dscp() in ipaccess_line_update(). These functions are not available yet in libosmo-netif 1.5.x and cause the build to fail. g_e1inp_ipaccess_config_pars.oml.dscp and g_e1inp_ipaccess_config_pars.oml.priority are not set anyway, so this makes no functional difference. Suggested-by: Pau Espin Pedrol <pespin(a)sysmocom.de> Change-Id: Ic46af94db8e0d821c5ca559e96c72d5041d32823 --- M src/ipaccess/ipaccess-config-e1-driver.c 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/ipaccess/ipaccess-config-e1-driver.c b/src/ipaccess/ipaccess-config-e1-driver.c index 71e70e1..48992c5 100644 --- a/src/ipaccess/ipaccess-config-e1-driver.c +++ b/src/ipaccess/ipaccess-config-e1-driver.c @@ -423,8 +423,6 @@ osmo_stream_cli_set_port(cli, IPACCESS_BTS_LISTEN_OML_PORT); osmo_stream_cli_set_proto(cli, IPPROTO_TCP); osmo_stream_cli_set_nodelay(cli, true); - osmo_stream_cli_set_priority(cli, g_e1inp_ipaccess_config_pars.oml.dscp); - osmo_stream_cli_set_ip_dscp(cli, g_e1inp_ipaccess_config_pars.oml.priority); /* Reconnect is handled by upper layers: */ osmo_stream_cli_set_reconnect_timeout(cli, -1); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39058?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: osmith/1.12.4 Gerrit-Change-Id: Ic46af94db8e0d821c5ca559e96c72d5041d32823 Gerrit-Change-Number: 39058 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log