- gerrit-log - lists.osmocom.org

[M] Change in osmo-upf[master]: Bump version: 0.1.1.112-9c90 → 0.2.0
by pespin 11 Dec '24

11 Dec '24

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-upf/+/39125?usp=email ) Change subject: Bump version: 0.1.1.112-9c90 → 0.2.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39125?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I772edbd17fcac0da597c30eecefa54f9fd8c3ed3 Gerrit-Change-Number: 39125 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Dec 2024 16:13:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-upf[master]: Bump version: 0.1.1.112-9c90 → 0.2.0
by laforge 11 Dec '24

11 Dec '24

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-upf/+/39125?usp=email ) Change subject: Bump version: 0.1.1.112-9c90 → 0.2.0 ...................................................................... Patch Set 1: (1 comment) File configure.ac: https://gerrit.osmocom.org/c/osmo-upf/+/39125/comment/1c3062fc_b226cfcf?usp… : PS1, Line 40: 10 do we need those large jumps? I didn't see any TODO-RELEASE items requiring any update of libosmocore etc? -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39125?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I772edbd17fcac0da597c30eecefa54f9fd8c3ed3 Gerrit-Change-Number: 39125 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Dec 2024 16:07:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ttcn3-hacks[master]: sccp: Let some time for SCCP RLC to reach IUT before finishing test
by pespin 11 Dec '24

11 Dec '24

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39126?usp=email ) Change subject: sccp: Let some time for SCCP RLC to reach IUT before finishing test ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Related to failures spotted in: https://jenkins.osmocom.org/jenkins/job/ttcn3-sccp-test/1804/ @laforge@osmocom.org since you know better about the Layer Manager in there, please have a quick look at whether it is expected that in sccp_demo_user the release of the only SCTP connection (and hence only used ASP) is not automatically releasing the SCCP-SCOC object, which is at DISCONN_PEND state at the time. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39126?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id7d5970bb0fe0e42fedcb56fe4a738a92ddd5bbf Gerrit-Change-Number: 39126 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 11 Dec 2024 16:05:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ttcn3-hacks[master]: sccp: Let some time for SCCP RLC to reach IUT before finishing test
by pespin 11 Dec '24

11 Dec '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39126?usp=email ) Change subject: sccp: Let some time for SCCP RLC to reach IUT before finishing test ...................................................................... sccp: Let some time for SCCP RLC to reach IUT before finishing test Otherwise tear down of the test component immediatelly afterwards creates a race condition where sometimes the RLC message is not sent before closing the socket. As a result, the SCCP-SCOC stays in DISCONN_PEND until T(rel) fires a while afterwards, generating a new RLSD in a follow-up test, disrupting expectancies of that unrelated test. Since sccp_demo_user doesn't implement a Layer Manager, the recv() 0 from the socket doesn't automatically tear down the SCCP conn, since it could have several ASPs: """ 0: asp-asp-srv-client: ss7_asp_xua_srv_conn_rx_cb(): sctp_recvmsg() returned 0 (flags=0x80) ... asp-srv-client: connection closed XUA_ASP(asp-srv-client){ASP_ACTIVE}: Received Event SCTP-COMM_DOWN.ind XUA_ASP(asp-srv-client){ASP_ACTIVE}: state_chg to ASP_DOWN XUA_AS(as-srv-client){AS_ACTIVE}: Received Event ASPAS-ASP_DOWN.ind XUA_AS(as-srv-client){AS_ACTIVE}: state_chg to AS_PENDING Delivering N-PCSTATE.indication to SCCP User 'SCCP Management' Ignoring SCCP user primitive N-PCSTATE.indication [Here same 2 lines for SCCP User 'refuser', 'echo', 'callback', 'test_client_vty'] XUA_ASP(asp-srv-client){ASP_DOWN}: No Layer Manager, dropping M-ASP_DOWN.indication XUA_ASP(asp-srv-client){ASP_DOWN}: No Layer Manager, dropping M-SCTP_RELEASE.indication """ Change-Id: Id7d5970bb0fe0e42fedcb56fe4a738a92ddd5bbf --- M sccp/SCCP_Tests_RAW.ttcn 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/26/39126/1 diff --git a/sccp/SCCP_Tests_RAW.ttcn b/sccp/SCCP_Tests_RAW.ttcn index f1f602c..5d5b0ab 100644 --- a/sccp/SCCP_Tests_RAW.ttcn +++ b/sccp/SCCP_Tests_RAW.ttcn @@ -252,6 +252,8 @@ log("Waiting for RLSD"); f_exp_sccp(tr_SCCP_RLSD(remote_lref, g_own_lref, hex2int('0D'H))); /* Cause: Expiration of Rx Inactivity Timer */ f_send_sccp(ts_SCCP_RLC(g_own_lref, remote_lref)); + /* Let some time for peer to receive the RLC */ + f_sleep(1.0); setverdict(pass); } @@ -325,6 +327,8 @@ self.stop; } } + /* Let some time for peer to receive the RLC */ + f_sleep(1.0); } private function f_tx_xudt_exp(SCCP_PAR_Address calling, SCCP_PAR_Address called, octetstring data) runs on SCCP_Test_RAW_CT { @@ -521,7 +525,8 @@ var template (present) integer cause := ?; f_exp_sccp(tr_SCCP_RLSD(remote_lref, g_own_lref, cause)); f_send_sccp(ts_SCCP_RLC(g_own_lref, remote_lref)); - + /* Let some time for peer to receive the RLC */ + f_sleep(1.0); setverdict(pass); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39126?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id7d5970bb0fe0e42fedcb56fe4a738a92ddd5bbf Gerrit-Change-Number: 39126 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-upf[master]: Bump version: 0.1.1.112-9c90 → 0.2.0
by osmith 11 Dec '24

11 Dec '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/39125?usp=email ) Change subject: Bump version: 0.1.1.112-9c90 → 0.2.0 ...................................................................... Bump version: 0.1.1.112-9c90 → 0.2.0 Change-Id: I772edbd17fcac0da597c30eecefa54f9fd8c3ed3 --- M TODO-RELEASE M configure.ac M debian/changelog M debian/control 4 files changed, 142 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/25/39125/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index d0852fc..0ed7189 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -1,9 +1,9 @@ # When cleaning up this file: bump API version in corresponding Makefile.am and rename corresponding debian/lib*.install -# according to https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info… -# In short: +# according to https://osmocom.org/projects/cellular-infrastructure/wiki/Make_a_new_release +# In short: https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info… # LIBVERSION=c:r:a # If the library source code has changed at all since the last update, then increment revision: c:r + 1:a. -# If any interfaces have been added, removed, or changed since the last update: c + 1:0:0. +# If any interfaces have been added, removed, or changed since the last update: c + 1:0:a. # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. -#library what description / commit summary line +#library what description / commit summary line diff --git a/configure.ac b/configure.ac index 5181131..de2f1ae 100644 --- a/configure.ac +++ b/configure.ac @@ -36,11 +36,11 @@ PKG_PROG_PKG_CONFIG([0.20]) dnl checks for libraries -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) -PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) -PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.6.0) -PKG_CHECK_MODULES(LIBOSMOPFCP, libosmo-pfcp >= 0.1.0) -PKG_CHECK_MODULES(LIBGTPNL, libgtpnl >= 1.2.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.10.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.10.0) +PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.10.0) +PKG_CHECK_MODULES(LIBOSMOPFCP, libosmo-pfcp >= 0.4.0) +PKG_CHECK_MODULES(LIBGTPNL, libgtpnl >= 1.3.0) PKG_CHECK_MODULES(LIBNFTABLES, libnftables >= 1.0.2) dnl checks for header files diff --git a/debian/changelog b/debian/changelog index c59f3aa..e8b8d87 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,133 @@ +osmo-upf (0.2.0) unstable; urgency=medium + + [ Neels Hofmeyr ] + * improve manual: PFCP and GTP interfaces + * example cfg: tweak logging + + [ Oliver Smith ] + * osmo_pfcp_tool: fix osmo_pfcp_tool_copyright error + * debian: add osmo-pfcp-tool to osmo-upf package + * Run struct_endianness.py + * contrib/jenkins: build nftables without python + * contrib/jenkins: clone netfilter repos with https + * contrib/jenkins: netfilter: use PARALLEL_MAKE + * debian: set compat level to 10 + * systemd: depend on networking-online.target + * .deb/.rpm: various fixes related to non-root + * contrib/systemd: AmbientCapabilities=CAP_NET_ADMIN + * contrib: remove rpm spec file + * debian/postinst: add checks, be verbose + + [ Neels Janosch Hofmeyr ] + * Allow running without a GTP dev + * drop charts/, duplicated from libosmo-pfcp.git + * manual: add/fix running.adoc + * manual: add 'Configure Primary Links' + * vty doc: indicate default nft table name + * silence misleading error: "HEARTBEAT_REQ: Unknown message type" + * drop unused enum up_session_kind + * tests/upf.vty: add some missing nodes to the test + * VTY: rename 'gtp' to 'tunend' + * VTY: rename 'nft' to 'tunmap' + * osmo-pfcp-tool VTY: rename 'endecaps' to 'tunend' + * cosmetic: in code, rename 'endecaps' to 'tunend' + * cosmetic: rename upf_gtp_tun to upf_gtp_tunend + * drop unused upf_gtp_dev_is_tunnel_active() + * cosmetic: rename upf_gtp_dev_tunnel_* to upf_gtp_dev_tunend_* + * vty: revert rename of 'show gtp' + * VTY: show gtp: still list tunmap if no tunend device is open + * up_gtp_action_to_str_buf(): always print PDR IDs + * use osmo_pfcp_ie_outer_header_creation_to_str_buf() + * gtpu_echo: do not osmo_fd_register twice + * VTY 'show gtp': more accurately identify local/remote IP + * fix access/core mixup of PDR IDs / tunmap FAR + * clarify comments and naming around PDR+FAR classification + * tunmap: choose local GTP addr by Network Instance IEs + * log: add missing sep in far_to_str + * fix PFCP Session Mod: Update FAR + * in GTP actions, also store local GTP addrs + * nft: rename addr to addr_remote, add addr_local + * nft: incoming GTP-U: match on local IP, not remote IP + * nft: rewrite source IP in outgoing GTP-U + * nft: log nft rulesets on debug log + * nft: end each rule in semicolon + * nft: ensure to assign rule id only once + * GTP,UE addrs in osmo_sockaddr: assert( port == 0 ) + * nft: allow to get the ruleset string without running + * vty: add: show nft-rule tunmap example + * add cfg: tunmap / nft-rule append + * nft: append 'accept' to each rule + * tunend: choose local GTP addr by Network Instance IEs + * manual: use 'tunend' and 'tunmap' + * manual: explain new netinst cfg + * manual: tweak 'running' for new netinst feature + * manual: add charts explaining tunend and tunmap + * manual: some tweaks in overview + * manual: fix broken reference to netinst section + * fix copy-paste bug in up_endpoint.c + * fix deprecation: use telnet_init_default() + * check rc of osmo_use_count_get_put() + * error log: fix msg for gtp_del_tunnel() failure + * fix various crashes on osmo_pfcp_endpoint_tx() err handling + * osmo-pfcp-tool: avoid stale pointers on msg copy + * fix some PFCP peer,session error handling paths + * drop unused function up_peer_tx + * move GTP port definitions to upf.h + * deprecate cfg 'nft rule tunmap append' + * tunmap: prep new nft ruleset: log only mapping id + * tunmap: refactor nft ruleset: fix "martians" and "1024" + * tunmap: ensure nft table is removed on program exit + * osmo_pfcp_tool: make usable again + * minor api doc + * cosmetic: simplify naming: struct upf_tunmap, struct upf_tunend + * cosmetic: reduce dup in tunnel struct definitions + * cosmetic: rename g_upf->gtp to tunend, ->nft to tunmap + * move next_teid from up_endpoint to g_upf + * cosmetic: rename next_seid to next_up_seid + * build: drop LIBOSMO_GTLV + * build: add libupf.la (noinst) + * add unique_ids_test.c + * tunmap: ensure assigned chain_id is unused + * cosmetic: clarify session active / partially active semantics + * unique_ids_test.c: fix coverity ASSERT_SIDE_EFFECT + * manual: fix typo in running.adoc + * manual: 'Running': flatten section depths a bit + * manual: 'Running': tweak, mention 'tunmap' and 'tunend' + * manual: 'Running': tweak word, fix ws at line end + * manual: explain GTP Echo workaround for tunmap + * manual: explain IP forwarding + * tunmap: always set GTP-U source port to 2152 when forwarding + * vty doc fix + * pfcp-tool: fix extra newline in vty_out + * fix msgb memleak on GTP echo response + * fix EXTRA_DIST for vty test scripts + * drop unreachable statement + * contrib/pfcp-tool-scripts: adjust tunend_session_est.vty and upf cfg to match up + * upf gtp-u echo: improve loging + * upf gtp-u echo: rx Echo Response messages + * pfcp-tool: always use specific PDR ids for access and core + * nft: batch nftables commands + * osmo-upf: add VTY 'gtp-echo' command + + [ Max ] + * Set working directory in systemd service file + * ctrl: take both address and port from vty config + * .deb/.rpm: add osmocom user during package install + + [ Vadim Yanitskiy ] + * update git URLs (git -> https; gitea) + * contrib/jenkins.sh: clone libnftnl and libnftables via git:// + * copyright: fix typo: sysmocom s/s.m.f.c./s.f.m.c./ GmbH + + [ arehbein ] + * osmo-pfcp-tool: Fix call to strerror + * up_session: Silence coverity warning + + [ Andreas Eversberg ] + * Use uniform log format for default config files + + -- Oliver Smith <osmith(a)sysmocom.de> Wed, 11 Dec 2024 16:37:06 +0100 + osmo-upf (0.1.1) unstable; urgency=medium [ Vadim Yanitskiy ] diff --git a/debian/control b/debian/control index 5c26faf..1dbf8d5 100644 --- a/debian/control +++ b/debian/control @@ -12,10 +12,10 @@ pkg-config, python3-minimal, libtalloc-dev, - libgtpnl-dev (>= 1.2.0), + libgtpnl-dev (>= 1.3.0), libnftables-dev (>= 1.0.2), - libosmocore-dev (>= 1.6.0), - libosmo-pfcp-dev (>= 0.1.0), + libosmocore-dev (>= 1.10.0), + libosmo-pfcp-dev (>= 0.4.0), osmo-gsm-manuals-dev (>= 1.2.0) Standards-Version: 3.9.8 Vcs-Git: https://gitea.osmocom.org/cellular-infrastructure/osmo-upf -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39125?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I772edbd17fcac0da597c30eecefa54f9fd8c3ed3 Gerrit-Change-Number: 39125 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in ...osmo-s1gw[master]: erab_fsm: session_modify(): split PFCP PDU handling
by pespin 11 Dec '24

11 Dec '24

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39124?usp=email ) Change subject: erab_fsm: session_modify(): split PFCP PDU handling ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39124?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I04fec627300fa9240e6b2bf22ff9ae08dd4c0f0d Gerrit-Change-Number: 39124 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Dec 2024 15:27:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: handle_ies(): pass IEI path to handle_ie()
by pespin 11 Dec '24

11 Dec '24

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39113?usp=email ) Change subject: s1ap_proxy: handle_ies(): pass IEI path to handle_ie() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39113?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I35528a91f7dbf321ad1a0811f1bbcdfb529d3530 Gerrit-Change-Number: 39113 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Dec 2024 15:25:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: Gb/NS: SNS: SNS Ack don't add List of IP4/6 Elements on success.
by lynxis lazus 11 Dec '24

11 Dec '24

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/39062?usp=email ) Change subject: Gb/NS: SNS: SNS Ack don't add List of IP4/6 Elements on success. ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/39062/comment/0262c9f0_3bec5e36?… : PS1, Line 7: Gb/NS: SNS: SNS Ack don't add List of IP4/6 Elements on success. > why? I'll improve the commit message more. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39062?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If99b204a9d754323e53746b31bc13df53a653b7d Gerrit-Change-Number: 39062 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Dec 2024 15:18:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: handle_ies(): pass IEI path to handle_ie()
by fixeria 11 Dec '24

11 Dec '24

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39113?usp=email ) Change subject: s1ap_proxy: handle_ies(): pass IEI path to handle_ie() ...................................................................... Patch Set 2: (1 comment) File src/s1ap_proxy.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39113/comment/5bd0d3a8_549b… : PS1, Line 395: when P :: [s1ap_ie_id()], %% Path > Acknowledged Done -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39113?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I35528a91f7dbf321ad1a0811f1bbcdfb529d3530 Gerrit-Change-Number: 39113 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Dec 2024 15:06:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in ...osmo-s1gw[master]: erab_fsm: session_modify(): split PFCP PDU handling
by fixeria 11 Dec '24

11 Dec '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39124?usp=email ) Change subject: erab_fsm: session_modify(): split PFCP PDU handling ...................................................................... erab_fsm: session_modify(): split PFCP PDU handling This patch prepares for a follow-up change adding the MME-initiated E-RAB modification logic. Handle the successful modification scenario in a separate function, which will be extended further soon. Change-Id: I04fec627300fa9240e6b2bf22ff9ae08dd4c0f0d --- M src/erab_fsm.erl 1 file changed, 14 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/24/39124/1 diff --git a/src/erab_fsm.erl b/src/erab_fsm.erl index a479cea..b249cd4 100644 --- a/src/erab_fsm.erl +++ b/src/erab_fsm.erl @@ -277,24 +277,23 @@ {shutdown, timeout}, {reply, From, {error, {timeout, ?FUNCTION_NAME}}}}; -session_modify(info, #pfcp{} = PDU, +session_modify(info, #pfcp{type = session_modification_response, + seid = SEID_Rsp, %% matches F-SEID we sent in the ESTABLISH Req + ie = #{pfcp_cause := 'Request accepted'}}, #erab_state{from = From, seid_loc = SEID_Rsp, c2u = C2U} = S) -> - case PDU of - #pfcp{type = session_modification_response, - seid = SEID_Rsp, %% matches F-SEID we sent in the ESTABLISH Req - ie = #{pfcp_cause := 'Request accepted'}} -> - ?LOG_DEBUG("PFCP session modified"), - {next_state, erab_setup, - S#erab_state{from = undefined}, - [{reply, From, {ok, C2U}}]}; - _ -> - ?LOG_ERROR("Rx unexpected PFCP PDU: ~p", [PDU]), - {stop_and_reply, - {shutdown, unexp_pdu}, - {reply, From, {error, {unexp_pdu, ?FUNCTION_NAME}}}} - end; + ?LOG_DEBUG("PFCP session modified"), + {next_state, erab_setup, + S#erab_state{from = undefined}, + [{reply, From, {ok, C2U}}]}; + +session_modify(info, #pfcp{} = PDU, + #erab_state{from = From}) -> + ?LOG_ERROR("Rx unexpected PFCP PDU: ~p", [PDU]), + {stop_and_reply, + {shutdown, unexp_pdu}, + {reply, From, {error, {unexp_pdu, ?FUNCTION_NAME}}}}; session_modify(Event, EventData, S) -> handle_event(?FUNCTION_NAME, Event, EventData, S). -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39124?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I04fec627300fa9240e6b2bf22ff9ae08dd4c0f0d Gerrit-Change-Number: 39124 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log