- gerrit-log - lists.osmocom.org

[XS] Change in osmo-remsim[master]: rspro_client_fsm: Fix missing return
by pespin 11 Dec '24

11 Dec '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39131?usp=email ) Change subject: rspro_client_fsm: Fix missing return ...................................................................... rspro_client_fsm: Fix missing return Recent commit added error return code paths through goto labels at the end, but forgot to add a return statement to avoid running onto them during normal code flow. Fixes: 8cfe1d808a57a0a877e934e0435651a6b792db8d Change-Id: I813432d42135b5f3f086ad93bd63bfa39f4becbc --- M src/rspro_client_fsm.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c index 29e0287..6a48ce4 100644 --- a/src/rspro_client_fsm.c +++ b/src/rspro_client_fsm.c @@ -493,6 +493,7 @@ /* FIXME: retry? Timer? Abort? */ goto err_free_ka_fi; } + return; err_free_ka_fi: osmo_ipa_ka_fsm_free(srvc->ka_fi); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39131?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I813432d42135b5f3f086ad93bd63bfa39f4becbc Gerrit-Change-Number: 39131 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-remsim[master]: rspro_client_fsm: Fix missing return
by pespin 11 Dec '24

11 Dec '24

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39131?usp=email ) Change subject: rspro_client_fsm: Fix missing return ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Merging this to get bankd ttcn3 tests to work again. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39131?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I813432d42135b5f3f086ad93bd63bfa39f4becbc Gerrit-Change-Number: 39131 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Dec 2024 17:49:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-remsim[master]: rspro_client_fsm: Fix missing return
by pespin 11 Dec '24

11 Dec '24

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39131?usp=email ) Change subject: rspro_client_fsm: Fix missing return ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39131?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I813432d42135b5f3f086ad93bd63bfa39f4becbc Gerrit-Change-Number: 39131 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Dec 2024 17:48:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-remsim[master]: rspro_client_fsm: Fix missing return
by pespin 11 Dec '24

11 Dec '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39131?usp=email ) Change subject: rspro_client_fsm: Fix missing return ...................................................................... rspro_client_fsm: Fix missing return Recent commit added error return code paths through goto labels at the end, but forgot to add a return statement to avoid running onto them during normal code flow. Fixes: 8cfe1d808a57a0a877e934e0435651a6b792db8d Change-Id: I813432d42135b5f3f086ad93bd63bfa39f4becbc --- M src/rspro_client_fsm.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/31/39131/1 diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c index 29e0287..6a48ce4 100644 --- a/src/rspro_client_fsm.c +++ b/src/rspro_client_fsm.c @@ -493,6 +493,7 @@ /* FIXME: retry? Timer? Abort? */ goto err_free_ka_fi; } + return; err_free_ka_fi: osmo_ipa_ka_fsm_free(srvc->ka_fi); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39131?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I813432d42135b5f3f086ad93bd63bfa39f4becbc Gerrit-Change-Number: 39131 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-remsim[master]: cosmetic: rspro_client_fsm: Document event handled in all_state
by pespin 11 Dec '24

11 Dec '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39130?usp=email ) Change subject: cosmetic: rspro_client_fsm: Document event handled in all_state ...................................................................... cosmetic: rspro_client_fsm: Document event handled in all_state Change-Id: Id03be7d67bb2530bbefb2a886a175f9a4a4d3cd8 --- M src/rspro_client_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/30/39130/1 diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c index 29e0287..868d2ab 100644 --- a/src/rspro_client_fsm.c +++ b/src/rspro_client_fsm.c @@ -321,7 +321,7 @@ static void srvc_st_init(struct osmo_fsm_inst *fi, uint32_t event, void *data) { switch (event) { - case SRVC_E_ESTABLISH: + case SRVC_E_ESTABLISH: /* Handled in all_state */ default: OSMO_ASSERT(0); } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39130?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id03be7d67bb2530bbefb2a886a175f9a4a4d3cd8 Gerrit-Change-Number: 39130 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in docker-playground[master]: ttcn3-remsim: Enable debug output of bankd
by pespin 11 Dec '24

11 Dec '24

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/39129?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: ttcn3-remsim: Enable debug output of bankd ...................................................................... ttcn3-remsim: Enable debug output of bankd Change-Id: I8cd9d32b2612390bde31fa2814a51ecda20f920e --- M ttcn3-remsim-test/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/29/39129/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39129?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I8cd9d32b2612390bde31fa2814a51ecda20f920e Gerrit-Change-Number: 39129 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[XS] Change in docker-playground[master]: ttcn3-remsim: Enable debug output of bankd
by pespin 11 Dec '24

11 Dec '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/39129?usp=email ) Change subject: ttcn3-remsim: Enable debug output of bankd ...................................................................... ttcn3-remsim: Enable debug output of bankd Change-Id: I8cd9d32b2612390bde31fa2814a51ecda20f920e --- M ttcn3-remsim-test/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/29/39129/1 diff --git a/ttcn3-remsim-test/jenkins.sh b/ttcn3-remsim-test/jenkins.sh index 281b00d..31c37c2 100755 --- a/ttcn3-remsim-test/jenkins.sh +++ b/ttcn3-remsim-test/jenkins.sh @@ -32,6 +32,7 @@ $REPO_USER/osmo-remsim-$IMAGE_SUFFIX \ /bin/sh -c "pcscd; \ osmo-remsim-bankd \ + -d DMAIN,1:DST2,1:DRSPRO,1:DREST,1:DSLOTMAP,1:DBANKDW,1:DGSMTAP,1 \ -i $SUB4_PREFIX.$SUBNET.10 \ >/data/osmo-remsim-bankd.log 2>&1" } -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39129?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I8cd9d32b2612390bde31fa2814a51ecda20f920e Gerrit-Change-Number: 39129 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-remsim[master]: bankd: Fix typo in fprintf string output
by pespin 11 Dec '24

11 Dec '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39128?usp=email ) Change subject: bankd: Fix typo in fprintf string output ...................................................................... bankd: Fix typo in fprintf string output Change-Id: I8115c01c0a4af9919543cc167c4de54caaed3f16 --- M src/bankd/bankd_main.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/28/39128/1 diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index c406415..cd68073 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -448,7 +448,7 @@ if (g_bankd->cfg.gsmtap_host) { rc = bankd_gsmtap_init(g_bankd->cfg.gsmtap_host); if (rc < 0) { - fprintf(stderr, "Unable to open GSMTAP"); + fprintf(stderr, "Unable to open GSMTAP\n"); exit(1); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39128?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I8115c01c0a4af9919543cc167c4de54caaed3f16 Gerrit-Change-Number: 39128 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: Log return code of unexpected end of process
by pespin 11 Dec '24

11 Dec '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39127?usp=email ) Change subject: testenv: Log return code of unexpected end of process ...................................................................... testenv: Log return code of unexpected end of process This providing further information, for instance if the process actually exited due to a signal (rc < 0) or due to exiting on its own (rc >= 0). While at it, rewrite the log line since a process exiting doesn't necessarily mean it crashed. Change-Id: I7bbee6ad8e114eeb1ef348184158230b53d0f3cf --- M _testenv/testenv/daemons.py 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/27/39127/1 diff --git a/_testenv/testenv/daemons.py b/_testenv/testenv/daemons.py index 86f3979..da8248e 100644 --- a/_testenv/testenv/daemons.py +++ b/_testenv/testenv/daemons.py @@ -107,9 +107,11 @@ def check_if_crashed(): crashed = False + returncode = None for daemon_name, daemon_proc in daemons.items(): if not testenv.testsuite.is_running(daemon_proc.pid): crashed = True + returncode = daemon_proc.poll() break if not crashed: return @@ -118,10 +120,10 @@ testenv.coredump.get_from_coredumpctl() if current_test: - logging.error(f"{daemon_name} crashed during {current_test}!") + logging.error(f"{daemon_name} unexpected exit during {current_test}! rc={returncode}") testenv.testsuite.wait_until_test_stopped() else: - logging.error(f"{daemon_name} crashed!") + logging.error(f"{daemon_name} unexpected exit! rc={returncode}") sys.exit(1) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39127?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7bbee6ad8e114eeb1ef348184158230b53d0f3cf Gerrit-Change-Number: 39127 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-upf[master]: Bump version: 0.1.1.112-9c90 → 0.2.0
by osmith 11 Dec '24

11 Dec '24

Attention is currently required from: laforge. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-upf/+/39125?usp=email ) Change subject: Bump version: 0.1.1.112-9c90 → 0.2.0 ...................................................................... Patch Set 1: (1 comment) File configure.ac: https://gerrit.osmocom.org/c/osmo-upf/+/39125/comment/8754ee15_bf504962?usp… : PS1, Line 40: 10 > do we need those large jumps? I didn't see any TODO-RELEASE items requiring any update of libosmocor […] With libosmocore 1.6.0 and libosmo-pfcp 0.1.0 as previously in configure.ac, libosmo-pfcp failed to build due to DLPFCP not being defined. I've bumped it to libosmocore 1.7.0 first, but then the build failed due to osmo_gtlvs_decode not being available (also used in libosmo-pfcp). I figured it would be easiest to just bump to latest versions instead, where it builds for sure. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39125?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I772edbd17fcac0da597c30eecefa54f9fd8c3ed3 Gerrit-Change-Number: 39125 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 11 Dec 2024 16:16:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log