- gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: remsim: bankd: Install vsmartcard before running testenv
by pespin 11 Dec '24

11 Dec '24

Attention is currently required from: laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39135?usp=email ) Change subject: remsim: bankd: Install vsmartcard before running testenv ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: @osmith@sysmocom.de with this patch applied I have all -c server and -c bankd tests passing as good as with docker-playground, which means we can move infra to use testenv. I agree though that that having those commands running each time the testsuite is run is not that nice, so ideas on how to integrate it better into testenv are welcome! Feel free to take over if you want. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39135?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib5ba5075eff4955354fa25d1c605f277e8a6962a Gerrit-Change-Number: 39135 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 11 Dec 2024 18:47:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ttcn3-hacks[master]: remsim: bankd: Install vsmartcard before running testenv
by pespin 11 Dec '24

11 Dec '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39135?usp=email ) Change subject: remsim: bankd: Install vsmartcard before running testenv ...................................................................... remsim: bankd: Install vsmartcard before running testenv This is needed for test RemsimBankd_Tests.TC_createMapping_exchangeTPDU to work. Change-Id: Ib5ba5075eff4955354fa25d1c605f277e8a6962a --- M remsim/testenv_bankd.cfg 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/35/39135/1 diff --git a/remsim/testenv_bankd.cfg b/remsim/testenv_bankd.cfg index 62ac07b..9a191a6 100644 --- a/remsim/testenv_bankd.cfg +++ b/remsim/testenv_bankd.cfg @@ -5,6 +5,7 @@ [pcscd] program=pcscd -f -d make=no +prepare=apt update && apt install -y --no-install-recommends help2man && git clone https://github.com/frankmorgner/vsmartcard.git && cd vsmartcard/virtualsmartcard && autoreconf -fi && ./configure && make "-j$(nproc)" install package=pcscd [bankd] -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39135?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib5ba5075eff4955354fa25d1c605f277e8a6962a Gerrit-Change-Number: 39135 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: ns2: trigger a reset in case of receiving a NS STATUS with incompatib...
by lynxis lazus 11 Dec '24

11 Dec '24

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/25559?usp=email ) Change subject: ns2: trigger a reset in case of receiving a NS STATUS with incompatible protocol state ...................................................................... Patch Set 3: -Code-Review -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25559?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I912315f816bd0597d4646627dbfdd270fbae2509 Gerrit-Change-Number: 25559 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 11 Dec 2024 18:39:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: ns2: trigger a reset in case of receiving a NS STATUS with incompatib...
by lynxis lazus 11 Dec '24

11 Dec '24

Attention is currently required from: lynxis lazus. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/25559?usp=email ) Change subject: ns2: trigger a reset in case of receiving a NS STATUS with incompatible protocol state ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25559?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I912315f816bd0597d4646627dbfdd270fbae2509 Gerrit-Change-Number: 25559 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 11 Dec 2024 18:39:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in libosmocore[master]: Gb/NS: SNS: SNS Ack don't add List of IP4/6 Elements on success.
by pespin 11 Dec '24

11 Dec '24

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/39062?usp=email ) Change subject: Gb/NS: SNS: SNS Ack don't add List of IP4/6 Elements on success. ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39062?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If99b204a9d754323e53746b31bc13df53a653b7d Gerrit-Change-Number: 39062 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 11 Dec 2024 18:11:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: Gb/NS: SNS: SNS Ack don't add List of IP4/6 Elements on success.
by lynxis lazus 11 Dec '24

11 Dec '24

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/39062?usp=email ) Change subject: Gb/NS: SNS: SNS Ack don't add List of IP4/6 Elements on success. ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/39062/comment/50ce3f2c_2a65572d?… : PS1, Line 7: Gb/NS: SNS: SNS Ack don't add List of IP4/6 Elements on success. > I'll improve the commit message more. Done https://gerrit.osmocom.org/c/libosmocore/+/39062/comment/e6c94296_edad1504?… : PS1, Line 9: SNS Add can't fail with Unknown IP Endpoint. > not sure what you mean here and the relation to the patch. Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39062?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If99b204a9d754323e53746b31bc13df53a653b7d Gerrit-Change-Number: 39062 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Dec 2024 18:02:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in libosmocore[master]: Gb/NS: SNS: SNS Ack don't add List of IP4/6 Elements on success.
by lynxis lazus 11 Dec '24

11 Dec '24

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/39062?usp=email to look at the new patch set (#2). Change subject: Gb/NS: SNS: SNS Ack don't add List of IP4/6 Elements on success. ...................................................................... Gb/NS: SNS: SNS Ack don't add List of IP4/6 Elements on success. The List of IP4/6 Elements should be only present on a SNS Ack if the procedure fails with cause code Unknown IP Endpoint. However ns2 code appended the List always to the SNS Ack. Remove List of IP4/6 Elements from SNS Add, it can't fail with Unknown IP Endpoint. Remove List of IP4/6 Elements from SNS Change Weight success case. Related: OS#6611 Change-Id: If99b204a9d754323e53746b31bc13df53a653b7d --- M src/gb/gprs_ns2_sns.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/62/39062/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39062?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If99b204a9d754323e53746b31bc13df53a653b7d Gerrit-Change-Number: 39062 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-remsim[master]: bankd: Add -T and -e cmdline params
by pespin 11 Dec '24

11 Dec '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39134?usp=email ) Change subject: bankd: Add -T and -e cmdline params ...................................................................... bankd: Add -T and -e cmdline params Change-Id: I2c33c667be77578699f4a5fb70c8b74c67f6e2cf --- M src/bankd/bankd_main.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/34/39134/1 diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index a7e02b3..d96d49c 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -303,6 +303,8 @@ " -g --gsmtap-ip A.B.C.D Enable GSMTAP and send APDU traces to given IP\n" " -G --gsmtap-slot <0-1023> Limit tracing to given bank slot, only (default: all slots)\n" " -L --disable-color Disable colors for logging to stderr\n" +" -T --timestamp Prefix every log line with a timestamp\n" +" -e --log-level number Set a global loglevel.\n" ); } @@ -328,10 +330,12 @@ { "gsmtap-ip", 1, 0, 'g' }, { "gsmtap-slot", 1, 0, 'G' }, { "disable-color", 0, 0, 'L' }, + { "timestamp", 0, 0, 'T' }, + { "log-level", 1, 0, 'e' }, { 0, 0, 0, 0 } }; - c = getopt_long(argc, argv, "hVd:i:p:b:n:N:I:P:sg:G:L", long_options, &option_index); + c = getopt_long(argc, argv, "hVd:i:p:b:n:N:I:P:sg:G:LTe:", long_options, &option_index); if (c == -1) break; @@ -380,6 +384,12 @@ case 'L': log_set_use_color(osmo_stderr_target, 0); break; + case 'T': + log_set_print_timestamp(osmo_stderr_target, 1); + break; + case 'e': + log_set_log_level(osmo_stderr_target, atoi(optarg)); + break; } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39134?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2c33c667be77578699f4a5fb70c8b74c67f6e2cf Gerrit-Change-Number: 39134 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: remsim: Enable debug output of bankd
by pespin 11 Dec '24

11 Dec '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39133?usp=email ) Change subject: remsim: Enable debug output of bankd ...................................................................... remsim: Enable debug output of bankd Change-Id: Idc1ed4b9419735170cac92916073757da01691ed --- M remsim/testenv_bankd.cfg 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/33/39133/1 diff --git a/remsim/testenv_bankd.cfg b/remsim/testenv_bankd.cfg index 04baeaf..62ac07b 100644 --- a/remsim/testenv_bankd.cfg +++ b/remsim/testenv_bankd.cfg @@ -8,7 +8,7 @@ package=pcscd [bankd] -program=osmo-remsim-bankd -d DMAIN:1 -i 127.0.0.10 -I 127.0.0.30 +program=osmo-remsim-bankd -d DMAIN,1:DST2,1:DRSPRO,1:DREST,1:DSLOTMAP,1:DBANKDW,1:DGSMTAP,1:DLINP,1 -i 127.0.0.10 -I 127.0.0.30 make=osmo-remsim package=osmo-remsim-bankd copy=bankd/bankd_pcsc_slots.csv -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39133?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idc1ed4b9419735170cac92916073757da01691ed Gerrit-Change-Number: 39133 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-remsim[master]: Several logging improvements
by pespin 11 Dec '24

11 Dec '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39132?usp=email ) Change subject: Several logging improvements ...................................................................... Several logging improvements Improve logging in several places which proved to be usfeful while analyzing behavior of the program. Change-Id: I4fa91ca8c8e576094d3a9598df5ad96b230bbde0 --- M src/bankd/bankd_main.c M src/rspro_client_fsm.c M src/server/rspro_server.c 3 files changed, 14 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/32/39132/1 diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index cd68073..a7e02b3 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -420,12 +420,15 @@ signal(SIGMAPADD, handle_sig_mapadd); signal(SIGUSR1, handle_sig_usr1); + LOGP(DMAIN, LOGL_INFO, "Reading PCSC slots...\n"); /* Np lock or mutex required for the pcsc_slot_names list, as this is only * read once during bankd initialization, when the worker threads haven't * started yet */ rc = bankd_pcsc_read_slotnames(g_bankd, "bankd_pcsc_slots.csv"); - if (rc) + if (rc) { + fprintf(stderr, "ERROR: reading PCSC slots\n"); exit(1); + } /* Connection towards remsim-server */ rc = server_conn_fsm_alloc(g_bankd, srvc); @@ -436,6 +439,8 @@ osmo_fsm_inst_dispatch(srvc->fi, SRVC_E_ESTABLISH, NULL); /* create listening socket for inbound client connections */ + LOGP(DMAIN, LOGL_INFO, "Initiating listen TCP socket at %s:%d\n", + g_bind_ip ? g_bind_ip : "INADDR_ANY", g_bind_port); rc = osmo_sock_init(AF_INET, SOCK_STREAM, IPPROTO_TCP, g_bind_ip, g_bind_port, OSMO_SOCK_F_BIND); if (rc < 0) { fprintf(stderr, "Unable to create TCP socket at %s:%d: %s\n", @@ -446,6 +451,7 @@ /* initialize gsmtap, if required */ if (g_bankd->cfg.gsmtap_host) { + LOGP(DMAIN, LOGL_INFO, "Initiating GSMTAP\n"); rc = bankd_gsmtap_init(g_bankd->cfg.gsmtap_host); if (rc < 0) { fprintf(stderr, "Unable to open GSMTAP\n"); @@ -456,6 +462,7 @@ /* create worker threads: One per reader/slot! */ for (i = 0; i < g_bankd->srvc.bankd.num_slots; i++) { struct bankd_worker *w; + LOGP(DMAIN, LOGL_INFO, "Initiating worker %d\n", i); w = bankd_create_worker(g_bankd, i); if (!w) { fprintf(stderr, "Error creating bankd worker thread\n"); @@ -463,12 +470,10 @@ } } - while (1) { - if (terminate) - break; + while (!terminate) { osmo_select_main(0); } - + LOGP(DMAIN, LOGL_NOTICE, "Terminated\n"); talloc_free(g_bankd); exit(0); } diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c index 03dbe15..d847f3b 100644 --- a/src/rspro_client_fsm.c +++ b/src/rspro_client_fsm.c @@ -502,6 +502,7 @@ osmo_stream_cli_destroy(srvc->conn); srvc->conn = NULL; err_exit: + LOGPFSML(fi, LOGL_FATAL, "exit(1)\n"); exit(1); } diff --git a/src/server/rspro_server.c b/src/server/rspro_server.c index 0936238..77b727e 100644 --- a/src/server/rspro_server.c +++ b/src/server/rspro_server.c @@ -780,6 +780,8 @@ static int ipa_keepalive_send_cb(struct osmo_ipa_ka_fsm_inst *ka_fi, struct msgb *msg, void *data) { struct osmo_stream_srv *srv = data; + struct rspro_client_conn *conn = osmo_stream_srv_get_data(srv); + LOGPFSML(conn->fi, LOGL_INFO, "Tx IPA PING\n"); osmo_stream_srv_send(srv, msg); return 0; } @@ -788,6 +790,7 @@ { struct osmo_stream_srv *peer = data; struct rspro_client_conn *conn = osmo_stream_srv_get_data(peer); + LOGPFSML(conn->fi, LOGL_NOTICE, "IPA PONG Timeout\n"); osmo_fsm_inst_dispatch(conn->fi, CLNTC_E_KA_TIMEOUT, NULL); return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39132?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I4fa91ca8c8e576094d3a9598df5ad96b230bbde0 Gerrit-Change-Number: 39132 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log