Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40254?usp=email )
Change subject: Split hnb_context,hnb_persistent,umts_cell_id to their own files
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40254?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I4ff65d14f94d99a57316c2483c92244078bb5dd9
Gerrit-Change-Number: 40254
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 08 May 2025 09:12:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40253?usp=email )
Change subject: Move hnbgw_cnlink to cnlink.h and hnbgw_cnpool to hnbgw_cn.h
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40253?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I75988112cff6c8c17d2bdb166a0934934c523dfc
Gerrit-Change-Number: 40253
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 08 May 2025 09:11:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: clufn, laforge.
pespin has posted comments on this change by clufn. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255?usp=email )
Change subject: Add required conversions for IPv6 and IPv4v6 support
......................................................................
Patch Set 5:
(2 comments)
File src/conv.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255/comment/26ce07a3_6955… :
PS5, Line 72: add_prefix(<<A:8, B:8, C:8, D:8, E:8, F:8, G:8, H:8, I:8, J:8, K:8, L:8, M:8, N:8, O:8, P:8>>) ->
> There is a second patch coming that uses the IP address requested by the UE is the IKE_AUTH request […]
Then please submit this function when it is needed, not here 😊
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255/comment/4f4518ab_60f5… :
PS5, Line 136: ipv6 = remove_prefix(Addr)};
> The IPv6 Address send by the epc has a prefix bit that causes issues in the epdg
can you point to the related spec, or open a ticket in redmine with a pcap file or similar?
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I2426e0dcee3ca92075b845f6b21a175a3d047c08
Gerrit-Change-Number: 40255
Gerrit-PatchSet: 5
Gerrit-Owner: clufn <callumfarrbennett(a)yahoo.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: clufn <callumfarrbennett(a)yahoo.com>
Gerrit-Comment-Date: Thu, 08 May 2025 09:04:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: clufn <callumfarrbennett(a)yahoo.com>
Attention is currently required from: laforge, pespin.
clufn has posted comments on this change by clufn. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255?usp=email )
Change subject: Add required conversions for IPv6 and IPv4v6 support
......................................................................
Patch Set 5:
(2 comments)
File src/conv.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255/comment/f684aa4a_022d… :
PS5, Line 72: add_prefix(<<A:8, B:8, C:8, D:8, E:8, F:8, G:8, H:8, I:8, J:8, K:8, L:8, M:8, N:8, O:8, P:8>>) ->
> I'm not seeing this one used anywhere?
There is a second patch coming that uses the IP address requested by the UE is the IKE_AUTH request that uses this to format the gtpv2 message
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255/comment/31459903_70bc… :
PS5, Line 136: ipv6 = remove_prefix(Addr)};
> Ah now I see, so you are doing 2 things in this comit: […]
The IPv6 Address send by the epc has a prefix bit that causes issues in the epdg
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I2426e0dcee3ca92075b845f6b21a175a3d047c08
Gerrit-Change-Number: 40255
Gerrit-PatchSet: 5
Gerrit-Owner: clufn <callumfarrbennett(a)yahoo.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 08 May 2025 09:01:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>