- gerrit-log - lists.osmocom.org

[XS] Change in osmo-ccid-firmware[master]: clang-format: set ColumnLimit: 0
by pespin 27 Feb '26

27 Feb '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42227?usp=email ) Change subject: clang-format: set ColumnLimit: 0 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I think it's fine keeping the check in general, and ignore it in specific cases where the opposite makes sense. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42227?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I1f0d511d90a0725f195e08dd6a99eb3d55bd6fc1 Gerrit-Change-Number: 42227 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Feb 2026 09:18:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ci[master]: lint/checkpatch: fix false FUNCTION_ARGUMENTS
by osmith 27 Feb '26

27 Feb '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/42226?usp=email ) Change subject: lint/checkpatch: fix false FUNCTION_ARGUMENTS ...................................................................... lint/checkpatch: fix false FUNCTION_ARGUMENTS Fix that the linter complains about: WARNING:FUNCTION_ARGUMENTS: function definition argument 'void' should also have an identifier name For functions with attributes at the end, e.g.: void Fallback_Handler(void) __attribute__((weak, alias("Dummy_Handler"))); Related: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/7c5b3be0_6f… Change-Id: I139bdabb38bd0c9ceda99921ebdc0196850c2a53 --- M lint/checkpatch/checkpatch.pl 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/lint/checkpatch/checkpatch.pl b/lint/checkpatch/checkpatch.pl index eada2a9..9a81dc2 100755 --- a/lint/checkpatch/checkpatch.pl +++ b/lint/checkpatch/checkpatch.pl @@ -6964,7 +6964,8 @@ # check for function declarations that have arguments without identifier names if (defined $stat && $stat =~ /^.\s*(?:extern\s+)?$Type\s*(?:$Ident|$\s*\*\s*$Ident\s*$)\s*$\s*([^{]+)\s*$\s*;/s && - $1 ne "void") { + $1 ne "void" && + $1 !~ /^void\)/) { my $args = trim($1); while ($args =~ m/\s*($Type\s*(?:$Ident|$\s*\*\s*$Ident?\s*$\s*$balanced_parens)?)/g) { my $arg = trim($1); -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42226?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I139bdabb38bd0c9ceda99921ebdc0196850c2a53 Gerrit-Change-Number: 42226 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: lint/checkpatch: fix false FUNCTION_ARGUMENTS
by osmith 27 Feb '26

27 Feb '26

Attention is currently required from: lynxis lazus. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42226?usp=email ) Change subject: lint/checkpatch: fix false FUNCTION_ARGUMENTS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42226?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I139bdabb38bd0c9ceda99921ebdc0196850c2a53 Gerrit-Change-Number: 42226 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 27 Feb 2026 09:16:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: lint/checkpatch: fix false FUNCTION_ARGUMENTS
by pespin 27 Feb '26

27 Feb '26

Attention is currently required from: lynxis lazus, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42226?usp=email ) Change subject: lint/checkpatch: fix false FUNCTION_ARGUMENTS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42226?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I139bdabb38bd0c9ceda99921ebdc0196850c2a53 Gerrit-Change-Number: 42226 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 27 Feb 2026 09:16:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-trx[master]: fix(threads): centralize portable strerror handling
by pespin 27 Feb '26

27 Feb '26

Attention is currently required from: Timur Davydov. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email ) Change subject: fix(threads): centralize portable strerror handling ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I642aff8a9f98823e117c4debd19384ddf5975039 Gerrit-Change-Number: 42199 Gerrit-PatchSet: 5 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Fri, 27 Feb 2026 09:15:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ccid-firmware[master]: main: rework panic handler
by laforge 27 Feb '26

27 Feb '26

Attention is currently required from: Hoernchen, lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42163?usp=email ) Change subject: main: rework panic handler ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Patchset: PS5: I don't understand why @ewild is removing himself from the reviewers. He is the subject matter expert and I am requesting his review of any patches going into this codebase. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42163?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I91c732001e848ec5509bf81af8aac1a2a80eb718 Gerrit-Change-Number: 42163 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 27 Feb 2026 08:45:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: fix --disable-log-macros
by laforge 27 Feb '26

27 Feb '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email ) Change subject: fix --disable-log-macros ...................................................................... fix --disable-log-macros Before 9197c1ac, the AC_ARG_ENABLE(log_macros, ...) action was hardcoded to [log_macros="yes"], so *any* use of the flag --enable-log-macros or --disable-log-macros would set log_macros="yes" -> AC_DEFINE([LIBOSMOCORE_NO_LOGGING]). The commit changed this to the standard [log_macros=$enableval], but broke the conditional test, so - AC_ARG_ENABLE sets $enableval to "no" for --disable-* flags -> log_macros is now "no" -> test fails -> LIBOSMOCORE_NO_LOGGING is never defined... The opposite of what it should do... Change-Id: I809ab2f61e72428ba21061055296eb83d6d710ab --- M configure.ac 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/configure.ac b/configure.ac index b32f304..b5f858f 100644 --- a/configure.ac +++ b/configure.ac @@ -241,7 +241,7 @@ ENABLE_CTRL_DEFAULT="yes" ENABLE_PSEUDOTALLOC_DEFAULT="no" ENABLE_EMBEDDED_DEFAULT="no" -ENABLE_LIBOSMOCORE_NO_LOGGING_DEFAULT="no" +ENABLE_LOG_MACROS_DEFAULT="yes" ENABLE_SANITIZE_DEFAULT="no" ENABLE_WERROR_DEFAULT="no" ENABLE_EXT_TESTS_DEFAULT="no" @@ -261,6 +261,7 @@ if test x"$embedded" = x"yes" then AC_DEFINE([EMBEDDED],[1],[Select building for embedded use]) + ENABLE_LOG_MACROS_DEFAULT="no" ENABLE_PLUGIN_DEFAULT="no" ENABLE_MSGFILE_DEFAULT="no" ENABLE_SERIAL_DEFAULT="no" @@ -507,8 +508,8 @@ [--disable-log-macros], [Disable logging macros that are also used internally to print information] )], - [log_macros=$enableval], [log_macros=$ENABLE_LIBOSMOCORE_NO_LOGGING_DEFAULT]) -if test x"$log_macros" == x"yes" + [log_macros=$enableval], [log_macros=$ENABLE_LOG_MACROS_DEFAULT]) +if test x"$log_macros" != x"yes" then AC_DEFINE([LIBOSMOCORE_NO_LOGGING],[1],[Disable logging macros]) fi -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I809ab2f61e72428ba21061055296eb83d6d710ab Gerrit-Change-Number: 42203 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: fix --disable-log-macros
by laforge 27 Feb '26

27 Feb '26

Attention is currently required from: Hoernchen, pespin. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email ) Change subject: fix --disable-log-macros ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I809ab2f61e72428ba21061055296eb83d6d710ab Gerrit-Change-Number: 42203 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Feb 2026 08:42:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-ccid-firmware[master]: same54: make the default irq handler weak
by osmith 27 Feb '26

27 Feb '26

Attention is currently required from: lynxis lazus. osmith has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224?usp=email ) Change subject: same54: make the default irq handler weak ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I looked at the [linter errors](https://jenkins.osmocom.org/jenkins/job/gerrit-lint/27152/consoleFu…: * checkpatch `function definition argument 'void' should also have an identifier name`: fix in https://gerrit.osmocom.org/c/osmo-ci/+/42226 * clang-format: line breaks: fix in https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42227 * clang-format: having exactly one space before `/* ... */` comments: looks like this cannot be configured. There is [SpacesBeforeTrailingComments](https://clang.llvm.org/docs/ClangFormatStyleO…, but it does not affect block comments :\ -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I544e9c84dd538bb744fb799904adc58f9d850465 Gerrit-Change-Number: 42224 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 27 Feb 2026 08:13:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ccid-firmware[master]: clang-format: set ColumnLimit: 0
by osmith 27 Feb '26

27 Feb '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42227?usp=email ) Change subject: clang-format: set ColumnLimit: 0 ...................................................................... clang-format: set ColumnLimit: 0 While our coding style says "we accept line lengths of up to 120 characters", in practice we oftentimes end up preferring longer lines (e.g. due to having comments at the end, or to keep them consistent with similar but shorter lines). The checkpatch config has already been adjusted to just ignore the line length completely. Adjust the clang-format config to do the same. Related: osmo-ci I88fd86ac550fddb3017aeceb647c3d9e75367372 Change-Id: I1f0d511d90a0725f195e08dd6a99eb3d55bd6fc1 --- M .clang-format 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/27/42227/1 diff --git a/.clang-format b/.clang-format index 4de65a5..e1b8d44 100644 --- a/.clang-format +++ b/.clang-format @@ -52,7 +52,7 @@ #BreakConstructorInitializers: BeforeComma # Unknown to clang-format-4.0 BreakAfterJavaFieldAnnotations: false BreakStringLiterals: false -ColumnLimit: 120 +ColumnLimit: 0 CommentPragmas: '^ IWYU pragma:' #CompactNamespaces: false # Unknown to clang-format-4.0 ConstructorInitializerAllOnOneLineOrOnePerLine: false -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42227?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I1f0d511d90a0725f195e08dd6a99eb3d55bd6fc1 Gerrit-Change-Number: 42227 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log