- gerrit-log - lists.osmocom.org

[M] Change in libosmo-sigtran[master]: tcap: Support TID with length 1..4
by osmith 28 Feb '26

28 Feb '26

Attention is currently required from: daniel, fixeria, lynxis lazus, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212?usp=email ) Change subject: tcap: Support TID with length 1..4 ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2748d85624e4be708f7554ee3e60a5bda9162845 Gerrit-Change-Number: 42212 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 27 Feb 2026 13:47:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: tcap: Lower log level failing to parse msg
by osmith 28 Feb '26

28 Feb '26

Attention is currently required from: daniel, fixeria, lynxis lazus, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42211?usp=email ) Change subject: tcap: Lower log level failing to parse msg ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS2: > Stuff coming from peers is not expected to be ERROR but NOTICE imho. […] Agreed. Would probably be good to write this down in a "logging best practices" wiki page or something, so we can point at it later. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42211?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Idef5736ee2481260f958eece2f5a3bfc009b3d69 Gerrit-Change-Number: 42211 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 27 Feb 2026 13:46:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in libosmo-asn1-tcap[master]: Use talloc to allocate asn1c decoded structs
by pespin 28 Feb '26

28 Feb '26

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email ) Change subject: Use talloc to allocate asn1c decoded structs ...................................................................... Patch Set 2: (1 comment) File src/tcap.c: https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219/comment/a154594b_800… : PS2, Line 29: vo > > But as mentioned above, defining it as weak actually deceives the reason to have the global symbo […] I can look at adding a new osmo_asn1_tcap_decode2() which also gets a "void *talloc_ctx" param, and then keep tcap_talloc_asn1_ctx private and internally set it when calling ber_decode(), then re-set it to NULL afterwards. -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I6d885527caa5b60011b4fac341b93026ab1833d9 Gerrit-Change-Number: 42219 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 27 Feb 2026 13:17:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-asn1-tcap[master]: Use talloc to allocate asn1c decoded structs
by laforge 28 Feb '26

28 Feb '26

Attention is currently required from: daniel, fixeria, lynxis lazus, osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email ) Change subject: Use talloc to allocate asn1c decoded structs ...................................................................... Patch Set 2: (1 comment) File src/tcap.c: https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219/comment/84eb6adb_3ea… : PS2, Line 29: vo > But as mentioned above, defining it as weak actually deceives the reason to have the global symbol in first place, apps are still not required to set it, so we are in the same position as with using a real function API. I was thinking of declaring it as non-weak in the library, but defining it as weak in all the applications/libraries that use it. This way at least one of them must define it, while still not clashing? The "perfect" solutions for multiple users of libasn1c would likely have been to make all calls pass around a context, so each user (in another library or application) can pass the talloc context into each encode/decode operation, and hence track only their own objects' memory usage wherever they want - doing away with a global variable in the first place. That in turn however of course breaks the asn1c API. Too late for libasn1c, but potentially not yet for libosmo-asn1-tcap. However, I think the number of new users we see for libosmo-asn1-tcap is likely very low, so also not really worth it. Feel free to go ahead with your approach, if you think it's superior. -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I6d885527caa5b60011b4fac341b93026ab1833d9 Gerrit-Change-Number: 42219 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 27 Feb 2026 13:11:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: NGAP_Emulation: Use specific record types for AMF/RAN IDs
by laforge 28 Feb '26

28 Feb '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42232?usp=email ) Change subject: NGAP_Emulation: Use specific record types for AMF/RAN IDs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42232?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibd85be865a3a61c97d312df76ab3d1ae7ae32a6a Gerrit-Change-Number: 42232 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Feb 2026 13:04:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in pysim[master]: docs/smpp-ota-tool: Add documentation/tutorial
by laforge 28 Feb '26

28 Feb '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42237?usp=email ) Change subject: docs/smpp-ota-tool: Add documentation/tutorial ...................................................................... Patch Set 1: (10 comments) File docs/smpp-ota-tool.rst: https://gerrit.osmocom.org/c/pysim/+/42237/comment/6f384f16_3412eeb9?usp=em… : PS1, Line 5: cards an eUICC must not be a card, in fact most often it is not. I would just write "of SIM/USIM/UICC/eUICC." or something like that. https://gerrit.osmocom.org/c/pysim/+/42237/comment/a1dca5bb_cf9dcc7e?usp=em… : PS1, Line 6: SMPP : server "... SMPP server (such as a production SMSC of a live cellular network) as well." I think it makes sense to clarify that one can use this in a production setup if one is an operator and has SMPP access to ones own SMSC. https://gerrit.osmocom.org/c/pysim/+/42237/comment/a433b6d8_ae166f51?usp=em… : PS1, Line 17: a se it's not "a set" but "sets of keys".. Somehow the paragraph doesn't really make it clear that the SCP80 keys must be used. You just say that the SCP80 protocol is used, and not that therem ight be different sets of keys for different SCPs and one of the SCP80 keysets must be used. https://gerrit.osmocom.org/c/pysim/+/42237/comment/5a0511ef_2bd90920?usp=em… : PS1, Line 17: card we have many more instances of "card" in the document, it seems. Maybe add an initial paragraph at the top that whenever "SIM" is used, any of UICC/USIM/ISIM/eUICC/eSIM is actually meant? Or one could also do the same with the word "card": Define the word "card" in the context of this document as "any SIM/USIM/ISIM/UICC/eUICC/eSIM whether or not it is in a physical card or solder form-factor"? https://gerrit.osmocom.org/c/pysim/+/42237/comment/c23d3254_fea15b03?usp=em… : PS1, Line 26: The KIK is not used in the scope of SCP80. oh, are you sure? That means you cannot deploy new SCP80 (or other) keys via SCP80? I would have assumed that using RAM one could also issue PUT KEY and then the KIK would be used? Do you have a spec reference for your statement that it's not used? https://gerrit.osmocom.org/c/pysim/+/42237/comment/29e48c59_b5678c82?usp=em… : PS1, Line 28: programmed into the issuer security domain (ISD) the keyset doesn't have to be in the ISD. I think any security domain (whether issuer or supplementary) could in theory specify its own material? Might be best to just say "security domain" without being too specific. https://gerrit.osmocom.org/c/pysim/+/42237/comment/d24b1c40_3c72e02a?usp=em… : PS1, Line 84: A0A40000027F20 might be worth using formatting instructions to use monospaced font for all APDUs or other hex-strings https://gerrit.osmocom.org/c/pysim/+/42237/comment/24338766_a56d9080?usp=em… : PS1, Line 86: is received by the SIM RFM application and then executed. This method poses some limitations that have to be taken into might be worth stating that he SIM RFM application is "on the card" https://gerrit.osmocom.org/c/pysim/+/42237/comment/72d2a4ae_e9bf2c30?usp=em… : PS1, Line 115: : To prevent this, we may include a replay protection counter within the message. In this case, the MSL indicates that a : replay protection counter is not required. However, to extended the security of our messages, we may chose to use a : counter anyway. In the following example, we will encode a counter value of 100. We will instruct the card to make sure : that the value we send is higher than the counter value that is currently stored in the card. it might be worth mentioning at some earlier point that the MSL of the card may be different for different card types/profiles, and that cards beyond lab/experimentation use should ideally have a MSL that makes the use of the counter mandatory. It's just the sysmoISIM-SJS1/SJA2/SJA5 that do not have a MSL requiring a counter as that makes it easier for lab/research type use. https://gerrit.osmocom.org/c/pysim/+/42237/comment/7d9b144f_664ade33?usp=em… : PS1, Line 162: overlap "... it will not wrap on overflow ... -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42237?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If0d18a263f5a6dc035b90f5c5c6a942d46bbba49 Gerrit-Change-Number: 42237 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Feb 2026 13:04:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in pysim[master]: contrib/smpp-ota-tool: define commandline arguments in global scope
by laforge 27 Feb '26

27 Feb '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42236?usp=email ) Change subject: contrib/smpp-ota-tool: define commandline arguments in global scope ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42236?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2d9782e3f5b1cac78c22d206fdcac4118c7d5e7c Gerrit-Change-Number: 42236 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Feb 2026 12:50:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: contrib/smpp-ota-tool: use '-' instead of '_' in command line args
by laforge 27 Feb '26

27 Feb '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42235?usp=email ) Change subject: contrib/smpp-ota-tool: use '-' instead of '_' in command line args ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42235?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icbe9d753d59263997e9ca34d46ed0daca36ca16c Gerrit-Change-Number: 42235 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Feb 2026 12:50:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: contrib/smpp-ota-tool: fix description string (copy+paste error)
by laforge 27 Feb '26

27 Feb '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42234?usp=email ) Change subject: contrib/smpp-ota-tool: fix description string (copy+paste error) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42234?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I559844bfa1ac372370ef9d148f2f8a6bf4ab4ef5 Gerrit-Change-Number: 42234 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Feb 2026 12:50:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in pysim[master]: tests/pySim-smpp2sim_test: add testcases for AES128 and AES256
by laforge 27 Feb '26

27 Feb '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42189?usp=email ) Change subject: tests/pySim-smpp2sim_test: add testcases for AES128 and AES256 ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42189?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1f10504f3a29a8c74a17991632d932819fecfa5a Gerrit-Change-Number: 42189 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Feb 2026 12:50:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log