- gerrit-log - lists.osmocom.org

[XS] Change in libosmo-asn1-tcap[master]: tests: Use mem alloc macro instead of direct calloc() call
by fixeria 28 Feb '26

28 Feb '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42218?usp=email ) Change subject: tests: Use mem alloc macro instead of direct calloc() call ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42218?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: Ia9c7cf1f958f273dd7a5e23cf7633e45fa9d577f Gerrit-Change-Number: 42218 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Feb 2026 16:56:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-asn1-tcap[master]: Makefile.am: Avoid removing tcap.h during make -C src/ regen
by fixeria 28 Feb '26

28 Feb '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42217?usp=email ) Change subject: Makefile.am: Avoid removing tcap.h during make -C src/ regen ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42217?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I89a34ef61e6f74ba7482a5abcf55404c157a14fb Gerrit-Change-Number: 42217 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Feb 2026 16:54:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-asn1-tcap[master]: Add README.md
by fixeria 28 Feb '26

28 Feb '26

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42216?usp=email ) Change subject: Add README.md ...................................................................... Patch Set 1: Code-Review-1 (3 comments) File README.md: https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42216/comment/1194e517_9ba… : PS1, Line 15: osmo-cbc fixme https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42216/comment/f07d8fb5_0b8… : PS1, Line 24: osmo-cbc fixme https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42216/comment/3a8ed843_f14… : PS1, Line 53: sbcap no SBcAP here, right? -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42216?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: Ie3fa506cb9b40992cebe6942ea833a2e49ba2680 Gerrit-Change-Number: 42216 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Feb 2026 16:50:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-asn1-tcap[master]: Use talloc to allocate asn1c decoded structs
by pespin 28 Feb '26

28 Feb '26

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email ) Change subject: Use talloc to allocate asn1c decoded structs ...................................................................... Patch Set 3: (1 comment) File src/tcap.c: https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219/comment/7ec7074e_cd1… : PS2, Line 29: vo > I can look at adding a new osmo_asn1_tcap_decode2() which also gets a "void *talloc_ctx" param, and […] @laforge@osmocom.org see https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42238 and https://gerrit.osmocom.org/c/libosmo-sigtran/+/42239 -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I6d885527caa5b60011b4fac341b93026ab1833d9 Gerrit-Change-Number: 42219 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 27 Feb 2026 14:54:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: Use new libosmo-asn1-tcap API osmo_asn1_tcap_TCMessage_decode()
by pespin 28 Feb '26

28 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42239?usp=email ) Change subject: Use new libosmo-asn1-tcap API osmo_asn1_tcap_TCMessage_decode() ...................................................................... Use new libosmo-asn1-tcap API osmo_asn1_tcap_TCMessage_decode() This allows passing a talloc context used to allocate memory when decoding the message. Related: SYS#5423 Related: OS#6965 Change-Id: Iebeb2808c54c5b82026a1b31d985aa73f602b42a --- M TODO-RELEASE M src/tcap_as_loadshare.c 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/39/42239/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 0ed7189..ef38361 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,3 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line +libosmo-asn1-tcap >0.2.1 osmo_asn1_tcap_TCMessage_decode() diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index 5a52f83..f7ae3b8 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -96,7 +96,7 @@ OSMO_ASSERT(ids); - rc = osmo_asn1_tcap_decode(tcapmsg, data, len); + rc = osmo_asn1_tcap_TCMessage_decode(tcapmsg, data, len, as); if (rc < 0) { LOGPAS(as, DLTCAP, LOGL_NOTICE, "Error decoding TCAP message rc: %d, message: %s\n", rc, osmo_hexdump(data, len)); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42239?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iebeb2808c54c5b82026a1b31d985aa73f602b42a Gerrit-Change-Number: 42239 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-asn1-tcap[master]: Use talloc to allocate asn1c decoded structs
by pespin 28 Feb '26

28 Feb '26

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, osmith. Hello Jenkins Builder, daniel, fixeria, laforge, lynxis lazus, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge Change subject: Use talloc to allocate asn1c decoded structs ...................................................................... Use talloc to allocate asn1c decoded structs This commit adds talloc support but will still use talloc NULL context everywhere when allocating memory. This is already useful since it allows programs enabling null context tracking to get a report of memory usage. Related: SYS#5423 Related: OS#6965 Change-Id: I6d885527caa5b60011b4fac341b93026ab1833d9 --- M configure.ac M debian/control M include/osmocom/tcap/asn_internal.h M libosmo-asn1-tcap.pc.in M src/Makefile.am M src/tcap.c M tests/parse/Makefile.am 7 files changed, 27 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-asn1-tcap refs/changes/19/42219/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I6d885527caa5b60011b4fac341b93026ab1833d9 Gerrit-Change-Number: 42219 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in libosmo-asn1-tcap[master]: Introduce API osmo_asn1_tcap_TCMessage_decode()
by pespin 28 Feb '26

28 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42238?usp=email ) Change subject: Introduce API osmo_asn1_tcap_TCMessage_decode() ...................................................................... Introduce API osmo_asn1_tcap_TCMessage_decode() This new API allows passing a talloc context where all memory is allocated by asn1c code is allocated. Related: SYS#5423 Related: OS#6965 Change-Id: I02923afb3936a1acf6643def27528e35e4b03e86 --- A TODO-RELEASE M include/osmocom/tcap/asn_internal.h M include/osmocom/tcap/tcap.h M src/Makefile.am M src/tcap.c 5 files changed, 25 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-asn1-tcap refs/changes/38/42238/1 diff --git a/TODO-RELEASE b/TODO-RELEASE new file mode 100644 index 0000000..9312dbd --- /dev/null +++ b/TODO-RELEASE @@ -0,0 +1,10 @@ +# When cleaning up this file: bump API version in corresponding Makefile.am and rename corresponding debian/lib*.install +# according to https://osmocom.org/projects/cellular-infrastructure/wiki/Make_a_new_release +# In short: https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info… +# LIBVERSION=c:r:a +# If the library source code has changed at all since the last update, then increment revision: c:r + 1:a. +# If any interfaces have been added, removed, or changed since the last update: c + 1:0:a. +# If any interfaces have been added since the last public release: c:r:a + 1. +# If any interfaces have been removed or changed since the last public release: c:r:0. +#library what description / commit summary line +libosmo-asn1-tcap add osmo_asn1_tcap_TCMessage_decode() diff --git a/include/osmocom/tcap/asn_internal.h b/include/osmocom/tcap/asn_internal.h index f4337d3..18e493f 100644 --- a/include/osmocom/tcap/asn_internal.h +++ b/include/osmocom/tcap/asn_internal.h @@ -35,7 +35,7 @@ #define ASN1C_ENVIRONMENT_VERSION 923 /* Compile-time version */ int get_asn1c_environment_version(void); /* Run-time version */ -extern void *tcap_talloc_asn1_ctx; +extern __thread void *tcap_talloc_asn1_ctx; #define CALLOC(nmemb, size) talloc_zero_size(tcap_talloc_asn1_ctx, (nmemb) * (size)) #define MALLOC(size) talloc_size(tcap_talloc_asn1_ctx, size) #define REALLOC(oldptr, size) talloc_realloc_size(tcap_talloc_asn1_ctx, oldptr, size) diff --git a/include/osmocom/tcap/tcap.h b/include/osmocom/tcap/tcap.h index 309f283..c7db4ab 100644 --- a/include/osmocom/tcap/tcap.h +++ b/include/osmocom/tcap/tcap.h @@ -6,6 +6,8 @@ #include <osmocom/tcap/TCAP_TCMessage.h> -int osmo_asn1_tcap_decode(struct TCAP_TCMessage *tcapmsg, const uint8_t *data, size_t data_len); +int osmo_asn1_tcap_decode(struct TCAP_TCMessage *tcapmsg, const uint8_t *data, size_t data_len) OSMO_DEPRECATED("Use osmo_asn1_tcap_TCMessage_decode() instead"); + +int osmo_asn1_tcap_TCMessage_decode(struct TCAP_TCMessage *tcapmsg, const uint8_t *data, size_t data_len, void *talloc_ctx); void osmo_asn1_tcap_TCMessage_free_contents(struct TCAP_TCMessage *tcapmsg); diff --git a/src/Makefile.am b/src/Makefile.am index 42089af..78d8d0d 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -243,7 +243,7 @@ ../../move-asn1-header-files.sh osmocom/tcap $(ASN_MODULE_INC) #Patch mem alloc defines to use talloc: sed -i "s/#define\tASN_INTERNAL_H/#define\tASN_INTERNAL_H\n#include <talloc.h>/g" $(top_srcdir)/include/osmocom/tcap/asn_internal.h - sed -i "s/#define\tCALLOC/extern void *tcap_talloc_asn1_ctx;\n#define\tCALLOC/g" $(top_srcdir)/include/osmocom/tcap/asn_internal.h + sed -i "s/#define\tCALLOC/extern __thread void *tcap_talloc_asn1_ctx;\n#define\tCALLOC/g" $(top_srcdir)/include/osmocom/tcap/asn_internal.h sed -i "s/calloc(nmemb, size)/talloc_zero_size(tcap_talloc_asn1_ctx, (nmemb) * (size))/g" $(top_srcdir)/include/osmocom/tcap/asn_internal.h sed -i "s/malloc(size)/talloc_size(tcap_talloc_asn1_ctx, size)/g" $(top_srcdir)/include/osmocom/tcap/asn_internal.h sed -i "s/realloc(oldptr, size)/talloc_realloc_size(tcap_talloc_asn1_ctx, oldptr, size)/g" $(top_srcdir)/include/osmocom/tcap/asn_internal.h diff --git a/src/tcap.c b/src/tcap.c index f5303ac..0957faa 100644 --- a/src/tcap.c +++ b/src/tcap.c @@ -26,7 +26,7 @@ #include <osmocom/tcap/asn_codecs.h> #include <osmocom/tcap/TCAP_TCMessage.h> -void *tcap_talloc_asn1_ctx; +__thread void *tcap_talloc_asn1_ctx; int osmo_asn1_tcap_decode(struct TCAP_TCMessage *tcapmsg, const uint8_t *data, size_t data_len) { @@ -41,6 +41,15 @@ return 0; } +int osmo_asn1_tcap_TCMessage_decode(struct TCAP_TCMessage *tcapmsg, const uint8_t *data, size_t data_len, void *talloc_ctx) +{ + int rc; + tcap_talloc_asn1_ctx = talloc_ctx; + rc = osmo_asn1_tcap_decode(tcapmsg, data, data_len); + tcap_talloc_asn1_ctx = NULL; + return rc; +} + void osmo_asn1_tcap_TCMessage_free_contents(struct TCAP_TCMessage *tcapmsg) { ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_TCAP_TCMessage, tcapmsg); -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42238?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I02923afb3936a1acf6643def27528e35e4b03e86 Gerrit-Change-Number: 42238 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-netif[master]: stream: Improve error handling and logging in write_cb
by pespin 28 Feb '26

28 Feb '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/42191?usp=email ) Change subject: stream: Improve error handling and logging in write_cb ...................................................................... stream: Improve error handling and logging in write_cb Nowhere in man 2 write/send/sendmsg it can be read that a return of 0 is actually an error, so avoid handling that case as error in stream_cli. While at ti, log the errno string. Change-Id: I68468f0452cbc86b6210bbd1dbfa251579270adb --- M src/stream_cli.c M src/stream_srv.c 2 files changed, 9 insertions(+), 4 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve diff --git a/src/stream_cli.c b/src/stream_cli.c index e59122b..a8b5fa6 100644 --- a/src/stream_cli.c +++ b/src/stream_cli.c @@ -604,8 +604,10 @@ (void)stream_cli_handle_connecting(cli, res); break; case STREAM_CLI_STATE_CONNECTED: - if (msg && res <= 0) { - LOGSCLI(cli, LOGL_ERROR, "received error %d in response to send\n", res); + if (msg && res < 0) { + char errbuf[64]; + strerror_r(-res, errbuf, sizeof(errbuf)); + LOGSCLI(cli, LOGL_ERROR, "error to send: %d (%s)\n", res, errbuf); (void)stream_cli_reconnect(cli); } /* res=0 && msgb=NULL: "connected notify", but we already received before a read_cb diff --git a/src/stream_srv.c b/src/stream_srv.c index 140515f..6c4eada 100644 --- a/src/stream_srv.c +++ b/src/stream_srv.c @@ -801,8 +801,11 @@ struct osmo_stream_srv *conn = osmo_iofd_get_data(iofd); LOGSSRV(conn, LOGL_DEBUG, "connected write\n"); - if (res < 0) - LOGSSRV(conn, LOGL_ERROR, "error to send: %s\n", strerror(errno)); + if (res < 0) { + char errbuf[64]; + strerror_r(-res, errbuf, sizeof(errbuf)); + LOGSSRV(conn, LOGL_ERROR, "error to send: %d (%s)\n", res, errbuf); + } if (osmo_iofd_txqueue_len(iofd) == 0) if (conn->flags & OSMO_STREAM_SRV_F_FLUSH_DESTROY) -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42191?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I68468f0452cbc86b6210bbd1dbfa251579270adb Gerrit-Change-Number: 42191 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-netif[master]: stream: Improve error handling and logging in write_cb
by pespin 28 Feb '26

28 Feb '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/42191?usp=email ) Change subject: stream: Improve error handling and logging in write_cb ...................................................................... Patch Set 2: (1 comment) File src/stream_cli.c: https://gerrit.osmocom.org/c/libosmo-netif/+/42191/comment/94c91aea_84bd991… : PS2, Line 609: strerror_r(-res, errbuf, sizeof(errbuf)); > "The strerror_r() function is similar to strerror(), but is thread safe" Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42191?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I68468f0452cbc86b6210bbd1dbfa251579270adb Gerrit-Change-Number: 42191 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Feb 2026 14:27:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-netif[master]: stream: Improve error handling and logging in write_cb
by pespin 28 Feb '26

28 Feb '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/42191?usp=email ) Change subject: stream: Improve error handling and logging in write_cb ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/stream_cli.c: https://gerrit.osmocom.org/c/libosmo-netif/+/42191/comment/c311814c_244e72d… : PS2, Line 609: strerror_r(-res, errbuf, sizeof(errbuf)); > Why do you use strerror_r instead of strerror here? "The strerror_r() function is similar to strerror(), but is thread safe" -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42191?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I68468f0452cbc86b6210bbd1dbfa251579270adb Gerrit-Change-Number: 42191 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Feb 2026 14:27:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log