Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42238?usp=email )
Change subject: Introduce API osmo_asn1_tcap_TCMessage_decode()
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42238?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-asn1-tcap
Gerrit-Branch: master
Gerrit-Change-Id: I02923afb3936a1acf6643def27528e35e4b03e86
Gerrit-Change-Number: 42238
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 28 Feb 2026 13:11:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: lynxis lazus.
Hoernchen has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42225?usp=email )
Change subject: sysmoOCTSIM: define own IRQ handlers
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Oh, disregard all of that, those are nvic vectors, back to bed.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42225?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: If8476fd4a784312a0597ddd0b7eb54a7ebf94868
Gerrit-Change-Number: 42225
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Sat, 28 Feb 2026 10:04:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: lynxis lazus.
Hoernchen has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42225?usp=email )
Change subject: sysmoOCTSIM: define own IRQ handlers
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Just to be safe, __attribute__((noinline)) ?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42225?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: If8476fd4a784312a0597ddd0b7eb54a7ebf94868
Gerrit-Change-Number: 42225
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Sat, 28 Feb 2026 10:03:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: lynxis lazus.
Hoernchen has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42225?usp=email )
Change subject: sysmoOCTSIM: define own IRQ handlers
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
it is unlikely that these no-op functions will show up in a stack trace after -O3, tho..
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42225?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: If8476fd4a784312a0597ddd0b7eb54a7ebf94868
Gerrit-Change-Number: 42225
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Sat, 28 Feb 2026 10:01:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Hoernchen, laforge.
lynxis lazus has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42231?usp=email )
Change subject: remsim-bankd: Don't pass on illegal TPDUs of illegal length
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/bankd/bankd_main.c:
https://gerrit.osmocom.org/c/osmo-remsim/+/42231/comment/c1704fdc_4e20bcc5?… :
PS3, Line 826: return -107;
> Maybe this is a more general question and not so much related to this commit. […]
(unresolv it)
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42231?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I5c9f1143b85470234acd2e2ffe3e0cf72bd2ae43
Gerrit-Change-Number: 42231
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 27 Feb 2026 21:31:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: Hoernchen, laforge.
lynxis lazus has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42231?usp=email )
Change subject: remsim-bankd: Don't pass on illegal TPDUs of illegal length
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/bankd/bankd_main.c:
https://gerrit.osmocom.org/c/osmo-remsim/+/42231/comment/6d48ac94_f29f2a7d?… :
PS3, Line 826: return -107;
Maybe this is a more general question and not so much related to this commit.
But when to drop the client connection?
If we return here -107, the bankd will close the client.
But isn't this quite a harsh behavior? The quite innocent client just passed data from the other end.
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42231?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I5c9f1143b85470234acd2e2ffe3e0cf72bd2ae43
Gerrit-Change-Number: 42231
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 27 Feb 2026 21:31:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes