- gerrit-log - lists.osmocom.org

[XS] Change in osmo-hlr[osmith/1.9.1]: db: flush after changing schema version
by pespin 02 Apr '25

02 Apr '25

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-hlr/+/39893?usp=email ) Change subject: db: flush after changing schema version ...................................................................... Patch Set 2: Code-Review-1 (1 comment) Patchset: PS2: @osmith@sysmocom.de it's safe doing a patch release on top of master, the content from the other commit should have been removed a long time ago. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/39893?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hlr Gerrit-Branch: osmith/1.9.1 Gerrit-Change-Id: I5943a1cb3447c038c6e7972f68f9656b73a9248b Gerrit-Change-Number: 39893 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Apr 2025 12:00:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in docker-playground[master]: debian-bookworm-build: fix lcov-to-cobertura-xml
by osmith 02 Apr '25

02 Apr '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/39897?usp=email ) Change subject: debian-bookworm-build: fix lcov-to-cobertura-xml ...................................................................... debian-bookworm-build: fix lcov-to-cobertura-xml Use a specific commit with lcov-to-cobertura-xml, as the latest master currently can't be installed with pip. Change-Id: I2e248bf988be055a3a88cc414946e0377e266e1e --- M debian-bookworm-build/Dockerfile 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/97/39897/1 diff --git a/debian-bookworm-build/Dockerfile b/debian-bookworm-build/Dockerfile index 6755dcf..b7744f6 100644 --- a/debian-bookworm-build/Dockerfile +++ b/debian-bookworm-build/Dockerfile @@ -173,11 +173,13 @@ # Install pip dependencies (alphabetic order) # break-system-packages: inside docker it's fine to install pkgs system-wide +# lcov-to-cobertura-xml: use this commit as the latest version fails: +# https://github.com/eriwen/lcov-to-cobertura-xml/issues/63 ADD https://gitea.osmocom.org/sim-card/pysim/raw/branch/master/requirements.txt /tmp/pysim_requirements.txt RUN set -x && \ cat /tmp/pysim_requirements.txt && \ pip3 install --break-system-packages \ - 'git+https://github.com/eriwen/lcov-to-cobertura-xml.git' \ + 'git+https://github.com/eriwen/lcov-to-cobertura-xml.git@028da3798355d0260c6…' \ 'git+https://github.com/osmocom/sphinx-argparse@inside-classes#egg=sphinx-ar…' \ 'git+https://github.com/podshumok/python-smpplib.git' \ 'pydbus' \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39897?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I2e248bf988be055a3a88cc414946e0377e266e1e Gerrit-Change-Number: 39897 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: osmo-release: improve check for REL argument
by osmith 02 Apr '25

02 Apr '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/39896?usp=email ) Change subject: osmo-release: improve check for REL argument ...................................................................... osmo-release: improve check for REL argument Verify that REL is actually "patch", "minor" or "major". If it is something else (e.g. because of a typo), the script would contiune otherwise and create an invalid release commit without bumping the version. Change-Id: Ibac10dbc983b6d65cce6de10371fb731505a7ce8 --- M osmo-release.sh 1 file changed, 17 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/96/39896/1 diff --git a/osmo-release.sh b/osmo-release.sh index 61adf57..e5c8e8f 100755 --- a/osmo-release.sh +++ b/osmo-release.sh @@ -2,19 +2,23 @@ VERSION=$1 REL=$2 -if [ "z$REL" = "z" ]; then - echo "usage: make REL=patch|minor|major release" - echo - echo "optional environment variables:" - echo " DRY_RUN=1 run checks but make no modifications" - echo " ALLOW_NO_LIBVERSION_CHANGE=1 skip LIBVERSION in Makefile.am fchecks" - echo " ALLOW_NO_LIBVERSION_DEB_MATCH=1 skip LIBVERSION in debian packaging checks" - echo " ALLOW_NO_LIBVERSION_RPM_MATCH=1 skip LIBVERSION in rpm packaging checks" - echo - echo "See also:" - echo "https://osmocom.org/projects/cellular-infrastructure/wiki/Make_a_new_release" - exit 1 -fi +case "$REL" in + patch|minor|major) + ;; + *) + echo "usage: make REL=patch|minor|major release" + echo + echo "optional environment variables:" + echo " DRY_RUN=1 run checks but make no modifications" + echo " ALLOW_NO_LIBVERSION_CHANGE=1 skip LIBVERSION in Makefile.am fchecks" + echo " ALLOW_NO_LIBVERSION_DEB_MATCH=1 skip LIBVERSION in debian packaging checks" + echo " ALLOW_NO_LIBVERSION_RPM_MATCH=1 skip LIBVERSION in rpm packaging checks" + echo + echo "See also:" + echo "https://osmocom.org/projects/cellular-infrastructure/wiki/Make_a_new_release" + exit 1 + ;; +esac ALLOW_NO_LIBVERSION_CHANGE="${ALLOW_NO_LIBVERSION_CHANGE:-0}" ALLOW_NO_LIBVERSION_DEB_MATCH="${ALLOW_NO_LIBVERSION_DEB_MATCH:-0}" -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39896?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibac10dbc983b6d65cce6de10371fb731505a7ce8 Gerrit-Change-Number: 39896 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-hlr[osmith/1.9.1]: Bump version: 1.9.0.1-aa8594 → 1.9.1
by osmith 02 Apr '25

02 Apr '25

osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-hlr/+/39895?usp=email ) Change subject: Bump version: 1.9.0.1-aa8594 → 1.9.1 ...................................................................... Bump version: 1.9.0.1-aa8594 → 1.9.1 Change-Id: I95762d87086d9299f6e2a72c699f99907bf40298 --- M debian/changelog 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/95/39895/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/39895?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-hlr Gerrit-Branch: osmith/1.9.1 Gerrit-Change-Id: I95762d87086d9299f6e2a72c699f99907bf40298 Gerrit-Change-Number: 39895 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder

1 0

[XS] Change in osmo-hlr[osmith/1.9.1]: Bump version: 1.9.0.1-aa8594 → 1.9.0
by osmith 02 Apr '25

02 Apr '25

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/39894?usp=email ) Change subject: Bump version: 1.9.0.1-aa8594 → 1.9.0 ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/39894?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-hlr Gerrit-Branch: osmith/1.9.1 Gerrit-Change-Id: I56d3eeb320e175d6d1d6b50d939bbe7fd98e3ad5 Gerrit-Change-Number: 39894 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder

1 0

[XS] Change in osmo-hlr[osmith/1.9.1]: Bump version: 1.9.0.1-aa8594 → 1.9.1
by osmith 02 Apr '25

02 Apr '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/39895?usp=email ) Change subject: Bump version: 1.9.0.1-aa8594 → 1.9.1 ...................................................................... Bump version: 1.9.0.1-aa8594 → 1.9.1 Change-Id: I95762d87086d9299f6e2a72c699f99907bf40298 --- M debian/changelog 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/95/39895/1 diff --git a/debian/changelog b/debian/changelog index b1c3c88..14977ca 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +osmo-hlr (1.9.1) unstable; urgency=medium + + * db: flush after changing schema version + * Bump version: 1.9.0.1-aa8594 → 1.9.0 + + -- Oliver Smith <osmith(a)sysmocom.de> Wed, 02 Apr 2025 09:55:12 +0200 + osmo-hlr (1.9.0) unstable; urgency=medium * db: flush after changing schema version -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/39895?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hlr Gerrit-Branch: osmith/1.9.1 Gerrit-Change-Id: I95762d87086d9299f6e2a72c699f99907bf40298 Gerrit-Change-Number: 39895 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-hlr[osmith/1.9.1]: db: flush after changing schema version
by osmith 02 Apr '25

02 Apr '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/39893?usp=email ) Change subject: db: flush after changing schema version ...................................................................... db: flush after changing schema version Flush the cache after changing the version, to make the scenario less likely that after an unclean shutdown the DB gets restored with the right table layout but wrong version. When that happens, osmo-hlr tries to upgrade the database layout again and fails with errors like "duplicate column name". Related: SYS#7394 Change-Id: I5943a1cb3447c038c6e7972f68f9656b73a9248b (cherry picked from commit 1a71e73fdc40ba712ab61a299c9d4a048df539a2) --- M src/db.c 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/93/39893/1 diff --git a/src/db.c b/src/db.c index 7b8a415..4ce5aa0 100644 --- a/src/db.c +++ b/src/db.c @@ -595,6 +595,7 @@ int rc; bool has_sqlite_config_sqllog = false; int version; + bool version_changed = false; LOGP(DDB, LOGL_NOTICE, "using database: %s\n", fname); LOGP(DDB, LOGL_INFO, "Compiled against SQLite3 lib version %s\n", SQLITE_VERSION); @@ -672,6 +673,7 @@ goto out_free; } version = CURRENT_SCHEMA_VERSION; + version_changed = true; } LOGP(DDB, LOGL_NOTICE, "Database '%s' has HLR DB schema version %d\n", dbc->fname, version); @@ -686,6 +688,7 @@ } LOGP(DDB, LOGL_NOTICE, "Database '%s' has been upgraded to HLR DB schema version %d\n", dbc->fname, version+1); + version_changed = true; } if (version != CURRENT_SCHEMA_VERSION) { @@ -702,6 +705,12 @@ goto out_free; } + /* Flush the cache after changing the version, to make the scenario + * less likely that after an unclean shutdown the DB gets restored + * with the right table layout but wrong version (SYS#7394). */ + if (version_changed) + sqlite3_db_cacheflush(dbc->db); + /* prepare all SQL statements */ for (i = 0; i < ARRAY_SIZE(dbc->stmt); i++) { rc = sqlite3_prepare_v2(dbc->db, stmt_sql[i], -1, -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/39893?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hlr Gerrit-Branch: osmith/1.9.1 Gerrit-Change-Id: I5943a1cb3447c038c6e7972f68f9656b73a9248b Gerrit-Change-Number: 39893 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-hlr[osmith/1.9.1]: Bump version: 1.9.0.1-aa8594 → 1.9.0
by osmith 02 Apr '25

02 Apr '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/39894?usp=email ) Change subject: Bump version: 1.9.0.1-aa8594 → 1.9.0 ...................................................................... Bump version: 1.9.0.1-aa8594 → 1.9.0 Change-Id: I56d3eeb320e175d6d1d6b50d939bbe7fd98e3ad5 --- M debian/changelog 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/94/39894/1 diff --git a/debian/changelog b/debian/changelog index dbf1ec1..b1c3c88 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,5 +1,11 @@ osmo-hlr (1.9.0) unstable; urgency=medium + * db: flush after changing schema version + + -- Oliver Smith <osmith(a)sysmocom.de> Wed, 02 Apr 2025 09:54:51 +0200 + +osmo-hlr (1.9.0) unstable; urgency=medium + [ Vadim Yanitskiy ] * subscriber-create-on-demand: rework configuration * subscriber-create-on-demand: add mode for MSISDN=IMSI -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/39894?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hlr Gerrit-Branch: osmith/1.9.1 Gerrit-Change-Id: I56d3eeb320e175d6d1d6b50d939bbe7fd98e3ad5 Gerrit-Change-Number: 39894 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in pysim[master]: saip-tool: add commandline option to edit mandatory services list
by laforge 02 Apr '25

02 Apr '25

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39863?usp=email ) Change subject: saip-tool: add commandline option to edit mandatory services list ...................................................................... Patch Set 3: (1 comment) File contrib/saip-tool.py: https://gerrit.osmocom.org/c/pysim/+/39863/comment/2c73979f_400e49a4?usp=em… : PS3, Line 106: action there is a way (I forgot how exactly, maybet he "choices" argument?) to tell the parser which strings are permitted here. Please try to figure out how to get that from the asn1 parser. This way we can * catch invalid/unsupported input already within argparse * the user sees which services they can add/remove in --help -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39863?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I120b98d4b0942c26674bc1365c5711101ec95235 Gerrit-Change-Number: 39863 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Apr 2025 07:39:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in pysim[master]: saip-tool: add commandline option to edit mandatory services list
by laforge 02 Apr '25

02 Apr '25

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39863?usp=email ) Change subject: saip-tool: add commandline option to edit mandatory services list ...................................................................... Patch Set 3: (1 comment) File contrib/saip-tool.py: https://gerrit.osmocom.org/c/pysim/+/39863/comment/1aeeab4f_0675acba?usp=em… : PS3, Line 104: set "set" sounds like it is setting (overwriting) the list. Add/remove however are incremental operations, so I think it's a bit of a misnomer. I'd suggest to rename to edit-mandatory-service-list, edit-mand-service-list or something like that, or "modify" instead of "edit". or if you think it's too long, {edit,modify}-mand-srv-list? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39863?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I120b98d4b0942c26674bc1365c5711101ec95235 Gerrit-Change-Number: 39863 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Apr 2025 07:37:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log