Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39863?usp=email ) Change subject: saip-tool: add commandline option to edit mandatory services list ...................................................................... Patch Set 3: (1 comment) File contrib/saip-tool.py: https://gerrit.osmocom.org/c/pysim/+/39863/comment/1aeeab4f_0675acba?usp=ema... : PS3, Line 104: set "set" sounds like it is setting (overwriting) the list. Add/remove however are incremental operations, so I think it's a bit of a misnomer. I'd suggest to rename to edit-mandatory-service-list, edit-mand-service-list or something like that, or "modify" instead of "edit". or if you think it's too long, {edit,modify}-mand-srv-list? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39863?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I120b98d4b0942c26674bc1365c5711101ec95235 Gerrit-Change-Number: 39863 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Wed, 02 Apr 2025 07:37:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No