Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39863?usp=email ) Change subject: saip-tool: add commandline option to edit mandatory services list ...................................................................... Patch Set 3: (1 comment) File contrib/saip-tool.py: https://gerrit.osmocom.org/c/pysim/+/39863/comment/2c73979f_400e49a4?usp=ema... : PS3, Line 106: action there is a way (I forgot how exactly, maybet he "choices" argument?) to tell the parser which strings are permitted here. Please try to figure out how to get that from the asn1 parser. This way we can * catch invalid/unsupported input already within argparse * the user sees which services they can add/remove in --help -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39863?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I120b98d4b0942c26674bc1365c5711101ec95235 Gerrit-Change-Number: 39863 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Wed, 02 Apr 2025 07:39:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No