- gerrit-log - lists.osmocom.org

[M] Change in pysim[master]: [3/6] personalization: refactor Puk
by laforge 19 Apr '25

19 Apr '25

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39743?usp=email ) Change subject: [3/6] personalization: refactor Puk ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39743?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I271e6c030c890778ab7af9ab3bc7997e22018f6a Gerrit-Change-Number: 39743 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 19 Apr 2025 16:14:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in pysim[master]: [2/6] personalization: refactor ConfigurableParameter, Iccid, Imsi
by laforge 19 Apr '25

19 Apr '25

Attention is currently required from: dexter, fixeria, neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39742?usp=email ) Change subject: [2/6] personalization: refactor ConfigurableParameter, Iccid, Imsi ...................................................................... Patch Set 7: Code-Review+1 (2 comments) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39742/comment/77dfcdc5_a3eee2d7?usp=em… : PS7, Line 67: = shouldn't that be a double-equals (also below)? to me it looks like an assignment rather than a comparison? https://gerrit.osmocom.org/c/pysim/+/39742/comment/a0f0005a_ad7564bd?usp=em… : PS7, Line 100: allow_types = (str, int, ) Does the comma with empty element imply that None is a vaid input value? In that case, I'd prefer an explicit None. Not critical. Just saying I don't understand the way that code is written. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39742?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8 Gerrit-Change-Number: 39742 Gerrit-PatchSet: 7 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 19 Apr 2025 16:11:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in pysim[master]: [1/6] personalization: refactor: drop ClassVarMeta use
by laforge 19 Apr '25

19 Apr '25

Attention is currently required from: fixeria, neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39741?usp=email ) Change subject: [1/6] personalization: refactor: drop ClassVarMeta use ...................................................................... Patch Set 7: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39741/comment/f3b91bd8_214049bb?usp=em… : PS7, Line 155: class SdKeyScp80_01(SdKey): I'm still somewhat doubtful that this is an improvement. You're turning something that was a very nice single-line syntax into something that now needs three lines to declare something. The original syntax was almost like a table, with columns listing each key_id and key_usage_qual at the same positinin of each line... What I really fail to see is some kind of argument in the commit log how the new approach is better than the old one. I really don't want to spend weeks or months arguing about this. I just want to understand what is the improvement here. "Not using a metaclass" doesn't seem like a qualitative improvement of the code. What was the problem caused by the metaclass? Why is it desirable to not use one? The questions are not rhethorical. I tend to use metaclasses quite a bit in pySim and elsewhere, and so far nobody has argued in code review that anything is wrong about this. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39741?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I60ea8fd11fb438ec90ddb08b17b658cbb789c051 Gerrit-Change-Number: 39741 Gerrit-PatchSet: 7 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 19 Apr 2025 16:07:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmocom-bb[master]: trx_toolkit/clck_gen: Don't use threads because Python GIL is latency...
by kirr 18 Apr '25

18 Apr '25

Attention is currently required from: fixeria. kirr has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40047?usp=email ) Change subject: trx_toolkit/clck_gen: Don't use threads because Python GIL is latency killer ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > P.S. However one thing that could be maybe possible to maybe do is to merge the patch > of pyx timerfd right after switch to cython. Then the time where fake_trx becomes py3.13-only will be limited. I moved `trx_toolkit/_clck_gen: Unroll our own timerfd_* functions` to come right after `trx_toolkit: Move FakeTRX-related performance-sensitive modules to Cython` in the patch series as explained above. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40047?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaa675c95059ec8ccfad667f69984d5a7f608c249 Gerrit-Change-Number: 40047 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Apr 2025 08:19:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: kirr <kirr(a)nexedi.com> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmocom-bb[master]: trx_toolkit/clck_gen: Don't use threads because Python GIL is latency...
by kirr 18 Apr '25

18 Apr '25

Attention is currently required from: fixeria. kirr has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40047?usp=email ) Change subject: trx_toolkit/clck_gen: Don't use threads because Python GIL is latency killer ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Looks good to me, thank you! […] Vadim, thanks for feedback. There are drawbacks of both approaches: if we do it earlier in the patchset, then faketrx cannot work without cython at all. However this fix does not require cython and can be done in pure python. It brings significant benefit just by itself, but unfortunately that speedup is not enough. Overall the problem here is similar to bootstrapping: you cannot really do via single-step without braking something: do single step in plain py - we break compatibility with py < 3.13. Do single step with upgrading to cython: we break compatibility with current tests because they all do currently fail as it is not programmed there to build fake_trx before running it. I choosed to do this step in plain py without bringing cython yet, because it looks more logical to me to fix this while being at plain py level. Reworking the patches to bring cython earlier would be alot of internal inter-patch churn without, in my view, strong benefit. I would appreciate if we can leave the order of steps as they are currently. Kirill P.S. However one thing that could be maybe possible to maybe do is to merge the patch of pyx timerfd right after switch to cython. Then the time where fake_trx becomes py3.13-only will be limited. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40047?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaa675c95059ec8ccfad667f69984d5a7f608c249 Gerrit-Change-Number: 40047 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Apr 2025 08:12:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: kirr <kirr(a)nexedi.com> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmocom-bb[master]: trx_toolkit/clck_gen: Don't use threads because Python GIL is latency...
by fixeria 18 Apr '25

18 Apr '25

Attention is currently required from: kirr. fixeria has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40047?usp=email ) Change subject: trx_toolkit/clck_gen: Don't use threads because Python GIL is latency killer ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > > Unfortunately os.timerfd_create() & friends are only available starting […] Looks good to me, thank you! Just one moment: can we somehow do this earlier in the patchset? Otherwise one would have to bypass the build verification for most of the patches in this set. Not only this is annoying (it needs to be done manually for each patch), but also imposes a risk of not noticing a regression somewhere in the middle. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40047?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaa675c95059ec8ccfad667f69984d5a7f608c249 Gerrit-Change-Number: 40047 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Comment-Date: Fri, 18 Apr 2025 07:24:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: kirr <kirr(a)nexedi.com> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmocom-bb[master]: trx_toolkit/clck_gen: Don't use threads because Python GIL is latency...
by kirr 18 Apr '25

18 Apr '25

Attention is currently required from: fixeria. kirr has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40047?usp=email ) Change subject: trx_toolkit/clck_gen: Don't use threads because Python GIL is latency killer ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Unfortunately os.timerfd_create() & friends are only available starting > from Python 3.13 . If this poses a problem it can be easily solved by > doing those timerfd related system calls in Cython, after we switch most > of the codebase to Cython later. I filed https://gerrit.osmocom.org/c/osmocom-bb/+/40092 trx_toolkit/_clck_gen: Unroll our own timerfd_* functions to do that, so that fake_trx and clck_gen can again work on any py3 versions, not only on py3 ≥ 3.13 . Hope it is ok. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40047?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaa675c95059ec8ccfad667f69984d5a7f608c249 Gerrit-Change-Number: 40047 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Apr 2025 07:11:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: kirr <kirr(a)nexedi.com> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmocom-bb[master]: trx_toolkit/_clck_gen: Unroll our own timerfd_* functions
by kirr 18 Apr '25

18 Apr '25

kirr has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40092?usp=email ) Change subject: trx_toolkit/_clck_gen: Unroll our own timerfd_* functions ...................................................................... trx_toolkit/_clck_gen: Unroll our own timerfd_* functions Iaa675c95059ec8ccfad667f69984d5a7f608c249 (trx_toolkit/clck_gen: Don't use threads because Python GIL is latency killer) switched CLCKGen to use timerfd and noted Unfortunately os.timerfd_create() & friends are only available starting from Python 3.13 . If this poses a problem it can be easily solved by doing those timerfd related system calls in Cython, after we switch most of the codebase to Cython later. As we are currently using py3.11 on the testing infrastructure it makes sense not to force us to upgrade to py3.13 there. -> Unroll our own timerfd_* wrappers so that clck_gen and fake_trx work again on all py3 versions, not only on py3 ≥ 3.13 . Change-Id: I39e4e05ba65fcb3e07bcfe19a3ef95201aaa40d0 --- M src/target/trx_toolkit/_clck_gen.pyx 1 file changed, 49 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/92/40092/1 diff --git a/src/target/trx_toolkit/_clck_gen.pyx b/src/target/trx_toolkit/_clck_gen.pyx index 3a6bfc7..dbd3c75 100644 --- a/src/target/trx_toolkit/_clck_gen.pyx +++ b/src/target/trx_toolkit/_clck_gen.pyx @@ -53,7 +53,7 @@ self._t_tick = int(self.ctr_interval // ns) # Initialize timer fd - self._timerfd = os.timerfd_create(time.CLOCK_MONOTONIC) + self._timerfd = _os_timerfd_create(time.CLOCK_MONOTONIC) # (Optional) clock consumer self.clck_handler = None @@ -63,7 +63,7 @@ @property def running(self): - t_next, _ = os.timerfd_gettime_ns(self._timerfd) + t_next, _ = _os_timerfd_gettime_ns(self._timerfd) return (t_next != 0) def start(self): @@ -71,11 +71,11 @@ self.clck_src = self.clck_start # start timer fd - os.timerfd_settime_ns(self._timerfd, initial=self._t_tick, interval=self._t_tick) + _os_timerfd_settime_ns(self._timerfd, flags=0, initial=self._t_tick, interval=self._t_tick) def stop(self): # stop timer fd - os.timerfd_settime_ns(self._timerfd, initial=0, interval=0) + _os_timerfd_settime_ns(self._timerfd, flags=0, initial=0, interval=0) # tick must be called periodically by CLCKGen user. # @@ -129,3 +129,48 @@ # Increase frame count (modular arithmetic) self.clck_src = (self.clck_src + 1) % GSM_HYPERFRAME + + +# ---- misc ---- + +# _os_timerfd_<func> is like os.timerfd_<func> but works on all python versions. +# we do it ourselves because os.timerfd_* is available only for py ≥ 3.13 + +from posix.time cimport timespec, itimerspec + +cdef extern from "<sys/timerfd.h>": + int timerfd_create(int clockid, int flags) + int timerfd_settime(int fd, int flags, const itimerspec *new_value, itimerspec *old_value) + int timerfd_gettime(int fd, itimerspec *curr_value) + + +cdef int _os_timerfd_create(int clockid, int flags=0) except -1: + fd = timerfd_create(clockid, flags) + if fd == -1: + _raise_oserr() + return fd + +cdef _os_timerfd_settime_ns(int fd, flags=0, initial=0, interval=0): + cdef itimerspec its + its.it_value .tv_sec = initial // 1000000000 # 1e9 + its.it_value .tv_nsec = initial % 1000000000 + its.it_interval .tv_sec = interval // 1000000000 + its.it_interval .tv_nsec = interval % 1000000000 + err = timerfd_settime(fd, flags, &its, NULL) + if err == -1: + _raise_oserr() + +cdef _os_timerfd_gettime_ns(int fd): # -> (next_expiration, interval) + cdef itimerspec its + err = timerfd_gettime(fd, &its) + if err == -1: + _raise_oserr() + cdef object t_next = 0L # py long to avoid int overflow + cdef object t_interval = 0L + t_next += its.it_value.tv_sec + t_next *= 1000000000 # 1e9 + t_next += its.it_value.tv_nsec + t_interval += its.it_interval.tv_sec + t_interval *= 1000000000 # 1e9 + t_interval += its.it_interval.tv_nsec + return (t_next, t_interval) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40092?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I39e4e05ba65fcb3e07bcfe19a3ef95201aaa40d0 Gerrit-Change-Number: 40092 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmocom-bb[master]: trx_toolkit/_fake_trx: Optimize IO loop fd polling
by kirr 18 Apr '25

18 Apr '25

Attention is currently required from: kirr. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/40064?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: trx_toolkit/_fake_trx: Optimize IO loop fd polling ...................................................................... trx_toolkit/_fake_trx: Optimize IO loop fd polling As can be seen from http://navytux.spb.ru/~kirr/osmo/fake_trx/pyx-base.html (Runner_5loop) the system spends more in py select wrapper compared to select system call itself. And also the wrapper releases/reacquires gil, which, as Iaa675c95059ec8ccfad667f69984d5a7f608c249 (trx_toolkit/clck_gen: Don't use threads because Python GIL is latency killer) shows, can have dramatic effect. It is also known that select inside the kernel is doing useless work at every call by registering/deregistering each fd every time. -> Avoid all that overhead by switching to epoll and doing epoll_wait ourselves and without releasing/reacquiring the gil. We can do that because fake_trx is single-threaded and because clck_gen._timerfd is setup to do ~ 200 Hz regular wakeup. Change-Id: I748810871601178cc97bcdaba41419949078c29d --- M src/target/trx_toolkit/_fake_trx.pyx 1 file changed, 111 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/64/40064/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40064?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I748810871601178cc97bcdaba41419949078c29d Gerrit-Change-Number: 40064 Gerrit-PatchSet: 2 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com>

1 0

[M] Change in osmocom-bb[master]: trx_toolkit/transceiver: Switch Transceiver to cdef class
by kirr 18 Apr '25

18 Apr '25

Attention is currently required from: kirr. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/40066?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: trx_toolkit/transceiver: Switch Transceiver to cdef class ...................................................................... trx_toolkit/transceiver: Switch Transceiver to cdef class - Put fields into the object struct; fields are now accessed directly via that C-level struct instead of via __dict__ lookup - cimport instead of import Transceiver at the users - switch to invoke several Transceiver function via C-level where appropriate. Add type annotations to trx variables correspondingly. Change-Id: Ic7039451136b04dacfaf839b21f11b300f579603 --- M src/target/trx_toolkit/_fake_trx.pyx M src/target/trx_toolkit/burst_fwd.pxd M src/target/trx_toolkit/burst_fwd.pyx A src/target/trx_toolkit/transceiver.pxd M src/target/trx_toolkit/transceiver.pyx 5 files changed, 76 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/66/40066/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40066?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic7039451136b04dacfaf839b21f11b300f579603 Gerrit-Change-Number: 40066 Gerrit-PatchSet: 2 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com>

1 0

2026

2025

2024

2023

2022

gerrit-log