- gerrit-log - lists.osmocom.org

[M] Change in osmocom-bb[master]: trx_toolkit/data_msg: Optimize RxMsg/TxMsg parsing
by kirr 18 Apr '25

18 Apr '25

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/40078?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: trx_toolkit/data_msg: Optimize RxMsg/TxMsg parsing ...................................................................... trx_toolkit/data_msg: Optimize RxMsg/TxMsg parsing Thread all calls related in parsing to be done via C-level and with explicit types. Leverage bytearray ability to cut prefix and suffix efficiently. Replace struct.unpack with custom C-level functions to deserialize big-endian integers. Use raw C pointers to access bytearray data to avoid related py-index overhead. Change-Id: I661a414bf5091fa6b872831ba911465a8d073397 --- M src/target/trx_toolkit/data_if.pyx M src/target/trx_toolkit/data_msg.pxd M src/target/trx_toolkit/data_msg.pyx 3 files changed, 69 insertions(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/78/40078/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40078?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I661a414bf5091fa6b872831ba911465a8d073397 Gerrit-Change-Number: 40078 Gerrit-PatchSet: 2 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in pysim[master]: [1/6] personalization: refactor: drop ClassVarMeta use
by neels 18 Apr '25

18 Apr '25

Attention is currently required from: fixeria, neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/39741?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: [1/6] personalization: refactor: drop ClassVarMeta use ...................................................................... [1/6] personalization: refactor: drop ClassVarMeta use Drop the ClassVarMeta/metaclass/ABCMeta stuff -- it doesn't seem to serve any purpose that is not similarly achieved with plain python inheritance. Upcoming patches will use normal inheritance a lot more. Note that most use of the ClassVarMeta was in the SdKey subclasses, and that these currently don't actually work. See the fix in patch I07dfc378705eba1318e9e8652796cbde106c6a52 . name: set a default name from the python class, as ClassVarMeta did. Also allow setting an explicit string as name instead, per subclass implementation (see I31f390d634e58c384589c50a33ca45d6f86d4e10). Related: SYS#6768 Change-Id: I60ea8fd11fb438ec90ddb08b17b658cbb789c051 --- M pySim/esim/saip/personalization.py 1 file changed, 147 insertions(+), 82 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/41/39741/7 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39741?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I60ea8fd11fb438ec90ddb08b17b658cbb789c051 Gerrit-Change-Number: 39741 Gerrit-PatchSet: 7 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in pysim[master]: [2/6] personalization: refactor ConfigurableParameter, Iccid, Imsi
by neels 18 Apr '25

18 Apr '25

Attention is currently required from: dexter, fixeria, laforge. Hello Jenkins Builder, dexter, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/39742?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-Review+1 by dexter, Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: [2/6] personalization: refactor ConfigurableParameter, Iccid, Imsi ...................................................................... [2/6] personalization: refactor ConfigurableParameter, Iccid, Imsi Main points/rationales of the refactoring, details below: 1) common validation implementation 2) offer classmethods The new features are optional, and will be heavily used by batch personalization patches coming soon. Implement Iccid and Imsi to use the new way, with a common abstract DecimalParam implementation. So far leave the other parameter classes working as they always did, to follow suit in subsequent commits. Details: 1) common validation implementation: There are very common validation steps in the various parameter implementations. It is more convenient and much more readable to implement those once and set simple validation parameters per subclass. So there now is a validate_val() classmethod, which subclasses can use as-is to apply the validation parameters -- or subclasses can override their cls.validate_val() for specialized validation. (Those subclasses that this patch doesn't touch still override the self.validate() instance method. Hence they still work as before this patch, but don't use the new common features yet.) 2) offer stateless classmethods: It is useful for... - batch processing of multiple profiles (in upcoming patches) and - user input validation to be able to have classmethods that do what self.validate() and self.apply() do, but do not modify any self.* members. So far the paradigm was to create a class instance to keep state about the value. This remains available, but in addition we make available the paradigm of a singleton that is stateless (the classmethods). Using self.validate() and self.apply() still work the same as before this patch, i.e. via self.input_value and self.value -- but in addition, there are now classmethods that don't touch self.* members. Related: SYS#6768 Change-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8 --- M pySim/esim/saip/personalization.py 1 file changed, 179 insertions(+), 34 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/42/39742/7 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39742?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8 Gerrit-Change-Number: 39742 Gerrit-PatchSet: 7 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in ...osmo-s1gw[master]: Bump version: 0.2.0-61-g09ac383 → 0.3.0
by fixeria 17 Apr '25

17 Apr '25

Attention is currently required from: laforge, osmith. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40091?usp=email ) Change subject: Bump version: 0.2.0-61-g09ac383 → 0.3.0 ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40091?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ibd805fb754ed210e07f2a7fea1a14f610e35e520 Gerrit-Change-Number: 40091 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 17 Apr 2025 19:57:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[M] Change in ...osmo-s1gw[master]: Bump version: 0.2.0 → 0.3.0
by fixeria 17 Apr '25

17 Apr '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40091?usp=email ) Change subject: Bump version: 0.2.0 → 0.3.0 ...................................................................... Bump version: 0.2.0 → 0.3.0 Change-Id: Ibd805fb754ed210e07f2a7fea1a14f610e35e520 --- M debian/changelog 1 file changed, 66 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/91/40091/1 diff --git a/debian/changelog b/debian/changelog index 35ec97f..7ea71d0 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,69 @@ +osmo-s1gw (0.3.0) unstable; urgency=medium + + * s1ap_proxy: merge process_pdu_safe() with process_pdu() + * s1ap_proxy: do not expose {en,de}code_pdu() API + * s1ap_proxy: turn this module into a gen_server + * s1ap_proxy: add E-RAB introspection API + * erab_fsm: rename erab_release_req/1 -> erab_release_cmd/1 + * erab_fsm: add erab_release/2 and erab_release_ind/1 + * s1ap_proxy: properly handle E-RAB RELEASE IND + * erab_fsm: add all-state event handler + * erab_fsm: add fetch_info/1 for state introspection + * sctp_server: add type hints + * sctp_server: cosmetic: use ?FUNCTION_NAME in send_data/2 + * sctp_server: pass MME addr/port to sctp_proxy as opaque data + * sctp_server: cosmetic: rename State -> S + * sctp_server: cosmetic: make #server_state last argument + * sctp_server: pass #server_state to client_{add,del}() + * sctp_server: make it abstract from sctp_proxy logic + * sctp_server: add fetch_conn_list/0 for state introspection + * sctp_proxy: add all-state event handler + * sctp_proxy: add fetch_info/1 for state introspection + * s1ap_proxy: use erab_uid() to log unique E-RAB ID + * s1ap_proxy: add a TODO about an optional IE + * s1ap_proxy: rework handle_ie/2 into handle_ie/3 + * s1ap_proxy: handle_ies(): reorder arguments + * s1ap_proxy: handle_ies(): pass IEI path to handle_ie() + * s1ap_proxy: handle_ies(): also handle #'ProtocolExtensionField' + * erab_fsm: store UID, expose it via fetch_info/1 + * erab_fsm: session_modify(): split PFCP PDU handling + * s1ap_proxy: cosmetic: fix wrong arity in comment + * s1ap_proxy: fix IEI path leak in handle_ies/4 + * erab_fsm: fix copy-paste in a log message + * erab_fsm: add more logging to clarify timeout events + * rebar.config: remove unneeded parse_transform + * erab_fsm: add pretty printer for F-TEID + * s1ap_proxy: handle UE CONTEXT RELEASE PDUs + * osmo_s1gw.app.src: set 'vsn' to 'semver' + * rebar.config: cosmetic: use spaces, not tabs + * rebar.config: relx: fix release name (must be an atom) + * rebar.config: relx: generate the version automatically + * {erab_fsm,sctp_proxy}: handle_event/4: fix return value + * {erab_fsm,sctp_proxy}: handle_event/4: reply to unknown calls + * erab_fsm: make erab_release_{cmd,ind}/1 non-blocking + * erab_fsm: handle RELEASE.{cmd,ind} in state erab_wait_setup_rsp + * erab_fsm: handle RELEASE.ind in state erab_wait_release_rsp + * erab_fsm: implement E-RAB MODIFY Req/Rsp procedure + * erab_fsm: implement E-RAB MODIFY Ind/Cnf procedure + * erab_fsm: pretty-print U2CM and U2AM during MODIFY Req/Ind + * s1ap_proxy: catch exceptions in handle_pdu/2 + * s1ap_proxy: handle E-RAB MODIFY REQ/RSP + * s1ap_proxy: handle E-RAB MODIFICATION IND/CNF + * s1ap_proxy: increment *_IN_PKT_* counters on exception + * sctp_server: invalidate handler's Pid on 'EXIT' + * sctp_{server,proxy}: log SCTP TSN, SID, SSN, and data len + * sctp_common: new module with common SCTP/S1AP API + * s1gw_metrics: use lists:filter/2 to create counters/gauges + * sctp_{client,server}: disable Nagle by setting sctp_nodelay + * s1gw_metrics: make exometer_report_statsd less verbose + * sctp_{client,server}: add and use sctp_common:parse_addr/1 + * sctp_{client,server}: accept arguments in form of a map + * sctp_{client,server}: allow passing additional sockopts + * sctp_{client,server}: make sctp_nodelay configurable + * sctp_{client,server}: set sndbuf/recbuf explicitly + + -- Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Fri, 18 Apr 2025 02:37:19 +0700 + osmo-s1gw (0.2.0) unstable; urgency=medium [ Vadim Yanitskiy ] -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40091?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ibd805fb754ed210e07f2a7fea1a14f610e35e520 Gerrit-Change-Number: 40091 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmocom-bb[master]: trx_toolkit/data_msg: Optimize RxMsg/TxMsg parsing
by kirr 17 Apr '25

17 Apr '25

kirr has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40078?usp=email ) Change subject: trx_toolkit/data_msg: Optimize RxMsg/TxMsg parsing ...................................................................... Patch Set 1: (1 comment) File src/target/trx_toolkit/data_msg.pyx: https://gerrit.osmocom.org/c/osmocom-bb/+/40078/comment/561a0f47_70de8b85?u… : PS1, Line 710: # NOTE header lenght is already pre-checked by _parse_msg > > 'lenght' may be misspelled - perhaps 'length'? […] ( I thought there is a way for Jenkins to fix this automatically via clicking "Please fix" button ) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40078?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I661a414bf5091fa6b872831ba911465a8d073397 Gerrit-Change-Number: 40078 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Apr 2025 15:34:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: kirr <kirr(a)nexedi.com>

1 0

[M] Change in osmocom-bb[master]: trx_toolkit/data_msg: Optimize RxMsg/TxMsg parsing
by kirr 17 Apr '25

17 Apr '25

kirr has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40078?usp=email ) Change subject: trx_toolkit/data_msg: Optimize RxMsg/TxMsg parsing ...................................................................... Patch Set 1: (2 comments) File src/target/trx_toolkit/data_msg.pyx: https://gerrit.osmocom.org/c/osmocom-bb/+/40078/comment/cc6fb76d_90adae90?u… : PS1, Line 397: # NOTE header lenght is already pre-checked by _parse_msg > 'lenght' may be misspelled - perhaps 'length'? Please fix. https://gerrit.osmocom.org/c/osmocom-bb/+/40078/comment/f685c27d_8b5f2926?u… : PS1, Line 710: # NOTE header lenght is already pre-checked by _parse_msg > 'lenght' may be misspelled - perhaps 'length'? Please fix. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40078?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I661a414bf5091fa6b872831ba911465a8d073397 Gerrit-Change-Number: 40078 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Apr 2025 15:33:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmocom-bb[master]: trx_toolkit/udp_link: Factor code to describe remote into .desc_remot...
by kirr 17 Apr '25

17 Apr '25

Attention is currently required from: fixeria, laforge. kirr has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40046?usp=email ) Change subject: trx_toolkit/udp_link: Factor code to describe remote into .desc_remote() function ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Acknowledged, but can be merged as-is and further improved later. Here we do not need it for performance. We only need to move the logic into one place because in https://gerrit.osmocom.org/c/osmocom-bb/+/40055 str remote_addr + remote_port will be changed to sole `struct sockaddr_in remote_addr` and without keeping the logic in one place we will need to update all users. I used a function, because `.desc_link()` is already a function, not a property. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40046?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1e2fa560ada7a8de4c9b9150058c2a1c73874fbe Gerrit-Change-Number: 40046 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Apr 2025 13:22:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmocom-bb[master]: trx_toolkit/burst_fwd: Do not inherit BurstForwarder from TRXList
by fixeria 17 Apr '25

17 Apr '25

Attention is currently required from: kirr. fixeria has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40053?usp=email ) Change subject: trx_toolkit/burst_fwd: Do not inherit BurstForwarder from TRXList ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40053?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9ce8ca1531eea5d59358fb41cc99d8c349757abb Gerrit-Change-Number: 40053 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Comment-Date: Thu, 17 Apr 2025 12:41:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in osmocom-bb[master]: trx_toolkit/fake_trx: Split it into fake_trx and _fake_trx modules
by fixeria 17 Apr '25

17 Apr '25

Attention is currently required from: kirr. fixeria has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40051?usp=email ) Change subject: trx_toolkit/fake_trx: Split it into fake_trx and _fake_trx modules ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40051?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iadffd49de8197564e57bfd9cb660b1d11136ffd4 Gerrit-Change-Number: 40051 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Comment-Date: Thu, 17 Apr 2025 12:37:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log