- gerrit-log - lists.osmocom.org

[M] Change in pysim[master]: [2/6] personalization: refactor ConfigurableParameter, Iccid, Imsi
by neels 19 Apr '25

19 Apr '25

Attention is currently required from: dexter, fixeria, laforge, neels. Hello Jenkins Builder, dexter, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/39742?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: [2/6] personalization: refactor ConfigurableParameter, Iccid, Imsi ...................................................................... [2/6] personalization: refactor ConfigurableParameter, Iccid, Imsi Main points/rationales of the refactoring, details below: 1) common validation implementation 2) offer classmethods The new features are optional, and will be heavily used by batch personalization patches coming soon. Implement Iccid and Imsi to use the new way, with a common abstract DecimalParam implementation. So far leave the other parameter classes working as they always did, to follow suit in subsequent commits. Details: 1) common validation implementation: There are very common validation steps in the various parameter implementations. It is more convenient and much more readable to implement those once and set simple validation parameters per subclass. So there now is a validate_val() classmethod, which subclasses can use as-is to apply the validation parameters -- or subclasses can override their cls.validate_val() for specialized validation. (Those subclasses that this patch doesn't touch still override the self.validate() instance method. Hence they still work as before this patch, but don't use the new common features yet.) 2) offer stateless classmethods: It is useful for... - batch processing of multiple profiles (in upcoming patches) and - user input validation to be able to have classmethods that do what self.validate() and self.apply() do, but do not modify any self.* members. So far the paradigm was to create a class instance to keep state about the value. This remains available, but in addition we make available the paradigm of a singleton that is stateless (the classmethods). Using self.validate() and self.apply() still work the same as before this patch, i.e. via self.input_value and self.value -- but in addition, there are now classmethods that don't touch self.* members. Related: SYS#6768 Change-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8 --- M pySim/esim/saip/personalization.py 1 file changed, 180 insertions(+), 34 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/42/39742/8 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39742?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8 Gerrit-Change-Number: 39742 Gerrit-PatchSet: 8 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in pysim[master]: [1/6] personalization: refactor: drop ClassVarMeta use
by neels 19 Apr '25

19 Apr '25

Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/39741?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: [1/6] personalization: refactor: drop ClassVarMeta use ...................................................................... [1/6] personalization: refactor: drop ClassVarMeta use Drop the ClassVarMeta/metaclass/ABCMeta stuff -- it doesn't seem to serve any purpose that is not similarly achieved with plain python inheritance. Upcoming patches will use normal inheritance a lot more. Note that most use of the ClassVarMeta was in the SdKey subclasses, and that these currently don't actually work. See the fix in patch I07dfc378705eba1318e9e8652796cbde106c6a52 . name: set a default name from the python class, as ClassVarMeta did. Also allow setting an explicit string as name instead, per subclass implementation (see I31f390d634e58c384589c50a33ca45d6f86d4e10). Related: SYS#6768 Change-Id: I60ea8fd11fb438ec90ddb08b17b658cbb789c051 --- M pySim/esim/saip/personalization.py 1 file changed, 149 insertions(+), 82 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/41/39741/8 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39741?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I60ea8fd11fb438ec90ddb08b17b658cbb789c051 Gerrit-Change-Number: 39741 Gerrit-PatchSet: 8 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in pysim[master]: [1/6] personalization: refactor: drop ClassVarMeta use
by neels 19 Apr '25

19 Apr '25

Attention is currently required from: fixeria, laforge. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39741?usp=email ) Change subject: [1/6] personalization: refactor: drop ClassVarMeta use ...................................................................... Patch Set 7: (1 comment) Patchset: PS6: > CSV matching: I have other use cases than you do. […] In this new patch set, the name and camel_to_snake() are back (they were lost by accident from branch rebasing). reasons in my decision against a meta class: - i don't understand what purpose a meta class serves. - fixeria's example shows that the shortest way to achieve class attributes is ~~~ class Foo: a = 1 b = 2 ~~~ I like this plain python better than kwargs juggling. - upcoming patches add a lot of class attributes, and i would like to consistently use one way. I chose the "normal python" way, so as a first step, this patch drops the meta class. - name: i would like to set explicit names like 'IMSI' instead of 'imsi', Hence i change to using an explicit 'name' attribute instead of getattr magic. When no explicit name is set, all still behaves as before this patch. I hope that I've made my point, so i am now, in a hopeful way, resolving this thread. Please -1 again if i should change it. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39741?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I60ea8fd11fb438ec90ddb08b17b658cbb789c051 Gerrit-Change-Number: 39741 Gerrit-PatchSet: 7 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 19 Apr 2025 20:59:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in pysim[master]: [1/6] personalization: refactor: drop ClassVarMeta use
by neels 19 Apr '25

19 Apr '25

Attention is currently required from: fixeria, laforge. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39741?usp=email ) Change subject: [1/6] personalization: refactor: drop ClassVarMeta use ...................................................................... Patch Set 7: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39741/comment/2f8fe753_c0f31009?usp=em… : PS7, Line 155: class SdKeyScp80_01(SdKey): > I'm still somewhat doubtful that this is an improvement. […] (merging with the other "thread") -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39741?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I60ea8fd11fb438ec90ddb08b17b658cbb789c051 Gerrit-Change-Number: 39741 Gerrit-PatchSet: 7 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 19 Apr 2025 20:37:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[M] Change in ...osmo-s1gw[master]: Bump version: 0.2.0-61-g09ac383 → 0.3.0
by fixeria 19 Apr '25

19 Apr '25

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40091?usp=email ) Change subject: Bump version: 0.2.0-61-g09ac383 → 0.3.0 ...................................................................... Bump version: 0.2.0-61-g09ac383 → 0.3.0 Change-Id: Ibd805fb754ed210e07f2a7fea1a14f610e35e520 --- M debian/changelog 1 file changed, 66 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog index 35ec97f..90691c8 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,69 @@ +osmo-s1gw (0.3.0) unstable; urgency=medium + + * s1ap_proxy: merge process_pdu_safe() with process_pdu() + * s1ap_proxy: do not expose {en,de}code_pdu() API + * s1ap_proxy: turn this module into a gen_server + * s1ap_proxy: add E-RAB introspection API + * erab_fsm: rename erab_release_req/1 -> erab_release_cmd/1 + * erab_fsm: add erab_release/2 and erab_release_ind/1 + * s1ap_proxy: properly handle E-RAB RELEASE IND + * erab_fsm: add all-state event handler + * erab_fsm: add fetch_info/1 for state introspection + * sctp_server: add type hints + * sctp_server: cosmetic: use ?FUNCTION_NAME in send_data/2 + * sctp_server: pass MME addr/port to sctp_proxy as opaque data + * sctp_server: cosmetic: rename State -> S + * sctp_server: cosmetic: make #server_state last argument + * sctp_server: pass #server_state to client_{add,del}() + * sctp_server: make it abstract from sctp_proxy logic + * sctp_server: add fetch_conn_list/0 for state introspection + * sctp_proxy: add all-state event handler + * sctp_proxy: add fetch_info/1 for state introspection + * s1ap_proxy: use erab_uid() to log unique E-RAB ID + * s1ap_proxy: add a TODO about an optional IE + * s1ap_proxy: rework handle_ie/2 into handle_ie/3 + * s1ap_proxy: handle_ies(): reorder arguments + * s1ap_proxy: handle_ies(): pass IEI path to handle_ie() + * s1ap_proxy: handle_ies(): also handle #'ProtocolExtensionField' + * erab_fsm: store UID, expose it via fetch_info/1 + * erab_fsm: session_modify(): split PFCP PDU handling + * s1ap_proxy: cosmetic: fix wrong arity in comment + * s1ap_proxy: fix IEI path leak in handle_ies/4 + * erab_fsm: fix copy-paste in a log message + * erab_fsm: add more logging to clarify timeout events + * rebar.config: remove unneeded parse_transform + * erab_fsm: add pretty printer for F-TEID + * s1ap_proxy: handle UE CONTEXT RELEASE PDUs + * osmo_s1gw.app.src: set 'vsn' to 'semver' + * rebar.config: cosmetic: use spaces, not tabs + * rebar.config: relx: fix release name (must be an atom) + * rebar.config: relx: generate the version automatically + * {erab_fsm,sctp_proxy}: handle_event/4: fix return value + * {erab_fsm,sctp_proxy}: handle_event/4: reply to unknown calls + * erab_fsm: make erab_release_{cmd,ind}/1 non-blocking + * erab_fsm: handle RELEASE.{cmd,ind} in state erab_wait_setup_rsp + * erab_fsm: handle RELEASE.ind in state erab_wait_release_rsp + * erab_fsm: implement E-RAB MODIFY Req/Rsp procedure + * erab_fsm: implement E-RAB MODIFY Ind/Cnf procedure + * erab_fsm: pretty-print U2CM and U2AM during MODIFY Req/Ind + * s1ap_proxy: catch exceptions in handle_pdu/2 + * s1ap_proxy: handle E-RAB MODIFY REQ/RSP + * s1ap_proxy: handle E-RAB MODIFICATION IND/CNF + * s1ap_proxy: increment *_IN_PKT_* counters on exception + * sctp_server: invalidate handler's Pid on 'EXIT' + * sctp_{server,proxy}: log SCTP TSN, SID, SSN, and data len + * sctp_common: new module with common SCTP/S1AP API + * s1gw_metrics: use lists:filter/2 to create counters/gauges + * sctp_{client,server}: disable Nagle by setting sctp_nodelay + * s1gw_metrics: make exometer_report_statsd less verbose + * sctp_{client,server}: add and use sctp_common:parse_addr/1 + * sctp_{client,server}: accept arguments in form of a map + * sctp_{client,server}: allow passing additional sockopts + * sctp_{client,server}: make sctp_nodelay configurable + * sctp_{client,server}: set sndbuf/recbuf explicitly + + -- Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Fri, 18 Apr 2025 02:56:33 +0700 + osmo-s1gw (0.2.0) unstable; urgency=medium [ Vadim Yanitskiy ] -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40091?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ibd805fb754ed210e07f2a7fea1a14f610e35e520 Gerrit-Change-Number: 40091 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmocom-bb[master]: trx_toolkit/burst_fwd: Switch BurstForwarder to cdef class
by laforge 19 Apr '25

19 Apr '25

Attention is currently required from: kirr. laforge has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40065?usp=email ) Change subject: trx_toolkit/burst_fwd: Switch BurstForwarder to cdef class ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40065?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8e5fe20ff5a9a0fbbb8ce82a7776837de1219e13 Gerrit-Change-Number: 40065 Gerrit-PatchSet: 3 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Comment-Date: Sat, 19 Apr 2025 16:53:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmocom-bb[master]: trx_toolkit/_fake_trx: Optimize IO loop fd polling
by laforge 19 Apr '25

19 Apr '25

Attention is currently required from: kirr. laforge has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40064?usp=email ) Change subject: trx_toolkit/_fake_trx: Optimize IO loop fd polling ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40064?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I748810871601178cc97bcdaba41419949078c29d Gerrit-Change-Number: 40064 Gerrit-PatchSet: 3 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Comment-Date: Sat, 19 Apr 2025 16:53:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmocom-bb[master]: trx_toolkit/_fake_trx: Invoke CLCKGen.tick via C
by laforge 19 Apr '25

19 Apr '25

Attention is currently required from: kirr. laforge has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40063?usp=email ) Change subject: trx_toolkit/_fake_trx: Invoke CLCKGen.tick via C ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40063?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I19a7a90cd420b481c555f37f3fb7f2ebb513d6e8 Gerrit-Change-Number: 40063 Gerrit-PatchSet: 2 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Comment-Date: Sat, 19 Apr 2025 16:52:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmocom-bb[master]: trx_toolkit/_clck_gen: Optimize timerfd read
by laforge 19 Apr '25

19 Apr '25

Attention is currently required from: kirr. laforge has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40062?usp=email ) Change subject: trx_toolkit/_clck_gen: Optimize timerfd read ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40062?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I23d5fc2b7209592c62a4655c42004777b8bb31a8 Gerrit-Change-Number: 40062 Gerrit-PatchSet: 2 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Comment-Date: Sat, 19 Apr 2025 16:52:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmocom-bb[master]: trx_toolkit/_clck_gen: Switch CLCKGen to cdef class
by laforge 19 Apr '25

19 Apr '25

Attention is currently required from: kirr. laforge has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40061?usp=email ) Change subject: trx_toolkit/_clck_gen: Switch CLCKGen to cdef class ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40061?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I2fb0219776b973c217348e34dab269aa804b2a04 Gerrit-Change-Number: 40061 Gerrit-PatchSet: 2 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Comment-Date: Sat, 19 Apr 2025 16:51:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log