- gerrit-log - lists.osmocom.org

[XS] Change in libosmo-sigtran[master]: sccp_demo_use: Log rx N-PCSTATE.ind

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40301?usp=email ) Change subject: sccp_demo_use: Log rx N-PCSTATE.ind ...................................................................... sccp_demo_use: Log rx N-PCSTATE.ind Change-Id: I19ff96c5892af412333ae413d95416c592e87f5c --- M examples/sccp_test_server.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/01/40301/1 diff --git a/examples/sccp_test_server.c b/examples/sccp_test_server.c index aa3a76c..1304bac 100644 --- a/examples/sccp_test_server.c +++ b/examples/sccp_test_server.c @@ -72,6 +72,12 @@ scu_prim->u.disconnect.conn_id, scu_prim->u.disconnect.cause, scu_prim->u.disconnect.importance); break; + case OSMO_PRIM(OSMO_SCU_PRIM_N_PCSTATE, PRIM_OP_INDICATION): + LOGP(DMAIN, LOGL_INFO, "Got N-PCSTATE.ind (affected_pc=%u sp_status=%s remote_sccp_status=%s)\n", + scu_prim->u.pcstate.affected_pc, + osmo_sccp_sp_status_name(scu_prim->u.pcstate.sp_status), + osmo_sccp_rem_sccp_status_name(scu_prim->u.pcstate.remote_sccp_status)); + break; default: LOGP(DMAIN, LOGL_NOTICE, "Unknown primitive %s\n", osmo_scu_prim_name(oph)); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40301?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I19ff96c5892af412333ae413d95416c592e87f5c Gerrit-Change-Number: 40301 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

[XS] Change in libosmo-sigtran[master]: sccp_scoc.c: Log SCRC Routing Failure return cause

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40300?usp=email ) Change subject: sccp_scoc.c: Log SCRC Routing Failure return cause ...................................................................... sccp_scoc.c: Log SCRC Routing Failure return cause Change-Id: I75ce13de26c443ca5b496a00618f44e82fcf1cfa --- M src/sccp_scoc.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/00/40300/1 diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c index 4086d34..48c0845 100644 --- a/src/sccp_scoc.c +++ b/src/sccp_scoc.c @@ -1577,7 +1577,8 @@ uint32_t conn_id; struct sccp_connection *conn; - LOGPSCI(inst, LOGL_NOTICE, "SCRC Routing Failure for message %s\n", + LOGPSCI(inst, LOGL_NOTICE, "SCRC Routing Failure (%s) for message %s\n", + osmo_sccp_return_cause_name(return_cause), xua_hdr_dump(xua, &xua_dialect_sua)); /* try to dispatch to connection FSM (if any) */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40300?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I75ce13de26c443ca5b496a00618f44e82fcf1cfa Gerrit-Change-Number: 40300 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

[XS] Change in libosmo-sigtran[master]: sccp: Log remote PC in LOGPSCC

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40299?usp=email ) Change subject: sccp: Log remote PC in LOGPSCC ...................................................................... sccp: Log remote PC in LOGPSCC This information was lacking as would have been useful when looking at some logs. Change-Id: Ifa3670f3f0894c3334299c6c9826a17bd63dd9ae --- M src/sccp_scoc.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/99/40299/1 diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c index fa373af..4086d34 100644 --- a/src/sccp_scoc.c +++ b/src/sccp_scoc.c @@ -128,7 +128,7 @@ struct osmo_timer_list t_rep_rel; }; #define _LOGPSCC(scc, subsys, level, fmt, args ...) \ - _LOGPSCU((scc)->user, subsys, level, "CONN(%d) " fmt, (conn)->conn_id, ## args) + _LOGPSCU((scc)->user, subsys, level, "CONN(%d,rpc=%u) " fmt, (conn)->conn_id, (conn)->remote_pc, ## args) #define LOGPSCC(scc, level, fmt, args ...) \ _LOGPSCC(scc, DLSCCP, level, fmt, ## args) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40299?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ifa3670f3f0894c3334299c6c9826a17bd63dd9ae Gerrit-Change-Number: 40299 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

[XS] Change in libosmo-sigtran[master]: sccp_scoc.c: assert value of sua_addr_parse()

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40298?usp=email ) Change subject: sccp_scoc.c: assert value of sua_addr_parse() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40298?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I008ee6f9024247c14d986a2baba061cc12bf68ec Gerrit-Change-Number: 40298 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 May 2025 12:40:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 2 weeks

1
0
0 0

[XS] Change in libosmo-sigtran[master]: sccp_scoc.c: assert value of sua_addr_parse()

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40298?usp=email ) Change subject: sccp_scoc.c: assert value of sua_addr_parse() ...................................................................... sccp_scoc.c: assert value of sua_addr_parse() Related: Coverity CID#523214 Change-Id: I008ee6f9024247c14d986a2baba061cc12bf68ec --- M src/sccp_scoc.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/98/40298/1 diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c index 4e390af..fa373af 100644 --- a/src/sccp_scoc.c +++ b/src/sccp_scoc.c @@ -917,7 +917,7 @@ if (xua) { udisp->cause = xua_msg_get_u32(xua, SUA_IEI_CAUSE); if (xua_msg_find_tag(xua, SUA_IEI_SRC_ADDR)) - sua_addr_parse(&udisp->responding_addr, xua, SUA_IEI_SRC_ADDR); + OSMO_ASSERT(sua_addr_parse(&udisp->responding_addr, xua, SUA_IEI_SRC_ADDR) == 0); data_ie = xua_msg_find_tag(xua, SUA_IEI_DATA); udisp->importance = xua_msg_get_u32(xua, SUA_IEI_IMPORTANCE); if (data_ie) { @@ -1035,8 +1035,8 @@ case SCOC_E_RCOC_CONN_IND: xua = data; /* copy relevant parameters from xua to conn */ - sua_addr_parse(&conn->calling_addr, xua, SUA_IEI_SRC_ADDR); - sua_addr_parse(&conn->called_addr, xua, SUA_IEI_DEST_ADDR); + OSMO_ASSERT(sua_addr_parse(&conn->calling_addr, xua, SUA_IEI_SRC_ADDR) == 0); + OSMO_ASSERT(sua_addr_parse(&conn->called_addr, xua, SUA_IEI_DEST_ADDR) == 0); conn->remote_ref = xua_msg_get_u32(xua, SUA_IEI_SRC_REF); conn->sccp_class = xua_msg_get_u32(xua, SUA_IEI_PROTO_CLASS) & 3; conn->importance = xua_msg_get_u32(xua, SUA_IEI_IMPORTANCE); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40298?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I008ee6f9024247c14d986a2baba061cc12bf68ec Gerrit-Change-Number: 40298 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

[XS] Change in ...osmo-epdg[master]: gsup: Fix rx of AuthInfoReq without IP addr val

by pespin

Attention is currently required from: clufn, fixeria, laforge, lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40297?usp=email ) Change subject: gsup: Fix rx of AuthInfoReq without IP addr val ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Please @callumfarrbennett@yahoo.com make sure you run ttcn3-epdg-test testsuite locally before submitting patches next time. See https://osmocom.org/projects/cellular-infrastructure/wiki/Titan_TTCN3_Tests… for more information. I also encourage you to write new tests in there for new features/scenarios you are introducing, to make sure we don't have regressions in the future. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40297?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Iaa4b45a00e472a324ad98f57a54db04454935130 Gerrit-Change-Number: 40297 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: clufn <callumfarrbennett(a)yahoo.com> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: clufn <callumfarrbennett(a)yahoo.com> Gerrit-Comment-Date: Wed, 14 May 2025 12:27:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 month, 2 weeks

1
0
0 0

[XS] Change in ...osmo-epdg[master]: gsup: Fix rx of AuthInfoReq without IP addr val

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40297?usp=email ) Change subject: gsup: Fix rx of AuthInfoReq without IP addr val ...................................................................... gsup: Fix rx of AuthInfoReq without IP addr val The var PdpAddress was being reassigned and erlang crashed when running ttcn3-epdg-test with: """ {{badmatch,#{ipv4 => <<0,0,0,0>>}},[{gsup_server,rx_gsup,3, [{file,"/tmp/osmo-epdg/src/gsup_server.erl"},{line,308}]}, {misc,'-spawn_wait_ret/2-fun-0-',2, [{file,"/tmp/osmo-epdg/src/misc.erl"},{line,43}]}]} """ Fixes: 2d2e43c061652ae6c9fd409e9badc33d5d66e068 Change-Id: Iaa4b45a00e472a324ad98f57a54db04454935130 --- M src/gsup_server.erl 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/97/40297/1 diff --git a/src/gsup_server.erl b/src/gsup_server.erl index c4c28cf..256522e 100644 --- a/src/gsup_server.erl +++ b/src/gsup_server.erl @@ -296,13 +296,14 @@ case maps:find(pdp_info_list, GsupMsgRx) of {ok, [PdpInfo]} -> #{pdp_context_id := _PDPCtxId, - pdp_address := #{address := PdpAddress, + pdp_address := #{address := PdpAddressRx, pdp_type_nr := PdpTypeNr, pdp_type_org := 241}, access_point_name := Apn } = PdpInfo, - case maps:is_key(ipv4,PdpAddress) or maps:is_key(ipv6,PdpAddress) of - true -> ok; %% Address received so do nothing + case maps:is_key(ipv4,PdpAddressRx) or maps:is_key(ipv6,PdpAddressRx) of + true -> %% Address received, use it + PdpAddress = PdpAddressRx; false -> %% No address received from strongswan, use a default value PdpTypeNr = ?GTP_PDP_ADDR_TYPE_NR_IPv4, PdpAddress = #{ipv4 => <<0,0,0,0>>} -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40297?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Iaa4b45a00e472a324ad98f57a54db04454935130 Gerrit-Change-Number: 40297 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

[XL] Change in libosmocore[master]: Introduce tests/osmo-config-merge testsuite

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/40295?usp=email ) Change subject: Introduce tests/osmo-config-merge testsuite ...................................................................... Patch Set 4: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/1ea205f3_6972069e?… : PS4, Line 7: testsuite > Can you explain why is it a whole new testsuite and not just part of the existing testsuite? There's several reasons: * This is testing an app, not some parts of the library. Hence, it allows specifically testing the app, or skipping it later on if user is not interested about it. * Given this app only function is to process text files, it feels natural to use the testsuite since it provides all the match and diff features. The natural way to test it is writing several input tests and validating the output. This means we'll potentially end up with tons of tests in the testsuite validating different scenarios. * Te tests/testsuite is already quite convoluted with tons of different stuff Does that mean it coudln't be in testsuite/test? It could be there. IMHO it's better to have it in a separate testsuite for the above reasons. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40295?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia172d4c280f4bae1b411ad805cca02355ca7fcc9 Gerrit-Change-Number: 40295 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 May 2025 11:57:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

[XL] Change in libosmocore[master]: Introduce tests/osmo-config-merge testsuite

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/40295?usp=email ) Change subject: Introduce tests/osmo-config-merge testsuite ...................................................................... Patch Set 4: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/653c8e2b_9937bd1d?… : PS4, Line 7: testsuite Can you explain why is it a whole new testsuite and not just part of the existing testsuite? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40295?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia172d4c280f4bae1b411ad805cca02355ca7fcc9 Gerrit-Change-Number: 40295 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 May 2025 07:26:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 month, 2 weeks

1
0
0 0

[L] Change in libosmocore[master]: osmo-config-merge: Fix comments with different indentation creating m...

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/40296?usp=email ) Change subject: osmo-config-merge: Fix comments with different indentation creating merge problems ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40296?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7de78d3ed3ca27e3470ea66a78ff9c5acfe65741 Gerrit-Change-Number: 40296 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 May 2025 07:25:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log