- gerrit-log - lists.osmocom.org

[XS] Change in libosmo-sigtran[master]: sccp_scoc.c: assert value of sua_addr_parse()

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40298?usp=email ) Change subject: sccp_scoc.c: assert value of sua_addr_parse() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: should we assert if the SCCP user hands us incorrect data? I would hope we're not venturing into open5gs-assert-style here? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40298?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I008ee6f9024247c14d986a2baba061cc12bf68ec Gerrit-Change-Number: 40298 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 May 2025 06:46:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 month, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: podman_install: tweak git commands

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40304?usp=email ) Change subject: testenv: podman_install: tweak git commands ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40304?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2ee26764d1471e54eff748e11ec2cce6fb662667 Gerrit-Change-Number: 40304 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 May 2025 06:45:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: podman_install: show checked out commits

by laforge

Attention is currently required from: fixeria, osmith, pespin. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40303?usp=email ) Change subject: testenv: podman_install: show checked out commits ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40303?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2837a41c919a9f7ef8c315ce5aa48fb4fe3f9a85 Gerrit-Change-Number: 40303 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 May 2025 06:44:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: podman_install: tweak git commands

by osmith

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40304?usp=email to look at the new patch set (#3). Change subject: testenv: podman_install: tweak git commands ...................................................................... testenv: podman_install: tweak git commands * Do not run them in podman: git is required to run testenv, by not running it through podman the command in the log is shorter. * Set advice.detachedHead=false for the git clone to avoid printing the "You are in 'detached HEAD' state. You can look around ..." text block that isn't useful in this context. Change-Id: I2ee26764d1471e54eff748e11ec2cce6fb662667 --- M _testenv/testenv/podman_install.py 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/04/40304/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40304?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2ee26764d1471e54eff748e11ec2cce6fb662667 Gerrit-Change-Number: 40304 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 month, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: podman_install: show checked out commits

by osmith

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40303?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: testenv: podman_install: show checked out commits ...................................................................... testenv: podman_install: show checked out commits When running with --podman --binary-repo and a testsuite needs a component for which we don't have a binary package (such as sccp_demo_user), we need to clone the source and build it. Show the commit from which we are building / have already built the component. Suggested-by: Pau Espin Pedrol <pespin(a)sysmocom.de> Change-Id: I2837a41c919a9f7ef8c315ce5aa48fb4fe3f9a85 --- M _testenv/testenv/podman_install.py 1 file changed, 12 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/03/40303/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40303?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2837a41c919a9f7ef8c315ce5aa48fb4fe3f9a85 Gerrit-Change-Number: 40303 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: podman_install: show checked out commits

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40303?usp=email ) Change subject: testenv: podman_install: show checked out commits ...................................................................... testenv: podman_install: show checked out commits When running with --podman --binary-repo and a testsuite needs a component for which we don't have a binary package (such as sccp_demo_user), we need to clone the source and build it. Show the commit from which we are building / have already built the component. Suggested-by: Pau Espin Pedrol <pespin(a)sysmocom.de> Change-Id: I2837a41c919a9f7ef8c315ce5aa48fb4fe3f9a85 --- M _testenv/testenv/podman_install.py 1 file changed, 13 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/03/40303/1 diff --git a/_testenv/testenv/podman_install.py b/_testenv/testenv/podman_install.py index 66777a6..13552b4 100644 --- a/_testenv/testenv/podman_install.py +++ b/_testenv/testenv/podman_install.py @@ -96,9 +96,18 @@ testenv.cmd.run(["apt-get", "-q", "install", "-y", "--no-install-recommends"] + pkgs) +def show_commit(project, cwd): + cmd = ["git", "-C", cwd, "-c", "color.ui=always", "log", "-1", "--oneline"] + env = {"GIT_PAGER": "cat"} + logging.info(f"{project}: showing current commit") + testenv.cmd.run(cmd, no_podman=True, env=env) + + def clone_project(project): - if os.path.exists(os.path.join(git_dir, project)): + git_dir_project = os.path.join(git_dir, project) + if os.path.exists(git_dir_project): logging.debug(f"{project}: already cloned") + show_commit(project, git_dir_project) return branch = "master" @@ -129,6 +138,7 @@ url, ] ) + show_commit(project, git_dir_project) def from_source_sccp_demo_user(): @@ -144,8 +154,8 @@ ] ) + clone_project("libosmo-sigtran") if not os.path.exists(sccp_demo_user_path): - clone_project("libosmo-sigtran") logging.info("Building sccp_demo_user") testenv.cmd.run(["autoreconf", "-fi"], cwd=sccp_dir) @@ -170,8 +180,8 @@ libosmocore_dir = os.path.join(git_dir, "libosmocore") osmo_ns_dummy_path = os.path.join(libosmocore_dir, "utils/osmo-ns-dummy") + clone_project("libosmocore") if not os.path.exists(osmo_ns_dummy_path): - clone_project("libosmocore") logging.info("Building osmo-ns-dummy") testenv.cmd.run(["autoreconf", "-fi"], cwd=libosmocore_dir) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40303?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2837a41c919a9f7ef8c315ce5aa48fb4fe3f9a85 Gerrit-Change-Number: 40303 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: tsetenv: podman_install: tweak git commands

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40304?usp=email ) Change subject: tsetenv: podman_install: tweak git commands ...................................................................... tsetenv: podman_install: tweak git commands * Do not run them in podman: git is required to run testenv, by not running it through podman the command in the log is shorter. * Set advice.detachedHead=false for the git clone to avoid printing the "You are in 'detached HEAD' state. You can look around ..." text block that isn't useful in this context. Change-Id: I2ee26764d1471e54eff748e11ec2cce6fb662667 --- M _testenv/testenv/podman_install.py 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/04/40304/1 diff --git a/_testenv/testenv/podman_install.py b/_testenv/testenv/podman_install.py index 13552b4..8fdd871 100644 --- a/_testenv/testenv/podman_install.py +++ b/_testenv/testenv/podman_install.py @@ -113,7 +113,7 @@ branch = "master" url = f"https://gerrit.osmocom.org/{project}" if testenv.args.binary_repo.endswith(":latest"): - ls_remote = testenv.cmd.run(["git", "ls-remote", "--tags", url], capture_output=True, text=True) + ls_remote = testenv.cmd.run(["git", "ls-remote", "--tags", url], capture_output=True, text=True, no_podman=True) tags = [] pattern = re.compile("^\d+\.\d+\.\d+$") for line in ls_remote.stdout.split("\n"): @@ -128,6 +128,8 @@ testenv.cmd.run( [ "git", + "-c", + "advice.detachedHead=false", "-C", git_dir, "clone", @@ -136,7 +138,8 @@ "--branch", branch, url, - ] + ], + no_podman=True, ) show_commit(project, git_dir_project) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40304?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2ee26764d1471e54eff748e11ec2cce6fb662667 Gerrit-Change-Number: 40304 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

[XS] Change in libosmo-sigtran[master]: sccp_scoc: Match local conn by src_ref, not dest_ref

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40302?usp=email ) Change subject: sccp_scoc: Match local conn by src_ref, not dest_ref ...................................................................... sccp_scoc: Match local conn by src_ref, not dest_ref SCRC Routing Failure is dispatched when a local SCCP Connection Oriented message fails to be routed to a peer. Hence, in order to figure out if the msg belons to a local conn, we need to use the src_ref (the sender), not the dst_ref (the peer's id). As a result, event SCOC_E_RCOC_ROUT_FAIL_IND was potentially being set to the wrong connection FSM. Change-Id: I0090f4088de407b476cfb0a6d652b384af714306 --- M src/sccp_scoc.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/02/40302/1 diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c index 48c0845..01a78d0 100644 --- a/src/sccp_scoc.c +++ b/src/sccp_scoc.c @@ -1582,7 +1582,7 @@ xua_hdr_dump(xua, &xua_dialect_sua)); /* try to dispatch to connection FSM (if any) */ - conn_id = xua_msg_get_u32(xua, SUA_IEI_DEST_REF); + conn_id = xua_msg_get_u32(xua, SUA_IEI_SRC_REF); conn = conn_find_by_id(inst, conn_id); if (conn) { osmo_fsm_inst_dispatch(conn->fi, -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40302?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0090f4088de407b476cfb0a6d652b384af714306 Gerrit-Change-Number: 40302 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

[XS] Change in libosmo-sigtran[master]: sccp_demo_use: Log rx N-PCSTATE.ind

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40301?usp=email ) Change subject: sccp_demo_use: Log rx N-PCSTATE.ind ...................................................................... sccp_demo_use: Log rx N-PCSTATE.ind Change-Id: I19ff96c5892af412333ae413d95416c592e87f5c --- M examples/sccp_test_server.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/01/40301/1 diff --git a/examples/sccp_test_server.c b/examples/sccp_test_server.c index aa3a76c..1304bac 100644 --- a/examples/sccp_test_server.c +++ b/examples/sccp_test_server.c @@ -72,6 +72,12 @@ scu_prim->u.disconnect.conn_id, scu_prim->u.disconnect.cause, scu_prim->u.disconnect.importance); break; + case OSMO_PRIM(OSMO_SCU_PRIM_N_PCSTATE, PRIM_OP_INDICATION): + LOGP(DMAIN, LOGL_INFO, "Got N-PCSTATE.ind (affected_pc=%u sp_status=%s remote_sccp_status=%s)\n", + scu_prim->u.pcstate.affected_pc, + osmo_sccp_sp_status_name(scu_prim->u.pcstate.sp_status), + osmo_sccp_rem_sccp_status_name(scu_prim->u.pcstate.remote_sccp_status)); + break; default: LOGP(DMAIN, LOGL_NOTICE, "Unknown primitive %s\n", osmo_scu_prim_name(oph)); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40301?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I19ff96c5892af412333ae413d95416c592e87f5c Gerrit-Change-Number: 40301 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

[XS] Change in libosmo-sigtran[master]: sccp_scoc.c: Log SCRC Routing Failure return cause

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40300?usp=email ) Change subject: sccp_scoc.c: Log SCRC Routing Failure return cause ...................................................................... sccp_scoc.c: Log SCRC Routing Failure return cause Change-Id: I75ce13de26c443ca5b496a00618f44e82fcf1cfa --- M src/sccp_scoc.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/00/40300/1 diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c index 4086d34..48c0845 100644 --- a/src/sccp_scoc.c +++ b/src/sccp_scoc.c @@ -1577,7 +1577,8 @@ uint32_t conn_id; struct sccp_connection *conn; - LOGPSCI(inst, LOGL_NOTICE, "SCRC Routing Failure for message %s\n", + LOGPSCI(inst, LOGL_NOTICE, "SCRC Routing Failure (%s) for message %s\n", + osmo_sccp_return_cause_name(return_cause), xua_hdr_dump(xua, &xua_dialect_sua)); /* try to dispatch to connection FSM (if any) */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40300?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I75ce13de26c443ca5b496a00618f44e82fcf1cfa Gerrit-Change-Number: 40300 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log