September 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-hlr[master]: gsupclient: add LIBOSMOGSM_LIBS to LIBADD
by pespin 08 Sep '26

08 Sep '26

Attention is currently required from: Andrei G. pespin has posted comments on this change by Andrei G. ( https://gerrit.osmocom.org/c/osmo-hlr/+/43578?usp=email ) Change subject: gsupclient: add LIBOSMOGSM_LIBS to LIBADD ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/43578?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I413ff47aa1e8034ea86c61134d3d6784942b0e3b Gerrit-Change-Number: 43578 Gerrit-PatchSet: 1 Gerrit-Owner: Andrei G <andrei.gosman(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Andrei G <andrei.gosman(a)gmail.com> Gerrit-Comment-Date: Tue, 08 Sep 2026 15:59:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-hlr[master]: gsupclient: add LIBOSMOGSM_LIBS to LIBADD
by pespin 08 Sep '26

08 Sep '26

Attention is currently required from: Andrei G. pespin has posted comments on this change by Andrei G. ( https://gerrit.osmocom.org/c/osmo-hlr/+/43578?usp=email ) Change subject: gsupclient: add LIBOSMOGSM_LIBS to LIBADD ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: We are also missing that and other dependencies in libosmo-gsup-client.pc.in "Requires.private: libosmocore" -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/43578?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I413ff47aa1e8034ea86c61134d3d6784942b0e3b Gerrit-Change-Number: 43578 Gerrit-PatchSet: 1 Gerrit-Owner: Andrei G <andrei.gosman(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Andrei G <andrei.gosman(a)gmail.com> Gerrit-Comment-Date: Tue, 08 Sep 2026 15:59:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-mgw[master]: mgcp_client: generate mgcp_common.h with printf
by pespin 08 Sep '26

08 Sep '26

Attention is currently required from: Andrei G. pespin has posted comments on this change by Andrei G. ( https://gerrit.osmocom.org/c/osmo-mgw/+/43576?usp=email ) Change subject: mgcp_client: generate mgcp_common.h with printf ...................................................................... Patch Set 2: (1 comment) File include/osmocom/mgcp_client/Makefile.am: https://gerrit.osmocom.org/c/osmo-mgw/+/43576/comment/30e9680b_c83d27f4?usp… : PS2, Line 12: printf '%s\n' "/*" "" " DO NOT EDIT THIS FILE!" " THIS IS OVERWRITTEN DURING BUILD" " This is an automatic copy of <osmocom/mgcp/mgcp_common.h>" "" " */" > mgcp_common.h Why not printing everything in one string like before? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/43576?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ibc547513745104212469ccddbc2e636c985cffe5 Gerrit-Change-Number: 43576 Gerrit-PatchSet: 2 Gerrit-Owner: Andrei G <andrei.gosman(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Andrei G <andrei.gosman(a)gmail.com> Gerrit-Comment-Date: Tue, 08 Sep 2026 15:55:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in libosmocore[master]: core/socket: sockaddr_cmp: compare fields
by pespin 08 Sep '26

08 Sep '26

Attention is currently required from: Andrei G. pespin has posted comments on this change by Andrei G. ( https://gerrit.osmocom.org/c/libosmocore/+/43575?usp=email ) Change subject: core/socket: sockaddr_cmp: compare fields ...................................................................... Patch Set 3: (1 comment) File tests/Makefile.am: https://gerrit.osmocom.org/c/libosmocore/+/43575/comment/e63cb72e_a10c23d1?… : PS3, Line 357: sockaddr_cmp_sockaddr_cmp_test_SOURCES = sockaddr_cmp/sockaddr_cmp_test.c Please rather add a "sockaddr_test" file instead of "sockaddr_cmp_test" one, and put the sockaddr_cmp() tests in one specific function inside that file. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43575?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I75fc62a92f546a906dbb1440984d62f962579255 Gerrit-Change-Number: 43575 Gerrit-PatchSet: 3 Gerrit-Owner: Andrei G <andrei.gosman(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Andrei G <andrei.gosman(a)gmail.com> Gerrit-Comment-Date: Tue, 08 Sep 2026 15:53:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libosmocore[master]: core/socket: init_osa: pass family-correct len
by pespin 08 Sep '26

08 Sep '26

Attention is currently required from: Andrei G. pespin has posted comments on this change by Andrei G. ( https://gerrit.osmocom.org/c/libosmocore/+/43574?usp=email ) Change subject: core/socket: init_osa: pass family-correct len ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/core/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/43574/comment/029fe642_fdef1324?… : PS1, Line 603: if (bind(sfd, &local->u.sa, osmo_sockaddr_size(local)) == -1) { AFAIU this will still fail for you when using a UNIX socket here? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43574?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I37cb08a6e1809d51c97e666f980d4c68f8b56933 Gerrit-Change-Number: 43574 Gerrit-PatchSet: 1 Gerrit-Owner: Andrei G <andrei.gosman(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Andrei G <andrei.gosman(a)gmail.com> Gerrit-Comment-Date: Tue, 08 Sep 2026 15:46:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: core/socket: local_ip: connect to discard port
by pespin 08 Sep '26

08 Sep '26

Attention is currently required from: Andrei G. pespin has posted comments on this change by Andrei G. ( https://gerrit.osmocom.org/c/libosmocore/+/43573?usp=email ) Change subject: core/socket: local_ip: connect to discard port ...................................................................... Patch Set 1: (1 comment) File src/core/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/43573/comment/9dd20c57_6e46b807?… : PS1, Line 2471: * port 0, while Darwin and the BSDs reject it with EADDRNOTAVAIL. */ Please describe what "9" is here and why was it picked (the IANA reserved). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43573?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I597874d5b2a81dd34c6a2b274fcf8d9bfc14c301 Gerrit-Change-Number: 43573 Gerrit-PatchSet: 1 Gerrit-Owner: Andrei G <andrei.gosman(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Andrei G <andrei.gosman(a)gmail.com> Gerrit-Comment-Date: Tue, 08 Sep 2026 15:43:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libosmocore[master]: core/stats_tcp: declare struct osmo_fd in header
by pespin 08 Sep '26

08 Sep '26

Attention is currently required from: Andrei G. pespin has posted comments on this change by Andrei G. ( https://gerrit.osmocom.org/c/libosmocore/+/43572?usp=email ) Change subject: core/stats_tcp: declare struct osmo_fd in header ...................................................................... Patch Set 1: (2 comments) File include/osmocom/core/stats_tcp.h: https://gerrit.osmocom.org/c/libosmocore/+/43572/comment/e185fefd_4c76e908?… : PS1, Line 14: /* The prototypes below name struct osmo_fd without declaring it. A translation Please drop the whole comment, if we had to add this paragraph for each forward declaration we'd have an entire bible by now. https://gerrit.osmocom.org/c/libosmocore/+/43572/comment/732e751f_6900c635?… : PS1, Line 18: struct osmo_fd; We usually place these forward declarations up in the file, eg. immediatelly after where you'd put an include. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43572?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2f31f45317e6a28f47470ba6a5e4a31e4704e831 Gerrit-Change-Number: 43572 Gerrit-PatchSet: 1 Gerrit-Owner: Andrei G <andrei.gosman(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Andrei G <andrei.gosman(a)gmail.com> Gerrit-Comment-Date: Tue, 08 Sep 2026 15:40:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in pysim[master]: smpp-ota-tool: add --format compact,expanded for TS 102 226 5.2
by dexter 08 Sep '26

08 Sep '26

Attention is currently required from: Hoernchen, daniel. dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43542?usp=email ) Change subject: smpp-ota-tool: add --format compact,expanded for TS 102 226 5.2 ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: This looks ok to me. If it makes it through the tests it should be fine. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43542?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Idad90756f85bb7e54ef720f6067bb5d6dcff0c42 Gerrit-Change-Number: 43542 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Sep 2026 15:37:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: core/hash: avoid __always_inline in public header
by pespin 08 Sep '26

08 Sep '26

Attention is currently required from: Andrei G, laforge. pespin has posted comments on this change by Andrei G. ( https://gerrit.osmocom.org/c/libosmocore/+/43571?usp=email ) Change subject: core/hash: avoid __always_inline in public header ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/43571/comment/2dacbc18_72c1ba12?… : PS2, Line 31: Signed-off-by: Andrei Gosman <andrei.gosman(a)gmail.com> We don't use Signed-off-by in osmocom projects. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43571?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I103831bacde6d2f3f2a140812cd1e2300298bab5 Gerrit-Change-Number: 43571 Gerrit-PatchSet: 2 Gerrit-Owner: Andrei G <andrei.gosman(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: Andrei G <andrei.gosman(a)gmail.com> Gerrit-Comment-Date: Tue, 08 Sep 2026 15:34:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libosmocore[master]: core/hash: avoid __always_inline in public header
by pespin 08 Sep '26

08 Sep '26

Attention is currently required from: Andrei G, laforge. pespin has posted comments on this change by Andrei G. ( https://gerrit.osmocom.org/c/libosmocore/+/43571?usp=email ) Change subject: core/hash: avoid __always_inline in public header ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43571?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I103831bacde6d2f3f2a140812cd1e2300298bab5 Gerrit-Change-Number: 43571 Gerrit-PatchSet: 2 Gerrit-Owner: Andrei G <andrei.gosman(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: Andrei G <andrei.gosman(a)gmail.com> Gerrit-Comment-Date: Tue, 08 Sep 2026 15:33:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log September 2026