Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43112?usp=email )
Change subject: libosmo-trx/ep: flush pending TRXC messages on endpoint teardown ......................................................................
Patch Set 7:
(3 comments)
File libosmo-trx/src/trx_ep.c:
https://gerrit.osmocom.org/c/osmo-trx/+/43112/comment/626c06db_5dca6482?usp=... : PS6, Line 348: flush = talloc(iofd, struct trx_ep_ctrl_flush);
Because the caller may call `osmo_trx_ep_free()` right after `osmo_trx_ep_close()`. […]
Implemented postponed free()ing the whole `struct osmo_trx_ep`.
https://gerrit.osmocom.org/c/osmo-trx/+/43112/comment/647c3a7c_079eefdf?usp=... : PS6, Line 552: * finish flushing on its own, since it may outlive the endpoint. */
I don't really see why would you like the ctrl socket to outlive the endpoint. […]
Done
https://gerrit.osmocom.org/c/osmo-trx/+/43112/comment/77ea756a_7d7e4b77?usp=... : PS6, Line 581: return !llist_empty(&ep->closing_flushes);
The list exists to let `osmo_trx_ep_free()` find outstanding flushes and sever their back-pointer, s […]
Done