Attention is currently required from: Andrei G.
laforge has posted comments on this change by Andrei G. ( https://gerrit.osmocom.org/c/libosmocore/+/43573?usp=email )
Change subject: core/socket: local_ip: connect to discard port
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
The general question is whether we suddenly [again] start to support anything beyond Linux. Many years ago we dropped support for FreeBSD, see the threads spawned by https://lists.osmocom.org/hyperkitty/list/openbsc@lists.osmocom.org/thread/…
At the same point, we stated we'd merge compatibiltiy pathes in this post eight years ago: https://lists.osmocom.org/hyperkitty/list/openbsc@lists.osmocom.org/message… - *if* there is someone committed to maintaining that platform compatibility. In my opionion this means also a plan and monitoring of continuous integration
As the mailing lists are basically unused these days, feel free to create a discussion at https://discourse.osmocom.org/ about your plans for Darwin maintenance of osmocom CNI, or if you prefer we can also discuss it in a feature issue filed at https://osmocom.org/projects/cellular-infrastructure/issues/new
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43573?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I597874d5b2a81dd34c6a2b274fcf8d9bfc14c301
Gerrit-Change-Number: 43573
Gerrit-PatchSet: 1
Gerrit-Owner: Andrei G <andrei.gosman(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Andrei G <andrei.gosman(a)gmail.com>
Gerrit-Comment-Date: Wed, 09 Sep 2026 07:01:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Andrei G.
osmith has posted comments on this change by Andrei G. ( https://gerrit.osmocom.org/c/osmo-iuh/+/43588?usp=email )
Change subject: build: rewrite generated includes without sed -i
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1:
IMHO this makes the code much less readable. How about this approach:
Define a `SED_I` variable that is set to `sed -i` by default. Then check if running on mac os, and if that is the case, set the variable to `sed -i ''`. Use `$(SED_I)` instead of directly calling `sed -i` everywhere.
After reading through https://osxhub.com/sed-command-mac/#inplace that should probably do it, but as I don't use mac os I have of course not tested it.
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/43588?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I6f803fcfb5dd81f0a0b2998b00622f6a19afc5da
Gerrit-Change-Number: 43588
Gerrit-PatchSet: 1
Gerrit-Owner: Andrei G <andrei.gosman(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Andrei G <andrei.gosman(a)gmail.com>
Gerrit-Comment-Date: Wed, 09 Sep 2026 06:59:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Andrei G.
laforge has posted comments on this change by Andrei G. ( https://gerrit.osmocom.org/c/libosmocore/+/43571?usp=email )
Change subject: core/hash: avoid __always_inline in public header
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43571?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I103831bacde6d2f3f2a140812cd1e2300298bab5
Gerrit-Change-Number: 43571
Gerrit-PatchSet: 2
Gerrit-Owner: Andrei G <andrei.gosman(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Andrei G <andrei.gosman(a)gmail.com>
Gerrit-Comment-Date: Wed, 09 Sep 2026 06:55:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Andrei G.
fixeria has posted comments on this change by Andrei G. ( https://gerrit.osmocom.org/c/osmo-trx/+/43581?usp=email )
Change subject: build: pass FFTWF_CFLAGS to arch/common
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43581?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I3243ce00bd42a22ff0fbbdd5ff3d00c7441662d0
Gerrit-Change-Number: 43581
Gerrit-PatchSet: 1
Gerrit-Owner: Andrei G <andrei.gosman(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Andrei G <andrei.gosman(a)gmail.com>
Gerrit-Comment-Date: Tue, 08 Sep 2026 19:37:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Andrei G.
fixeria has posted comments on this change by Andrei G. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43587?usp=email )
Change subject: sgsn: vty: guard NULL iu.ue_ctx when dumping
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43587?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I19d380401edcdce18586ed9de26cfe85c925c1f2
Gerrit-Change-Number: 43587
Gerrit-PatchSet: 1
Gerrit-Owner: Andrei G <andrei.gosman(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Andrei G <andrei.gosman(a)gmail.com>
Gerrit-Comment-Date: Tue, 08 Sep 2026 19:36:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Andrei G.
lynxis lazus has posted comments on this change by Andrei G. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43587?usp=email )
Change subject: sgsn: vty: guard NULL iu.ue_ctx when dumping
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Looks good to me, but the rework of the sgsn should take place first.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43587?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I19d380401edcdce18586ed9de26cfe85c925c1f2
Gerrit-Change-Number: 43587
Gerrit-PatchSet: 1
Gerrit-Owner: Andrei G <andrei.gosman(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Andrei G <andrei.gosman(a)gmail.com>
Gerrit-Comment-Date: Tue, 08 Sep 2026 16:23:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Andrei G.
pespin has posted comments on this change by Andrei G. ( https://gerrit.osmocom.org/c/osmo-iuh/+/43592?usp=email )
Change subject: hnb-test: parse LU Accept IEs after the LAI
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/43592?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I2e1eb8e1bc3db5f20b04a3161713c8a47847c6dc
Gerrit-Change-Number: 43592
Gerrit-PatchSet: 1
Gerrit-Owner: Andrei G <andrei.gosman(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Andrei G <andrei.gosman(a)gmail.com>
Gerrit-Comment-Date: Tue, 08 Sep 2026 16:21:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Andrei G.
pespin has posted comments on this change by Andrei G. ( https://gerrit.osmocom.org/c/osmo-iuh/+/43594?usp=email )
Change subject: hnb-test: decode CO messages as the RAN side
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File tests/hnb-test-rua.c:
https://gerrit.osmocom.org/c/osmo-iuh/+/43594/comment/379f14e3_24e186da?usp… :
PS1, Line 29: /* hnb-test is the RAN side of Iu: decode the connection oriented
This is obvious and it was simply missed, please drop this whole comment.
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/43594?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: Ibdf7fa518d15ebdb247fa349ee4df7b3888ca455
Gerrit-Change-Number: 43594
Gerrit-PatchSet: 1
Gerrit-Owner: Andrei G <andrei.gosman(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Andrei G <andrei.gosman(a)gmail.com>
Gerrit-Comment-Date: Tue, 08 Sep 2026 16:20:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Andrei G.
pespin has posted comments on this change by Andrei G. ( https://gerrit.osmocom.org/c/osmo-iuh/+/43589?usp=email )
Change subject: hnbap, rua, sabp: link against libosmo-ranap
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1:
imho it would be far better that each library would have its own function and not make eg. SABP depend on RANAP.
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/43589?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: Ic936829788536bc1b1973a5ed3082a82cbf90d04
Gerrit-Change-Number: 43589
Gerrit-PatchSet: 1
Gerrit-Owner: Andrei G <andrei.gosman(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Andrei G <andrei.gosman(a)gmail.com>
Gerrit-Comment-Date: Tue, 08 Sep 2026 16:18:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Andrei G, osmith.
pespin has posted comments on this change by Andrei G. ( https://gerrit.osmocom.org/c/osmo-iuh/+/43588?usp=email )
Change subject: build: rewrite generated includes without sed -i
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
Not really big fan of the new resulting code but ok...
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/43588?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I6f803fcfb5dd81f0a0b2998b00622f6a19afc5da
Gerrit-Change-Number: 43588
Gerrit-PatchSet: 1
Gerrit-Owner: Andrei G <andrei.gosman(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: Andrei G <andrei.gosman(a)gmail.com>
Gerrit-Comment-Date: Tue, 08 Sep 2026 16:15:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes