Attention is currently required from: jolly.
pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43684?usp=email )
Change subject: Update VTY tests to Cisco like DSCP configuration
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
This should be merged into the previous commit.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43684?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: If4f96e27861428bec183e93b765f7f0185d8fc54
Gerrit-Change-Number: 43684
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Mon, 21 Sep 2026 11:15:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: jolly.
pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667?usp=email )
Change subject: Add Cisco like DSCP configuration support
......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS4:
+1 once you fix the vty tests in this same commit, see also my other 2 comments regarding vty output improvements.
File src/ss7_asp_vty.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/e50eadfb_7e568… :
PS4, Line 420: struct osmo_ss7_asp *asp = vty->index;
btw, I'd personally add a vty_out() here telling the user this vty is deprecated and that qos-class should be used instead.
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/df2fa597_55eae… :
PS4, Line 449: vty_out(vty, "%% Config updated: ip-dscp %d -> %d%s", asp->cfg.ip_dscp, qos->ip_dscp,
I think you are missing the "qoss-class" somewhere in the string? like " -> qos-class %d (ip-dscp %d)"
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ic346698fc63771d95e474aec53ffb6c776636b3b
Gerrit-Change-Number: 43667
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Mon, 21 Sep 2026 11:14:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Hoernchen.
dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43566?usp=email )
Change subject: contrib: add scp81 OTA trigger builder
......................................................................
Patch Set 3: Code-Review+1 Verified+1
(3 comments)
Patchset:
PS3:
I have tried it (only generating the API, I didn't sent it to a card), seems to work fine.
File contrib/scp81_trigger.py:
https://gerrit.osmocom.org/c/pysim/+/43566/comment/bf1113ed_f8248a44?usp=em… :
PS3, Line 1: #!/usr/bin/env python3
As it seems the execution bit is not set on this file.
https://gerrit.osmocom.org/c/pysim/+/43566/comment/6ba49438_ecca2576?usp=em… :
PS3, Line 50: ap.add_argument("--psk-id", help="PSK identity for ClientHello (required unless --no-sec)")
missing comma: (required, unless ...)
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43566?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic646626319cd7a26195d0ffff55900032abcddeb
Gerrit-Change-Number: 43566
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Sep 2026 11:08:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43681?usp=email )
Change subject: smf: Implement f_n11_update_sm_context()
......................................................................
smf: Implement f_n11_update_sm_context()
Change-Id: I3c79ba747886add0ea8e5ea3003364eedf4c43be
---
M library/HTTP2_Msg.ttcn
M library/TS29502_Nsmf_PDUSession_Templates.ttcn
A library/TS29503_Nudm_UECM_Templates.ttcn
M smf/SMF_Session_CT.ttcn
M smf/SMF_Session_CT_5G.ttcn
M smf/gen_links.sh
6 files changed, 482 insertions(+), 16 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/81/43681/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43681?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3c79ba747886add0ea8e5ea3003364eedf4c43be
Gerrit-Change-Number: 43681
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>