Attention is currently required from: jolly.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Add Cisco like DSCP configuration support
......................................................................
Add Cisco like DSCP configuration support
Add Cisco like VTY configuration support for DSCP. QoS classes can be
defined and configured per SS7 instance and the classes can be assigned
to listener and connections like this:
cs7 instance 0
qos class 3
qos-ip-dscp 36
...
asp myasp 2905 2905 m3ua
qos-class 3
...
asp asp-srv-m3ua 2906 2905 m3ua
qos-class 3
...
asp asp-clnt-m3ua 2905 2906 m3ua
qos-class 3
...
Ensure that the ongoing listener or connection socket is updated
whenever the QoS class is changed or deleted or its DSCP value is
changed.
Deprecated "ip-dscp" and "init-ip-dscp" configuration is still
supported. When QoS class is assigned, the deprecated configuration is
removed and vice versa.
Related: OS#6753
Depends-on: I06927855a173c5b6dbf5c93aa08ea75e1d9d5f37 (libosmocore)
Change-Id: Ic346698fc63771d95e474aec53ffb6c776636b3b
---
M TODO-RELEASE
M src/Makefile.am
M src/ss7_asp.c
M src/ss7_asp.h
M src/ss7_asp_vty.c
M src/ss7_instance.c
M src/ss7_instance.h
A src/ss7_qos_class.c
A src/ss7_qos_class.h
A src/ss7_qos_class_vty.c
M src/ss7_vty.c
M src/ss7_vty.h
M src/ss7_xua_srv.c
M src/ss7_xua_srv.h
M src/ss7_xua_srv_vty.c
15 files changed, 413 insertions(+), 27 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/67/43667/4
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ic346698fc63771d95e474aec53ffb6c776636b3b
Gerrit-Change-Number: 43667
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43665?usp=email )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: HTTP2_Functions: Remove trailing \r\n from multipart data payload
......................................................................
HTTP2_Functions: Remove trailing \r\n from multipart data payload
Change-Id: I7348b8734e23e63e51b5b9c5234075ff073b96e1
---
M library/HTTP2_Functions.ttcn
1 file changed, 13 insertions(+), 2 deletions(-)
Approvals:
laforge: Looks good to me, but someone else must approve
Jenkins Builder: Verified
fixeria: Looks good to me, approved
diff --git a/library/HTTP2_Functions.ttcn b/library/HTTP2_Functions.ttcn
index 554b7eb..307938b 100644
--- a/library/HTTP2_Functions.ttcn
+++ b/library/HTTP2_Functions.ttcn
@@ -72,14 +72,25 @@
return HTTP2_multipart_part {
var HTTP2_multipart_part part;
var octetstring delim := char2oct("\r\n\r\n");
+ var octetstring trail := char2oct("\r\n");
- /* 0..off is headers, off+lengthof(delim)..end is the data. */
+ /* 0..off is headers, off+lengthof(delim)..end is the data.
+ * Furthermore, data contains an extra "\r\n" at the end. */
var integer off := f_strstr_oct(data, delim, 0);
var octetstring header := substr(data, 0, off);
off := off + lengthof(delim);
+
+ /* Validate data trail: */
+ if (lengthof(data) < lengthof(trail) or
+ substr(data, lengthof(data) - lengthof(trail), lengthof(trail)) != trail) {
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,
+ log2str("Rx unexpected part data: ", data));
+
+ }
+
part := {
headers := f_HTTP2_multipart_msg_parse_part_headers(header),
- data := substr(data, off, lengthof(data) - off)
+ data := substr(data, off, lengthof(data) - lengthof(trail) - off)
}
return part;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43665?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7348b8734e23e63e51b5b9c5234075ff073b96e1
Gerrit-Change-Number: 43665
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>