Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43656?usp=email )
Change subject: IPAd: Add support for testing IPAd polling two eIMs
......................................................................
Patch Set 1:
(1 comment)
File ipad/IPAd_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43656/comment/1636beca_0b71… :
PS1, Line 111: private function f_init_pars(boolean second_eim := false)
maybe call it "second_eim_present"?
I have an idea that you might consider also:
We could have a record that holds the eimFqdn and eimId values. We then could use this record to create an array in pars. The array would get its default contents via an a parameter in f_init_pars.
in f_eim_init(), we then would loop over the array and create a GetEimConfigurationDataResponse dynamically.
This would allow us to put as many eIMs as we want. Not just two.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43656?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I14c3f09a4c21d5f643e6e499a095410b6c8f02ed
Gerrit-Change-Number: 43656
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Mon, 21 Sep 2026 12:12:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: pespin.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667?usp=email )
Change subject: Add Cisco like DSCP configuration support
......................................................................
Patch Set 4:
(2 comments)
File src/ss7_asp_vty.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/cf84b99f_c0b28… :
PS4, Line 420: struct osmo_ss7_asp *asp = vty->index;
> btw, I'd personally add a vty_out() here telling the user this vty is deprecated and that qos-class […]
Done
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/2db486cd_61882… :
PS4, Line 449: vty_out(vty, "%% Config updated: ip-dscp %d -> %d%s", asp->cfg.ip_dscp, qos->ip_dscp,
> I think you are missing the "qoss-class" somewhere in the string? like " -> qos-class %d (ip-dscp %d […]
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ic346698fc63771d95e474aec53ffb6c776636b3b
Gerrit-Change-Number: 43667
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Sep 2026 11:58:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: jolly.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Add Cisco like DSCP configuration support
......................................................................
Add Cisco like DSCP configuration support
Add Cisco like VTY configuration support for DSCP. QoS classes can be
defined and configured per SS7 instance and the classes can be assigned
to listener and connections like this:
cs7 instance 0
qos class 3
qos-ip-dscp 36
...
asp myasp 2905 2905 m3ua
qos-class 3
...
asp asp-srv-m3ua 2906 2905 m3ua
qos-class 3
...
asp asp-clnt-m3ua 2905 2906 m3ua
qos-class 3
...
Ensure that the ongoing listener or connection socket is updated
whenever the QoS class is changed or deleted or its DSCP value is
changed.
Deprecated "ip-dscp" and "init-ip-dscp" configuration is still
supported. When QoS class is assigned, the deprecated configuration is
removed and vice versa.
Update vty tests to the new VTY command layout and test the new VTY
commands.
Related: OS#6753
Depends-on: I06927855a173c5b6dbf5c93aa08ea75e1d9d5f37 (libosmocore)
Change-Id: Ic346698fc63771d95e474aec53ffb6c776636b3b
---
M TODO-RELEASE
M src/Makefile.am
M src/ss7_asp.c
M src/ss7_asp.h
M src/ss7_asp_vty.c
M src/ss7_instance.c
M src/ss7_instance.h
A src/ss7_qos_class.c
A src/ss7_qos_class.h
A src/ss7_qos_class_vty.c
M src/ss7_vty.c
M src/ss7_vty.h
M src/ss7_xua_srv.c
M src/ss7_xua_srv.h
M src/ss7_xua_srv_vty.c
M tests/vty/osmo_stp_test.vty
M tests/vty/ss7_asp_test.vty
M tests/vty/vty_test_runner.py
18 files changed, 468 insertions(+), 51 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/67/43667/5
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ic346698fc63771d95e474aec53ffb6c776636b3b
Gerrit-Change-Number: 43667
Gerrit-PatchSet: 5
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43652?usp=email )
Change subject: Add index to ipa_es10b_get_eim_cfg_data_filter
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43652?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I7a3cbbf8cd765f6da955434d897d9ffbe847f525
Gerrit-Change-Number: 43652
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Mon, 21 Sep 2026 11:50:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria, osmith.
Hello Jenkins Builder, fixeria, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43681?usp=email
to look at the new patch set (#4).
Change subject: smf: Implement f_n11_update_sm_context()
......................................................................
smf: Implement f_n11_update_sm_context()
Change-Id: I3c79ba747886add0ea8e5ea3003364eedf4c43be
---
M library/HTTP2_Msg.ttcn
M library/TS29502_Nsmf_PDUSession_Templates.ttcn
A library/TS29503_Nudm_UECM_Templates.ttcn
M smf/SMF_Session_CT.ttcn
M smf/SMF_Session_CT_5G.ttcn
M smf/gen_links.sh
6 files changed, 483 insertions(+), 17 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/81/43681/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43681?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3c79ba747886add0ea8e5ea3003364eedf4c43be
Gerrit-Change-Number: 43681
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: dexter.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43652?usp=email )
Change subject: Add index to ipa_es10b_get_eim_cfg_data_filter
......................................................................
Patch Set 3:
(3 comments)
File src/ipa/libipa/es10b_get_eim_cfg_data.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43652/comment/8c830078_1494b03c… :
PS2, Line 297:
> maybe set *eim_cfg_data_item = NULL; for good measure?
Done
https://gerrit.osmocom.org/c/onomondo-ipa/+/43652/comment/dff204ab_6ebb13ec… :
PS2, Line 309: /* In case no eim_id is specified, just pick the item from the list that is specified by index */
> Maybe rephrase the comment a bit? […]
Done
https://gerrit.osmocom.org/c/onomondo-ipa/+/43652/comment/3b2aea46_37ecf1ff… :
PS2, Line 317:
> Maybe add a comment? […]
Done
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43652?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I7a3cbbf8cd765f6da955434d897d9ffbe847f525
Gerrit-Change-Number: 43652
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Sep 2026 11:37:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43653?usp=email )
Change subject: Add support for polling multiple eIMs
......................................................................
Patch Set 2:
(1 comment)
File src/ipa/main.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43653/comment/9274c102_81c9123b… :
PS2, Line 151: static struct ipa_context *ctx = NULL;
> I would suggest to move this to the top of the module and to add a comment. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43653?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: Ifcad584dd04dc83c59124ce32e60254a72537d02
Gerrit-Change-Number: 43653
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Sep 2026 11:37:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>